Commit Graph
13029 Commits
Author SHA1 Message Date
Sheetal Nandi 1b12a855e8 Merge branch 'master' into inputFiles 2019-01-24 15:44:45 -08:00
Wesley Wigham 0ddcab3469 Fix master: handle generating type name for late bound dupe message more nicely (#29572)
* Fix master: handle generating type name for late bound dupe message more nicely

* Make literal type casts more specific in many places to better reflect the checks performed
2019-01-24 15:37:13 -08:00
Sheetal Nandi ec817f55f3 Fix unnecessary union 2019-01-24 15:27:39 -08:00
Ryan Cavanaugh 1a742e6f27 Merge pull request #27918 from collin5/b27914
Improve error message for duplicate property with computed name
2019-01-24 14:35:51 -08:00
Sheetal Nandi 399f987918 Add todos for sourcemap that accidently got reverted. 2019-01-24 13:54:45 -08:00
Sheetal Nandi 216ed1b385 Get dts content from sourceFile if present 2019-01-24 13:47:27 -08:00
Sheetal Nandi 50d98aee0e Create getters for js sourcemap, dts and dts map text getters in prepend nodes 2019-01-24 13:38:25 -08:00
Ryan Cavanaugh 16b6706ee1 Merge pull request #29463 from jack-williams/check-in-expression-with-union
Fix #29457
2019-01-24 13:07:22 -08:00
Sheetal Nandi 61b95fea5a Merge pull request #29555 from petebacondarwin/external-skip-trivia-fix
Use the correct source when skipping trivia
2019-01-24 12:09:10 -08:00
Anders Hejlsberg 71d70ef161 Merge pull request #29563 from Microsoft/fixSwitchControlFlow
Fix switch statement control flow logic
2019-01-24 10:36:52 -08:00
Anders Hejlsberg 9844436231 Match control flow logic for switch statements to conditional expressions 2019-01-24 09:30:36 -08:00
Pete Bacon Darwin 331b9bcfde Use the correct source when skipping trivia
A custom `SourceMapSource` can optionally provide its own `skipTrivia`
function. If this is not provided then the compiler will use the default
function designed for TypeScript source files.

Previously, when calling this default function we were passing the current
`sourceMapSource` rather than the specified `source` whose trivia needs
to be skipped. This resulted in the `pos` being incorrectly calculated for
external source files that need mapping.

**Side note:**

There are actually two possible constructors available for creating
`SourceMapSource` objects. One of them defaults to an identity function
for the `skipTrivia` function if it is not provided (see
https://github.com/Microsoft/TypeScript/blob/49689894d747714d6b2b8461b9033020efec9625/src/compiler/utilities.ts#L6972-L6976)
and the other one leaves the `skipTrivia` field `undefined` (see
https://github.com/Microsoft/TypeScript/blob/5fc8f1dd801dbacfe7e2d624f80b7a6a3868d180/src/services/services.ts#L776-L797)

Unfortunately, it appears that the second of these two constructors is the
one available when importing the "typescript" module in node.js code.
2019-01-24 10:28:10 +00:00
xiaofa d7601b755f fix trailing comma should not allowed in dynamic import argument 2019-01-24 18:16:34 +08:00
kingwl e8497096d8 Merge branch 'master' into improve_type_arguments_parser_1 2019-01-20 01:54:49 +08:00
Pranav Senthilnathan d38c616e29 Fix resolution of properties from prototype assignment in JS (#29302)
* fix type derived from prototype assignment

* accept new baselines

* remove direct intersection with object literal assigned to prototype

* add tests

* change webpack submodule commit

* fix submodule commits

* comment and simplify getJSDocTypeReference

* remove circularity guards that aren't hit anymore
2019-01-18 16:00:18 -08:00
Wesley Wigham 20285e66e9 Include all flow nodes made within try blocks as antecedents for catch or finally blocks (#29466)
* Include all flow nodes made within `try` blocks as antecedents for `catch` or `finally` blocks

* Fix typo
2019-01-18 14:43:31 -08:00
Wesley Wigham addeff325b Make the relationship between partial mapped types and the empty object not apply for subtype relationship (#29384) 2019-01-17 15:42:58 -08:00
Wesley Wigham b6ae492009 Add missing arity check on second inference pass (#29386) 2019-01-17 15:21:17 -08:00
Sheetal Nandi 9bd23652ef Merge pull request #29161 from Microsoft/incrementalBuild
Supports incremental build in tsc --b --w mode
2019-01-17 13:44:48 -08:00
Sheetal Nandi 900d6f7c90 renames 2019-01-17 12:29:23 -08:00
Jack Williams 5651789629 Fix #29457
Use allTypesAssignableToKind instead of isTypeAssignableToKind to
account for union types.
2019-01-17 20:03:46 +00:00
Sheetal Nandi dbae2cba47 add missing type annotation 2019-01-17 11:54:43 -08:00
Wesley Wigham 045a450972 Merge branch 'fix-generic-types-intersections' of git://github.com/flapenguin/TypeScript into flapenguin-fix-generic-types-intersections 2019-01-17 10:49:04 -08:00
Sheetal Nandi 9f3b77a8bd PR feedback 2019-01-17 09:23:20 -08:00
Benjamin Lichtman 5fc8f1dd80 Add opt-in user preference for prefix and suffix text on renames (#29314)
* Add user preference to control renaming through exports

* Only impact renaming

* Update baselines

* Use flag to control all prefix and suffix text and imports

* [WIP] add tests

* Only skip export import specifier with flag

* [WIP] Update tests

* Update test

* Pick up preference from host and update test

* Shorten flag name

* Add missing utility function

* Update comment

* [WIP] rename flag and respond to cr

* [WIP] Add flag for forRelatedSymbol

* Use larger search symbol set for old-style rename

* Respond to CR

* Fix small error

* Fix type mismatch

* Update comment and remove unnecessary exprot

* Respond to CR
2019-01-16 10:58:07 -08:00
Wesley Wigham 41a7bf4b73 Fake up value declaration for synthetic jsx children symbol so they get excess property checked (#29359) 2019-01-15 22:31:57 -08:00
Daniel Rosenwasser adb4738cff Merge pull request #28132 from a-tarasyuk/feature/28086
28086 - "--downlevelIteration errors should mention using later targets"
2019-01-15 14:06:57 -08:00
Wesley Wigham 49689894d7 Elaborate jsx children elementwise (#29264)
* Heavy WIP, but has good contextual typing fix

* Add arity error, refine messages and spans

* Small error message change

* Better error messages, text-specific message
2019-01-15 11:32:36 -08:00
Sheetal Nandi 520e33fa51 PR feedback 2019-01-14 18:15:54 -08:00
Ron Buckton 5763e2c3d4 Remove overzealous simple relationship check for unique symbols 2019-01-14 17:08:04 -08:00
Sheetal Nandi e745fca413 Fix typo 2019-01-14 14:35:05 -08:00
Sheetal Nandi d69b2ea448 Merge pull request #29380 from Microsoft/sourceMap
Use the SourceMapSource to get line and column instead of current source file
2019-01-14 14:30:27 -08:00
Sheetal Nandi ff97d86cfa Fix typo 2019-01-14 14:00:22 -08:00
Wesley Wigham 3d2bf6a75f Fix implement interface quickfix import types (#29410)
* Pass module specifier resolution host thru types constructed by implements quickfixes

* Add regression test

* Fix scope node for generated methods, fix lints
2019-01-14 13:56:27 -08:00
Wesley Wigham dc0f4afe5e Save & recalculate declare flag modifier on late printed statements (#29412)
* Save & recalculate declre flag modifier on late printed statements

* Accept related baseline updates
2019-01-14 13:53:04 -08:00
Sheetal Nandi 3943588793 CompilerHostLikeForCache rename 2019-01-14 12:48:22 -08:00
Sheetal Nandi c909becdd5 Rename indexing variable 2019-01-14 12:44:37 -08:00
Sheetal Nandi d4055a3234 Merge pull request #26017 from ajafff/rest-param-destructuring
allow BindingPattern in FunctionRestParameter
2019-01-14 10:58:19 -08:00
Gabriela Britto e5708e1903 Merge pull request #29352 from Microsoft/qualified-name-param-tag-error
Qualified name param tag error
2019-01-14 10:28:08 -08:00
Alexander ba94fd9e05 Merge branch 'master' of https://github.com/Microsoft/TypeScript into feature/28086 2019-01-12 08:39:06 +02:00
Sheetal Nandi d1061579d3 Merge branch 'master' into sourceMap 2019-01-11 14:47:24 -08:00
Sheetal Nandi c1edbb8522 Merge branch 'master' into incrementalBuild 2019-01-11 14:34:45 -08:00
Wesley Wigham fadd95f72b Fix unneeded cast lints (#29383) 2019-01-11 14:24:49 -08:00
Sheetal Nandi 9f19c06dbf Merge pull request #29372 from JoshuaKGoldberg/codefix-enable-decorators
Added codefix to enable experimentalDecorators in the user's config file
2019-01-11 12:45:28 -08:00
Sheetal Nandi 021c63f1c3 Use the SourceMapSource to get line and column instead of current source file
Fixes #29300
2019-01-11 12:24:33 -08:00
Alexander d5f5d7347e Merge branch 'master' of https://github.com/Microsoft/TypeScript into feature/28086 2019-01-11 22:21:02 +02:00
Alexander a076417837 remove unused error message 2568 2019-01-11 22:13:29 +02:00
Sheetal Nandi fb99d552ea Merge pull request #29022 from mprobst/no-resolve-libref
Do not process library reference directives with noLib set.
2019-01-11 09:03:46 -08:00
Josh Goldberg 8d28f9230c Added codefix to enable experimentalDecorators in the user's config file
Starts on #29035 by creating a codefix to enable the `experimentalDecorators` setting in a user's config file, if one exists. The issue's discussion also mentions giving a more precise error message if the user has a jsconfig or tsconfig or creating one if not; I'd rather tackle those in separate PRs to keep this one small.

Doesn't create the code action if no config file is present. Otherwise keeps to the precedent of returning without action when the config file contents aren't the expected JSON structure (looking at `fixCannotFindModule.ts`).  Moves a couple JSON helpers from that file into the sibling `helpers.ts` so both codefixes can use them.
2019-01-11 09:20:12 -05:00
Martin Probst 11b150129a Do not process library reference directives with noLib set.
When a user sets `noLib`, this indicates that they will supply their own
list of `lib*.d.ts` files as part of input sources. In this situation,
TypeScript should not try to resolve library reference directives.

This avoids a problem where TypeScript loads a file that e.g. contains
`/// <reference lib="es2015.symbol"/>`. Previously, TypeScript would use
its builtin ts.libMap and attempt to load builtin libraries from the
TypeScript installation, instead of respecting the user-supplied set of
libraries.
2019-01-11 09:02:49 +01:00