Commit Graph
9587 Commits
Author SHA1 Message Date
Anders Hejlsberg ce2ac1751e Merge pull request #17771 from Microsoft/fixCircularContextualType
Fix circular contextual return type error
2017-08-16 09:17:15 +02:00
Andy 93abebc04a Change function name to camelCase (#17751) 2017-08-15 12:26:00 -07:00
Andy 7409648416 Remove unused UseTypeAliasValue flag (#17779) 2017-08-15 10:24:15 -07:00
Andy 10c8d5effa In services, show the aliasSymbol for a type even if it's not accessible in the current scope (#17433)
* In services, show the aliasSymbol for a type even if it's not accessible in the current scope

* Rename flag
2017-08-15 10:23:45 -07:00
Anders Hejlsberg a1cbeb2eca Merge pull request #17767 from tycho01/15768-generic-numeric-index-error
loosen number index check, fixes #15768
2017-08-14 19:02:06 +02:00
Andy 543e0affff Make exportSymbol public (#17457)
* Make exportSymbol public

* Add a `getExportSymbolOfSymbol` method

* Use own implementation instead of delegating to `getExportSymbolOfValueSymbolIfExported`
2017-08-14 09:20:48 -07:00
Daniel Rosenwasser ea7c7d3467 Merge pull request #16631 from Microsoft/fix13721
Emit class annotation comment on downlevel classes
2017-08-14 10:33:41 -04:00
Tycho Grouwstra 4268e13cde simplify fix as suggested by @ahejlsberg 2017-08-14 17:45:18 +08:00
Anders Hejlsberg dacc851434 No contextual return type when type is circular 2017-08-14 09:01:50 +02:00
Tycho Grouwstra 1d6863ab0b loosen number index check, fixes #15768 2017-08-14 02:18:47 +08:00
Wesley Wigham d03d1074ee Make compiler options which map to a flag case-insensitive again (#17755) 2017-08-11 19:59:43 -07:00
Ron Buckton e3b6df64b3 Add support to infer the quote style for import quick fixes 2017-08-11 14:26:25 -07:00
Ryan Cavanaugh c110ecb870 Merge pull request #17625 from RyanCavanaugh/extract-method-2
Extract Method
2017-08-11 10:54:48 -07:00
Andy f64b8ad902 Add "preserveSymlinks" option (#16661)
* Add "preserveSymlinks" option

* Respond to PR comments
2017-08-11 10:03:21 -07:00
Andy b3f3f336ad Use hasModifier and hasModifiers helper functions (#17724) 2017-08-11 07:15:15 -07:00
Ryan Cavanaugh 8a92315171 Merge 2017-08-10 17:05:45 -07:00
Ryan Cavanaugh c27ee81341 Merge branch 'master' into extract-method-2 2017-08-10 17:02:14 -07:00
Ryan Cavanaugh f957429efd Style fixups 2017-08-10 16:23:17 -07:00
Ryan Cavanaugh 1ad411e13e Various fixes 2017-08-10 13:13:18 -07:00
Andy 08fbcd8b80 Fix many no-object-literal-type-assertion lint errors (#17278)
* Fix many no-object-literal-type-assertion lint errors

* Simple fixes

* Use a union for FlowNode

* PR feedback and remove remaining `id()` uses

* Use a union for CodeBlock

* Discriminate CodeBlock by CodeBlockKind
2017-08-10 12:52:15 -07:00
Andy fe3a05e89a A function should be context-sensitive if its return expression is (#17697)
* A function should be context-sensitive if its return expression is

* Remove outdated comment

* Fix typo
2017-08-10 07:08:24 -07:00
Andy 4c824505ad Treat NoSubstitutionTemplateLiteral same as a StringLiteral (#17704) 2017-08-10 06:53:48 -07:00
Andy 2c4361aadf Simplify assignTypeToParameterAndFixTypeParameters (#17706) 2017-08-10 06:51:50 -07:00
Nathan Shively-Sanders 8ae7c6c227 Fix type predicate index in error reporting
Previously type predicate error checking didn't take the `this`
parameter into account when checking for errors. This led to spurious
errors. Note that it's not feasible to change the initial value of
`parameterIndex` because several checks refer to the original
declaration, for example to make sure that a type predicate doesn't
refer to a rest parameter.
2017-08-09 15:43:47 -07:00
Andy e1ba65ae64 Add simple version of chooseOverload for common case of single non-generic signature (#17589)
* Add simple version of `chooseOverload` for common case of single non-generic signature

* Use a single function
2017-08-09 14:41:38 -07:00
Andy 37b20ee670 For duplicate source files of the same package, make one redirect to the other (#16274)
* For duplicate source files of the same package, make one redirect to the other

* Add reuseProgramStructure tests

* Copy `sourceFileToPackageId` and `isSourceFileTargetOfRedirect` only if we completely reuse old structure

* Use fallthrough instead of early exit from loop

* Use a set to efficiently detect duplicate package names

* Move map setting outside of createRedirectSourceFile

* Correctly handle seenPackageNames set

* sourceFileToPackageId -> sourceFileToPackageName

* Renames

* Respond to PR comments

* Fix bug where `oldSourceFile !== newSourceFile` because oldSourceFile was a redirect

* Clean up redirectInfo

* Respond to PR comments
2017-08-09 14:39:06 -07:00
Andy 17a6f7b56a Remove unused internal utilities (#17380)
* Remove unused internal utilities

* Handle undefined input to `mapDefined`
2017-08-09 14:37:59 -07:00
Wesley Wigham a6f37f55e4 Add a leading space on binary operator token trailing comments (#17691)
* Add a leading space on token trailing comments

* Demystify comment
2017-08-09 14:27:37 -07:00
Andy f28f5fd041 Don't check function expression grammar if this is SkipContextSensitive (#17698) 2017-08-09 14:09:52 -07:00
Wesley Wigham 6221d7089e Fix import addition location (#17327)
* Add test with bug

* Fix for import placement

* Consolidate comment recognition functions into utilities

* Add another test with all 3 kinds

* Recognize path directives as part of triple slash directives

* Also handle no-default-lib triple-slash comments

* Test for all the triple-slash kinds

* Keep import-placement logic in the quickfix, since its not really a node start; accept new baselines

* Work in not-ES6, use a real no-lib comment

* Remove no default lib triple slash comment, it disables checking and thereby quick fixes

* Copy regex rather than have a regex copy
2017-08-09 14:03:37 -07:00
Yui 39e0cc61a7 Fix 16628: "undefined" exception when name of binding element in binding pattern is empty (#17132)
* Handle the case where binding pattern name element is empty

* Update tests and baselines

* Feedback from PR

* Handle empty binding patterns more generally in emitter

* Dont simply handling fo empty binding patterns and stay spec compliant

* PR feedback
2017-08-09 13:47:44 -07:00
Wesley Wigham c399230767 Retain comments inside return statements (#17557)
* Retain comments inside return statements by including the return keyword in the parse tree

* Revert "Retain comments inside return statements by including the return keyword in the parse tree"

This reverts commit 5d2142edb1.

* Readd test

* Function for handling printing comments on a token
2017-08-08 19:53:53 -07:00
Ron Buckton 73f941d1c0 Merge pull request #17658 from Knagis/14559-non-polling-watcher
Handle empty directory path as the current directory Fixes #14559
2017-08-08 17:28:58 -07:00
Wesley Wigham 43e758e1a9 Create synthetic default exports for dynamic imports (#17492)
* Create synthetic default exports for dynamic imports

* Slightly better solution

* Actually accept baselines

* Slightly adjust synthetic type

* Cache synthetic type

* Inline variables, remove non-required calls

* Rename function
2017-08-08 17:01:18 -07:00
Nathan Shively-Sanders 847d7fe3c8 Merge pull request #17404 from Microsoft/use-type-param-constraints-for-computed-prop-types
Use type parameter constraints for computed property types
2017-08-08 16:29:28 -07:00
Ron Buckton 75c8ecb2f1 Merge pull request #17517 from tinganho/IgnoredCatchParameter
Ignored catch parameter
2017-08-08 16:15:18 -07:00
Nathan Shively-Sanders fac93a304c Add parentheses:clarify evaluation order of &&/||
in isTypeAssignableToKind
2017-08-08 16:11:42 -07:00
Nathan Shively-Sanders e47df360dc Use isTypeAny instead of checking flags directly 2017-08-08 14:51:06 -07:00
Andy 3deb39bba6 Remove unnecessary check that type is ObjectType (#17418) 2017-08-08 14:01:16 -07:00
Nathan Shively-Sanders e494d73b29 Merge branch 'master' into use-type-param-constraints-for-computed-prop-types 2017-08-08 13:26:24 -07:00
Wesley Wigham a46d6bde97 Add a seperate cache for the all attributes version of the jsx attributes type (#17620) 2017-08-08 13:07:27 -07:00
Nathan Shively-Sanders a2c66c3262 Merge pull request #17660 from Microsoft/weak-type-errors-on-signature-only-types
Weak type errors on signature-only types
2017-08-08 12:40:50 -07:00
Andy 85f59098d3 validateSpecs: Use array helpers (#17275)
* validateSpecs: Use array helpers

* Make filter predicate smaller

* forEach -> for-of
2017-08-08 11:38:41 -07:00
Nathan Shively-Sanders 7ff1d8e797 Add specific weak type error for callable types
"Did you mean to call it?"
2017-08-08 11:25:32 -07:00
Andy 94518e8533 Don't count self-reference when setting isReferenced (#17495)
* Don't count self-reference when setting `isReferenced`

* Improve comment
2017-08-08 11:18:20 -07:00
Andy 5141ce751d Deduplicate unresolvedImports (#17248)
* Deduplicate unresolvedImports

* Add `isNonDuplicateInSortedArray` helper
2017-08-08 11:02:10 -07:00
Nathan Shively-Sanders 781da2332d Merge branch 'master' into weak-type-errors-on-signature-only-types 2017-08-08 10:45:52 -07:00
Andy ceae613e4c Add lint rule to check that Debug.assert calls do not eagerly interpolate strings (#17125)
* And lint rule to check that `Debug.assert` calls do not eagerly interpolate strings

* Use more specific 'assert' functions to avoid callbacks

* Respond to PR feedback
2017-08-08 07:56:14 -07:00
Andy 382785a528 Fix logging of module resolution errors (#17144) 2017-08-08 07:54:08 -07:00
Karlis Gangis 51e9aef2a7 FileWatcher - handle empty directory path as the current directory Fixes #14559 2017-08-08 09:32:37 +03:00