Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
30,197 Commits 367 Branches 233 Tags
bc0d2ec26c36dbbbadfc04693f991e4e9bc0f8b6
Commit Graph
22160 Commits
Author SHA1 Message Date
csigs d154b58406 LEGO: check in for master to temporary branch. 2020-05-16 22:10:40 +00:00
Eli Barzilay 33c3e9e2c6 Make processTaggedTemplateExpression visit a returned node 
This problem was introduced in 70399e146e (from PR #23801), which added
a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`,
before that, it would fallback to the default of `visitNode`.  So re-add
that happen in `processTaggedTemplateExpression`.

Since it doesn't hurt, I left a `Debug.checkDefined(property.name)`
instead of `!`-ing it.

Fixes #38558.
 2020-05-15 19:46:45 -04:00
Eli Barzilay d7dd06e36d goToDefinition: find only the value if it's the RHS of an assignment 2020-05-15 18:55:57 -04:00
Jesse TrinityandGitHub 1a15717bc4 Fix regression organize imports duplicates comments (#38599) 
* delete import comments on organize imports

* add unit test

* accept new baseline

* respond to review comment
 2020-05-15 14:25:11 -07:00
Ron BucktonandGitHub 1cbe7ef000 Fix crash in JS declaration emit (#38508) 
* Fix crash in JS decl emit

* Emit as class with private ctor
 2020-05-15 14:00:59 -07:00
Wesley WighamandGitHub 7fc456f2d7 Include unknown in spread prop override check (#38577) 2020-05-14 14:36:38 -07:00
Greg Hurrell cfc4573c82 Fix (cosmetic) typos in checker.ts comments 
Just some small things I noticed while looking at some recent PRs.
 2020-05-14 19:40:41 +02:00
Anders HejlsbergandGitHub c1f676dd3f Perform intersection reduction before and after getApparentType (#38565) 
* Perform intersection reduction before and after getApparentType

* Add regression tests
 2020-05-13 20:57:17 -07:00
Alexander TandGitHub 71711257ea fix(33836): allow readonly modifier for a field with only get accessor (#36543) 2020-05-13 13:28:32 -07:00
Wenlu WangandGitHub 9725d623ce Fix build type error (#38525) 2020-05-13 07:44:49 -04:00
Daniel RosenwasserandGitHub b682ee1a8a Merge pull request #38489 from microsoft/removeDuplicateInfo 
Remove duplicate JSDoc comments
 2020-05-12 12:52:15 -07:00
Daniel RosenwasserandGitHub c2b559403d Merge pull request #38502 from alan-agius4/export-star-colon 
fix: add missing semi-colon to `__exportStar` unnamed function
 2020-05-12 10:59:03 -07:00
Sheetal NandiandGitHub 5d6a5d04ea Fix detecting default project when file is part for more than one project but not part of default configured project (eg because its output of that projet) (#38429) 
Fixes #38366
 2020-05-12 10:16:59 -07:00
Nathan Shively-SandersandGitHub 3f06adf662 Merge pull request #38240 from a-tarasyuk/feat/add-outlining-spans-for-object-destructuring-elements 
feat: Add outlining spans for object destructuring elements
 2020-05-12 07:35:03 -07:00
Nathan Shively-SandersandGitHub cbf15bb6ed feat(38225): change diagnostic message for remove braces from arrow function body (#38226) 2020-05-12 07:27:09 -07:00
Alexander TandGitHub 5895493815 fix(37877): include in NavigationBar default exported child items (#38255) 2020-05-12 07:26:31 -07:00
Alan Agius 7ec21e93fe fix: add missing semi-colon to __exportStar unnamed function 
Fixes #38501
 2020-05-12 13:27:01 +02:00
csigs 0e37296396 LEGO: check in for master to temporary branch. 2020-05-12 04:10:41 +00:00
Daniel RosenwasserandGitHub f9e1bcd0c4 Merge pull request #38439 from lissein/void-0-template-strings 
Changed template strings to emit void 0 instead of undefined (#38430)
 2020-05-11 17:09:28 -07:00
Daniel e9867a7353 Add and use the 'intersperse' helper function. 2020-05-11 22:17:01 +00:00
csigs 27b9daf0a3 LEGO: check in for master to temporary branch. 2020-05-11 22:10:44 +00:00
Ron BucktonandGitHub d07e866a28 Fix for jsdoc modifiers on constructor params (#38403) 
* Fix for jsdoc modifiers on constructor params

* Update Public API baseline and fix unique symbol grammar check for js
 2020-05-11 15:07:43 -07:00
Daniel 74d6d04d70 Don't add duplicates of JSDoc comments. 2020-05-11 21:39:47 +00:00
Nathan Shively-SandersandGitHub 1a88430a7e Improve assert message in binder (#38270) 
* Improve assert message in binder

Looking at the code, I don't think the assert can ever fire, but it
clearly does, or did in the past. This will make it easier for people to
create a repro.

* fix lint

* Use BindableStaticNameExpression not BindableStaticAccessExpression

This type does allow identifiers, but those are ruled out earlier, so I added
an assert for that case.
 2020-05-11 13:40:54 -07:00
jeffy-gandGitHub fd71eb2c85 fix broken regex on "src/services/completions.ts#getCompletionData" (#37546) 
* fix broken regex on src/services/completions.ts#840

* update forslash test

breaking changes fourslash test

Temporarily retain the before fix code for easy comparison

* regex

* fourslash test (Temporary code

* regex: more restrictive in terms of jsdoc format

fourslash test

* regex: max indent restriction

* achieved goal by partial match strategy (probably

* cleanup

* apply requested changes

* Change to a version with minimal modifications
 2020-05-11 13:02:20 -07:00
WenqiandGitHub 1b7b3eb0f7 report error for duplicate @type declaration (#38340) 2020-05-11 12:47:49 -07:00
Alexander TandGitHub 738b6b5b68 fix(38073): hide 'Extract to function in global scope' action for arrow functions which use 'this' (#38107) 2020-05-11 12:25:25 -07:00
lissein 946abeadb0 Changed template strings to emit void 0 instead of undefined (#38430) 
undefined is not a keyword in es5 and es3 so we now emit void 0 instead in template strings.
 2020-05-09 04:53:14 +02:00
Wesley WighamandGitHub 7b03835b77 Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit (#38368) 
* Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit

* Add special lookups test case, rename helper

* Accept slightly modified baselines
 2020-05-08 10:46:28 -07:00
csigs 92b7d8b6f2 LEGO: check in for master to temporary branch. 2020-05-08 16:13:19 +00:00
Manuel ThalmannandGitHub cbc959ba35 Make isDynamicFileName available publicly (#38269) 
* Make isDynamicFileName available publicly

This commit fixes #37987

* Acknowledge Public APIs
 2020-05-08 07:31:59 -07:00
csigs ece47d9d9a LEGO: check in for master to temporary branch. 2020-05-08 04:10:54 +00:00
csigs 9ba861904b LEGO: check in for master to temporary branch. 2020-05-07 22:11:10 +00:00
Anders HejlsbergandGitHub 0091fd6c64 Exclude arrays and tuples from full intersection property check (#38395) 
* Exclude arrays and tuples from full intersection property check

* Add regression test
 2020-05-07 15:03:51 -07:00
Anders HejlsbergandGitHub 7798f532df Fix crash caused by assertion with evolving array type (#38398) 
* Properly finalize evolving array type in getTypeAtFlowCall

* Add regression test
 2020-05-07 14:05:57 -07:00
csigs 1d2414822d LEGO: check in for master to temporary branch. 2020-05-07 16:10:38 +00:00
Eli Barzilay 29cf049e61 moveToNewFile: handle namespace imports too 
Fixes #35591
 2020-05-07 11:46:36 -04:00
Jack WilliamsandGitHub 05d59a1f1a Unify logic in typeof narrowing (#33434) 2020-05-06 15:15:24 -07:00
csigs c08b020ae9 LEGO: check in for master to temporary branch. 2020-05-06 22:10:57 +00:00
Alexander TGitHubNathan Shively-Sanders
 		683b3ec058 feat(37782): 'declare method' quick fix for adding a private method (#37806) 
* feat(37782): add quick-fix action to declare a private method for names that start from underscore

* better merge order in messages json

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-05-06 15:10:02 -07:00
Wenlu WangGitHubNathan Shively-Sanders
 		e66ce879a9 expose jsdoc factory (#29539) 
* expose jsdoc factory

* refactor jsdoc factory

* correctly jsdoc factory types

* update jsdoc factory

* Add check for delete expression must be optional

* accept new basseline

* Revert "Add check for delete expression must be optional"

This reverts commit 76937c3b1a.

* remove newline

* make linter happy

* Add deprecated comment

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-05-06 15:06:12 -07:00
Wenlu WangGitHubNathan Shively-Sanders
 		8d78984558 Add support of contextual quick info (#37451) 
* Add support of contextual quick info

* Avoid document comment map

* Make lint happy

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-05-06 15:05:31 -07:00
Nathan Shively-SandersandGitHub 35c1ba67ba Update LKG 2020 05 06 (#38371) 
* Update LKG

* remove now-extraneous casts
 2020-05-06 14:42:05 -07:00
Josh GoldbergGitHubOrta Therox
 		be2eb8a2e1 Allowed comment directives to be multiline (#38228) 
* Allowed comment directives to be multiline

* Added tests, and perhaps fixed a test runner bug?

* I think it's going to need a consistent variable to loop over

* Used dynamically computed indexes in verifies

* Added multiline tests

* Increased flexibility for multiline comment parsing

* Undid a couple of formatting changes; removed backslashes from multiline regexp

* Added baseline tests for multiline comment skipping

Co-authored-by: Orta Therox <orta.therox@gmail.com>
 2020-05-06 13:09:29 -07:00
Ron BucktonandGitHub 4b08c0582d Fix regression in name resolution in parameter (#38351) 2020-05-06 12:04:28 -07:00
Alexander TandGitHub ec93a7cf7b fix(36055): forbid union type with invalid types in the 'in' operator (#37786) 2020-05-06 11:41:50 -07:00
csigs c33d6044fa LEGO: check in for master to temporary branch. 2020-05-06 04:10:41 +00:00
Anders HejlsbergandGitHub 2524fb164a Consistent narrowing by discriminant (#38311) 
* Consistent requirements for narrowing by discriminant

* Add tests
 2020-05-05 20:06:07 -07:00
Alexander TandGitHub c219fdae08 fix(37703): forbid required parameter after optional (#38155) 2020-05-05 10:29:17 -07:00
Alexander TandGitHub d86bdf4e5c add outlining spans for the tuple type (#38179) 2020-05-05 09:48:33 -07:00