Commit Graph
6519 Commits
Author SHA1 Message Date
Anders Hejlsberg 884c72efb4 Merge pull request #18654 from Microsoft/strictFunctionTypes
Strict function types
2017-10-02 23:09:17 +01:00
Anders Hejlsberg c2344e07a4 Add error elaboration test 2017-10-02 13:40:26 -07:00
Andy eefe5c9706 Fix acquiring format options for getEditsForRefactor (#18848)
* Fix acquiring format options for getEditsForRefactor

* Add test

* Fix test description

* Use `executeCommandSeq`
2017-10-02 13:26:35 -07:00
Anders Hejlsberg bf75a3f4ac Emit .d.ts file in test 2017-10-02 12:54:04 -07:00
Andy 637ed57451 Fix crash when extending non-EntityNameExpression (#18853) 2017-10-02 10:39:03 -07:00
Andy e6980722a6 Fix bug: Report errors on extends expression in JS even if an @augments tag is present (#18854) 2017-10-02 10:33:53 -07:00
Anders Hejlsberg 0756aa1753 Merge branch 'master' into strictFunctionTypes 2017-09-28 15:39:57 -07:00
Andy 7959bd0a3d Check JSDoc @param tag names (#18777) 2017-09-28 13:44:38 -07:00
Andy 4bba6ee02e Support accessing enum types from JSDoc (#18703) 2017-09-28 13:43:39 -07:00
Armando Aguirre a39110add9 Merge pull request #18806 from armanio123/FixScriptBlockFormatting
Fixed formatting on script blocks
2017-09-28 12:35:32 -07:00
Andy 1a2de721b5 Fixes to @augments handling (#18775)
* Fixes to @augments handling

* Renames and diagnostic changes

* Add test for < > characters

* Use more specific return type
2017-09-28 12:34:54 -07:00
Armando Aguirre 8683ac92c8 Fixed formatting on script blocks, added regrestion tests, fixed minor bugs 2017-09-27 15:18:25 -07:00
Andrew Casey 3eea1a9e9a Generalize extract method to handle constants as well
Major changes:

1) Instead of skipping undesirable scopes, include them and mark them
with errors.  Constants can be extracted into more scopes.

2) Update the tests to call through the "public" API.  This caused some
baseline changes.

3) Rename refactoring to "Extract Symbol" for generality.

4) Return a second ApplicableRefactorInfo for constants.  Distinguish
the two by splitting the action name.
2017-09-26 17:29:34 -07:00
Andy ecef2dc970 Improve testing of code fixes, and improve diagnostic messages (#18742)
* Improve testing of code fixes, and improve diagnostic messages

* Disambiguate `newFileContent` from `newRangeContent`
2017-09-26 15:16:29 -07:00
Anders Hejlsberg 6a481e8ddc Update tests 2017-09-25 16:59:39 -07:00
Wesley Wigham 8f9724811d Add fix for crash in #18712 (#18751) 2017-09-25 13:07:44 -07:00
Andy b4018a2ef1 Handle @typedef tag with missing type (#18662)
* Handle @typedef tag with missing type

* Add single quotes to diagnostic

* Remove redundant jsdoc checking (now done on every source element)

* Update baselines
2017-09-25 12:11:33 -07:00
Andy 17f10c032e Fix crash when @augments tag has no type (#18739) 2017-09-25 09:58:46 -07:00
Mohamed Hegazy 4221fb6a39 Check for initializer before using it (#18708) 2017-09-22 17:14:22 -07:00
Andy 72c8b804da Use JSDoc @type tag type cast as a contextual type (#18690)
* Use JSDoc `@type` tag type cast as a contextual type

* Suggested changes
2017-09-22 10:42:02 -07:00
Anders Hejlsberg 70e8f7364e Add tests 2017-09-21 21:40:31 -07:00
Nathan Shively-Sanders 36cdbb2857 Merge pull request #18625 from Microsoft/fix-getAdjustedStartPosition-on-first-line
Fix get adjusted start position on first line
2017-09-21 10:08:30 -07:00
Nathan Shively-Sanders 3cc0aeb6be PR comments
I plan to fix the missing comment issue when I add the
convert-jsdoc-types-to-typescript-types refactoring. Or at least work
around it.
2017-09-21 09:44:51 -07:00
Daniel Rosenwasser 6a34dc953a Added test and accepted baselines. 2017-09-21 02:07:33 -07:00
Ron Buckton d9951cbb8e Merge pull request #17919 from henrymercer/fix-empty-object-property-access
Fix property access on an object literal
2017-09-20 19:06:04 -07:00
Andrew Casey f00c78c9b5 Merge pull request #18622 from amcasey/NoModifiers
JavaScript: handle lack of modifiers on extracted method
2017-09-20 17:10:42 -07:00
Nathan Shively-Sanders 410f84656d Update baselines temporarily
The loss of comments is not good, but should be fixed when
(1) trivia-handling issues are fixed or (2) the reafactorings themselves
add a workaround.
2017-09-20 16:31:28 -07:00
Andrew Casey a1dee452fa JavaScript: handle lack of modifiers on extracted method
The emitter expects undefined, rather than empty.  This only affects JS,
because TS applies `private` to all extracted methods.

(cherry picked from commit 9630c46ea7)
2017-09-20 16:25:15 -07:00
Andy 4d2aa9bf2c Fix formatting when keyword is parsed as part of a JSX identifier (e.g. module-layout) (#18598) 2017-09-20 15:01:04 -07:00
Andy d5e7227dbb Look at correct 'package.json' location for a scoped package (#18580)
* Look at correct 'package.json' location for a scoped package

* Update baseline
2017-09-20 08:15:24 -07:00
Magnus Kulke b549e26665 Consider underscore for type parameters in unused-local checks (#18539)
* Consider underscore for type parameters in unused-local errors.

* Addressed review comments.
2017-09-19 16:57:26 -07:00
Henry Mercer a8810925ac Merge branch 'master' into fix-empty-object-property-access 2017-09-20 00:29:18 +01:00
Andy 12649516cf navigation tree / bar: Set span of anonymous function to span of VariableDeclaration containing it (#18575)
* navigation tree / bar: Set span of anonymous function to span of VariableDeclaration containing it

* Add back `isFunctionOrClassExpression`
2017-09-19 14:39:29 -07:00
Henry Mercer 76ef97449c Expand test to ensure property access on object literal has correct behaviour 2017-09-19 22:18:15 +01:00
Andy 0ae42ea3de Allow relative imports of '.js' files when --noImplicitAny is disabled (#18489)
* Allow relative imports of '.js' files when `--noImplicitAny` is disabled

* Update baselines, and don't ignore a diagnostic about missing JSX
2017-09-19 12:42:29 -07:00
Nathan Shively-Sanders 339a7e5f63 Merge branch 'master' into make-jsdoc-getters-public 2017-09-19 11:20:06 -07:00
Andrew Casey cb63ea5242 Merge pull request #18563 from amcasey/GH18546
Stop requiring that the full range of a declaration fall within the selection
2017-09-19 10:47:16 -07:00
Nathan Shively-Sanders cc678a5184 Merge pull request #18440 from Microsoft/fix-javascript-signature-instantiation
Fix javascript signature instantiation
2017-09-19 08:43:16 -07:00
Andrew Casey af49c60a2c Stop requiring that the full range of a declaration fall within the
selection

Fixes #18546
2017-09-18 19:17:47 -07:00
Andy 79e12eb48b Ensure that emitter calls callbacks for empty blocks (#18547) 2017-09-18 10:05:44 -07:00
Benjamin Lichtman 83f2401523 Merge pull request #17954 from uniqueiniquity/regions
Add support for custom outlining regions
2017-09-15 17:04:32 -07:00
Nathan Shively-Sanders 088da79079 Merge pull request #18451 from Microsoft/allow-booleans-in-spreads
Allow `falsy | T` spreads for falsy primitives
2017-09-15 16:24:16 -07:00
Nathan Shively-Sanders cb8d9d6143 Revert spread-falsy-union/fix spread of primitive
Turns out partialising falsy unions wasn't needed -- I was just
returning the wrong thing when spreading primitives.
2017-09-15 16:11:41 -07:00
uniqueiniquity 3dfeb2d0f4 Combine and simplify regex 2017-09-15 15:52:08 -07:00
Andrew Casey abd4f58824 Restore single-token tests 2017-09-15 10:45:15 -07:00
Nathan Shively-Sanders 0197357e31 Remove mistakenly added test file
Intended for a different PR
2017-09-15 10:28:13 -07:00
Nathan Shively-Sanders 7497d4cb3a Merge branch 'master' into allow-booleans-in-spreads 2017-09-15 10:26:57 -07:00
Nathan Shively-Sanders f97d5fa11d Update tests with improved spread-falsy-union rules 2017-09-15 10:06:58 -07:00
Vakhurin Sergey 95594e3ef3 Fixed formatting for multiline initialization of object and class members (#18494) 2017-09-15 09:12:35 -07:00
Andy c522f379b2 Update assertion: symbol in union type may be a Function (#18483) 2017-09-14 15:02:32 -07:00