Commit Graph
16725 Commits
Author SHA1 Message Date
AndyandGitHub aa102435b3 Fix insertNodeAtClassStart for empty class with comment (#23342) 2018-04-26 08:00:38 -07:00
csigs 096f65c05d LEGO: check in for master to temporary branch. 2018-04-26 04:10:18 +00:00
AndyandGitHub cdfd92b90d Don't add import completion from a re-export in "./index" (#23623)
* Don't add import completion from a re-export in "./index"

* Simpler heuristic
2018-04-25 16:15:49 -07:00
Wesley WighamandGitHub 4a6888a850 There exist type parameters with symbols but without TypeParameterDeclaration nodes (#23690)
* There exist type parameters with symbols but without TypeParameterDeclaration nodes

* Add test
2018-04-25 15:53:06 -07:00
AndyandGitHub 4dc4b8d777 Remove unused property 'referencedDiagnostics' (#23688) 2018-04-25 15:24:36 -07:00
Nathan Shively-SandersandGitHub b2bfccfce4 Prototype-property assignment:fix name resolution crash (#23680) 2018-04-25 13:59:40 -07:00
AndyandGitHub 9b05bd5cd7 Remove unnecessary check for ElementAccessExpression#argumentExpression being defined (#23685) 2018-04-25 13:30:34 -07:00
Wesley WighamandGitHub ec05f29632 Make signature help node building cancellable (#23543)
* Make token building cancellable

* Scope cancellation token, make find all refs and quickinfo cancellable

* Make completion entry details cancellable

* Actually accept public API update

* Add test verifying cancellations within checker for select language service operations

* Document runWithCancellationToken a bit more

* Add post-cancellation verification to test
2018-04-25 11:44:13 -07:00
AndyandGitHub 583bcea603 Always parse an argument for an ElementAccessExpression (#23683) 2018-04-25 10:08:35 -07:00
AndyandGitHub 5280d23b63 importNameCodeFix: consistently put fixes to use existing imports before fixes for existing imports (#23663) 2018-04-25 08:04:20 -07:00
csigs 16c24bd57c LEGO: check in for master to temporary branch. 2018-04-25 04:10:19 +00:00
csigs dfbc842164 LEGO: check in for master to temporary branch. 2018-04-24 22:11:15 +00:00
Sheetal NandiandGitHub ce5d5d8f72 Merge pull request #23636 from Microsoft/getErrWithInferredProject
Fix the crash when reporting errors of file that was referenced by inferred project root, is opened right after closing the root file
2018-04-24 11:33:29 -07:00
Anders HejlsbergandGitHub 5d67f8ef68 Merge pull request #23645 from Microsoft/distributeKeyofUnion2
Distribute 'keyof' union types (take 2)
2018-04-24 10:09:45 -07:00
AndyandGitHub 59765e2d86 goToDefinition: Also add definitions for symbol if it does not match the signature symbol (#23657) 2018-04-24 09:41:47 -07:00
csigs b72abdb120 LEGO: check in for master to temporary branch. 2018-04-24 16:10:31 +00:00
AndyandGitHub 969aa45ea5 Improve error message for unused type (#23633) 2018-04-24 08:54:42 -07:00
AndyandGitHub eca17ac243 Support import fix even when the error is that a type is used as a value (#23655) 2018-04-24 08:54:14 -07:00
csigs 0e5ea2c8f6 LEGO: check in for master to temporary branch. 2018-04-24 10:10:45 +00:00
csigs 90500e88df LEGO: check in for master to temporary branch. 2018-04-24 04:10:22 +00:00
Anders Hejlsberg 09590bc041 Transform 'keyof (A | B)' to 'keyof A & keyof B' 2018-04-23 20:57:11 -07:00
AndyandGitHub fc30bd10e3 Suggestion to convert to ES6 module should only trigger in projects which express some intent to use ES6 (#23576) 2018-04-23 16:05:37 -07:00
Sheetal Nandi 6ec763884e Fix the crash when reporting errors of file that was referenced by inferred project root, is opened right after closing the root file
Fixes the crash reported in https://github.com/Microsoft/TypeScript/issues/23255#issuecomment-382653325
2018-04-23 15:36:32 -07:00
Nathan Shively-SandersandGitHub 905f9a02ad module.exports = Entity is an alias, just like export = Entity (#23570)
* Make `module.export =` an alias like `export=` is

This breaks a couple of tests for previous workarounds. Fix in upcoming
commits.

* Basically fixes all the breaks, but needs cleanup

* More notes to myself

* Clean up TODOs

* Call mergeSymbolTable and delete export= afterward

instead of basically copying the code myself.

* More cleanup

* Remove unnecessary check in import type checking

* Revert to DIY code.

It is more correct and will go away in a few days.

* Exported class expressions can be used as type

In both JS and TS

* Do not require named class expressions
2018-04-23 15:24:31 -07:00
csigs 1f753b3962 LEGO: check in for master to temporary branch. 2018-04-23 22:10:46 +00:00
AndyandGitHub 222f35d927 Make symbol display at ExportSpecifier use 'export', not 'import' (#23629) 2018-04-23 13:29:14 -07:00
Anders HejlsbergandGitHub 0179d97403 Merge pull request #23592 from Microsoft/improveIndexTypes
Support number and symbol named properties with keyof and mapped types
2018-04-23 13:22:56 -07:00
AndyandGitHub 645258cc7d Allow getting import completion details with misspelled name (#23624) 2018-04-23 11:24:51 -07:00
AndyandGitHub 2e78d1ef21 getEditsForFileRename: Update tsconfig "files" (#23625) 2018-04-23 11:11:06 -07:00
Wesley WighamandGitHub eb112ab492 Deduplicate declarations in combined type/value symbols (#23593) 2018-04-21 12:50:05 -07:00
Mohamed HegazyandGitHub 7f34340dcf Merge pull request #21476 from Kingwl/concat-string-in-enum-member
allow string concat in enum member declaration
2018-04-21 12:42:10 -07:00
Anders Hejlsberg 652e4932f6 Address CR feedback 2018-04-21 09:32:46 -07:00
csigs cb96e3fad5 LEGO: check in for master to temporary branch. 2018-04-21 10:10:32 +00:00
csigs 5b2f4ac380 LEGO: check in for master to temporary branch. 2018-04-21 04:10:23 +00:00
csigs ec0e04f853 LEGO: check in for master to temporary branch. 2018-04-20 22:10:46 +00:00
AndyandGitHub 699ea246ff Skip arrow functions in checkAndReportErrorForMissingPrefix (#23584) 2018-04-20 15:02:18 -07:00
AndyandGitHub 5c94bef0e1 Add 'renameFile' command to services (#23573)
* Add 'renameFile' command to services

* renameFile -> getEditsForFileRename

* Support `<reference path>` directives
2018-04-20 13:43:09 -07:00
Nathan Shively-SandersandGitHub e65681a2b7 Fix assert in getjsdochost (#23575)
* Fix assert in getJSDocHost

* Update public API to add wider type

* Remove now-unnecessary type assertion
2018-04-20 10:41:58 -07:00
AndyandGitHub 22f2b118b7 Add 'triggerCharacter' option for completions requests (#23491)
* Add 'triggerCharacter' option for completions requests

* mhegazy code review

* More code review

* Handle '<' in comment
2018-04-20 10:25:58 -07:00
Mohamed HegazyandGitHub 2826bc72b8 Merge pull request #23470 from JoshuaKGoldberg/standardized-non-pretty-newlines
Adjusted newlines in non-pretty output for consistency
2018-04-20 10:01:03 -07:00
Anders Hejlsberg eb7bbfb28e Properties with numeric names have numeric literal types in keyof T 2018-04-20 09:55:59 -07:00
AndyandGitHub 18c3f5ffa0 Use getFirstConstructorWithBody in one more place, and simplify other class members iteration (#23567) 2018-04-20 09:43:38 -07:00
AndyandGitHub 94cc59ca60 Support getting JSDoc comment starting at a FunctionType node (#23546)
* Support getting JSDoc comment starting at a FunctionType node

* Move || to end of line
2018-04-20 09:43:20 -07:00
Mohamed HegazyandGitHub c8e4b7ba50 Merge pull request #23566 from ajafff/generator-cfa
binder: don't inline control flow of generator function
2018-04-20 09:11:50 -07:00
csigs 760f8b85ab LEGO: check in for master to temporary branch. 2018-04-20 16:10:25 +00:00
Klaus MeinhardtandNathan Shively-Sanders f57ba59a77 resolveEntityName: don't return false (#23563)
Fixes: #23562
2018-04-20 08:42:29 -07:00
Klaus Meinhardt 4827728b16 binder: don't inline generator function's control flow
Fixes: #23565
2018-04-20 16:26:53 +02:00
csigs ee834a270a LEGO: check in for master to temporary branch. 2018-04-20 10:10:36 +00:00
Josh Goldberg 7812e5180f Trailing whitespace, oh no! 2018-04-19 22:01:08 -07:00
Josh Goldberg 351251193d Simplified to one output line 2018-04-19 21:54:08 -07:00