Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
30,862 Commits 367 Branches 233 Tags
97a072926ffe2cb870732295fd3f0608e9a4e768
Commit Graph
5807 Commits
Author SHA1 Message Date
Daniel RosenwasserandGitHub 97a072926f Revert "Add '(approximate)' to the beginning of quick info requests in PartialSemantic mode (#40061)" (#40072) 
This reverts commit 2426eb4980.
 2020-08-17 11:45:39 -07:00
Daniel RosenwasserandGitHub 2426eb4980 Add '(approximate)' to the beginning of quick info requests in PartialSemantic mode (#40061) 
* Add '(approximate)' to the beginning of quick info requests.

* Use 'approximation' instead of 'approximate'.
 2020-08-14 17:54:10 -07:00
ZenandGitHub 0ed523bb60 fix jsx completions after attributes (#39859) 
closes #39530
 2020-08-13 16:14:12 -07:00
Sheetal NandiandGitHub 03d946d145 Revert to including only open files in partial semantic server mode (#40026) 2020-08-12 20:45:59 -07:00
Jesse TrinityandGitHub 91a7c359b3 Insert auto imports after header comment (#39924) 
* place first import after header

* don't insert before non-header
 2020-08-06 13:33:29 -07:00
Andrew BranchandGitHub 87a3b42d72 Handle empty package.json files (#39937) 2020-08-06 11:04:21 -07:00
Sheetal NandiandGitHub da5ff57608 Renames in servermode per feedback (#39883) 
* Server mode renames as per feedback

* More renames
 2020-08-05 12:19:15 -07:00
Andrew BranchandGitHub 7f4e1b699a Find tagless JSDoc as preceding token (#39912) 2020-08-05 10:09:45 -07:00
Sheetal NandiGitHubDaniel Rosenwasser
 		aee78acedb Add separate flag serverMode for server mode (#39735) 
* Add separate flag serverMode for server mode to allow back compatibility

* Addressed code review feedback.

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
 2020-08-02 18:18:26 -07:00
Andrew BranchandGitHub 86a87c493c Limit auto import provider project size (#39855) 
* Limit auto import provider project size

* Add test

* Make option configurable

* Fix test

* Only bail when setting is auto

* Fix other test

* Update API baseline
 2020-08-02 17:47:49 -07:00
Orta TheroxGitHubAndrew Branch
 		faf128de15 Fix formatting scanner on JSX text that looks like trivia (#39718) 
* Fix formatting scanner on JSX text that looks like trivia

* Combine if statements

Co-authored-by: Andrew Branch <andrew@wheream.io>
 2020-07-30 13:56:14 -04:00
Andrew BranchandGitHub 8f04f91ef5 Add diagnostic info to getNameForExportedSymbol crash (#39790) 
* Add diagnostic info to getNameForExportedSymbol crash

* Add JS indicator
 2020-07-28 12:53:56 -07:00
Sheetal NandiGitHubNathan Shively-Sanders
 		48e58f44db Handle unresolved baseType when trying to get completions for static member (#39731) 
* Handle unresolved baseType when trying to get completions for static member
Fixes  #38067

* Update src/services/completions.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* correct the condition

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-07-24 16:37:28 -07:00
Andrew BranchGitHubSheetal Nandi
 		ec33814616 Make AutoImportProviderProject work with symlinked monorepos (#39679) 
* Hack everything together

* Add test

* Remove realpath from program

* Ensure symlinked directories are directories

* Revert unnecessary change

* Update baselines

* Use host program realpath on AutoImportProviderProject files before program creation

* Which fixes hasRoots() too

* Apply suggestions from code review

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>

* Lint

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
 2020-07-22 13:53:30 -07:00
Andrew BranchandGitHub b834096998 Fix emit/formatting issues in refactors (#39506) 
* Fix #37948

* Fix formatter skipping tab/space fixup on comments, handle trailing commas in list closing line count.

Fixes #37944

* Add newline between imports and main body of new file in moveToNewFile

Fixes #37941

* Update baseline (probably broken before?)
 2020-07-22 10:31:42 -07:00
SongGitHubOrta
 		e76d17257a Fix 38219: signature helper works for optional function condition. (#39672) 
* fix optional fuction condition.

* Adds a test

Co-authored-by: Orta <git@orta.io>
 2020-07-22 12:30:21 -04:00
SongandGitHub d897646a4a fix 39453 (#39579) 
* fix 39453

* add restriction.

* add tests

* comment.

* fix as suggestion.
 2020-07-21 09:40:25 -07:00
Sheetal NandiGitHubDaniel Rosenwasser
 		667ba74c93 Resolve only relative references in open files on syntax server (#39476) 
* Resolve only relative references in open files on syntax server

* Support resolving tripleslash references only in the open file

* Apply suggestions from code review

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
 2020-07-16 14:31:24 -07:00
Alexander TandGitHub c07c885151 fix(39515): fix getting a position for an element before the line break CRLF/LF on the line that contains 'after' element (#39554) 2020-07-16 13:56:30 -07:00
Alexander TandGitHub 6430211f8f fix(38868): add separator for type parameters (#39621) 2020-07-16 10:58:16 -07:00
Alexander TandGitHub ececf3b0a7 fix(33511): show jsx namespace default import quick fix if it does not exists in the current scope (#38419) 2020-07-14 15:43:18 -07:00
Jesse TrinityGitHubNathan Shively-Sanders
 		17022388bd Add refactor convertToOptionalChainExpression (#39135) 
* add convertOptionalChain

* cover more cases

* expose containsMatchingReference

* clean up performing edits

* bound start position

* add tests

* refactor and handle edge cases

* update tests

* consider explicit requests for empty spans

* update fourslash to use trigger reason

* add tests cases for trigger reason

* fix errors

* remove type assertion

* fix non ampersand chains

* clean up some logic

* add ternary case

* add diagnostic message

* add nullish check for ternary expressions

* Update src/services/refactors/convertToOptionalChainExpression.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Update src/services/refactors/convertToOptionalChainExpression.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Update tests/cases/fourslash/refactorConvertToOptionalChainExpressionForTriggerReason3.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Update tests/cases/fourslash/refactorConvertToOptionalChainExpressionForTriggerReason1.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* reformat and remove unused checks

* allow any for ternary refactor

* add tests

* add tests

* check return and variable statements

* use isMatchingReference instead of containsMatchingReference

* allow partial selections

* fine tune selection ranges

* recurse for call expressions

* fix spellings

* add recursive cases

* remove isOrContainsMatchingReference

* cleanup

* more refactoring

* cleanup

* rename tests

* address PR comments

* check match syntactically

* handle another call expression case

* some renames

* inline some checks

* add test

* address comments

* add refactorNotAvailableReason

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-07-13 19:33:33 -07:00
Armando AguirreandGitHub 6279f981b3 Merge pull request #37029 from armanio123/AddToggleCommentFeature 
Add ToggleLineComment and ToggleMultilineComment service
 2020-07-13 17:48:50 -07:00
Andrew BranchandGitHub 3c91133f97 Fix find-all-references on undefined (#39591) 
* Fix find-all-references on `undefined`

* Show references in input files in baseline

* Inline commentEachLine

* firstOrUndefined doesn’t take undefined
 2020-07-13 17:21:16 -07:00
Armando Aguirre 635ee24a3c Merge remote-tracking branch 'upstream/master' into AddToggleCommentFeature 2020-07-13 16:58:19 -07:00
Ron BucktonandGitHub 2c08affa0d Merge pull request #39264 from microsoft/migrateMapsAndSets 
Migrate maps and sets
 2020-07-13 10:38:30 -07:00
Kenn SarsabaandGitHub 629dd6487b Fix typo (#39585) 2020-07-13 07:43:53 -07:00
Armando Aguirre 0d38f09e36 PR comments and minor bugs 2020-07-10 17:44:02 -07:00
Sheetal NandiandGitHub 8002473ea6 Add ClassExpression, FunctionExpression and ArrowFunction to check for cancellation token from classifier (#39557) 
Fixes #35364
 2020-07-10 13:39:09 -07:00
Armando Aguirre a534f2aa97 Fixed syntax error 2020-07-09 22:15:02 -07:00
Armando Aguirre ef81a0d0ee Merge remote-tracking branch 'upstream/master' into AddToggleCommentFeature 2020-07-09 21:55:36 -07:00
Armando Aguirre b81f240e96 PR comments 2020-07-09 18:35:54 -07:00
Sheetal NandiandGitHub b397d1fd4a Fixes searches for export * as 'identifier' (#39533) 
* Fixes searches for export * as 'identifier'
Fixes #39006

* Fix the context span to export declaration (was incorrectly set to sourceFile in prev commit)
 2020-07-09 13:45:43 -07:00
ShuiRuTianGitHubSong GaoSheetal Nandi
 		bf1ea6508b fix static method reference non-static (#38730) 
* fix static method reference non-static

* fix contextRangeIndex

* fix lint.

* fix style.

* update according to suggestion.

* continue fix.

* use every rather than foreach

* format

* fix

* add comment.

* fix according to review suggestions.

* Update src/services/findAllReferences.ts

* Update src/services/findAllReferences.ts

* Update src/services/findAllReferences.ts

* Update src/services/findAllReferences.ts

* Update src/services/findAllReferences.ts

Co-authored-by: Song Gao <song.gao@laserfiche.com>
Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
 2020-07-09 12:21:12 -07:00
Jesse TrinityandGitHub 8e9de9bed2 Fix39458 (#39508) 
* remove undefined from optional parameter

* accept baselines

* use getTypeWithFacts
 2020-07-09 11:17:18 -07:00
Andrew BranchandGitHub 03c79d7422 Insert auto-imports in sorted order (#39394) 
* Sort auto-imports

* Avoid re-checking sort all the time

* Add comment
 2020-07-08 15:25:04 -07:00
Alexander TandGitHub 48c19eebaf fix(25155): add space before optional parameters/properties (#38798) 2020-07-08 13:38:15 -07:00
Sheetal NandiandGitHub 0f86c04af3 Fixes searches for symbols exported using export * as (#39507) 
Fixes #39006
 2020-07-08 13:31:21 -07:00
Alexander TandGitHub ebac7ec08f fix(39421): omit prefix text for rest binding element (#39433) 2020-07-08 13:25:28 -07:00
Nathan Shively-SandersandGitHub 53a756ea63 Type this in more constructor functions (#39447) 
* Type `this` in more constructor functions

Previously,  `this: this` in constructor functions only when there was
an explicit `@constructor` tag on the function. Now, `this: this` for
any function that's known to be a constructor function.

This improves completions inside constructor functions; also note that
previously the compiler *did* type `this: this` inside methods of constructor
functions, so this fix makes us more consistent. This is reflected in
the large number of baselines that improve.

The fix is a simple switch to `isJSConstructor`, which is the standard
way to detect constructor functions. I'm not sure why the original PR
didn't use this method.

I remember discussing this limitation in the original bug, #25979, and
I guess I decided that it made sense. But I was heavily primed by the bug's
framing of the problem in terms of `noImplicitThis`, which *should*
require an explicit `@constructor` tag.

With better typing comes better detection of `@readonly` assignment; I
had to fix the readonly detection code to use `isJSConstructor` as well.

* Remove `Add @class tag` fix for noImplicitThis.

The new rules mean that it never applies. It's possible that it should
apply to functions like

```js
function f() {
  this.init()
}
```

In which `init` is never defined, but I think this program is incomplete
enough that not offering the fix is fine.

* Fix precedence of `@this`

Previously, both `@class` and `@this` in a jsdoc would cause the `@this`
annotation to be ignored. This became a worse problem with this PR,
because `this` is correctly typed even without the annotation.

This commit makes sure that `@this` is checked first and used if
present.
 2020-07-08 08:44:17 -07:00
Ron Buckton 9d5cd280ef Merge branch 'master' into migrateMapsAndSets 
# Conflicts:
#	src/compiler/checker.ts
#	src/compiler/commandLineParser.ts
#	src/compiler/core.ts
#	src/compiler/moduleNameResolver.ts
#	src/compiler/transformers/declarations.ts
#	src/compiler/tsbuildPublic.ts
#	src/compiler/types.ts
#	src/compiler/utilities.ts
#	src/harness/client.ts
#	src/server/editorServices.ts
#	src/server/typingsCache.ts
#	src/server/utilities.ts
#	src/services/codefixes/convertToAsyncFunction.ts
#	src/services/documentRegistry.ts
#	src/services/importTracker.ts
#	src/services/refactorProvider.ts
#	src/services/refactors/extractSymbol.ts
#	src/testRunner/unittests/programApi.ts
#	src/typingsInstallerCore/typingsInstaller.ts
#	tests/baselines/reference/api/tsserverlibrary.d.ts
#	tests/baselines/reference/api/typescript.d.ts
 2020-07-07 13:53:46 -07:00
Andrew BranchandGitHub 0c75021860 Process type nodes in codefixes/refactors for auto-imports recursively (#39130) 
* Process type nodes for auto-imports recursively

* Rename function
 2020-07-07 13:11:23 -07:00
Alexander TandGitHub 6b493f2048 fix(23871): change insertNodeAfter to replaceNode to avoid extra newlines (#38045) 2020-07-07 12:54:03 -04:00
Alexander TandGitHub 2a92a6ea91 fix(39332): handle quotes preference in interface method signatures (#39348) 2020-07-06 17:00:35 -07:00
Daniel RosenwasserandGitHub 64696225ab Merge pull request #39418 from a-tarasyuk/feat/25259-diagnostic 
feat(25259): Better error report for equals instead of colon in object literals / change diagnostic message
 2020-07-06 12:13:49 -07:00
Daniel RosenwasserandGitHub 77bf2045d8 Merge pull request #39379 from a-tarasyuk/bug/39346 
fix(39346): Intelligent code completion not working in child class with composited base interface
 2020-07-06 11:59:30 -07:00
Alexander T 9f8585913b feat(25259): change diagnostic message 2020-07-04 09:05:47 +03:00
Alexander T d137e4a23b fix(39346): show completion in inherited classes from the composited base interface 2020-07-02 11:40:17 +03:00
Ron BucktonandGitHub 7b942b4fa8 Revert the type change to ts.Map (#39366) 2020-07-01 17:00:26 -07:00
Nathan Shively-SandersandGitHub df5981319f Fix crash on completion in jsdoc namepath (#39347) 
contextToken may be undefined, so the isAssertionExpression call in
filterGlobalCompletion needs to check for undefined.
 2020-06-30 15:53:13 -07:00