Commit Graph
499 Commits
Author SHA1 Message Date
Mohamed Hegazy 962c4de875 Address code review comments 2014-10-27 15:30:38 -07:00
Mohamed Hegazy b6f4aa9da9 Fix wrong condition for unterminated multi-line comments 2014-10-23 14:08:04 -07:00
Mohamed Hegazy 3c32fcc8df Move helpers to the bottom of the function 2014-10-23 13:44:10 -07:00
Mohamed Hegazy 48404452b8 Cleanup completion list logic:
- Do not walk the tree multiple times for the same session, instead pass along the previous token
- Use current token if the this is not after a dot to avoid running into scoping issues
- Also, add some documentation about different steps
2014-10-23 13:42:56 -07:00
Mohamed Hegazy 899271ce57 Merge branch 'master' into completionFixes
Conflicts:
	src/services/services.ts
2014-10-23 12:57:22 -07:00
Mohamed Hegazy d327873d7b Fix issue #764, select the correct scope node if not left of a dot 2014-10-23 12:52:42 -07:00
Mohamed Hegazy 669044c495 Fix issue #866, detect the current location correctelly in completion entry details 2014-10-23 12:35:04 -07:00
Mohamed Hegazy 3dc6072f58 Disallow completion in interface declarations 2014-10-23 09:27:50 -07:00
Mohamed Hegazy 463b2392b7 remove call to getSourceUnit 2014-10-22 17:36:43 -07:00
Mohamed Hegazy 417cea9cc0 move completion list position detection to the new tree 2014-10-22 17:33:16 -07:00
Daniel Rosenwasser 06e5f158ca Merge branch 'master' into syntacticClassificationOnNewTree 2014-10-22 15:57:03 -07:00
Daniel Rosenwasser 32606ac1b6 Addressed CR feedback. 2014-10-22 15:56:00 -07:00
Anders Hejlsberg 051478d7d5 Merge pull request #942 from Microsoft/unionTypeFixes
Union type fixes and optimizations
2014-10-22 14:48:22 -07:00
Anders Hejlsberg 71c69a8e83 Renaming getApparentPropertyOfType to getPropertyOfType 2014-10-22 14:33:06 -07:00
Anders Hejlsberg f4ccaf28c3 Union type fixes and optimizations 2014-10-22 10:53:08 -07:00
Jason Freeman 1b8814cdcd Address PR feedback 2014-10-20 11:51:45 -07:00
Jason Freeman c20e4f53ea Produce SignatureHelpParameters from type parameters for generic help 2014-10-17 17:03:45 -07:00
Jason Freeman 808ded88d6 Signature Help relies on display building routines in checker 2014-10-17 17:03:43 -07:00
Jason Freeman 390b92dac0 Move getChildListThatStartsWithOpenerToken inside getSignatureHelpItems 2014-10-17 16:55:07 -07:00
Jason Freeman 3961ad3b82 Merge branch 'master' into displayBuilder
Conflicts:
	src/compiler/checker.ts
2014-10-16 13:32:22 -07:00
Jason Freeman e0e9fe83d2 Address PR feedback for displayBuilder 2014-10-16 13:11:19 -07:00
Daniel Rosenwasser d33aa4335f Switched syntactic classifier to use new tree.
Also added tests.
2014-10-15 15:01:38 -07:00
Sheetal Nandi 781661f719 Merge pull request #884 from Microsoft/moveSymbolDisplayPartKindToServices
Move symbolDisplayPartKind to services side
2014-10-15 13:57:58 -07:00
Jason Freeman 672d8e576f Get rid of getRootSymbol and include target's flags in transient symbol's flags 2014-10-15 12:20:22 -07:00
Dick van den Brink 648c697257 Removed some unused var statements 2014-10-15 20:11:35 +02:00
Jason Freeman 1619738b93 Extract the write methods into a display builder in the checker 2014-10-14 17:30:30 -07:00
Daniel Rosenwasser dde8855530 Merge branch 'master' into semanticColorizationModules
Conflicts:
	src/services/services.ts
2014-10-14 17:07:16 -07:00
Daniel Rosenwasser 6971c3a9cb Removed unnecessary boolean coercion. 2014-10-14 16:22:16 -07:00
Mohamed Hegazy f5cd4145d5 Merge branch 'master' into unionTypes
Conflicts:
	src/compiler/types.ts
	src/services/services.ts
2014-10-13 16:16:13 -07:00
Mohamed Hegazy 4f4f59a781 Merge changes from master in services.ts 2014-10-13 14:06:16 -07:00
Sheetal Nandi ab48363bfa Fix how arguments and undefined are shown in the quickInfo
Removes the undefined identication from symbol flags instead add method to typechecker
2014-10-13 13:06:03 -07:00
Anders Hejlsberg fc842b177e Merge branch 'master' into unionTypes
Conflicts:
	src/compiler/checker.ts
	src/compiler/types.ts
	src/services/services.ts
	tests/baselines/reference/assignmentCompatBetweenTupleAndArray.errors.txt
	tests/baselines/reference/bestCommonTypeOfTuple.types
	tests/baselines/reference/bestCommonTypeOfTuple2.types
	tests/baselines/reference/castingTuple.errors.txt
	tests/baselines/reference/contextualTypeWithTuple.errors.txt
	tests/baselines/reference/genericCallWithTupleType.errors.txt
	tests/baselines/reference/indexerWithTuple.types
	tests/baselines/reference/numericIndexerConstrainsPropertyDeclarations.errors.txt
2014-10-13 12:37:34 -07:00
Sheetal Nandi a934d50a9b Move symbolDisplayPartKind to services side 2014-10-13 12:35:17 -07:00
Mohamed Hegazy 4442b45bad Add a temporary fix to quick info 2014-10-10 17:19:43 -07:00
Daniel Rosenwasser 41c45a9088 Fixed semantic colorization for module names on the value side. 2014-10-10 17:04:30 -07:00
Mohamed Hegazy f5a9feee9f ensure unionProperty symbols have declarations set at creation time 2014-10-10 16:41:05 -07:00
Sheetal Nandi 6f6be7e0e4 Removed incorrect check of symbolKind determination of undefined symbol 2014-10-10 15:58:33 -07:00
Sheetal Nandi 3715af1a5a Show call and construct signatures when using aliases 2014-10-10 15:52:34 -07:00
Sheetal Nandi 471d80d91e Show better alias information in completion entry and quickInfo 2014-10-10 15:24:19 -07:00
Sheetal Nandi 8ff6251200 Do not use internal aliasing when getting symbol full name to show in quickInfo or completion list 2014-10-10 15:02:48 -07:00
Mohamed Hegazy 9f43ac02de respond to code review remarks 2014-10-10 10:59:30 -07:00
Daniel Rosenwasser b2457bd9b3 Re-added semantic colorization fix for colliding types colliding in value and namespace space, added a test. 2014-10-09 17:02:23 -07:00
Daniel Rosenwasser c5c05769d7 Merge pull request #865 from Microsoft/undoContextualSemanticClassification
Undid changes where contextual semantics are taken into account.
2014-10-09 14:38:49 -07:00
Daniel Rosenwasser 8659dc5ca0 Addressed CR feedback. 2014-10-09 13:54:37 -07:00
Daniel Rosenwasser 8fd1c7915c Undid changes where contextual semantics are taken into account. 2014-10-09 13:38:33 -07:00
Sheetal Nandi 87a92b3dd3 Fixed the bad merge and tests failing because of it 2014-10-09 13:18:08 -07:00
Mohamed Hegazy 927f04f64f Fix contextually typed object literal proeprties that are not properties of the union type but are properties on of one of its constituant types 2014-10-09 11:16:04 -07:00
Mohamed Hegazy dc43e83646 Merge branch 'unionTypes' into unionTypesLS
Conflicts:
	src/compiler/checker.ts
	src/services/services.ts
2014-10-09 11:02:57 -07:00
Mohamed Hegazy 2eb51ab874 Use getRootSymbols for all union property needs 2014-10-08 23:28:17 -07:00
Mohamed Hegazy 779db6e76a Support find all refs on union properties 2014-10-08 23:21:56 -07:00