* Add test case for #8229
* Do not report errors during contextual typecheck
Fixes#8229
* Handle the scenario when let [a=undefined]=[]
* Instantiate contextual this parameters if needed
* Test that contextually typed generic this parameters are instantiated
* Don't allow `.ts` to appear in an import
* Add specific error message for unwanted '.ts' extension
* Allow `await` in a simple unary expression
* More tests
* Forbid `await await`
* Allow `await await`
* Improve error message
* Don't allow ".d.ts" extension in an import either.
* Rename 'find' functions
* Assign and instantiate contextual this type if not present
* JSDoc supports null, undefined and never types
* Update baselines in jsDocParsing unit tests
* Return non-JsDocComment children
... to make syntactic classification work
* Move supportedTypescriptExtensionsWithDtsFirst next to supportedTypeScriptExtensions and rename
* Fix comment
* Treat special property access symbol differently
... when retriving documentation
* Fix tests
* Update shim version to be 2.1 (#10424)
* Check return code paths on getters (#10102)
* Check return paths on getters
* Remove TODO comment
* Remove extraneous arguments from harness's runBaseline (#10419)
* Remove extraneous arguments from runBaseline
* Address comments from @yuit
* Remove needless call to basename
* Refactor baseliners out of compiler runner (#10440)
* CR feedback
* fix broken tests
* Pass in baselineOpts into types baselines so that RWC baselines can be written to internal folder (#10443)
* Add more test for 10426
* routine update of dom libs
* Add test for jsdoc syntactic classification for function declaration
* Simplify implementation
* Tolerate certain errors in tsconfig.json
* Add test for configFile error tolerance
* Use TS parser to tolerate more errors in tsconfig.json
* Implement tuple types as type references to synthesized generic types
* Add comments + minor changes
* Accept new baselines
* Add .types extension
* Properly guard for undefined in getTypeReferenceArity
* Add jsdoc nullable union test case to fourslash
* Fix class/interface merging issue + lint error
* Allow "typings" in a package.json to be missing its extension (but also allow it to have an extension)
* Contextually type this in getDeclFromSig, not checkThisExpr
* Update parser comment with es7 grammar (#10459)
* Use ES7 term of ExponentiationExpression
* Update timeout for mac OS
* Address PR: add space
* allowSyntheticDefaultImports resolves to modules instead of variables
Fixes#10429 by improving the fix in #10096
* Rename getContextuallyTypedThisParameter to getContextualThisParameter
* Fix 10472: Invalid emitted code for await expression (#10483)
* Properly emit await expression with yield expression
* Add tests and update baselines
* Move parsing await expression into parse unary-expression
* Update incorrect comment
* Add test case for #8229
* Do not report errors during contextual typecheck
Fixes#8229
* Handle the scenario when let [a=undefined]=[]
* Don't allow `.ts` to appear in an import
* Add specific error message for unwanted '.ts' extension
* Allow `await` in a simple unary expression
* More tests
* Forbid `await await`
* Allow `await await`
* Improve error message
* Don't allow ".d.ts" extension in an import either.
* Rename 'find' functions
* Move supportedTypescriptExtensionsWithDtsFirst next to supportedTypeScriptExtensions and rename
* Fix comment
* Treat special property access symbol differently
... when retriving documentation
* Fix tests
* Update shim version to be 2.1 (#10424)
* Check return code paths on getters (#10102)
* Check return paths on getters
* Remove TODO comment
* Remove extraneous arguments from harness's runBaseline (#10419)
* Remove extraneous arguments from runBaseline
* Address comments from @yuit
* Remove needless call to basename
* Refactor baseliners out of compiler runner (#10440)
* CR feedback
* fix broken tests
* Pass in baselineOpts into types baselines so that RWC baselines can be written to internal folder (#10443)
* Change getUnionType to default to no subtype reduction
* Remove unnecessary subtype reduction operations
* Use binary searching in union types to improve performance
* Optimize type inference
* Fixed broken singleAsteriskRegex. Fixes#9918 (#9920)
* Lock ts-node to 1.1.0 while perf issue is investigated (#9933)
* Fix typo in comment for MAX_SAFE_INTEGER
* In ts.performance.now, bind window.performance.now
Using an arrow function. Previously, it was set directly to
window.performance.now, which fails when used on Chrome.
* Add lint enforcing line endings (#9942)
* Add servicesSources to the list of prerequisites for running tests
* Support emitting static properties for classes with no name
* Add assertion whitespace lint rule (#9931)
* Add assertion whitespace lint rule
* Fix typo
* Add the word `Rule` to Jakefile
* Limit travis build matrix (#9968)
* Convert getErrorBaseline to use canonical diagnostic formatting (#9708)
* Convert getErrorBaseline to use canonical diagnostic formatting
* Fix lint
* Found another clone of format diagnostic - consolidate
* Fully declone
* Unify nodeKind implementations for navigationBar and navigateTo
* Fix test and rename a function
* Fix lint errors
* Remove hardcoded port, use the custom port
* Unlock ts-node version (#9960)
* Allow an abstract class to appear in a local scope
* JSDoc understands string literal types
Unfortunately, I didn't find a way to reuse the normal string literal
type, so I had to extend the existing JSDoc type hierarchy. Otherwise,
this feature is very simple.
* Update baselines to be current
* Add find and findIndex to ReadonlyArray
* The optional this should be readonly too.
* Update baseline source location
* Re-add concat overload to support inferring tuples
* Update baselines with new concat overload
* Update LastJSDoc[Tag]Node
* Display enum member types using qualified names
* Accept new baselines
* Fix lint error
* null/undefined are allowed as index expressions
`null` and `undefined` are not allowed with `--strictNullChecks` turned
on. Previously, they were disallowed whether or not it was on.
* Use correct nullable terminology
* Get rid of port parameter
* Remove [port] in usage message
* Properly reset type guards in loops
* Add regression test
* Introduce the `EntityNameExpression` type
* Allow `export =` and `export default` to alias any EntityNameExpression, not just identifiers.
* Lint tests helper files
* recreate program if baseUrl or paths changed in tsconfig
* Simplify some code
* Have travis use a newer image for the OSX build (#10034)
Suggested by travis support for stopping the randomly-halting-builds issue.
* Correctly check for ambient class flag
* Use "best choice type" for || and ?: operators
* jsx opening element formatting
* change error message for unused parameter property
fix
* Fix issue related to this and #8383
* Add additional tests
* Accept new baselines
* Provide `realpath` for module resolution in LSHost
* Add test
* Add test baselines
* Accept new baselines
* CR feedback
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix#10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes#10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* avoid using the global name
* Fix single-quote lint
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Correctly update package.json version
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes#10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Add completion for quote property name in object literal expression
* Add fourslash tests for completion of quoted property in object literal expression
* Handle object-literal expression as an argument
Undo wip
Undo wip
Conflicts:
src/services/services.ts
* Add tests and baseline for object literal expression for arguments
* wip
* Add completion for quote property name in object literal expression
* Add fourslash tests for completion of quoted property in object literal expression
* Handle object-literal expression as an argument
* Add tests and baseline for object literal expression for arguments
* Undo wip
* Undo wip
Kanchalai Tanglertsampan
Zhengbo Li
Yui
Mohamed Hegazy
zhengbli
Daniel Rosenwasser
jramsay
Jason Ramsay
Andy
Ron Buckton
Anders Hejlsberg
Ryan Cavanaugh
Kagami Sascha Rosylight
Wesley Wigham
Herrington Darkholme