Commit Graph
2472 Commits
Author SHA1 Message Date
Andy 0e9b815956 Improve performance of duplicate check (#23516) 2018-04-18 12:58:16 -07:00
Sheetal Nandi b0d6896235 Merge pull request #23438 from Microsoft/typingsFiles
Better handling of typing installer events and consuming typing files in tsserver
2018-04-18 11:34:46 -07:00
Benjamin Lichtman 48f98bdd4d Merge pull request #23452 from uniqueiniquity/normalizeDocumentHighlightsPaths
Normalize document highlights paths
2018-04-17 12:31:00 -07:00
Nathan Shively-Sanders db68075b67 Add create-react-app and puppeteer user tests (#23471)
* Add create-react-app

* Add puppeteer

Everything is broken now. I am going back to master to see if that fixes
things.

* Add puppeteer baseline

* Add chalk override (gitignore was ignoring it)
2018-04-17 11:21:11 -07:00
uniqueiniquity 160356317b Treat expectedRanges as readonly 2018-04-17 09:20:52 -07:00
Josh Goldberg 9dff614bd2 Combined the "Found X error(s)" and "Compilation" complete --watch messages 2018-04-17 01:47:43 -07:00
uniqueiniquity 606492b677 Fix lint error and normalization issue 2018-04-16 16:20:12 -07:00
uniqueiniquity e9d6f788ca Add test 2018-04-16 15:59:22 -07:00
Andy cae464058a Delete "delete me" files (#23446) 2018-04-16 15:29:02 -07:00
Mohamed Hegazy a8618a79e1 Merge pull request #23358 from joscha/joscha/fix-non-imports-matching
fix: do not match MySymbol.import("mod")
2018-04-16 12:37:53 -07:00
Joscha Feth 4dc9db1e70 detect nested non-imports 2018-04-15 11:27:51 +10:00
Sheetal Nandi 60b19f5782 Invalidate the unresolved import resolutions when typing files are set
This has 3 changes:
1. In updateGraph when enqueue the typing installation request (depending on unresolved imports)
2. When ActionSet event is received, invalidate only files with unresolved imports and resolve those.
3. When ActionInvalidate event is received, typing installer has detected some change in global typing cache location, so just enqueue a new typing installation request. This will repeat the cycle of setting correct typings and pickiing unresolved imports
2018-04-13 15:17:13 -07:00
Sheetal Nandi c9479f7263 Remove the specialized type UnresolvedImportsMap which is just a redirection and helps only in test only 2018-04-13 15:17:13 -07:00
Nathan Shively-Sanders a0b08f31f9 Fix jakefile case and circular references
Fails on Linux but not on Windows. Weird!
2018-04-12 16:11:16 -07:00
Sheetal Nandi a9ffabbe51 Merge pull request #23374 from Microsoft/npmInstallCommandTooLong
Handle command too long failure in typings installer
2018-04-12 14:17:47 -07:00
Ryan Cavanaugh ff60520460 Merge branch 'master' into referencesDogfood_1 2018-04-12 12:26:10 -07:00
Sheetal Nandi b3d83c81cc Handle command too long failure in typings installer 2018-04-12 11:43:18 -07:00
Joscha Feth 4da2e5eda3 fix: do not match MySymbol.import("mod") 2018-04-12 19:31:07 +10:00
Andy edcf087145 Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment (#23314)
* Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment

* Also test for export specifier
2018-04-11 19:01:30 -07:00
Ryan Cavanaugh 0e07d775a1 You have to do this everywhere now! 2018-04-11 16:59:53 -07:00
Ryan Cavanaugh df95de3231 Merge branch 'master' into referencesDogfood_1 2018-04-11 16:17:38 -07:00
Ryan Cavanaugh bb8fd41793 Fix harness file listing 2018-04-11 15:39:12 -07:00
Andy 28455c65b3 patternMatcher: Return single best match instead of list (#23166) 2018-04-11 15:35:22 -07:00
Andy f6b206a75a When testing references, also test documentHighlights respects filesToSearch (#23306)
* When testing references, also test documentHighlights respects filesToSearch

* Fix handling for redirects and move assertion inside getDocumentHighlights

* Add another assert
2018-04-11 14:07:22 -07:00
Andy f479de6d02 patternMatcher: Just return 'undefined' for an invalid pattern (#23237)
* patternMatcher: Just return 'undefined' for an invalid pattern

* Fix tests
2018-04-10 14:38:16 -07:00
Andy 4b706fc479 Add 'disableSuggestions' to UserPreferences (#23283)
* Add 'disableSuggestions' to UserPreferences

* Make mergeMapLikes return a new object

* Avoid additional clone

* mergeMapLikes -> object spread
2018-04-10 11:53:24 -07:00
Andy 556a8010b9 Fix bug: ensure 'reportsUnnecessary' is actually sent by tsserver (#23293) 2018-04-10 10:15:15 -07:00
Andy 71b39014eb Fix bug: Include comment for @param tag with nested tag (#23276)
* Fix bug: Include comment for @param tag with nested tag

* Add another comment to test
2018-04-09 14:09:59 -07:00
Sheetal Nandi 7a0a1f6a28 Do not watch script infos that are part of global typings location 2018-04-06 15:52:39 -07:00
Sheetal Nandi 62c6fe2ccc There is no need to ensure project structure when tryiong to get inferred project
The project operations will validate if its valid anyways
2018-04-06 14:22:08 -07:00
Andy 24842b4002 When --noUnusedLocals/--noUnusedParameters is disabled, add suggestions instead of errors (#22361)
* When --noUnusedLocals/--noUnusedParameters is disabled, add suggestions instead of errors

* Improve performance: do not add unused suggestion diagnostics unless asking for a suggestion

* Add "unused" flag to diagnostics

* Code review

* reportsUnused -> reportsUnnecessary

* Fix test
2018-04-05 12:33:00 -07:00
Andrew Casey 855171bde5 Introduce a --syntaxOnly server mode
1. Disable the LS in all projects
 2. Don't create Program objects
 3. Ignore config files
2018-04-04 16:44:15 -07:00
Mohamed Hegazy e2bd282414 Merge pull request #22254 from JoshuaKGoldberg/pretty-watch-error-summaries
Added an errors summary for --pretty --watch results
2018-04-04 16:08:31 -07:00
Josh Goldberg 0dbebec28f Feedback: correct order in watch.ts; DRY tests 2018-04-04 13:21:19 -04:00
Wesley Wigham a81a645128 Enable member completions for import types (#23085)
* Enable member completions for import types

* Add missing semicolon

* Compact statements

* Ye doth compacteth too much

* Handle class accesibility
2018-04-03 11:53:01 -07:00
Mohamed Hegazy e6fa4e4415 Merge pull request #23043 from alan-agius4/feature/compiler-host-falsy-file
fix: `CompilerHost.getSourceFile` is being called for odd filenames
2018-04-02 17:08:31 -07:00
Andy 72e92a0558 Remove unused properties from patternMatcher (#23076) 2018-04-02 12:02:35 -07:00
Alan Agius 7e482b27fb fix: CompilerHost.getSourceFile is being called for odd filenames besides the one being compiled
Ignore falsy file names from `getDefaultLibraryFileName`

Closes: #13629
2018-04-02 20:58:37 +02:00
Josh Goldberg cf0a0ec001 Fixed unit tests for error counts 2018-04-01 22:57:38 -07:00
Josh Goldberg d268279c8e Merge branch 'master' into pretty-watch-error-summaries 2018-04-01 21:44:55 -07:00
Mohamed Hegazy 849ecdf50a Merge pull request #22981 from a-tarasyuk/bug/advanced-options-do-not-work-with---init
Allow using Advanced_Options with --init
2018-03-30 09:22:49 -07:00
Alexander T 75df5456a2 Allow using Advanced_Options with --init. Exclude all possible Advanced_Options in tsconfig.json which were NOT defined in command line 2018-03-30 07:49:16 +03:00
Wesley Wigham 3189d1732c Handful more usages of emitIfPresent on optional nodes (#22274) 2018-03-29 15:45:17 -07:00
Sheetal Nandi a0fe072fa7 Merge pull request #22613 from Microsoft/configFileErrors
Make config file parsing errors available through program and expose API
2018-03-29 13:08:03 -07:00
Sheetal Nandi d8bf95ff10 PR feedback 2018-03-29 09:13:03 -07:00
Sheetal Nandi f885cd971e Do not watch child directories of the sym link folders
Fixes #22668
2018-03-28 21:11:13 -07:00
Sheetal Nandi e40f2943b1 Revert "Do not watch child directories of the sym link folders"
This reverts commit 3280865049.
2018-03-28 21:10:29 -07:00
Sheetal Nandi 3280865049 Do not watch child directories of the sym link folders
Fixes #22668
2018-03-28 18:37:07 -07:00
Andy b518120883 findAllReferences: Respect search file set searching for references to an exported symbol (#22657)
* findAllReferences: Respect search file set searching for references to an exported symbol

* Remove debugging code
2018-03-27 18:48:27 -07:00
Andy 3e32e15895 Add 'fixAllDescription' property to CodeFixAction (#22616)
* Add 'fixAllDescription' property to CodeFixAction

* Code review

* Add to protocol

* Make fixAllDescription be just a string
2018-03-27 18:21:21 -07:00