Commit Graph
28283 Commits
Author SHA1 Message Date
Sheetal Nandi 8ac45805c0 Add error related to file not in rootDir and file not part of included root files at the references 2019-08-09 14:19:40 -07:00
Sheetal Nandi fd515b519e Handle status and error messages for better checking 2019-08-09 13:38:25 -07:00
Sheetal Nandi 9e8fbcd7f8 Transitively upstream blocked project should not build 2019-08-09 13:38:25 -07:00
Sheetal Nandi 94d54b967d Circular reference in the build queue is build stoppable error 2019-08-09 13:38:25 -07:00
Sheetal Nandi d9ad559042 Verify demo build 2019-08-09 13:38:24 -07:00
Nathan Shively-Sanders 85b8d27ea3 Remove error on invalid jsdoc tokens (#32769)
* Remove error on invalid jsdoc tokens

In JSDoc:

1. In the scanner, don't issue an error, even for invalid identifiers.
2. In the binder, don't issue an error for reserved (but otherwise valid)
identifiers.

/**
 * Example of 1: "\"
 * Example of 2: @private
 */

* Update baselines

* Add invalid unicode escape test for JSDoc

* Add quotes around invalid unicode escape

* Add another unicode escape JSDoc test
2019-08-09 12:53:15 -07:00
Nathan Shively-Sanders b24050aefd Excess discriminated types match all discriminable properties (#32755)
* Target types in excess property checking must match all discriminable properties

This allows fewer types to be discriminated in excess properties, which
fixes some examples.

* Add excess property test

* Fix semicolon lint

* Remove extra semicolon!

* Improve EPC for unions with multiple discriminants
2019-08-08 15:34:52 -07:00
Orta b70f894881 Merge pull request #32668 from orta/fix_31209
Suppress console.log & others inside the TS Server runtime so that language service plugins don't accidentally use them and kill the server
2019-08-08 08:56:35 -07:00
Andrew Branch 984956afec Only add unnecessary-await suggestion on await expressions (#32754) 2019-08-07 11:27:36 -07:00
Ben Lichtman 9971e8b560 Merge pull request #32688 from uniqueiniquity/skipCOSForDTS
Avoid compile on save when there is no emit impact
2019-08-07 10:44:54 -07:00
Ben Lichtman 3646809ecd Move helper function outside class 2019-08-07 09:46:49 -07:00
Orta b239c2a90e Merge pull request #31366 from ypresto/fix-comment-unknown
Fix outdated comments for unknown type
2019-08-07 11:23:43 -04:00
Orta 79598af113 Merge pull request #31980 from sisisin/fix/typo-comment-at-import-tracker
chore(tsserver): fix typo
2019-08-07 11:16:24 -04:00
Orta 47182b543a Merge pull request #32454 from 0verk1ll/develop
Add Semicolons to Gulpfile.js
2019-08-07 10:29:18 -04:00
Wesley Wigham abd127f308 Only check import = reference when target is Value (#32747) 2019-08-06 16:44:42 -07:00
Wesley Wigham f333684179 Fix unicode escapes in jsx identifiers and extended unicode characters in jsdoc (#32716)
* Fix unicode escapes in jsx identifiers and extended unicode characters in jsdoc

* Support unicode escapes in JSDoc

* Add tests for extended escapes
2019-08-06 15:14:32 -07:00
Nathan Shively-Sanders 480b73915f Improve excess property checking for intersections (#32582)
* Improve excess property checking for intersections

Still a draft, the implementation needs improvement

* Use mutable isIntersection in checkTypeRelatedTo

This makes parameter lists a lot shorter. Seems like a slight
improvement, although I can revert if I change my mind.

* Fix semicolon lint

* Remove TODOOOO

* Revert "Use mutable isIntersection in checkTypeRelatedTo"

This reverts commit b8dccff2a2.
2019-08-06 15:03:24 -07:00
Wesley Wigham d00056f096 Support extended unicode escapes in identifiers, per es6 spec (#32725) 2019-08-06 14:43:41 -07:00
Ron Buckton d75740280f Resolve module specifier relative to moduleFile.originalFileName (#32722)
* Resolve module specifier relative to moduleFile.originalFileName

* Use baseline testing for outputs

* Added skipLibCheck to test

* Switch to using vfs.formatPatch for output
2019-08-06 13:48:58 -07:00
TypeScript Bot 024193fd43 Update user baselines (#32732) 2019-08-06 13:42:07 -07:00
Ben Lichtman c0f187a4e8 Allow compile on save with decorator emit 2019-08-06 13:39:18 -07:00
Andrew Casey 01e1b1bb27 Merge pull request #32612 from mrcrane/etw-logger
Use optional module "@microsoft/typescript-etw" for ETW logging
2019-08-06 12:44:48 -07:00
Michael Crane 47e77c976b Remove unnecessary 'commandSucceeded' variable 2019-08-06 11:48:31 -07:00
Nathan Shively-Sanders 269c3d3a56 Suggestions now use diagnosticCollection (#32740)
Previously they used multiMaps, unlike all the other diagnostics. This
prevents duplicate suggestions, like other kinds diagnostics.

Fixes #28710
2019-08-06 11:15:06 -07:00
Orta Therox f8b7a05777 Handle the variadic args for inline console.logs 2019-08-06 14:09:37 -04:00
Ron Buckton cc3db8f448 Merge branch 'Saulzi-master' 2019-08-06 10:48:47 -07:00
Ron Buckton 3ff0a249d2 Update based on PR feedback 2019-08-06 10:46:17 -07:00
Wesley Wigham 7adc175dfc Adjust isIdentifierText to skip multiple characters when a code point is multiple chars long (#32720)
* Adjust isIdentifierText to skip multiple characters when a code point is multiple chars long

* Add a few examples with mixed unicode characters

* for posterity, add some unicode cursive script characters

* Test some more planes more explicitly
2019-08-05 23:37:26 -07:00
Ron Buckton 624d1cad93 Fix inferred TNext of generator to use TNext of contextual return type (#32719) 2019-08-05 17:55:28 -07:00
Ron Buckton e3f4979736 Fix emit for object rest on a module export (#32699)
* Fix emit for object rest on a module export

* Add tests for exports of empty object/array binding patterns

* Add delay for exec to ensure diff tool has enough time to start
2019-08-05 16:53:21 -07:00
Wesley Wigham 3b54ffcf0e Preserve const enums should keep import refs (#28498)
* Preserve const enums should keep import refs

for exported const enums exported via export default

Move some functionality around, small cleanup

Remove unneeded const enum check

* Only mark const enums as references with preserveConstEnums on in export assignments

* Limit change to declarations and preserveConstEnums mode
2019-08-05 16:47:29 -07:00
Ron Buckton 4df2fc663c Do not include built/local/enu when producing LKG (#32723) 2019-08-05 16:19:38 -07:00
Michael Crane f6fb130530 Add 'readFileWorker' instead of modifying 'readFile' 2019-08-05 15:19:25 -07:00
sisisin 33a6509751 Fixes export destructured variables reference (#32007)
* Add basic test for current behavior

* Fixes getting destructured variables references(#31922)

* Add test case that renames destructured property

* Fixes missing nested object destrucuturing variable references
2019-08-05 12:00:06 -07:00
Ron Buckton 5710f7d5ff Merge branch 'master' of https://github.com/Saulzi/TypeScript into Saulzi-master 2019-08-05 11:17:32 -07:00
Andrew Branch c1e0db7953 Escape apparent substitution in synthesized NoSubstitutionTemplateLiterals (#32580)
* Add failing test

* Escape apparent substitution in synthesized NoSubstitutionTemplateLiterals
2019-08-05 09:31:59 -07:00
Alexander T 012bacc415 Define interface for TSConfig. Change compilerOnSave to compileOnSave (#32481) 2019-08-05 09:24:09 -07:00
Ron Buckton 3c690f1264 Move const enums and typeof facts maps out of createTypeChecker (#32691) 2019-08-03 13:09:11 -07:00
Andrew Branch e82d0af554 Fix readonly occurrences highlighting (#32583)
* Fix readonly occurrences highlighting

* Rename function

* Rename again

* Apply suggestions from code review

Remove unused function
2019-08-02 18:24:46 -07:00
Michael Crane cca32f079c Remove more try-finally blocks 2019-08-02 16:49:50 -07:00
Michael Crane 7d44a4592e Remove try-finally blocks 2019-08-02 16:39:33 -07:00
Wesley Wigham 6b4f730535 Fix binding of jsdoc typedefs with no in-comment name attached to an expression statement (#32610)
* Fix binding of jsdoc typedefs with no in-comment name attached to an expression statement

* Check toplevel flag before bind

* Small renames
2019-08-02 16:14:19 -07:00
Andrew Branch 62f65a7884 Make auto-imports more likely to be valid for the file (including JS) & project settings (#32684)
* Add failing tests

* Use default import or namespace import for import fixes when compiler options allow

* Don’t do import * for export=, ever

* Only do import default for export equals if nothing else will work

* Never do import/require in a JavaScript file

* Update tests for changes in master

* Add const/require fix for JS and select based on usage heuristic

* Fix JS UMD import
2019-08-02 15:58:10 -07:00
Andrew Branch 725321f08c Prioritize “property names” over punctuation in smart select (#32687)
* Prioritize “property names” over punctuation in smart select

* Update doc comment
2019-08-02 15:57:44 -07:00
Ben Lichtman 0cab79fc56 Add test 2019-08-02 15:56:01 -07:00
Ben Lichtman 5233bcc064 Avoid compile on save for declaration files 2019-08-02 15:53:54 -07:00
TypeScript Bot e75972cbad Update user baselines (#32683) 2019-08-02 13:36:34 -07:00
Wesley Wigham acdbd10626 Amend scanner to support astral characters in identifiers when parsing es6+ (#32096)
* Amend scanner to support astral characters in identifiers when parsing es6+

* Use charSize helper rather than one-off maybe advance helper

* Update script to emit informative comment, run in unicode 12.1 environment

* Add suggested change
2019-08-02 13:15:51 -07:00
Sheetal Nandi bf903eb48f Merge pull request #32613 from microsoft/singleHostFsWatchFile
Create only single StatFileWatcher through node
2019-08-02 11:03:28 -07:00
Michael Crane 5e19753979 Update browser table 2019-08-02 10:50:49 -07:00