Microsoft/TypeScript
1
0 Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
24,550 Commits 367 Branches 233 Tags
7b405c4ad9bed4e32b88b9393f90167acaa48415
Commit Graph
17986 Commits
Author SHA1 Message Date
Sheetal Nandi 7b405c4ad9 Test that verifies we arent updating all projects unnecessarily when called with compileOnSave and project 2018-07-30 14:10:56 -07:00
Sheetal Nandi ab1b899cea Use isArray instead of isProjectsArray 2018-07-27 12:50:32 -07:00
Sheetal Nandi 399f497a32 Unify getProjects for compileOnSave and others like (navigation etc) 2018-07-27 12:47:47 -07:00
Sheetal Nandi 94033f212d If project name is specified in compile on save, do not update all projects to just use that project 2018-07-27 11:21:14 -07:00
Andy 3bfe91cdd8 navigationBar: Fix bug for shorthand ambient module (#25992) 2018-07-26 17:27:12 -07:00
Andy af3f737451 Fix bug for isValidTrigger when contextToken is undefined (#25993) 2018-07-26 17:26:58 -07:00
Andy 0e5af11625 Fix bugs for go-to-definition on mapped type method (#25991) 2018-07-26 17:26:41 -07:00
Andy 998c911c49 Break createSignatureHelpItems into functions (#25948) 2018-07-26 17:26:29 -07:00
Andy 0227997fa5 Use import().T for import completions/fixes of pure types in JS files (#25852) 
* Use `import().T` for import completions/fixes of pure types in JS files

* Don't call tryUseExistingNamespaceImport if position undefined
 2018-07-26 16:16:57 -07:00
Wesley Wigham d590d5bd0c Remove extraneous const, fixing #25714 (#25982) 2018-07-26 14:43:00 -07:00
Daniel Rosenwasser 6b60babeaf Merge pull request #25978 from Microsoft/capturedGlobalThis 
Better error message for captured global 'this' in noImplicitThis
 2018-07-26 13:20:05 -07:00
Wesley Wigham d17efe69d1 Fix #25954 - Always retain export modifier if default modifier is present (#25974) 
* Fix #25954 - Always retain export modifier if default modifier is present

* Also fix an issue with scope markers in ambient modules not affecting the modifiers required
 2018-07-26 12:39:03 -07:00
Andy 673ae746da Simplify and inline getPropertySymbolsFromType (#25940) 
* Simplify and inline getPropertySymbolsFromType

* Combine lambdas
 2018-07-26 11:52:22 -07:00
Daniel Rosenwasser 64d01d8e8f Provide a better error on arrow functions that capture the global 'this'. 2018-07-26 11:51:04 -07:00
Mohamed Hegazy 3057be3a0b Merge pull request #25966 from ajafff/shorthandPropertyAssignment-initializer-symbol 
correctly resolve Symbol of destructuring shorthand intializer
 2018-07-26 09:32:39 -07:00
Andy 5e94cf626b Expand span of @typedef with properties to include the @typedef tag (#25950) 2018-07-26 08:56:24 -07:00
Klaus Meinhardt b65bbfd42d correctly resolve Symbol of destructuring shorthand intializer 
Fixes: #21046
 2018-07-26 14:37:52 +02:00
Sheetal Nandi d920efe3f9 Merge branch 'master' into resolveJsonModuleError 2018-07-25 17:32:22 -07:00
Andy f12e9a8389 Minor refactor in goToTypeDefinition (#25951) 2018-07-25 17:10:06 -07:00
Andy 1e8a5bf2f1 signatureHelp: Factor out 'isSyntacticOwner' function (#25518) 2018-07-25 17:01:35 -07:00
Sheetal Nandi dfb5cbd373 When json module is not found, include enabling --resolveJsonModule might help. 
Fixes #25722
 2018-07-25 16:20:37 -07:00
Matt McCutchen da64479a64 Improve the error message when asserting to a type that is not 
comparable to the original.

Also improve the error message for implicit conversion of a symbol to a
string in a template literal, which previously shared the error message
with type assertions.

Fixes #25539.  Addresses #25870.
 2018-07-25 19:13:10 -04:00
Anders Hejlsberg 7473772291 Merge pull request #25938 from Microsoft/fixRestTupleArityCheck 
Fix rest tuple arity check
 2018-07-25 14:40:57 -07:00
Anders Hejlsberg 5288c37010 Rest parameter with fixed size tuple should be same as regular parameters 2018-07-25 12:42:37 -07:00
Andy 7546fd03c6 Simplify getContainers (#23323) 2018-07-25 12:30:13 -07:00
Andy bd600cfd50 Fix duplicate "this" completion (#25900) 2018-07-25 12:29:28 -07:00
Andy d60f4988a6 In getPropertySymbolsFromContextualType, use union discriminant to filter types (#25914) 2018-07-25 11:53:20 -07:00
Nathan Shively-Sanders 9658b476c2 Fix inferFromUsage on index signatures (#25934) 
* Fix inferFromUsage on index signatures

1. Check the argumentExpression to determine the index signature type.
Previously, the code mistakenly checked the type of the element access
itself, which never returned a good type.
2. If inference for the index signature type fails, substitute anyType.
Previously, the code would create a bad index signature with an
undefined type.
3. Add tests. Previously, there were no tests.

* Fixing (1) means that number index signatures are now created.
Previously, only string index signatures would be created.
* Fixing (2) means that index signatures will be inferred from single
usage like `return a[0]`. Previously, the refactoring would fail,
perhaps because of a check when stringifying the index signature (I
haven't tracked down why.)

* Update fourslash test with improved inference
 2018-07-25 10:51:11 -07:00
Anders Hejlsberg 7b4d13c95c Merge pull request #25859 from Microsoft/optimizePrimitiveIntersections 
Optimize creation of intersections of union types
 2018-07-25 10:28:43 -07:00
Anders Hejlsberg f9681e2327 Update comment 2018-07-25 07:10:44 -07:00
Anders Hejlsberg dd4fd8c60e Merge pull request #25913 from Microsoft/fixCircularConstraintCheck 
Fix circular constraint check
 2018-07-25 06:46:51 -07:00
Anders Hejlsberg ff6059abf6 Address CR feedback 2018-07-24 17:58:03 -07:00
Andy e4d4b0ae4b Handle PropertyAssignment in getCommentOwnerInfo (#25911) 2018-07-24 17:43:46 -07:00
Mohamed Hegazy fd2eb4918d Merge pull request #25604 from mprobst/fix-exported-var-comments 
Retain synthetic comments on exports.
 2018-07-24 17:41:44 -07:00
Wesley Wigham 7d44014c56 Fix typos 2018-07-24 16:37:07 -07:00
Wesley Wigham 23eb591e01 Lookup files by resolved Path and not by fileName in sourcemapDecoder when querying program (#25908) 
* Check if the file returned by the program actually refers to the same file as we intend

* Simplify
 2018-07-24 15:44:22 -07:00
Anders Hejlsberg 1fd1de9625 More simplification + consistent use of getConstraintOfTypeParameter 2018-07-24 15:27:39 -07:00
Wesley Wigham f6d3ac9b5d Fix #25820 - handle redirected files when comparing paths (#25902) 
* Fix #25820 - handle redirected files when comparing paths

* Update test to do case check
 2018-07-24 15:24:52 -07:00
Mohamed Hegazy 870c55c7a5 Merge pull request #25863 from mattmccutchen/issue-9744 
Report a semantic error for an arrow function with a "this" parameter.
 2018-07-24 15:08:26 -07:00
Anders Hejlsberg 7233cde0dc Simplify logic in getBaseConstraint 2018-07-24 14:49:22 -07:00
Wesley Wigham 797d8bd07b Call toPath on sourceRoot to ensure it is always absolute (#25838) 
* Call toPath on sourceRoot to ensure it is always absolute

* Leave canonicalization to avoid a Path/string union
 2018-07-24 14:14:41 -07:00
Wesley Wigham 59854bbd55 Inspect all possible module paths when looking for the best one to create a specifier with (#25850) 
* Inspect all possible specifier paths when looking for the best one

* Add missing secondary option from test
 2018-07-24 13:56:21 -07:00
Anders Hejlsberg 8ddeb966f5 Consistently include circularity check in type parameter constraints 2018-07-24 06:19:58 -07:00
Andy 30c41492d9 moduleSpecifiers: Allow "*" as a path mapping (#25881) 2018-07-23 17:11:30 -07:00
Nathan Shively-Sanders 2146a91df3 Simplify getWidenedTypeFromJSSpecialPropertyDeclarations (#25868) 
* Split getWidenedTypeFromJSSpecialPropertyDeclaration

1. Handle this-property assignments
2. Handle other special property assignment

I have only started simplifying [2].

* Split into two passes

1. Look for jsdoc
2. Look for type of initializers

Both can be broken into their own functions.

* Break into two functions

* Move back to original function and single loop

Then, convert the 2 extracted functions to reduce-style functions that
take state and return the updated state.

* Cleanup suggestions from review
 2018-07-23 15:52:48 -07:00
Matt McCutchen f72193eedc Report a semantic error for an arrow function with a "this" parameter. 
Fixes #9744.
 2018-07-23 10:42:56 -04:00
Anders Hejlsberg c0e0c1c2f3 Revise intersection optimizations to include string, number and symbol 2018-07-21 12:23:02 -07:00
Andy 93722c8942 findAllReferences/rename: Search in all open projects (#25648) 
* findAllReferences/rename: Search in all open projects

* Avoid needing a dummy location when location is unused

* Remove Program#getDeclarationEmitPath

* Only iterate over enabled projects
 2018-07-20 16:53:59 -07:00
Andy 3d672d9550 Ensure fixSpelling and importFixes still trigger on "Did you mean the instance/static member ..." (#25847) 2018-07-20 16:51:35 -07:00
Mohamed Hegazy 00a64172af Merge pull request #25680 from a-tarasyuk/bug/25667-getmodifiedtime-has-wrong-return-type 
25667 - getModifiedTime has wrong return type
 2018-07-20 16:35:43 -07:00