Commit Graph
17397 Commits
Author SHA1 Message Date
Mohamed Hegazy b4dea5ecce Merge pull request #24760 from krk/codefix-asterisk
addMethodDeclaration codefix creates a generator function when target…
2018-06-08 08:57:49 -07:00
krk d7a0619009 Inlined asterisk token creation. 2018-06-08 14:49:11 +03:00
csigs 75df424a6d LEGO: check in for master to temporary branch. 2018-06-08 04:10:38 +00:00
Andy 3822e3e4ed tryGetModuleNameAsNodeModule: Ignore file extension (#24774) 2018-06-07 15:45:03 -07:00
csigs 18e4ca62ed LEGO: check in for master to temporary branch. 2018-06-07 22:10:59 +00:00
Ron Buckton e947154aec Merge pull request #24768 from Microsoft/fix24722
Fix prologue order in async function
2018-06-07 15:05:09 -07:00
Andy 48dedacf3b fixStrictClassInitialization: Don't provide a default for string or number (#24767)
* fixStrictClassInitialization: Don't provide a default for `string` or `number`

* Update baselines
2018-06-07 15:03:38 -07:00
Andy 33d0893259 Add completions from literal contextual types (#24674)
* Add completions from literal contextual types

* Remove getTypesOfUnion

* undo baseline changes
2018-06-07 15:03:19 -07:00
Sheetal Nandi 604bebab86 Merge pull request #24769 from Microsoft/ignoreWindowsUsersFolder
Do not watch folders like "c:/users/username", "c:/users/username/folderAtRoot"
2018-06-07 14:36:10 -07:00
Andy 399ae51406 Support 'tsconfig.json' when converting TextChanges to CodeEdits (#24667)
* Support 'tsconfig.json' when converting TextChanges to CodeEdits

* Create Project#getSourceFileOrConfigFile to use instead
2018-06-07 14:30:19 -07:00
Andy fde6f22408 Fix bug: In newFileChanges, setParentNodes in new source file (#24765) 2018-06-07 14:28:06 -07:00
Sheetal Nandi 16e01174b7 Do not watch folders like "c:/users/username", "c:/users/username/folderAtRoot"
Fixes Microsoft/vscode#51139
2018-06-07 13:52:34 -07:00
Ron Buckton 2b4569c04f Fix prologue order in async function 2018-06-07 13:34:16 -07:00
Andy 87217018b8 Add 'nameSpan' property to NavigationTree (#24698) 2018-06-07 12:43:57 -07:00
Mohamed Hegazy d2be8dd6c4 Merge pull request #24761 from ajafff/avoid-useless-closures
checker: avoid useless closures
2018-06-07 12:18:08 -07:00
Andy 0fefaf286d moveToNewFile: Infer quote preference (#24652) 2018-06-07 12:10:48 -07:00
Andy 83c58a4fb5 Don't consider x. a new identifier location just because x has a number index signature (#24699)
* Don't consider `x.` a new identifier location just because x has a number index signature

* Update more tests
2018-06-07 12:05:47 -07:00
Klaus Meinhardt 5b92bdd88f checker: avoid useless closures 2018-06-07 20:35:47 +02:00
krk acbda14450 addMethodDeclaration codefix creates a generator function when target is child of a YieldExpression, resolves #24728 2018-06-07 20:59:06 +03:00
Wesley Wigham d0ae03c4cc Handle import types in serializeType (#24701) 2018-06-07 10:40:14 -07:00
csigs 7f2436ca35 LEGO: check in for master to temporary branch. 2018-06-07 16:10:39 +00:00
csigs 836eed3d02 LEGO: check in for master to temporary branch. 2018-06-07 04:10:32 +00:00
csigs 7cd85f3acb LEGO: check in for master to temporary branch. 2018-06-06 22:10:42 +00:00
Mohamed Hegazy 34dd7738c9 Merge pull request #24672 from bakkot/binding-comma
Allow trailing commas after non-rest elements in destructuring
2018-06-06 13:00:17 -07:00
Nathan Shively-Sanders 30994c86e4 Improve valueDeclaration for js module merges (#24707)
Nearly everything in a merge of JS special assignments looks like a
valueDeclaration. This commit ensures that intermediate "module
declarations" are not used when a better valueDeclaration is available:

```js
// File1.js
var X = {}
X.Y.Z = class { }

// File2.js
X.Y = {}
```

In the above example, the `Y` in `X.Y.Z = class { }` was used as the
valueDeclaration for `Y` because it appeared before `X.Y = {}` in the
compilation.

This change exposed a bug in binding, #24703, that required a change in
typeFromPropertyAssignmentOutOfOrder. The test still fails for the
original reason it was created, and the new bug #24703 contains a repro.
2018-06-06 11:11:15 -07:00
Ron Buckton 942c42bf29 Merge pull request #24677 from Microsoft/checkEvaluatorSyntax
Fails test if evaluator source text has errors
2018-06-06 10:42:11 -07:00
Nathan Shively-Sanders d6250c8342 Fix circularity error when extending class in same JSContainer (#24710)
Do this by not widening properties of an object literal that are

1. JS initialisers
2. and not an object literal

These properties have types that will never widen, so the compiler
shouldn't ask for the types earlier than it strictly needs to.
2018-06-06 09:13:38 -07:00
csigs 16597e5e97 LEGO: check in for master to temporary branch. 2018-06-06 16:10:34 +00:00
csigs 3c8f64ce14 LEGO: check in for master to temporary branch. 2018-06-06 07:55:52 +00:00
Nathan Shively-Sanders 8d737ca959 Simplify parseJSDocIdentifierName (#24660)
* Simplify parseJSDocIdentifierName

It now always creates a missing node. The one place that depended on it
returning undefined, parseJSDocTypeNameWithNamespace, now returns
undefined before calling parseJSDocIdentifierName.

* Remove assert

It is adequately proven at compile time.
2018-06-05 14:30:37 -07:00
Wesley Wigham d9b93903c0 Use more nodelike paths for import types when possible (#24610)
* Use more nodelike paths for import types when possible

* move functionality from services into compiler, fix with propert file/directory conflict handling

* mark suspect cast
2018-06-05 12:54:36 -07:00
Andy 735a46f838 If parsing a function type fails, parseTypeReference() to ensure something is returned (#24567)
* If parsing a function type fails, parseTypeReference() to ensure something is returned

* Avoid tryParse

* Add missing semicolon

* Don't check for undefined, check for missing type

* Don't set parameters undefined, set to missingList and return false

* Update API baselines

* Code review
2018-06-05 10:24:37 -07:00
csigs 54845d2396 LEGO: check in for master to temporary branch. 2018-06-05 16:10:39 +00:00
csigs bcd4768699 LEGO: check in for master to temporary branch. 2018-06-05 10:10:41 +00:00
Ron Buckton 6575d930fc Fails test if evaluator source text has errors 2018-06-04 17:05:46 -07:00
Mohamed Hegazy e9ebb3e95c Merge remote-tracking branch 'origin/master' into updateDom 2018-06-04 17:01:34 -07:00
Mohamed Hegazy a14f034100 Merge pull request #24576 from ajafff/fix-syntax-error
fix syntax error in unit test
2018-06-04 16:42:23 -07:00
Ron Buckton fbeb58a147 Merge pull request #23893 from Microsoft/libReference
Adds 'lib' reference directives
2018-06-04 16:14:52 -07:00
csigs 8515d65796 LEGO: check in for master to temporary branch. 2018-06-04 22:11:01 +00:00
Kevin Gibbons 87bb5e3cbb Allow trailing commas after-rest elements in destructuring 2018-06-04 14:58:30 -07:00
Ron Buckton 666841264c Merge branch 'master' into libReference 2018-06-04 14:38:56 -07:00
Wesley Wigham 7eaa78846e Visit the children of an import type/require call/dynamic import when looking for those (#24663) 2018-06-04 14:31:56 -07:00
Wesley Wigham cbbf2e4e6f Resolve aliases before using getTypereferenceType (#24594) 2018-06-04 14:19:41 -07:00
Andy b3a4b72a16 Always include Jsdoc comment in getTouchingPropertyName (#23379) 2018-06-04 14:15:41 -07:00
Andy a641e6f85f goToDefinition: Put variable definition before signature definition (#24649)
* goToDefinition: Put variable definition before signature definition

* Fix lint
2018-06-04 14:13:27 -07:00
Mohamed Hegazy f960d5c97f Port generated lib files 2018-06-04 14:13:16 -07:00
Mohamed Hegazy 5ba223d7dd Change file name 2018-06-04 14:05:56 -07:00
Ron Buckton fb09aeb23d Remove debugger statement 2018-06-04 13:42:31 -07:00
Sheetal Nandi c3dcc83d4f Merge pull request #24664 from Microsoft/builderAPIBreak
Fix the issue with createSemanticDiagnosticsBuilderProgram, createEmitAndSemanticDiagnosticsBuilderProgram and createAbstractBuilder not assignable to CreateProgram<T>
2018-06-04 13:35:40 -07:00
Nathan Shively-Sanders 7db4b1cbc7 Fix property assignment on aliases (#24659)
Aliases don't have valueDeclarations, which caused a crash when passed
to isJavascriptContainer before.
2018-06-04 13:34:23 -07:00