Commit Graph
24525 Commits
Author SHA1 Message Date
Oleksandr TandGitHub 0df9462a96 fix(49058): Language service crashes for static member in class with unresolved base members (#49059)
* fix(49058): skip unresolved base members

* use getTypeOfSymbol instead of getExportsOfModule
2022-05-16 14:29:40 -07:00
Nathan Shively-SandersandGitHub 95731f0397 No errors on apparent type of bigint or symbol, even for recent targets (#49104)
* Remove bigint from Object.freeze in es5.d.ts

`BigInt` isn't resolved whenever `lib < es2020`, but it's not an error
when `target < es2020`. I have a few ideas for improving this situation
but for the RC I'm going to remove `bigint` from Object.freeze's
signature.

* Update other baselines

* No errors for missing apparent type of bigint,symbol for any target

* Update test text
2022-05-16 09:14:00 -07:00
csigsandGitHub 528f708ab8 LEGO: Merge pull request 49130
LEGO: Merge pull request 49130
2022-05-16 08:16:23 -07:00
csigsandGitHub 9e70b69a97 LEGO: Merge pull request 49117
LEGO: Merge pull request 49117
2022-05-15 09:00:13 -07:00
csigsandGitHub fba6eeaf6e LEGO: Merge pull request 49108
LEGO: Merge pull request 49108
2022-05-14 05:10:05 -07:00
Daniel RosenwasserandGitHub 0414deeaaf Merge pull request #48954 from a-tarasyuk/fix/48948
fix(48948): constructor can't be the name of class accessors and generators
2022-05-13 12:20:45 -07:00
csigsandGitHub 90b1321baa LEGO: Merge pull request 49098
LEGO: Merge pull request 49098
2022-05-13 03:59:47 -07:00
Oleksandr T 9607a5310f add messages to plainJSErrors 2022-05-13 09:24:08 +03:00
Jake BaileyandGitHub 92894d36af Make watch/FS testing code friendlier for project loading in module transformation (#49087) 2022-05-12 16:43:44 -07:00
Jack WorksandGitHub b689cd0aa9 feat: support error when comparing with object/array literals (#45978)
* feat: support error when comparing with object/array literals

* chore: include regexp, function and class literal

* chore: include regexp, function and class literal

* test: update baseline

* fix: baseline
2022-05-12 15:45:22 -07:00
Anton GilgurandGitHub da00ba67ed fix: getDefaultLibFilePath should normalize __dirname (#49051)
- this currently causes a bug on Windows with mixed path separators
  - it returns a POSIX backslash path for __dirname, and then adds a
    forward slash from the directorySeparator, causing mixed separators
    - TS uses `/` internally and lets the host convert if needed, so
      I assume this should be normalized to all forward slashses instead
  - example of the bug from my tests:
    ```
    Expected: "D:\\a\\rollup-plugin-typescript2\\rollup-plugin-typescript2\\node_modules\\typescript\\lib\\lib.d.ts"
    Received: "D:\\a\\rollup-plugin-typescript2\\rollup-plugin-typescript2\\node_modules\\typescript\\lib/lib.d.ts"
    ```

- every other use of __dirname in the codebase seems to be normalized
  except for this one
  - could use normalizeSlashes for this, but I figure combinePaths is
    more appropriate since that will handle it and combine properly as
    well without any `+ directorySeparator +` stuff
2022-05-12 13:21:56 -07:00
csigsandGitHub 1ba609660b LEGO: Merge pull request 49081
LEGO: Merge pull request 49081
2022-05-12 04:28:47 -07:00
Oleksandr TandGitHub c300fea325 fix(7410): allow using JSXElement as JSXAttributeValue (#47994) 2022-05-11 14:47:35 -07:00
5c2febfe02 Allow referencing type-only exports as namespace members in ImportTypes and TypeQueries (#49056)
* Allow referencing type-only exports as namespace members in ImportTypes and TypeQueries

* Add extra test case

* ;; -> ;

* undefined -> false

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
2022-05-11 11:44:59 -07:00
csigsandGitHub 3c87170604 LEGO: Merge pull request 49069
LEGO: Merge pull request 49069
2022-05-11 08:29:06 -07:00
Daniel RosenwasserandGitHub 3e24f14871 Merge pull request #49029 from DavidSouther/fix/44466-contextual-keyword-assertion
fix(44466): Fixes parsing contextual keyword casts as arrow functions
2022-05-10 16:37:49 -07:00
Andrew BranchandGitHub 08b1cce595 Add regression test for #46192 (#49057) 2022-05-10 16:27:46 -07:00
Justin GrantandGitHub 8bf45a4f93 fix: update types for RTF.p.formatToParts() result (#46508)
This commit updates the type of `RelativeTimeFormatPart` to clarify that
the `unit` prop is always singular, unlike the plural or singular values
that are accepted as inputs.

This also changes `RelativeTimeFormatPart` to be a discriminated
union type because the `unit` prop is only present if the `type` prop's
value is not "literal".

Fixes #46245
2022-05-10 16:06:08 -07:00
Sheetal NandiandGitHub 6ee549075b Identify when file name is matched by default include spec (#49040)
Fixes #43679
2022-05-10 10:34:03 -07:00
mstsskandGitHub fcd80db0c6 fix(48912): fractionalSecondDigits is 1, 2 or 3. (#49042) 2022-05-10 09:22:50 -07:00
csigsandGitHub 0cd551d56a LEGO: Merge pull request 49044
LEGO: Merge pull request 49044
2022-05-10 03:58:37 -07:00
Mateusz BurzyńskiandGitHub 9236e39374 Fixed an issue with contextual type for intersection properties (#48668)
* Add a failing test case for contextual type not provided for functions comming from a property with intersection type

* Fixed an issue with contextual type for intersection properties

* Fixed how type of a property of a contextual type is being computed when intersections with indexers are used
2022-05-09 16:03:48 -07:00
Devon GovettandGitHub 17431eab46 Add missing source property to Intl formatRangeToParts methods (#48754) 2022-05-09 15:57:42 -07:00
ZzzenandGitHub 604e5fca55 Add JSDoc's @inheritDoc Support for Static Class Members for TypeScript (#46719)
* Add JSDoc's @inheritDoc Support for Static Class Members for TypeScript

* use public api

* fix

* add tests

* simplify implementation

* extract comments from inherticDoc
2022-05-09 15:57:27 -07:00
Oleksandr TandGitHub 69214c0e56 fix(49001): handle missing imports in addMissingMember QF (#49009) 2022-05-09 15:52:15 -07:00
ryohei.udagawaandGitHub c1c3ebcadf fix: fractionalSecondDigits configure (#49014) 2022-05-09 15:24:24 -07:00
Oleksandr TandGitHub aa48a37e09 fix(48673): allow Find All References on access modifier for constructor (#48813) 2022-05-09 14:56:56 -07:00
d6e483b8da fix(48887) exposing rest helper functions externally (#48888)
* fix(48887) exposing rest helper functions externally

* fixing baseline + adding hint about how to fix baseline

* Update src/harness/harnessIO.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2022-05-09 14:25:05 -07:00
Ron BucktonandGitHub e2bd89b309 Report error for invalid 'this' type during 'await' (#48946) 2022-05-09 13:58:36 -07:00
Andrew BranchandGitHub f3f0a3f394 Fix module specifier generation crash from typesVersions (#49035) 2022-05-09 12:48:24 -07:00
Wesley WighamandGitHub f84ec3e8b4 Fix type parameter comparability to consistently allow comparisons on unconstrained type parameters (#48861)
* Fix type parameter comparability to consistently allow comparisons on unconstrained type parameters

* Less elaboration, non-strict-mode fix
2022-05-09 12:22:00 -07:00
David Souther e9d39bd95f Remove spurious lookAhead, as this fn is already in a lookAhead 2022-05-09 10:53:58 -07:00
David Souther 3dd9ef43ce fix(44466): Fixes parsing contextual keyword casts as arrow functions 2022-05-09 10:22:22 -07:00
csigsandGitHub 1071240907 LEGO: Merge pull request 49016
LEGO: Merge pull request 49016
2022-05-08 08:08:33 -07:00
csigsandGitHub 53343dd94d LEGO: Merge pull request 49010
LEGO: Merge pull request 49010
2022-05-07 05:42:49 -07:00
Daniel RosenwasserandGitHub 94391dc9b5 Bump version to 4.8. 2022-05-07 00:22:34 +00:00
Ryan CavanaughandGitHub 1a4643bdce Flag resolution mode assertions in non-nightly builds (#49002)
* Flag resolution mode assertions in non-nightly builds

* Add checker check
2022-05-06 16:31:40 -07:00
Jake BaileyandGitHub 8d0393d227 Fix missing parsingContext restore at return in parseDelimitedList (#48999) 2022-05-06 13:36:27 -07:00
Andrew BranchandGitHub 2ffe6864b1 Respect importModuleSpecifierEnding inside node_modules packages (#48995)
* Respect importModuleSpecifierEnding inside node_modules packages

* Add tests for missing package.json
2022-05-06 12:58:12 -07:00
Jake BaileyandGitHub 4765355e71 Fix more tests missing 'it' call in 'describe' (#48994) 2022-05-06 11:09:42 -07:00
Kenta MoriuchiandGitHub 4a0b083c69 Add ES2022 Intl.Segmenter type (#48800)
* Add `Intl.Segmenter` type

* Update baseline

* Fix useless generics

* Fix indent size

* Fix `ResolvedSegmenterOptions`
2022-05-05 17:09:06 -07:00
Andrew CaseyandGitHub 58114cf387 Harden combineProjectOutputForReferences against empty results (#48978)
Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until #48619 is merged.

Fixes #48963
2022-05-05 13:52:34 -07:00
Andrew BranchandGitHub 4680b54616 Clear ExportMapCache on cancellation requested (#48979) 2022-05-05 13:42:30 -07:00
Oleksandr TandGitHub f8a09bee6f fix(48878): return errorType on invalid nodes in getTypeAtLocation (#48967) 2022-05-05 13:07:32 -07:00
Wesley WighamandGitHub 8e433cda3d Allow export map entries to remap back to input files for a program (#47925)
* Allow export map entries to remap back to input files for a program

* Fix file casing issues on windows

* Implement abiguity error, doesnt quite work

* Refine selection logic in error case to use getCommonSourceDirectory, add more tests
2022-05-05 12:53:56 -07:00
Sheetal NandiandGitHub 1e157ef1b2 Fix node16 tests (#48974) 2022-05-05 11:45:05 -07:00
650c056fa0 No error on toplevel return in JS (#48874)
* No error on toplevel return in JS

Turns out it's only an error in modules.
It's possible to keep this error on the list of "OK for JS" errors and
make the checker code stop issuing it for JS scripts only. However, I
don't think the error is valuable enough to do that.

Fixes #48224

* Restore 'return' statement.

* Update Baselines and/or Applied Lint Fixes

* Re-add missing baselines

* No error in toplevel script files

Only issue "no top-level return" error for modules, not scripts,
regardless of whether it's TS or JS.

* Keep Disallowing return in ambient locations

* Allow toplevel return only in non-ESM JS files

* Add test of toplevel return in JS script

* Revert "Add test of toplevel return in JS script"

This reverts commit 2a6dec475a.

* Revert "Allow toplevel return only in non-ESM JS files"

This reverts commit 6291ae3ba2.

* Revert "Keep Disallowing return in ambient locations"

This reverts commit 714ea8e524.

* Revert "No error in toplevel script files"

This reverts commit 2056e13d52.

* restore orphaned baseline

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com>
2022-05-05 09:35:15 -07:00
Nathan Shively-SandersandGitHub 46e8306050 Skip ambient modules in globalThis (#48938)
* Skip ambient modules in globalThis

Previously, globalThis mistakenly included ambient modules, even though
these are not values:

```ts
declare module "ambientModule" {
  export type typ = 1
  export var val: typ
}
type Oops = (typeof globalThis)[\"ambientModule\"]
```

This PR adds ambient modules to the kinds of things that are skipped
when constructing `globalThis`' properties, along with block-scoped
variables.

* Skip only modules with every declaration ambient

The modules are required to have at least one declaration so that our
treatment of `globalThis` stays the same, and
`globalThis.globalThis.globalThis` remains legal.
2022-05-05 09:33:32 -07:00
Jake BaileyandGitHub 7d60dc1f5d Revert "feat(47595): allow using private fields in type queries" (#48959) 2022-05-04 16:50:30 -07:00
Andrew BranchandGitHub e26bc8a117 Skip missing nodes in formatting (#48953) 2022-05-04 15:07:34 -07:00