Commit Graph
3555 Commits
Author SHA1 Message Date
AndyandGitHub 7541c705bf Support navTo for special assignment kinds (#18154)
* Support navTo for special assignment kinds

* Return ScriptElementKind.unknown
2017-09-07 07:45:11 -07:00
AndyandGitHub b533b24686 extractMethod: Don't try to extract a single token (#18090)
* extractMethod: Don't try to extract a single token

* Update tests
2017-09-07 07:28:12 -07:00
AndyandGitHub b3c87aa919 Support find-all-references for default keyword (#17992)
* Support find-all-references for anonymous default exports

* Also handle re-exported default exports

* Add test for using `export =` with `--allowSyntheticDefaultExports`
2017-09-07 07:26:22 -07:00
AndyandGitHub 817c329667 getFormattingScanner: Ensure scanner is closed, and avoid global variables (#18293) 2017-09-07 07:23:53 -07:00
AndyandGitHub 23f793fc3e findAllReferences: Handle root symbols of binding element property symbol (#17738) 2017-09-07 07:23:06 -07:00
AndyandGitHub 0434fe797a Get quickInfo from a contextual type if possible (#18119) 2017-09-07 07:22:39 -07:00
AndyandGitHub 8c714c3651 Support special JS property assignments in doc comment templates (#18193) 2017-09-07 07:21:47 -07:00
AndyandGitHub 53b5abe5bb Update fromCodeFixContext (#18290) 2017-09-07 07:19:00 -07:00
AndyandGitHub 697c4d3353 Add debugName property to Rule (#18289) 2017-09-06 14:46:47 -07:00
AndyandGitHub 36607e1bde Allow quoted names in completions (#18162)
* Allow quoted names in completions

* Don't allow string literal completions if not in an object literal; and use string literals for number keys

* Add TODO
2017-09-06 14:39:53 -07:00
Anders Hejlsberg 601a21c77b Fix signature help 2017-09-02 15:39:14 -07:00
Anders Hejlsberg b65ff647c1 Improved caching scheme for anonymous types 2017-09-02 10:27:48 -07:00
Matt BiernerandMohamed Hegazy c7b4ed3a91 Fix extract method for anon class expressions (#18168)
Check `scope.name` when trying to extract from an anon class
2017-08-31 13:21:08 -07:00
AndyandGitHub 601c113d93 Handle indexed access types in getSymbolAtLocation and findAllReferences (#18149)
* Handle indexed access types in getSymbolAtLocation and findAllReferences

* Update baselines, simplify `const objectType`
2017-08-30 14:19:49 -07:00
Andrew CaseyandGitHub 27e590dd5e Merge pull request #18121 from amcasey/WalkerCancel
Allow cancellation during extract method's symbol walking
2017-08-29 17:24:12 -07:00
Andrew Casey 19c3a150e7 Allow cancellation during extract method's symbol walking 2017-08-29 15:38:43 -07:00
Ryan CavanaughandGitHub fa77e141b0 Merge pull request #17811 from RyanCavanaugh/fix17544
Filter + log undefined elements from the codeActions array
2017-08-29 15:32:44 -07:00
Ryan CavanaughandGitHub d7b3b6c77d Merge pull request #18120 from RyanCavanaugh/fix457864
Don't crash when a JS file appears in an inferred context
2017-08-29 14:18:47 -07:00
Ryan Cavanaugh 0e2d399c49 Don't crash when a JS file appears in an inferred context 2017-08-29 13:29:56 -07:00
Andrew Casey a816079dda Add perf comment 2017-08-29 11:24:07 -07:00
Andrew Casey 01d7f0b699 Test that the return type of the extracted method counts as usage 2017-08-29 11:24:05 -07:00
Andrew Casey 30802cda97 Handle loose type parameters in Extract Method
Known limitations:

1. If a type parameter on an inner symbol shadows a type parameter on an
outer symbol, the generated code will be incorrect.  We should either
rename one or more type parameters or forbid the extraction.

2. Type arguments are always passed explicitly, even if they would be
inferred correctly.
2017-08-29 11:10:16 -07:00
AndyandGitHub 9daa70c47e Revert "Handle indexed access types in getSymbolAtLocation and findAllReferences (#17787)" (#18111)
This reverts commit 30b3cb0f68.
2017-08-29 09:37:27 -07:00
AndyandGitHub 30b3cb0f68 Handle indexed access types in getSymbolAtLocation and findAllReferences (#17787) 2017-08-29 07:53:22 -07:00
AndyandGitHub e73b10a304 Use isPartOfExpression in extractMethod, not isExpression (#18047)
* Use isPartOfExpression in extractMethod, not isExpression

* Add whitespace
2017-08-25 15:15:16 -07:00
AndyandGitHub fe1242c8a9 Don't try to extract import to a method (#18025) 2017-08-25 09:53:56 -07:00
AndyandGitHub 3a0ab74ed6 Test for action description of code actions, and simplify description for extracting method to file (#18030)
* Test for action description of code actions, and simplify description for extracting method to file

* Add unit test file missing from tsconfig.json (only affects gulp) and update tests

* Use the actual number

* Use "module scope" or "global scope" instead of "this file"
2017-08-25 09:53:28 -07:00
AndyandGitHub e2141ad469 Mark some arrays as readonly (#17725)
* Mark some arrays as readonly

* Avoid unnecessary allocations and style changes

* Fix lint
2017-08-24 09:55:01 -07:00
Andrew CaseyandGitHub 49676c58f3 Merge pull request #17844 from amcasey/SymbolWalker
Resuscitate the SymbolWalker API
2017-08-23 13:32:21 -07:00
Ryan Cavanaugh 43b8ce664c Merge 2017-08-22 14:31:49 -07:00
Wesley WighamandAndrew Casey 053b915061 Rebase SymbolWalker change onto master
From PR #9847.
2017-08-22 11:33:32 -07:00
Basarat Ali SyedandMohamed Hegazy ac098535cb export UsageEntry used by already exported functions 🌹 (#17853) 2017-08-21 16:55:40 -07:00
AndyandGitHub 5e8e735db5 quickInfo: Don't check for type === undefined, check for any (#17815)
* quickInfo: Don't check for `type === undefined`, check for `any`

* Fixes:
* We still want to do some work even if type is `any`
* Second test for `if (type)` is necessary because it might not have been assigned.
2017-08-18 17:21:25 -07:00
Benjamin LichtmanandGitHub 45c62ac0a6 Merge pull request #17709 from uniqueiniquity/objectsInArray
Correct outlining spans for object and array literals in array
2017-08-18 16:25:08 -07:00
uniqueiniquity e6c1afb4a0 Style changes and cleanup 2017-08-18 15:59:22 -07:00
Arthur OzgaandGitHub a3d113bed3 Merge pull request #16385 from aozgaa/isInMultiLineComment
multi-line comment formatting fix and handler
2017-08-18 12:43:37 -07:00
Arthur Ozga e4e969a210 respond to comments 2017-08-17 20:06:46 -07:00
AndyandGitHub babb88a0aa Remove duplicate function (#17807) 2017-08-17 06:52:15 -07:00
Daniel RosenwasserandGitHub a38da8af70 Merge pull request #17838 from Microsoft/rev2.6.0
Bump version to 2.6.0.
2017-08-16 23:50:50 -07:00
Arthur Ozga bc0c9a440e Merge branch 'master' into formattingAfterParseError 2017-08-16 20:27:06 -07:00
Arthur Ozga 6029b5cce8 cleanup 2017-08-16 18:12:28 -07:00
Arthur Ozga 19e2fa6fc5 Merge branch 'master' into isInMultiLineComment 2017-08-16 17:57:04 -07:00
Arthur Ozga b7bc7d889e clarify JsxText handling 2017-08-16 17:56:20 -07:00
Arthur Ozga 23ca368020 Use simpler indentation for comments
* When in a multi-line comment, we would have liked to use the start of
the comment as a reference point for the indentation inside the comment,
but determining the number of columns shifted for the comment start
woudl require determining the length w/r/t graphemes, which we do not
currently implement. We would like to avoid taking on a runtime
dependency on a grapheme-parsing library.

Instead, we look at the indentation level on the previoud line or start
of the comment as a reference point, and correct shift for lines
starting with an asterisk.
2017-08-16 17:51:29 -07:00
Daniel Rosenwasser 3f50f20d0a Updated version in 'src' as well. 2017-08-16 14:49:44 -07:00
Arthur Ozga a08d18af57 consolidate isInComment and getRangeOfEnclosingComment 2017-08-15 12:09:43 -07:00
Arthur Ozga a209db7bb6 dont compute preceding token twice 2017-08-15 12:09:02 -07:00
Arthur Ozga f3e0cbbd52 findPrecedingToken handles EOF child more gracefully 2017-08-15 12:09:02 -07:00
Arthur Ozga 472ad9d313 findPrevious changes 2017-08-15 12:08:00 -07:00
Arthur Ozga b2188ad66c cleanup 2017-08-15 12:08:00 -07:00