* `const` modifier on type parameters + revised contextual type logic
* Accept new baselines
* Fix modifier checking
* Add tests
* Cache isConstTypeVariable check
* Revert "Cache isConstTypeVariable check"
This reverts commit f8fd1fd29f.
* Fewer isConstTypeParameterContext checks
* Pay attention to cached `undefined` contextual type
* Allow `const` modifier in more places + properly print back
* Also permit `const` in method signature type parameters
* Fix parsing of `const` modifier in array expression type parameters
* Accept new baselines
* Remove unused properties from NodeLinks
* Rename `permitInvalidConstAsModifier` to `permitConstAsModifier`
* Added override keyword to codefixed implemented abstract methods
* Only when noImplicitOverrides is true, and always check abstract modifier
* Added test on abstract/override already being there
* Added back a few test cases
* Check declaration modifier, not class modifier
* Fix excess property checking for intersections with index signatures
* Add regression tests
* Limit check to only fresh object literals on the source side
* feat(51000): add ignoreDeprecations option
* use constants of versions
* change the ignoreDeprecations type to allow only one value - '5.0'
* add tests
* update baseline
* add typeScriptVersion to CreateProgramOptions
* update baseline
* change diagnostic message
* Add support for JSDocOverloadTag
* Use overload tag to determine function type
* Update baselines
* Add new tests along with baselines
* Add tests for all @overload tags in one comment
* Add tests for find-all-ref and rename operations
* Add tests for alternative uses of @overload tag
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* Add ignore case option to organizeImports
* Adopt in auto-imports, use same case-insensitive comparison as eslint
* Fix build/lint
* Mark functions internal
* Update affected auto import test
* Update API baseline
* Update protocol
* Update API baseline
* Short-circuit comparisons that have already failed
* WIP
* Add extension error back unless noEmit is set
* Add non-relative tests
* Add error for importing from declaration file
* Update unit test
* Add explicit flag for importing from .ts extensions
* Add module specifier resolution changes
* Add auto-import tests
* Disallow relative imports into node_modules
* Ensure auto-imports don’t suggest ./node_modules;
* Test a non-portable declaration emit issue
* Test auto-importing TSX file
* Update path completions
* Fix lint due to merge
* Remove minimal-specific stuff
* Remove minimal tests
* Update unit tests
* Add options
* Add customConditions option
* Add first tests
* CJS constructs are not allowed
* Add another test
* Fix extension adding/replacing priority
* Update test to reflect the choice not to block on unrecognized extensions
* Add auto-imports and string completions tests
* Revamp string completions ending preferences
* Comment test
* Auto-imports of declaration files cannot use .ts extension
* Have declaration file auto imports default to extensionless instead
* Add test for custom conditions
* Fix indentation
* Add baseline showing resolvePackageJsonImports/Exports compatibility
* Fix test and prevent CJS require from resolving
* Update unit test baselines
* Fix bad merge conflict resolution
* Make resolvedUsingTsExtension optional
* Update missed baselines
* Revert now-unnecessary API implementation changes
* Clean up
* Update baselines to es5 emit
* Rename to `bundler`
* tsconfig.extends as array
* Updated baselines
* Changes for pr
* Changes for pr comments
* Fixed formatting and edited a test
* Resolved errors after a merge conflict
* Added "string | list" type implentation
* Removed string | list type implementation
* Fixed formatting
* Added compiler test
* Resolving programUpdate errors
* Fixing commandLineParser error
* feat(49323): add support throws jsdoc tag
* change "name" to "typeExpression". parse "exception" as a synonym for "throws"
* include typeExpression from the throws tag in the quick info
* add JSDocThrowsTag to ForEachChildNodes
* Fixed tuple types indexed by a type parameter
* If only there was a tool to add that missing semicolon for me
* Rename to baseConstraint
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* retroactive approach to remove duplicate diagnostics
* use code instead of messageText, update test
* use existing de-dupe function
* rename test and baselines
* add fourslash test for better assertion of fix
* review feedback: move deduplicate to getDiagnosticsHelper
* accept baseline with sorted diagnostics
* remove newline
* Change the default emit target to ES5
* Add baseline update
* Remove tests with a hardcoded sourcemap in it
* Update hardcoded tests
* Merge with main
* Restore tests
* Fix missed errors in switch when using union of literal and non-literal types (#38686)
This commit makes it so we don’t use the base type of literals when checking comparability in switch. The comparability checks handle that case already, is my understanding, so we don’t need to clobber the type before actually doing the check, causing missed errors.
When comparing the types in switch, if a union with a literal and a non-literal was used, the compiler in `checker.ts` would automatically get the base type of all parts of the union, resulting in missed errors. For example, if the union of the non-literal `number` and literal `"hello"` was compared to the literal `"world"` in a switch case, the compiler would miss that they’re actually not comparable.
Maybe someone can tell me why we were getting the base type before checking comparability, rather than relying on the logic within the comparability checks to handle literal/base type comparability?
* Fix lint (whitespace) issue in checker.ts by running lint with fix flag.
* fix services' type's isLiteral
* update literal completions tests
* initial prototype
* use symbol to expression. TODO: filter existing, replace import nodes
* WIP
* WIP
* remove booleans from literals
* trigger at case keyword positions
* clean up tests
* fix element access expression case
* refactor dealing with existing values into a tracker
* fix merge errors
* cleanup and more tests
* fix lint errors
* more merge conflict fixes and cleanup
* use appropriate quotes
* small indentation fix
* refactor case clause tracker
* experiment: support tabstops after each case clause
* address small CR comments
* fix completion entry details; add test case
* fix lint errors
* remove space before tab stops; refactor
Oleksandr T
Mateusz Burzyński
Andrew Branch
Gabriela Araujo Britto
Ron Buckton
Anders Hejlsberg
Josh Goldberg
Tomasz Lenarcik
navya9singh
George Manning
Ryan Cavanaugh
Jake Bailey
Eric Ferreira
Isabel Duan
Wesley Wigham
Lyu, Wei-Da
Eyal Halpern Shalev