Commit Graph
20091 Commits
Author SHA1 Message Date
Anders Hejlsberg 9c401b4dbb Remove over-eager check of AccessFlags.Writing in getIndexedAccessType 2019-04-28 13:56:11 -07:00
Wenlu WangandRyan Cavanaugh 454b4280b1 check more case for empty binding patten (#25263)
* check more case for empty binding patten

* refactor binding pattern checking  getWidenedType

* fix spelling

* fix merge and rebase
2019-04-26 14:00:04 -07:00
Clay MillerandRyan Cavanaugh d934401265 Change the type of 'uriComponent' (passed to 'encodeURIComponent') from 'string' to 'string | number | boolean'. Fixes #18159 (#31103)
- According to the ECMAScript 5.1 spec (§15.1.3.4), 'encodeURIComponent' invokes the abstract operation 'ToString': https://www.ecma-international.org/ecma-262/5.1/#sec-15.1.3.4
- In the spec (§9.8), 'ToString' accepts an 'Undefined', 'Null', 'Boolean', 'Number', 'String' or 'Object' argument: https://www.ecma-international.org/ecma-262/5.1/#sec-9.8
- TypeScript’s 'StringConstructor' accepts an argument with type 'any': https://github.com/Microsoft/TypeScript/blob/b0100100a18d740ad0b7c626bc81b800b5273ece/lib/lib.es5.d.ts#L518
2019-04-26 13:07:14 -07:00
Sheetal NandiandGitHub 94ee0dc769 Merge pull request #31100 from Microsoft/tsBuildCacheModuleResolution
Cache module resolutions across tsbuild to be able to resolve the modules faster
2019-04-26 07:33:59 -07:00
Jack WilliamsandRyan Cavanaugh 0949ad1130 Fix #24991: Weaken narrowing for == (#29840)
Spelling
2019-04-25 19:30:03 -07:00
Anders HejlsbergandGitHub 95413f0a24 Merge pull request #31000 from Microsoft/ignoreStringIndexSignaturesOnly
Ignore string (but keep numeric) index signatures from constraints
2019-04-25 17:01:46 -07:00
Klaus MeinhardtandRyan Cavanaugh d865ea774a resolveName: remove useless case (#28669)
PropertySignature cannot occur in a class.
The condition inside the clause required the parent to be a class, so it was never true.

This removes the case clause and the part of the condition that is now useless.
2019-04-25 15:43:43 -07:00
Max HeiberandRyan Cavanaugh f9d12ed54b fix 31012 allow noEmitOnError with isolatedModules (#34) (#31043)
fix #31012

Since the purpose of isolatedModules: true is to
do extra validation to ensure that separate
compilation is safe

Allowing emit in the presence of errors is
compatible with that intention.

Signed-off-by: Max Heiber <max.heiber@gmail.com>
2019-04-25 15:31:03 -07:00
amaksimovich2andRyan Cavanaugh 5b79b942e8 add action for enabling experimentalDescorators option in user config… (#30484)
* add action for enabling experimentalDescorators option in user config file, change error message for this case #29035

* add missing changes in tests

* Add "experimental decorators" tests for jsconfig file
2019-04-25 14:55:04 -07:00
Wenlu WangandRyan Cavanaugh b8e3c41ee1 fix jsdoc iterator on expression of export assignment (#30558) 2019-04-25 14:53:06 -07:00
Kagami Sascha RosylightandRyan Cavanaugh 1a75d525fa add ES2020 matchAll APIs (#30936) 2019-04-25 14:11:50 -07:00
Daniel RosenwasserandGitHub 58898f4351 Make Omit alias a separate type (#31115)
Make `Omit` alias a separate type
2019-04-25 16:40:24 -04:00
Klaus MeinhardtandRyan Cavanaugh b45df892a8 emit error on destructuring of rest property (#29609)
Fixes: #26005
2019-04-25 13:33:49 -07:00
Andy HansonandRyan Cavanaugh dc7c9bad3d Avoid eagerly computing test payload (#27851) 2019-04-25 13:26:19 -07:00
Andy HansonandRyan Cavanaugh 9168bd4845 Simplify hasExportDeclarations (#27846) 2019-04-25 13:25:48 -07:00
Ely AlamilloandRyan Cavanaugh 591b25593d update error message and update baselines (#27628) 2019-04-25 13:16:41 -07:00
Andy HansonandRyan Cavanaugh aafba363e4 Avoid recalculating versionPaths in loadNodeModuleFromDirectory (#27537)
* Avoid recalculating versionPaths in loadNodeModuleFromDirectory

* Update baselines
2019-04-25 11:06:31 -07:00
Andy HansonandRyan Cavanaugh 6e4c150d6b When function parameters span multiple lines, make the function span start at the ( (#26907)
* When function parameters span multiple lines, make the function span start at the `(`

* Undo unnecessary change
2019-04-25 10:53:39 -07:00
Wenlu WangandRyan Cavanaugh 583edce6b0 fix compiler crash (#25925) 2019-04-25 10:51:36 -07:00
Andy HansonandRyan Cavanaugh e007ccf97b Simplify chaining of transforms (#22994) 2019-04-25 10:38:20 -07:00
Wenlu WangandRyan Cavanaugh bc46c770bf allow literan enum const assertions (#30700)
* allow literan enum const assertions

* update desc
2019-04-25 10:09:21 -07:00
Daniel Rosenwasser 57938e6cc2 Make Omit alias its own mapped type so that references to it never expand to Pick<...>. 2019-04-24 16:57:20 -07:00
Sheetal Nandi 93b958e0ea Share module resolution cache among different program 2019-04-24 12:47:01 -07:00
Sheetal Nandi 3264b64f08 Reuse map if module resolution is same for redirected and own files 2019-04-24 11:57:59 -07:00
Andrew BranchandGitHub 4b81e37941 Merge pull request #31093 from andrewbranch/bug/30997
Fix crash getting error for type alias index signature without a type
2019-04-24 11:36:38 -07:00
Sheetal NandiandGitHub f27cf9b34e Merge pull request #30971 from Microsoft/dtsSignatureChange
Handle when change in type of dts may result in only dts emit but not js emit
2019-04-24 11:16:22 -07:00
Andrew Branch 956436853e Fix crash getting error for type alias index signature without a type 2019-04-24 10:35:23 -07:00
Jordan HarbandandRyan Cavanaugh d4ff58d53f [fix] ES5 Object.keys only accepts an object (#27089) 2019-04-24 10:18:31 -07:00
Andrew BranchandGitHub 6608349ea2 Merge pull request #31008 from andrewbranch/bug/29358
Support binding patterns in Promise -> async/await refactor
2019-04-24 08:43:15 -07:00
Ron BucktonandGitHub e2310f2831 Merge pull request #26151 from Kingwl/PropertyDeclarationExclamationToken
visit exclamation token
2019-04-23 21:21:58 -07:00
6e0b39e399 Update src/compiler/visitor.ts
Co-Authored-By: Kingwl <kingwenlu@gmail.com>
2019-04-23 21:27:06 -05:00
Wesley WighamandGitHub d7f03fb0fa Parse generic function types in import type argument lists (#31079)
* Parenthesize in import type node factory

* And now parse unparenthesized generic functions so we can handle parsing the older output
2019-04-23 14:48:31 -07:00
David SherretandRyan Cavanaugh 8fc6640f55 Rename _objectLiteralBrandBrand to _objectLiteralBrand. (#30797) 2019-04-23 14:33:54 -07:00
Wenlu WangandRyan Cavanaugh 27075555c8 fix generate typenode from negative numerical literal (#30610) 2019-04-23 14:20:53 -07:00
Ryan CavanaughandGitHub 885d4d63c8 Remove "generate types" code (#31075) 2019-04-23 13:51:47 -07:00
Wesley WighamandGitHub b47194bfa1 Fix contextual types for a single jsx child (#31040) 2019-04-23 13:51:39 -07:00
Andrii DieievandWesley Wigham 54fa950757 Skip primitive types comparison with array and object types (#31077) 2019-04-23 13:49:32 -07:00
Wesley WighamandGitHub b02b823f03 Track parameter references errors in resolve name rather than secondary pass (#30349) 2019-04-23 13:46:19 -07:00
tkondoandRyan Cavanaugh 84b8ab816c Fix iterable SetConstructor interface (#29777) 2019-04-23 13:27:30 -07:00
Klaus MeinhardtandRyan Cavanaugh 760393f893 fix false positive 'variable is used before being assigned' in destructuring (#29636)
Fixes: #29458
2019-04-23 13:22:37 -07:00
Matt McCutchenandRyan Cavanaugh 6487d1ffe0 Remove the rule that replaces a union of literal types with the base type when comparing equality to a type that isn't a union of literal types. (#27588)
type when comparing equality to a type that isn't a union of literal
types.

The rule is redundant because a primitive type is already directed-
comparable to a value of that primitive type, and it causes errors to be
missed when comparing a type parameter _constrained_ by a union of
literal types to another union of literal types.

The baseline changes look like improvements to me.

Fixes #26758.
2019-04-23 12:59:07 -07:00
Wenlu WangandRyan Cavanaugh bd178746de improve error message when type have same name (#27065)
* improve error message when type have same name

* fix lint and function name

* update test case

* accept baseline
2019-04-23 12:56:03 -07:00
Andrew BranchandGitHub cd56398a53 Merge pull request #30743 from andrewbranch/bug/30675
Make anonymous function formatting apply to anonymous generators too
2019-04-23 09:35:35 -07:00
Daniel RosenwasserandGitHub c74d25c115 30837 - Bad error message when default 'import'-ing an 'export =' without 'esModuleInterop' (#30847)
30837 - Bad error message when default 'import'-ing an 'export =' without 'esModuleInterop'
2019-04-23 11:23:06 -04:00
Daniel RosenwasserandGitHub 6427711f99 Better erreor messages for properties mis-handled as shorthand property declarations (#31039)
Better erreor messages for properties mis-handled as shorthand property declarations
2019-04-22 16:14:21 -04:00
Wesley WighamandGitHub 7a3e68fc5c Only return the substitute in substitution instantiation when assignability fails (rather than subtype) (#31027)
* Only return the substitute in substitution instantiation when assignability fails (rather than subtype)

* Add test from issue
2019-04-19 16:02:11 -07:00
Wesley WighamandGitHub 40a2eb2b4b Unify couldContainTypeVariables and the similar check done during instantiation (#30969)
* Stop symbol based filtering in couldContainTypeVariables

* Unify couldContainTypeVariables and the similar check done during instantiation
2019-04-19 16:01:53 -07:00
Wesley WighamandGitHub 1a4c15fb11 handle generic types in getArrayifiedType (#30606) 2019-04-19 14:32:33 -07:00
karthikkp 181d126b02 diagnostic messages conflicts resolved 2019-04-20 01:38:17 +05:30
Andrew Branch 95fb694eed Consistify tabs/spaces in test and baselines 2019-04-19 08:58:29 -07:00