* Add failing tests
* Use default import or namespace import for import fixes when compiler options allow
* Don’t do import * for export=, ever
* Only do import default for export equals if nothing else will work
* Never do import/require in a JavaScript file
* Update tests for changes in master
* Add const/require fix for JS and select based on usage heuristic
* Fix JS UMD import
* Bind a jsdoc enum as SymbolFlags.TypeAlias and not SymbolFlags.Enum
* Actually include an @enum tag as a declaration
* Add enum tag refs into a couple more syntax kind lists
* accept symbol baseline update
* Fix type keyword completions
1. In functions, type keywords were omitted.
2. In All context, no keywords were omitted.
(1) fixes#28737
(2) removes 17 keywords that should not be suggested, even at the
toplevel of a typescript file:
* private
* protected
* public
* static
* abstract
* as
* constructor
* get
* infer
* is
* namespace
* require
* set
* type
* from
* global
* of
I don't know whether we have a bug tracking this or not.
* Change keyword filter in filterGlobalCompletion
Instead of changing FunctionLikeBodyKeywords
* Add more tests cases
* Make type-only completions after < more common
Because isPossiblyTypeArgumentPosition doesn't give false positives now
that it uses type information.
* Add remove unnecessary await fix
* Add test for removing unnecessary parens after await is gone
* Fix handling of numbers in property access expressions
* Don’t offer suggestion when awaited type is any/unknown
* Fix random other test
* Fix new expression edge cases
* Only remove parens for identifiers and call expressions
* Move package.json related utils to utilities
* Add failing test
* Make first test pass
* Don’t filter when there’s no package.json, fix scoped package imports
* Use type acquisition as a heuristic for whether a JS project is using node core
* Make same fix in getCompletionDetails
* Fix re-exporting
* Change JS node core module heuristic to same-file utilization
* Remove unused method
* Remove other unused method
* Remove unused triple-slash ref
* Update comment
* Refactor findAlias to forEachAlias to reduce iterations
* Really fix re-exporting
* Use getModuleSpecifier instead of custom hack
* Fix offering auto imports to paths within node modules
* Rename things and make comments better
* Add another reexport test
* Inline `symbolHasBeenSeen`
* Simplify forEachAlias to findAlias
* Add note that symbols is mutated
* Symbol order doesn’t matter here
* Style nits
* Add test with nested package.jsons
* Fix and add tests for export * re-exports
* Start prototyping addMissingAwait codefix
* Filter by diagnostics that have missing-await related info
* Start writing tests and checking precedence
* Implement codeFixAll, add test for binary expressions
* Add test for iterables
* Add test for passing argument
* Add test for call/construct signatures
* Add test for awaiting initializer
* Improve assertion error
* Replace specific property access error with general one and add await related info
* Add test for property access
* Require code to be inside a function body to offer await
* Accept suggestion
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
* Add explicit test for code fix being not available unless something is a Promise
* Skip looking for function body if already in AwaitContext flags
* Inline getCodeActions function for symmetry
Now only the immediately preceding jsdoc of a node is retrieved by
getJSDoc, although it still does the correct non-local lookup for nodes
like ParameterDeclaration.
This doesn't change parsing or binding, which use the per-node Node.jsdoc
property directly. But it does change everything that relies on getJSDoc,
which includes the checker and language service.
Fixes#32062, which contains the analysis that justifies the change.
Andrew BranchandGitHub
Nathan Shively-SandersandGitHub
OrtaandGitHub
Orta Therox
Andrew CaseyandGitHub
Wesley WighamandGitHub
Andrew Casey
Sheetal Nandi
Dmitrijs Minajevs
Daniel RosenwasserandGitHub
Titian Cernicova-Dragomir
Florian Regensburger
