Commit Graph
26853 Commits
Author SHA1 Message Date
copilot-swe-agent[bot]andRyanCavanaugh 869eb505d5 Fix contextual typing sensitivity to binding pattern structure
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
2025-07-29 04:32:36 +00:00
copilot-swe-agent[bot]andRyanCavanaugh 649c90af15 Fix contextual typing sensitivity to binding pattern structure
Modified getTypeFromArrayBindingPattern to make contextual type construction
agnostic to whether tuple destructuring elements have binding names. When
includePatternInType is true, cap minLength at 2 to ensure consistent
contextual types regardless of binding pattern variations.

This fixes an issue where [, , t] and [, s, ] produced different contextual
types, causing inconsistent generic type inference and spurious excess
property errors.

Addresses feedback in #41548 about making contextual types position-agnostic.

Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
2025-07-29 00:01:39 +00:00
copilot-swe-agent[bot]andRyanCavanaugh 4235412daa Detailed investigation of tuple destructuring excess property issue
Reverted all previous changes and conducted thorough analysis of the root cause.
Found that the issue is related to contextual typing and generic type inference,
not specifically the "last element position" but rather the pattern of
first element omitted + last element named.

Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
2025-07-28 22:47:22 +00:00
copilot-swe-agent[bot]andRyanCavanaugh 31a298b0a2 Final fix: restrict heuristic to simple string literal unions only
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
2025-07-28 22:02:28 +00:00
copilot-swe-agent[bot]andRyanCavanaugh dd30988866 Refine excess property check heuristic for constraint types
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
2025-07-28 21:57:21 +00:00
copilot-swe-agent[bot]andRyanCavanaugh 7adcf162bf Add support for type parameters in isKnownProperty and create test case
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
2025-07-28 21:49:10 +00:00
Daniel Rosenwasser be86783155 Give more specific errors for verbatimModuleSyntax (#62113) 2025-07-23 15:38:01 -07:00
CSIGS@microsoft.com 22ef57786f LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main (#62068) 2025-07-22 13:23:03 -07:00
Mateusz Burzyński d5a414cd1d Don't use noErrorTruncation when printing types with maximumLength set (#62091) 2025-07-22 08:56:52 -07:00
Jake Bailey f14b5c8a2f Remove unused and confusing dom.iterable.d.ts file (#62037) 2025-07-21 14:30:30 -07:00
Nathan Shively-Sanders 2778e84ed8 Restore AbortSignal.abort (#62086) 2025-07-17 11:27:15 -07:00
CSIGS@microsoft.com 65cb4bd2d5 LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250710202354753 to main (#62038) 2025-07-10 13:45:15 -07:00
Jake Bailey 9e20e032ef Clear out checker-level stacks on pop (#62016) 2025-07-08 07:54:20 -07:00
Julian Taub 87740bc7fe Fix for Issue 61081 (#61221) 2025-07-07 13:30:01 -07:00
833a8d492c Fix Symbol completion priority and cursor positioning (#61945)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com>
2025-07-02 14:46:24 -07:00
CSIGS@microsoft.com 0018c9ff12 LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250702194908541 to main (#61992) 2025-07-02 14:35:28 -07:00
Daniel Rosenwasser fe698aef28 Just add a trailing call to visitNode instead of creating a new array when collecting outlining spans (#61987) 2025-07-02 10:18:12 -07:00
Jake Bailey 441655c270 DOM Update 2025-06-18 (#61986) 2025-07-01 18:49:19 -07:00
Kenta Moriuchi 8518a8764e fix Intl.Segments#containing return value type (#61236) 2025-07-01 17:10:50 -07:00
Idan Goshen 3ba257ffac fix: diagnostic message for class name 'Object' when targeting different ECMAScript versions (#61850) 2025-06-30 15:46:33 -07:00
Anthony Fu e58dde511c perf: improve regexp performance by using non-capturing groups (#58551) 2025-06-30 15:12:49 -07:00
Mateusz Burzyński 1ea1809e16 Properly disallow yield in bodyless arrows (#61976) 2025-06-30 14:52:49 -07:00
Mateusz Burzyński b70d4d7e4b Revert change to type print in an error message (#61977) 2025-06-30 14:30:04 -07:00
Mateusz Burzyński 91cdbd518c Fixed nullish coalesce operator's precedence (#61372) 2025-06-30 13:49:03 -07:00
Mateusz Burzyński 58665cf3ae Don't return tags when returning quick info for JSDoc nodes (#59816) 2025-06-30 13:20:08 -07:00
Mateusz Burzyński c35b14335a Keep accessors as accessors in emitted anonymous class declarations (#60853) 2025-06-30 13:19:53 -07:00
Mateusz Burzyński 3267e426e3 Handle silentNeverType in iteration-related functions (#61317) 2025-06-30 12:52:51 -07:00
Mateusz Burzyński 5519be3ae1 Fixed crash when getting a definition for a class member with a computed name and an override modifier (#60631) 2025-06-30 12:48:39 -07:00
Mateusz Burzyński 2ea2ecfdc1 Fixed crash in hasVisibleDeclarations related to binding elements (#61352) 2025-06-30 11:57:47 -07:00
Mateusz Burzyński c33f83ac9b Fixed a printer crash caused by empty parameter modifiers (#60537) 2025-06-30 11:14:10 -07:00
Mateusz Burzyński b46556e7b7 Fixed JSDoc display on JsxNamespacedName attributes (#61825) 2025-06-30 11:07:48 -07:00
Mateusz Burzyński 8665f920c9 Fixed crash on ComputedPropertyName when computing interactive inlay hints (#61857) 2025-06-30 10:28:27 -07:00
Mateusz Burzyński d297037a83 Fixed crash on ConstructSignature when computing interactive inlay hints (#61973) 2025-06-30 10:21:50 -07:00
Roman A dfb7488978 Fix capitalisation for checkJs (#61795) 2025-06-29 09:24:21 -07:00
Ryan Cavanaugh efeb135c6f Revert #54442 and add a testcase (#61955) 2025-06-27 08:52:58 -07:00
Gabriela Araujo Britto 02672d281c Use jsx language variant for jsx file scanning in getChildren (#61928) 2025-06-25 15:37:21 -07:00
CopilotandRyanCavanaugh 6e519c59c1 Fix BigInt literal error in ambient contexts when targeting < ES2020 (#61935)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
2025-06-25 14:29:50 -07:00
CopilotandRyanCavanaugh 1ed8674bba Allow accessor properties in ambient contexts when targeting ES5 (#61927)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
2025-06-25 14:29:02 -07:00
Anders Hejlsberg e6a50a7861 Use strict subtype relation in getCommonSupertype (#61903) 2025-06-24 15:38:59 -07:00
Jake Bailey dca71700ba Fix bad JSON syntax in tests, use JSON.parse first for perf (#61901) 2025-06-24 14:51:46 -07:00
Mateusz Burzyński 50b93bc803 Allow trailing commas after import attributes in ImportType (#61920) 2025-06-24 09:49:37 -07:00
Mateusz Burzyński 78c16795cd Don't ignore completions at source file locations (#61909) 2025-06-23 13:20:43 -07:00
CSIGS@microsoft.com 5a3271b9ba LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250618192323088 to main (#61898) 2025-06-18 13:01:28 -07:00
CSIGS@microsoft.com f1d2494e91 LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250617192341571 to main (#61887) 2025-06-17 13:28:42 -07:00
CSIGS@microsoft.com dd1e258ba5 LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250611192551558 to main (#61846) 2025-06-11 13:57:43 -07:00
Jake Bailey 12e09f44f6 Port "Improve type discrimination algorithm" from tsgo (#61828) 2025-06-09 16:20:15 -07:00
Nicolò Ribaudo 0dfd0c2143 Restore import defer = parsing (#61837) 2025-06-09 14:31:15 -07:00
Anders Hejlsberg 34d1ea68f6 Fix type variable leaks and cache inconsistencies (#61668) 2025-06-09 14:20:27 -07:00
Andrew Branch cb38d99d08 Add --module node20 (#61805) 2025-06-09 14:20:00 -07:00
VincentBailly 97cfa26f2a optimization, reduce memory usage (#61822) 2025-06-09 11:48:30 -07:00