Commit Graph

1371 Commits

Author SHA1 Message Date
Sheetal Nandi d6dfd9a217 Do not remove inferred project immediately and try to reuse it on next file open 2018-04-24 11:53:36 -07:00
Sheetal Nandi 616458261c Detach the removed typing files from the project 2018-04-24 11:53:36 -07:00
Sheetal Nandi 4b19d12e0e Rearrange code such that project Root path of open file is always used in watching and removing the config file watches 2018-04-24 11:53:35 -07:00
Sheetal Nandi 6ec763884e Fix the crash when reporting errors of file that was referenced by inferred project root, is opened right after closing the root file
Fixes the crash reported in https://github.com/Microsoft/TypeScript/issues/23255#issuecomment-382653325
2018-04-23 15:36:32 -07:00
Andy 5c94bef0e1 Add 'renameFile' command to services (#23573)
* Add 'renameFile' command to services

* renameFile -> getEditsForFileRename

* Support `<reference path>` directives
2018-04-20 13:43:09 -07:00
Andy 22f2b118b7 Add 'triggerCharacter' option for completions requests (#23491)
* Add 'triggerCharacter' option for completions requests

* mhegazy code review

* More code review

* Handle '<' in comment
2018-04-20 10:25:58 -07:00
Sheetal Nandi 0526ff5fad Merge pull request #23484 from Microsoft/typingInstallerWatch
Use watch recursive directories instead of watchFile for node_modules and bower components
2018-04-19 09:59:58 -07:00
Sheetal Nandi 56b618b9fc Use indexOf and substr to exclude node_modules and bowerComponents instead of using loop 2018-04-18 11:44:28 -07:00
Sheetal Nandi b0d6896235 Merge pull request #23438 from Microsoft/typingsFiles
Better handling of typing installer events and consuming typing files in tsserver
2018-04-18 11:34:46 -07:00
Sheetal Nandi 67bb67edf1 Cache canonical global cache's package.json path 2018-04-18 11:22:02 -07:00
Sheetal Nandi 7c5f5249ae Renames as per PR feedback 2018-04-18 11:05:56 -07:00
Andrew Casey 26c836b12a Propagage reportsUnnecessary in convertToDiagnosticsWithLinePosition 2018-04-17 19:44:52 -07:00
Sheetal Nandi db9620d8f0 Use watch recursive directories instead of watchFile for node_modules and bower components 2018-04-17 14:27:21 -07:00
Sheetal Nandi d64f2483e4 Update to respond to PR feedback 2018-04-17 14:17:15 -07:00
Andy cae464058a Delete "delete me" files (#23446) 2018-04-16 15:29:02 -07:00
Sheetal Nandi 82e9a7595b Invoked should be property on watchers map instead of local variable since watchers arent closed if they need to be reopened 2018-04-13 15:17:13 -07:00
Sheetal Nandi 60b19f5782 Invalidate the unresolved import resolutions when typing files are set
This has 3 changes:
1. In updateGraph when enqueue the typing installation request (depending on unresolved imports)
2. When ActionSet event is received, invalidate only files with unresolved imports and resolve those.
3. When ActionInvalidate event is received, typing installer has detected some change in global typing cache location, so just enqueue a new typing installation request. This will repeat the cycle of setting correct typings and pickiing unresolved imports
2018-04-13 15:17:13 -07:00
Sheetal Nandi 35abe26824 Force new typings resolution only if there are more or less script infos in the project.
This helps in reducing number of forced typing installation requests
We anyways use changes in unresolved import array to determine if we need to enqueue new typing request
Hence there is no need to soley rely on hasChanges from updateGraph which just indicates that we didnt reused the program (that does not mean new files were added to the program or changes in unresolved imports)
2018-04-13 15:17:13 -07:00
Sheetal Nandi c9479f7263 Remove the specialized type UnresolvedImportsMap which is just a redirection and helps only in test only 2018-04-13 15:17:13 -07:00
Sheetal Nandi b0fb73c47c Typings cache is internal data structure 2018-04-13 15:17:12 -07:00
Sheetal Nandi a9ffabbe51 Merge pull request #23374 from Microsoft/npmInstallCommandTooLong
Handle command too long failure in typings installer
2018-04-12 14:17:47 -07:00
Ryan Cavanaugh ff60520460 Merge branch 'master' into referencesDogfood_1 2018-04-12 12:26:10 -07:00
Sheetal Nandi b3d83c81cc Handle command too long failure in typings installer 2018-04-12 11:43:18 -07:00
Andy ff7ef4a25a Add fixName property to CodeFixAction (#23350) 2018-04-12 09:05:30 -07:00
Ryan Cavanaugh 0e07d775a1 You have to do this everywhere now! 2018-04-11 16:59:53 -07:00
Ryan Cavanaugh df95de3231 Merge branch 'master' into referencesDogfood_1 2018-04-11 16:17:38 -07:00
Ryan Cavanaugh 501d7be7ba Add explicit file lists to server tsconfig files 2018-04-11 15:39:12 -07:00
Ryan Cavanaugh 21d16693da Explicitly list server source files in their current emitted order 2018-04-11 15:38:27 -07:00
Ryan Cavanaugh 3ca1d2d7e3 Remove all reference comments from server/ 2018-04-11 15:38:26 -07:00
Andy 4b706fc479 Add 'disableSuggestions' to UserPreferences (#23283)
* Add 'disableSuggestions' to UserPreferences

* Make mergeMapLikes return a new object

* Avoid additional clone

* mergeMapLikes -> object spread
2018-04-10 11:53:24 -07:00
Andy 556a8010b9 Fix bug: ensure 'reportsUnnecessary' is actually sent by tsserver (#23293) 2018-04-10 10:15:15 -07:00
Andy 542184a05a Rename infoCheck to suggestionCheck (#23286) 2018-04-09 14:09:07 -07:00
Sheetal Nandi 7a0a1f6a28 Do not watch script infos that are part of global typings location 2018-04-06 15:52:39 -07:00
Sheetal Nandi c9f39951b6 Do not send project update in background if there was no ensureUpdate pending on the project structure 2018-04-06 14:58:13 -07:00
Sheetal Nandi 62c6fe2ccc There is no need to ensure project structure when tryiong to get inferred project
The project operations will validate if its valid anyways
2018-04-06 14:22:08 -07:00
Sheetal Nandi e304178c65 Add time stamp into the ti log. 2018-04-06 14:22:04 -07:00
Andy 24842b4002 When --noUnusedLocals/--noUnusedParameters is disabled, add suggestions instead of errors (#22361)
* When --noUnusedLocals/--noUnusedParameters is disabled, add suggestions instead of errors

* Improve performance: do not add unused suggestion diagnostics unless asking for a suggestion

* Add "unused" flag to diagnostics

* Code review

* reportsUnused -> reportsUnnecessary

* Fix test
2018-04-05 12:33:00 -07:00
Andy 4f80fbddc2 Fix typo and use array helper (#23169)
* Fix typo and use array helper

* Update API baselines
2018-04-05 10:17:01 -07:00
Andrew Casey 855171bde5 Introduce a --syntaxOnly server mode
1. Disable the LS in all projects
 2. Don't create Program objects
 3. Ignore config files
2018-04-04 16:44:15 -07:00
uniqueiniquity 36cdb52b17 Handle double quotes for every argument 2018-04-02 16:41:29 -07:00
uniqueiniquity 8f503fb483 Close over getLogPath 2018-04-02 15:38:04 -07:00
uniqueiniquity e625a6a9b4 Use object destructuring instead of tuple 2018-04-02 15:12:26 -07:00
uniqueiniquity ffbb046cd4 Consume extra parts of file path 2018-04-02 13:58:31 -07:00
uniqueiniquity 361be11a04 Remove trailing whitespace 2018-04-02 12:32:15 -07:00
uniqueiniquity 0238991cd3 Ensure TSS_LOG handles paths with spaces 2018-04-02 11:04:52 -07:00
Andy 3e32e15895 Add 'fixAllDescription' property to CodeFixAction (#22616)
* Add 'fixAllDescription' property to CodeFixAction

* Code review

* Add to protocol

* Make fixAllDescription be just a string
2018-03-27 18:21:21 -07:00
Andrew Casey 517cf6aa89 Add support for suppressing project events
VS doesn't consume (e.g.) `syntaxDiag` events, so there's no reason to
do the work to compute their payloads.
2018-03-22 16:44:09 -07:00
Andy 67670d8726 Revert change to canUseEvents in IoSessionOptions (#22791) 2018-03-22 10:29:32 -07:00
Andrew Casey 564183f9ed Fix lint errors 2018-03-21 15:18:06 -07:00
Andrew Casey 9352a8bc11 Delete IoSessionOptions
Many of the operations were unused because the values were being
accessed directly from the enclosing scope.
2018-03-21 14:56:06 -07:00