Klaus Meinhardt
4cd859aa85
Allow referencing 'this' in parameters of functions in the constructor
...
Fixes : #29286
2019-01-07 22:09:27 +01:00
Martin Probst
7a2b2cebbf
Do not emit code for @extends tags in JS. ( #29244 )
...
When transpiling JavaScript, TS3.1+ emits `@extends` tags as code. E.g.
/** @extends {SuperClass} */
class SubClass {}
Causes an ES5 emit that references SuperClass:
/**
* @extends {SomeBase}
*/
var SubClass = /** @class */ (function (_super) {
__extends(SubClass, _super);
function SubClass() {
return _super !== null && _super.apply(this, arguments) || this;
}
return SubClass;
}(SomeBase));
Note the literal references to `SomeBase`.
This appears to be an accidental effect of 0f55566cf4 . It refactored
`getEffectiveBaseTypeNode` for type checking, but missed an instance
where it is also used for emit logic. This change fixes the problem by
specifically getting the heritage clauses directly off the AST.
Change-Id: I3128a757e5924e2528c61230a90ac13650852542
2019-01-04 08:13:14 -08:00
Sheetal Nandi
d8ee4116ef
Fix function declaration without body to be checked as context sensitive
...
Fixes #29032
2019-01-03 12:46:39 -08:00
Benjamin Lichtman
11585d29bc
Merge pull request #29218 from uniqueiniquity/jsdocSpanForVarStatement
...
Jsdoc span for var statement
2018-12-31 16:27:34 -08:00
Benjamin Lichtman
aebcb6df36
Merge pull request #29216 from uniqueiniquity/multilineArgumentSpans
...
Give appropriate outlining span for array and object literals as args in call expression
2018-12-31 15:18:07 -08:00
Benjamin Lichtman
bb2f300191
Add test
2018-12-31 15:15:47 -08:00
Benjamin Lichtman
a266131928
Add test
2018-12-31 14:43:56 -08:00
Benjamin Lichtman
adcb278272
Add test
2018-12-31 14:11:08 -08:00
Daniel Rosenwasser
0dbb9760c0
Merge pull request #29147 from Kingwl/type_query_completions
...
fix typeof completions broken
2018-12-31 10:36:39 -08:00
Anders Hejlsberg
beebda3574
Merge pull request #29110 from Microsoft/fixDiscriminantCheck
...
Fix discriminant property check
2018-12-30 17:46:01 -10:00
Anders Hejlsberg
8570a67572
Merge pull request #29121 from Microsoft/mappedTypeConstraints
...
Improve constraints for non-homomorphic mapped types
2018-12-30 17:44:41 -10:00
Anders Hejlsberg
fd3af78b8b
Merge pull request #29179 from Microsoft/typeParameterDefaultForwardReference
...
No self or forward references in type parameter defaults
2018-12-30 17:43:57 -10:00
Anders Hejlsberg
8e1403144d
Merge pull request #29192 from Microsoft/initializerWidening
...
Fix initializer widening
2018-12-28 17:15:36 -10:00
Anders Hejlsberg
7f4d1ac475
Add regression test
2018-12-28 09:38:19 -10:00
Benjamin Lichtman
c46090b8dc
Show template literal in navtree function call args
2018-12-27 17:43:56 -08:00
Anders Hejlsberg
a400a8afec
Add regression test
2018-12-27 14:05:14 -10:00
王文璐
7c93affd7d
fix typeof completions broken
2018-12-25 17:30:04 +08:00
Anders Hejlsberg
7ad2661625
Add tests
2018-12-21 12:51:01 -08:00
Anders Hejlsberg
3e93461fc8
Add regression test
2018-12-20 07:21:49 -08:00
Wesley Wigham
08022d57c8
Allow calls on unions of dissimilar signatures ( #29011 )
...
* Add core of new union signature logic and test - needs intersection signature logic to fully work
* Add inversion of variance for class props lookup from union sig returns
* Fix lints
* Combine parameter names for nicer quick info
* PR feedback 1
* Fix miscopy
* PR feedback round 2
* Remove argument name combining because loc :(
* Nit cleanup round 3
* Reinline getTupleTypeForArgumentAtPos
* Remove a tad more
* No step on sneky off-by-one error
2018-12-19 16:35:01 -08:00
Daniel Rosenwasser
ab2a38ebef
Merge pull request #29102 from Microsoft/declarationEmitForDefaultExportClassExtendingExpression
...
Declaration emit for default exported class extending expression
2018-12-19 16:19:36 -08:00
Daniel Rosenwasser
54352dc1c9
Added test case.
2018-12-19 15:51:31 -08:00
Anders Hejlsberg
3e0639add5
Merge pull request #29053 from Microsoft/fixDestructuringControlFlow
...
Fix destructuring control flow analysis
2018-12-19 11:12:41 -08:00
Wesley Wigham
d23effc200
Non-latebound computed property names should print as their underlying name type ( #29084 )
2018-12-18 17:02:34 -08:00
Anders Hejlsberg
8ac18be108
Merge pull request #29082 from Microsoft/widenIntersectionTypes
...
Properly widen intersection types
2018-12-18 12:53:33 -08:00
Wesley Wigham
4e3bc9e35a
Reset constEnumOnlyModule flag on relevant symbol merges in binder ( #29079 )
2018-12-18 12:31:53 -08:00
Anders Hejlsberg
519c501ea5
Add regression test
2018-12-18 11:58:06 -08:00
Anders Hejlsberg
c52e5985b7
Merge pull request #29068 from Microsoft/noGenericEmptyObject
...
Generic types should never be considered empty objects
2018-12-17 15:59:42 -08:00
Wesley Wigham
d2885eab4a
Add regression test for #29047 ( #29066 )
2018-12-17 14:56:48 -08:00
Anders Hejlsberg
ab797df977
Add regression test
2018-12-17 14:14:54 -08:00
Anders Hejlsberg
307a9b66af
Add tests
2018-12-16 07:23:28 -08:00
Daniel Rosenwasser
4d74f67325
Merge pull request #28888 from Microsoft/numericPropertyAccess
...
Avoid adding a dot when comment a property acccess's expression has trailing comments
2018-12-13 15:18:27 -08:00
Kerem
de4803658e
Disable truncation for codefixes in signatureToMethodDeclaration. ( #28188 )
2018-12-13 11:21:36 -08:00
Wesley Wigham
5788446aa1
Use contextual parameter types over binding pattern initializer types ( #28967 )
...
* Use contextual parameter types over binding pattern initializer types
* Remove unneeded check
2018-12-12 15:39:32 -08:00
Anders Hejlsberg
fecbdb68bd
Merge pull request #28965 from Microsoft/simplifyIndexedAccess
...
Simplify indexed access types applied to mapped types
2018-12-11 17:56:03 -08:00
Daniel Rosenwasser
2999a1eb47
Merge remote-tracking branch 'origin/master' into numericPropertyAccess
2018-12-11 16:52:23 -08:00
Anders Hejlsberg
77d01ab332
Update tests
2018-12-11 15:12:47 -08:00
Anders Hejlsberg
2150a64f0c
Add tests
2018-12-11 12:11:16 -08:00
Philip Pesca
e6aa992095
Fix error message when type argument arity is wrong ( #28366 )
...
* Fix error message when type argument arity is wrong
* Parenthesize 's' in plurals
* Update baseline
* Update baseline
* Use old error message
* Revert parantheses
2018-12-11 09:54:38 -08:00
Daniel Rosenwasser
2e9be8c05b
Added more tests, including some in 'removeComments' mode.
2018-12-10 22:21:15 -08:00
Anders Hejlsberg
45411e525c
Add tests
2018-12-10 16:30:30 -08:00
Daniel Rosenwasser
bc59582c7d
Merge pull request #28627 from ajafff/arrow-arguments
...
ArrowFunction has no own 'arguments'
2018-12-10 11:42:43 -08:00
Daniel Rosenwasser
3e6a666b5e
Merge pull request #28919 from a-tarasyuk/feature/28893-allow-trailing-comma-on-tuple-types
...
feature/28893 allow trailing comma on tuple types
2018-12-10 11:33:33 -08:00
Anders Hejlsberg
cd6d2fdc18
Merge pull request #28940 from Microsoft/explicitUnknownConstraint
...
Type parameter constrained to 'unknown' not assignable to '{}'
2018-12-10 10:29:06 -08:00
Anders Hejlsberg
d2cc282134
Add tests
2018-12-10 09:45:55 -08:00
Anders Hejlsberg
7a0779288f
Add tests
2018-12-10 09:14:41 -08:00
Alexander
e219b17ff0
TupleType - add additional tests to handle error on extra comma
2018-12-08 20:50:09 +02:00
Anders Hejlsberg
34d9d4bc8c
Merge pull request #28870 from Microsoft/discriminatedUnionInference
...
Improved type inference for discriminated unions
2018-12-07 15:44:41 -08:00
Daniel Rosenwasser
8150169762
Merge pull request #28857 from JoshuaKGoldberg/identifiers-after-numeric-literals
...
Added error for IdentifierStart immediately after a NumericLiteral
2018-12-06 11:49:56 -08:00
Josh Goldberg
a211184347
Clarified error message; extended error to identifier end
...
Lengthening the reported error length to include all of the identifier necessitates scanning for all of the identifier. I also reset the `pos` after so other identifier scanning still happens.
2018-12-06 11:17:06 -08:00