Commit Graph
3452 Commits
Author SHA1 Message Date
Nathan Shively-Sanders 41bb446865 Revert unioning of this argument types
The right solution is to not instantiate this-types of unions, which is a
separate problem more to do with this-class types.
2016-02-08 16:39:19 -08:00
Nathan Shively-Sanders 738713b146 Improve error reporting
1. Fix bug in error reporting in compareSignaturesRelated.
2. When the this-argument is a union type, allow assignability when the
method's signature is assignable to *any* member of the union.
2016-02-08 14:01:51 -08:00
Nathan Shively-Sanders fa598758b1 Improve display and contextual typing of this
1. Always display `this` type if annotated.
2. Contextually type un-annotated `this` parameters in addition to `this`
expressions.
2016-02-08 09:41:57 -08:00
Nathan Shively-Sanders 80de700be0 Get contextual type of this parameter correctly
Now the language service also sees the contextual type.

Note that with this change, the type display for contextually typed this
parameters goes away because there is no symbol. I'll fix type display
next.
2016-02-05 16:18:21 -08:00
Nathan Shively-Sanders 2f74da112d Add specific error messages for out-of-place this
Also remove lint in checker.
2016-02-04 16:01:10 -08:00
Nathan Shively-Sanders 8c87da523b First round of review comments addressed.
Only major thing is a bug fix in
`isContextSensitiveFunctionLikeDeclaration`, and turning on context
sensitivity to `this` even with `--strictThis` off.
2016-02-04 15:43:43 -08:00
Nathan Shively-Sanders 8032b06f33 Merge branch 'master' into this-function-types 2016-02-02 16:16:46 -08:00
Ryan Cavanaugh bd3e9f262a Merge pull request #6709 from RyanCavanaugh/fix6662
Don't crash when return type jsdoc tag is malformed
2016-02-02 13:40:13 -08:00
Ryan Cavanaugh 554ea1b57c Merge pull request #6679 from RyanCavanaugh/fix6645
Allow multiple 'this' property assignments in Salsa
2016-02-02 12:49:09 -08:00
Daniel Rosenwasser 3dae2534f3 Merge pull request #6278 from Microsoft/theyreNotTHATSpecial
Remove most special treatment of specialized signatures.
2016-02-02 12:45:30 -08:00
Vladimir Matveev 7259074dfb Merge pull request #6846 from Microsoft/noErrorOnEmptyDtsFile
do not error if typings for external library is empty .d.ts file
2016-02-02 12:12:52 -08:00
Vladimir Matveev fb99a6697d do not error if typings for external library is empty .d.ts file 2016-02-02 11:36:38 -08:00
Ryan Cavanaugh 2d7a2f4d30 Merge pull request #6680 from RyanCavanaugh/fix6646
Parse JSDoc comments for ES6 class constructors and methods
2016-02-02 10:48:29 -08:00
Ryan Cavanaugh b15ff81384 Add malformed parameter test 2016-02-01 21:48:16 -08:00
Daniel Rosenwasser 0855933757 Merge pull request #6587 from nojvek/master
pretty output for jsx and createElement emits to children array
2016-02-01 21:38:15 -08:00
Ryan Cavanaugh 3dfd378b7e Add some tests 2016-02-01 21:20:37 -08:00
Ryan Cavanaugh a4c6f66686 Treat multiple prototype property assignments as union property declarations 2016-02-01 20:59:37 -08:00
Vladimir Matveev a17dbd5c2b Merge pull request #6798 from Microsoft/dottedNamesInJsx
properly classify dotted tag names in jsx
2016-02-01 16:49:59 -08:00
Vladimir Matveev 555f35e2cd Merge pull request #6803 from Microsoft/noDirExistsCheckInClassic
don't do 'directoryExists' check in classic resolution scheme
2016-02-01 16:49:51 -08:00
Vladimir Matveev f94c7202d2 update baselines 2016-02-01 15:54:14 -08:00
Daniel Rosenwasser dd0a2e0340 Added tests. 2016-02-01 14:17:29 -08:00
Vladimir Matveev e6c6d3090a properly classify dotted tag names in jsx 2016-02-01 13:35:57 -08:00
Vladimir Matveev 4a01708c13 Merge pull request #6789 from Microsoft/transpileJs
suppress validation of output paths in transpile scenarios
2016-02-01 11:27:27 -08:00
Vladimir Matveev b0b0712c73 suppress validation of output paths in transpile scenarios 2016-02-01 10:36:47 -08:00
Ryan Cavanaugh bb7216a1ea Merge pull request #6741 from RyanCavanaugh/fix6673
Fixes bug #6673
2016-02-01 10:18:47 -08:00
Ryan Cavanaugh 202c1e6e4b Merge pull request #6707 from RyanCavanaugh/fix6693
Don't show the currently-completing thing at the cursor in JS files
2016-02-01 10:03:22 -08:00
Vladimir Matveev e168e945e5 Merge pull request #6770 from Microsoft/dottedNamesInSystem
properly handle dotted namespace names in System modules
2016-02-01 10:01:05 -08:00
Vladimir Matveev 726514bac0 Merge pull request #6763 from Microsoft/classInterfaceCrossFileMerge
properly handle merged declarations across files
2016-02-01 10:00:54 -08:00
Vladimir Matveev 4d2cd6f88b properly dotted namespace names in System modules 2016-01-31 12:10:33 -08:00
Vladimir Matveev e5aa9cbc6f properly handle merged declarations across files 2016-01-30 19:58:29 -08:00
Vladimir Matveev 39216e8811 Merge pull request #6742 from Microsoft/augmentExportEquals
allow augmentation for entities exported via 'export='
2016-01-30 19:47:06 -08:00
Ron Buckton fe23cc3c44 Merge pull request #6684 from Microsoft/fixDecoratedClassName
Fix ES6 decorated class double binding.
2016-01-29 17:37:24 -08:00
Vladimir Matveev 5d22d18a70 allow augmentation for entities exported via 'export=' 2016-01-29 16:27:34 -08:00
Ryan Cavanaugh f89ebb8fd8 Fixes bug #6673
#6673
2016-01-29 16:01:41 -08:00
Nathan Shively-Sanders d030889166 Update baselines
1. Display of `this` changes for quick info.
2. The type of Function.call/apply/bind is more precise.
2016-01-29 14:52:47 -08:00
Nathan Shively-Sanders a4f1154377 Fix free function bug in cachingInServerLSHost 2016-01-29 14:51:35 -08:00
Nathan Shively-Sanders 04e7d81105 Add tests and baselines for this-function types. 2016-01-29 14:49:52 -08:00
Daniel Rosenwasser ad9bff88fa Merge branch 'master' into theyreNotTHATSpecial 2016-01-29 14:47:23 -08:00
Vladimir Matveev 56355d1d17 fix access check issues when declaration is in multiple files 2016-01-29 13:28:27 -08:00
guybedford 94fe3e0fb2 set __moduleName from context.id argument 2016-01-29 18:42:23 +02:00
Ron Buckton 4835e43a8f Merge branch 'master' into fixDecoratedClassName 2016-01-28 17:59:04 -08:00
Ron Buckton 0978639ab2 Merge branch 'master' into fixDecoratedClassName 2016-01-28 17:53:56 -08:00
Yui e954929d4b Merge pull request #5833 from Microsoft/fix4211
Error when accessing this before super
2016-01-28 15:55:03 -08:00
Ryan Cavanaugh 5a845bf0fc Don't crash when return type jsdoc tag is malformed
Fixes #6662
2016-01-28 15:48:18 -08:00
Ryan Cavanaugh 124bd517e7 Don't show the currently-completing thing at the cursor in JS files
Fixes #6693
2016-01-28 15:18:50 -08:00
Vladimir Matveev 78b525312f Merge pull request #6704 from Microsoft/isRequireCall_fix
add extra argument to 'isRequireCall' to check if argument is string …
2016-01-28 15:16:53 -08:00
Kanchalai Tanglertsampan bf854a784f Merge branch 'master' into fix4211 2016-01-28 14:33:50 -08:00
Vladimir Matveev 3661b66be4 add extra argument to 'isRequireCall' to check if argument is string literal 2016-01-28 14:18:23 -08:00
Anders Hejlsberg cb6dd18174 Merge pull request #6702 from Microsoft/readonlyInDeclarationFiles2
Readonly in declaration files (part 2)
2016-01-28 13:56:18 -08:00
Ryan Cavanaugh 2ef6f13532 Merge pull request #6699 from RyanCavanaugh/fix6663
Use union types in the return type of functions in the error case
2016-01-28 13:30:03 -08:00