Commit Graph
2355 Commits
Author SHA1 Message Date
Wesley Wigham 62185673fd Emit unqiue symbols with typeof if possible before issuing an error (#21403) 2018-02-28 15:44:12 -08:00
Sheetal Nandi 005a50f587 Merge pull request #22136 from Microsoft/moduleResolution
Use cache for the non-relative module resolution and enhance the watches for failed lookup locations
2018-02-28 14:39:22 -08:00
Andy fa4619c5c1 Add 'info' diagnostics (#22204)
* Add 'info' diagnostics

* Code review
2018-02-28 11:16:32 -08:00
Andy f4af74aae1 Simplify TextChanges#getChanges (#22157)
* Simplify TextChanges#getChanges

* Rename function and improve assert
2018-02-27 12:26:05 -08:00
Andy 0b1e21794d fourslash diagnostics tests: use objects instead of strings (#22193) 2018-02-26 14:55:26 -08:00
Wesley Wigham d15b098e70 Increase rwc js verification timeout (#22191)
* Increase js verification timeout

* Add seperator
2018-02-26 12:55:08 -08:00
Andrew Casey 8ead7ab29c Organize imports within ambient module declarations 2018-02-22 16:30:57 -08:00
Sheetal Nandi 86dca7bada Merge pull request #22090 from Microsoft/fileDeletedWatchClose
In tsc--watch, fix the leaking watch when old source file is not part of program any more
2018-02-22 16:04:17 -08:00
Andy a299d2dd1c isDeclarationName: support ComputedPropertyName (#22123)
* isDeclarationName: support ComputedPropertyName

* update additional baseline
2018-02-22 15:53:49 -08:00
Sheetal Nandi fdb5e95f0a Use the module cache to resolve non relative module name as well 2018-02-22 15:44:13 -08:00
Sheetal Nandi 403b7d8604 Add tests for module resolution order and reuse 2018-02-22 15:35:19 -08:00
Andrew Casey 72a7194b6c Merge pull request #22007 from amcasey/UnusedImports
Implement ts.OrganizeImports.removeUnusedImports
2018-02-21 13:35:43 -08:00
Sheetal Nandi 05fcc225a4 Add test case when the deleted file's watch is not closed 2018-02-21 10:57:04 -08:00
Andy b00c13b716 Fix bug: Handle QualifiedName in getMeaningFromRightHandSideOfImportEquals (#21779)
* Fix bug: Handle QualifiedName in getMeaningFromRightHandSideOfImportEquals

* Fix lint
2018-02-20 14:32:51 -08:00
Andrew Casey fee1df34ce Implement ts.OrganizeImports.removeUnusedImports
TODO: Still need to add support for organizing imports in ambient
modules
2018-02-20 10:21:25 -08:00
Andy b3edc8f9f4 Apply 'no-unnecessary-type-assertion' lint rule (#22005)
* Apply 'no-unnecessary-type-assertion' lint rule

* Fix type error

* Fix tsconfig.json

* Add --format back
2018-02-16 18:38:00 -08:00
Andrew Casey 7a31394788 Group imports before sorting and coalescing 2018-02-16 13:15:07 -08:00
Andrew Casey 5c278cee17 Address PR feedback
Eliminate cancellation token

Add organizeImports.ts to tsconfig.json

Simplify ts.OrganizeImports.organizeImports

Simplify sortImports

Semantic change: all invalid module specifiers are now considered to be
equal.

Simplify comparisons using ||

Pull out imports with invalid modules specifiers

...for separate processing.  They are tacked on to the end of the
organized imports in their original order.

Bonus: downstream functions can now assume imports have valid module
specifiers.

Rename baseline folder with leading lowercase

Simplify coalesceImports

Remove some unnecessary null checks

Simplify baseline generation
2018-02-16 10:56:16 -08:00
Andrew Casey f4141ac6bf Separate OrganizeImports into its own namespace and file 2018-02-16 10:52:29 -08:00
Andrew Casey 979b14689e Fix lint errors 2018-02-16 10:52:21 -08:00
Andrew Casey 5656f35b6a Introduce an organizeImports command
In phase 1, it coalesces imports from the same module and sorts the
results, but does not remove unused imports.

Some trivia is lost during coalescing, but none should be duplicated.
2018-02-16 10:51:38 -08:00
Andy f8f4bb8fdd textChanges: Clean up handling of newLineCharacter (#21970) 2018-02-15 13:02:56 -08:00
Andy 47d84f87ce assertItemInCompletionList: Fix error messages (#21908)
* assertItemInCompletionList: Fix error messages

* Fix lint
2018-02-14 08:11:38 -08:00
Sheetal Nandi d9d98cf11a Handle the delayed updates due to user action correctly when ensuring the project structure is upto date
Fixes #20629
2018-02-12 16:53:47 -08:00
Sheetal Nandi e702d90cfe Repro scenario for finding no project of #20629 2018-02-12 13:12:55 -08:00
Andy 20a6be67a0 Clarify assumptions in verifyImportFixAtPosition (#21899) 2018-02-12 13:05:13 -08:00
Andrew Casey e65a1a429c Harden Extract Symbol against symbols without declarations
Fixes #21793
2018-02-09 19:42:34 -08:00
Andrew Casey 025418fdb0 Handle class declarations without names in Extract Symbol
Fixes #21816
2018-02-09 19:09:25 -08:00
Benjamin Lichtman f989ef7261 Merge pull request #21004 from uniqueiniquity/updateATA
Enable typings cache entries to expire and be updated
2018-02-09 14:17:26 -08:00
Andy 16f3b93ffd Simplify TextSpan creation (#21306)
* Simplify TextSpan creation

* Rename 'start' to 'pos' where possible
2018-02-08 13:51:10 -08:00
Sheetal Nandi a0b8be0198 Merge branch 'master' into symbolAndTypesOfString 2018-02-08 11:09:26 -08:00
Sheetal Nandi bf707ac265 Merge pull request #21743 from Microsoft/defaultProjectForFile
Fix getDefaultProjectForFile check
2018-02-08 09:58:43 -08:00
Wesley Wigham 871e71d4ef Move insertSorted from server to core, use for diagnostic collections (#21401)
* Move insertSorted from server to core, use for diagnostic collections

* All keep the overall list sorted, too

* Increase timeout for js verification

* Use knowledge of how diagnostics are sorted to make all diagnostic list creation lazy and more efficient

* Staunchly avoid array allocation in favor of resizing an existing array
2018-02-07 17:00:59 -08:00
Sheetal Nandi b18f830216 Fix getDefaultProjectForFile check
Fixes #21738
2018-02-07 14:42:51 -08:00
Sheetal Nandi 3b1a3f8a4d Merge pull request #21693 from Microsoft/fileChangeThroughDeleteAndCreate
Handle file versioning little better in tsc --watch mode
2018-02-07 10:24:27 -08:00
Andy c1b4c5b827 Fix bug in normalizeAndPreserveTrailingSlash: For "./", return "", not "/" (#21704) 2018-02-07 09:07:05 -08:00
Sheetal Nandi 2684784545 Handle source file versioning better since the emit depends on it
This ensures that when file is deleted and re-created, the file version isnt same to ensure emits correctly
Fixes #21444
2018-02-06 12:30:13 -08:00
Andy c4c9a00a9f Support incomplete identifier in JSX initializer completions (#21681) 2018-02-06 11:40:39 -08:00
Sheetal Nandi 384aad6906 Add test case for file change happening as part of file create and delete 2018-02-06 10:50:32 -08:00
Mohamed Hegazy 8f8fec433e Rename switch --emitDeclarationsOnly to --emitDeclarationOnly (#21651)
* Rename `--emitDeclarationsOnly` to `--renameDeclarationOnly`

* Rename test files
2018-02-05 14:48:50 -08:00
Andy 48c0af5d43 Support testing document highlights with "filesToSearch" (#21640)
* Support testing document highlights with "filesToSearch"

* Fix lint
2018-02-05 14:02:50 -08:00
Andy 1784e51929 Fix harness getDirectores implementation to not include directory as prefix (#21633) 2018-02-05 11:11:00 -08:00
Sheetal Nandi 271b47ce93 Emit the symbol information for declaration names (could be string literals and more) 2018-02-01 14:30:32 -08:00
Sheetal Nandi 1fb3593e61 Merge pull request #21537 from Microsoft/donotClearScreenWithDiagnostics
Do not clear console in watch mode if --diagnostics or --extendedDiagnostics is specified
2018-02-01 10:18:02 -08:00
Andrew Casey 02972899d7 Merge pull request #21379 from amcasey/HighlightingAssert
Check syntax kind in isDeclarationNameOrImportPropertyName
2018-02-01 10:11:10 -08:00
Sheetal Nandi d4c84368e5 Do not clear console in watch mode if --diagnostics or --extendedDiagnostics is specified 2018-02-01 10:07:28 -08:00
Sheetal Nandi 11214b9dcd Removing the test added for cancellation during affected list since thats not possible anymore as the affected files would anyways be semantically checked
This is just part missed during revert of 0b79f4a
2018-01-31 17:15:54 -08:00
Sheetal Nandi cf540198e6 Always get diagnostics when emitting irrespective of whether its declaration only emit
The diagnostics reporting and expression resolution caching is quite intermingled at present.
Hence when we tried to get the declaration output without getting diagnostics, the resolution for functions return expression is cached but errors arent reported
Symbols arent marked as referenced. So at later time when trying to get the diagnostics since the expression resolution is cached, it doesnt even go through all checks
For now get diagnostics irrespective of declaration only output to avoid this issue.
Fixes #21518
2018-01-31 16:22:27 -08:00
Armando Aguirre 6435d26510 Merge pull request #21505 from armanio123/SetNoEmitTrueJsConfig
Set noEmit = true  on jsconfig.json file
2018-01-31 11:08:04 -08:00
Wesley Wigham 6219be6144 Do no path canonicalization during config parsing (#20311)
* Do no canonicalization during config parsing

* Add test from issue

* Apply code review feedback
2018-01-30 14:16:44 -08:00