Wesley Wigham
345b2b4f2b
Resolve aliases before using getTypereferenceType ( #24594 ) ( #24671 )
2018-06-05 12:35:42 -07:00
Wesley Wigham
1d885b392e
Visit the children of an import type/require call/dynamic import when looking for those ( #24663 ) ( #24670 )
2018-06-05 12:35:28 -07:00
Andy
a86882f996
If parsing a function type fails, parseTypeReference() to ensure something is returned ( #24567 ) ( #24695 )
...
* If parsing a function type fails, parseTypeReference() to ensure something is returned
* Avoid tryParse
* Add missing semicolon
* Don't check for undefined, check for missing type
* Don't set parameters undefined, set to missingList and return false
* Update API baselines
* Code review
2018-06-05 11:02:58 -07:00
Sheetal Nandi
c52fb0e92f
Merge pull request #24665 from Microsoft/builderAPIBreak29
...
[release-2.9] Fix the issue with createSemanticDiagnosticsBuilderProgram, createEmitAndSemanticDiagnosticsBuilderProgram and createAbstractBuilder not assignable to CreateProgram<T>
2018-06-04 13:35:52 -07:00
Andy
4e17e771cf
moveToNewFile: Update namespace imports ( #24612 ) ( #24657 )
...
* moveToNewFile: Update namespace imports (#24612 )
* Port needed changes from #24469
2018-06-04 13:16:36 -07:00
Sheetal Nandi
5bcd19275b
Tests to acknowledge the public watch api
2018-06-04 13:09:02 -07:00
Wesley Wigham
be50eea00c
Fix merge lexical environment to *always* respect prologue statements ( #24602 ) ( #24654 )
2018-06-04 12:29:43 -07:00
Sheetal Nandi
c619875a8a
Disable source maps and declaration emit for the json module
...
Fixes #24546
2018-06-04 10:58:04 -07:00
Wesley Wigham
a56fe765cf
Visit super arguments even when no signature exists ( #24591 ) ( #24595 )
2018-06-02 13:32:47 -07:00
Andy
0fb9b1adbd
Fix bug when name resolution fails in a @typedef: Don't set lastLocation ( #24585 )
...
* Fix bug when name resolution fails in a @typedef: Don't set `lastLocation`
* Add noEmit to test
2018-06-01 16:50:43 -07:00
Wesley Wigham
2dd189922f
Include export specifiers in the list of syntactic defaults ( #24549 ) ( #24578 )
2018-06-01 12:16:01 -07:00
Andy
3f77e1eae1
Support import completion for merged declaration exports ( #24539 ) ( #24572 )
2018-06-01 10:28:00 -07:00
Andy
8dc7d5aa88
getEditsForFileRename: Support directory rename ( #24305 ) ( #24568 )
...
* getEditsForFileRename: Support directory rename
* Code review
* Handle imports inside the new file/directory
* Document path updaters
* Shorten relative paths where possible
* Reduce duplicate code
* Rewrite, use moduleSpecifiers.ts to get module specifiers from scratch instead of updating relative paths
* Update additional tsconfig.json fields
* Add test with '.js' extension
* Handle case-insensitive paths
* Better tsconfig handling
* Handle properties inside compilerOptions
* Use getOptionFromName
2018-06-01 09:48:48 -07:00
Sheetal Nandi
de1849faa5
Do not emit trailing comma in json module
...
Fixes #24530
2018-05-31 12:50:53 -07:00
Alexander T
6024ed29d3
Do not emit 'use strict' prologue in .json files with --alwaysStrict
2018-05-31 12:19:24 -07:00
Wesley Wigham
124e0a3c37
For type emit, walk non-parent containers when those containers have aliases leading to the target ( #24507 ) ( #24510 )
2018-05-31 09:17:49 -07:00
Andy
ca8ee38157
moveToNewFile: Remove newlines after last moved statement ( #24503 ) ( #24505 )
2018-05-31 09:11:26 -07:00
Wesley Wigham
71ea6c3f28
Lookup type arguments correcly for taged templates when checking generic arity ( #24496 ) ( #24504 )
2018-05-30 15:41:48 -07:00
Nathan Shively-Sanders
7b1e32ecec
Fix exported type resolution in commonjs ( #24495 )
...
* Fix resolution of exported types in commonjs
It is fine to resolve the types of exported classes in ES6:
```js
export class C {
}
var c = new C()
```
But not for commonjs exported classes:
```js
module.exports.C = class {
}
var c = new C() // should error
```
Fixes #24492
* All jsdoc type aliases are available locally in commonjs modules
* Check that location isSourceFile before commonJsModuleIndicator
2018-05-30 14:14:01 -07:00
Wesley Wigham
4369d54c6b
Use external aliases in quickinfo and signature help return types ( #24391 ) ( #24395 )
...
* Dont include import types in quick info type names
* Add UseAliasDefinedOutsideCurrentScope flag to LS operations which were missing it
2018-05-24 18:35:15 -07:00
Nathan Shively-Sanders
a7b2983d12
Disallow nested object param syntax in callback tag ( #24392 )
...
* Callback tag:Disallow nested-object-param syntax
Previously this caused a crash in parsing. If/when we want to support
this syntax, we will need to fix this crash.
* Update baselines
2018-05-24 15:12:35 -07:00
Andy
a7b7b3c2ad
moveToNewFile: Format the new file ( #24379 ) ( #24382 )
2018-05-24 11:35:02 -07:00
Andy
68bc957cf6
moveToNewFile: Respect UserPreferences#quote ( #24365 ) ( #24378 )
2018-05-24 10:06:38 -07:00
Andy Hanson
0ef6937202
getEditsForFileRename: Handle old file still being present
2018-05-23 16:17:24 -07:00
Mohamed Hegazy
a4fd87eeb6
Merge pull request #24347 from weswigham/constraint-fix
...
Check for keyof constraint type instead of syntactic check (#24098 )
2018-05-23 08:42:46 -07:00
Mohamed Hegazy
3546503d49
Merge pull request #24346 from weswigham/metadata-change
...
Use unknown serialization kind when type symbol isnt resolved (#24332 )
2018-05-23 08:42:34 -07:00
Sheetal Nandi
c435179450
Fix getter of local symbol for export= when it is json module
...
Fixes #24341
2018-05-22 20:18:05 -07:00
Wesley Wigham
b60ad05eb5
Check for keyof constraint type instead of syntactic check ( #24098 )
...
* Check for keyof constraint type instead of syntactic check
* Readopt older candidateType check, even though it shouldnt really matter
* OK. Just use maybetypeOfKind
* Remove redundant boolean check
2018-05-22 17:00:10 -07:00
Wesley Wigham
ef6b961877
Use unknown serialization kind when type symbol isnt resolved ( #24332 )
...
* Use unknown serialization kind when type symbol isnt resolved
* Add test for the isolated modules case
2018-05-22 16:57:11 -07:00
Andy
14fcbc1830
moveToNewFile: Don't provide refactor if selection is just imports ( #24336 ) ( #24339 )
2018-05-22 16:04:58 -07:00
Armando Aguirre
4e88e3c6eb
Merge pull request #24335 from armanio123/FixObjectLiteralExpression
...
Fix object literal expression
2018-05-22 15:33:01 -07:00
Wesley Wigham
3321537c99
Use symbolToTypeNode for class & interface references ( #24330 ) ( #24334 )
...
* Use merged symbols when calculating qualification, use symbolToTypeNode
* Accept baselines
2018-05-22 15:22:36 -07:00
Andy
38a037058a
moveToNewFile: Support selecting the name of a declaration ( #24331 ) ( #24333 )
2018-05-22 14:48:37 -07:00
Mohamed Hegazy
9d57903630
Merge pull request #24312 from Kingwl/multiline-type-literal-formatter
...
fix wrong formatting with multiline type literals with IntersectionTy…
2018-05-22 10:06:24 -07:00
Andy
982c8d0af9
Add suggestion diagnostics for unused label and unreachable code ( #24261 )
...
* Add suggestion diagnostics for unused label and unreachable code
* Always error on unused left hand side of comma
2018-05-22 07:56:29 -07:00
Anders Hejlsberg
f52c4af448
Merge pull request #24310 from Microsoft/nonWideningLiteralInferences
...
Non-widening literal type inferences
2018-05-22 06:56:34 -07:00
王文璐
4b47c0cb82
fix wrong formatting with multiline type literals with IntersectionType and UnionType
2018-05-22 14:01:04 +08:00
Armando Aguirre
0b18bdf590
Added tests
2018-05-21 18:22:13 -07:00
Anders Hejlsberg
9d4096f9c4
Add tests
2018-05-21 16:43:55 -07:00
Andy
802dc2bb9b
fixUnusedIdentifier: If every VariableDeclaration is unused, remove the VariableStatement ( #24231 )
2018-05-21 15:54:33 -07:00
Andy
440291e316
Fix bug: Get merged module symbol in forEachExternalModule ( #24295 )
2018-05-21 10:48:50 -07:00
Andy
c09cc70ebe
Fix bug: VariableDeclaration initializer may be undefined ( #24256 )
2018-05-21 07:58:33 -07:00
Daniel Rosenwasser
3563a0576d
Use single quotes around 'typeof' in message.
2018-05-18 23:44:38 -07:00
Wesley Wigham
02fe840732
Get constraint with this argument of the type parameter for comparisons ( #21210 )
...
* Get constraint with this argument of the type parameter for comparisons
* Also instantiate indexed accesses
* Add much simpler test
2018-05-18 18:30:23 -07:00
Andy
3eb66da155
Add code fix to remove unused label ( #24037 )
...
* Add code fix to remove unused label
* Test with trivia and fix indentation with dedented label
2018-05-18 15:25:24 -07:00
Sheetal Nandi
3bb9ccfa8e
Merge pull request #24234 from Microsoft/unusedIdentifierCorrectFile
...
Unused variable error reporting needs to handle nodes that could not belong to current source file
2018-05-18 13:25:19 -07:00
Mohamed Hegazy
8c2ed976a5
Merge pull request #24187 from Kingwl/disallow-in-function-like-initializer
...
disallow acesssor generate in function like initializer
2018-05-17 19:41:01 -07:00
王文璐
45c06cfd11
only allow refactor if selected span overlaps name declaration
2018-05-18 10:07:45 +08:00
Sheetal Nandi
52e8c2d663
Unused variable error reporting needs to handle nodes that could not belong to current source file
...
Eg. when resolving module, the another file gets checked and its locals are added to potentiallyUnused list
Fixes #24215
2018-05-17 16:27:08 -07:00
Wesley Wigham
66d6e5e6e0
Remove leveldown, stip absolute paths from test mk 2, accept reordered and new user baselines ( #24227 )
2018-05-17 15:32:10 -07:00