Commit Graph
3910 Commits
Author SHA1 Message Date
Andy 2efc92d1dc Adjust formatting rule priority: Never delete space after case (#20615) 2017-12-18 10:54:54 -08:00
Andy 9a62454485 Include static 'this' accesses in references of class (#20483) 2017-12-18 10:54:22 -08:00
Andrew Casey 5e2dec7727 Merge pull request #20729 from amcasey/GH19839
Refine Extract Local
2017-12-15 16:51:25 -08:00
Wesley Wigham dd933f4413 Fix get symbol at location to behave correctly for parameter assignments and jsx attributes (#20706)
* Fix get symbol at location to behave correctly got parameter assignments and jsx attributes

* Handle all those edge cases that weren;t explicitly handled

* Fix part of bug WRT getTypeAtLocation and for loops

* Baseline corrections pursuant to #20710

* Restore jsdoc tag interpretation

* Clean up some code, revert fourslash tests

* Cleanup types used by PR feedback
2017-12-15 15:50:22 -08:00
Andrew Casey adc3234e46 Don't insert a blank line after extracted locals at the start of the file 2017-12-15 15:49:27 -08:00
Andrew Casey 9efab94dfd Annotate fewer extracted constants with types
Expose `isContextSensitive` from the checker and omit type annotations
for expressions for which it returns false.
2017-12-15 15:11:17 -08:00
Andrew Casey e9ac87c2d6 Don't insert a blank line after extracted locals
Still insert a blank line after extracted properties.
2017-12-15 15:11:16 -08:00
Benjamin Lichtman 26c1a49d59 Merge pull request #20640 from uniqueiniquity/revertToJsDocInclusionList
Revert to inclusion list for JsDoc comment completion
2017-12-14 14:37:31 -05:00
Ryan Cavanaugh f6603cd9f2 Merge pull request #20545 from RyanCavanaugh/codefixOmnibus
Omnibus fixes for telemetry-sourced crashes
2017-12-13 12:49:58 -08:00
Andy 8ad4aeece1 Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter (#20574)
* Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter

* Don't require newLineCharacter as input to ChangeTracker methods, and make it private again
2017-12-12 12:23:13 -08:00
Andy 21ff2cd501 Remove unnecessary getFirstChildOfKind helper function (#20647) 2017-12-12 11:25:58 -08:00
uniqueiniquity 97a573984f Add type alias declarations to inclusion list docs 2017-12-11 16:15:32 -08:00
uniqueiniquity 03b036b630 Revert "Loosen restrictions on jsdoc completion locations"
This reverts commit 612616a105.
2017-12-11 15:56:31 -08:00
Wesley Wigham eba15b5990 Preserve literal types in contextual unions (#19966)
* Cherrypick non-comparability related changes from prolific literals PR

* Renames and other style changes

* Accept changes to new tests

* Exclude the domain root from contextual typing literals except for type variables

* Readd simple preservation fix

* Add huge map test

* Revert changes to widening on destructuring initalizers

* Use tristate for subtype-reduction type

* Rename type and argument

* Move longer-running test to user suite
2017-12-11 18:03:38 -05:00
Andy b629ff4204 Fix bug: FunctionDeclaration may have missing name (#20618) 2017-12-11 09:45:20 -08:00
Ryan Cavanaugh 92c3b23a32 Bail at the correct point when containingFunction is undefined 2017-12-07 14:27:46 -08:00
Ryan Cavanaugh fa988eacbd Fixes #20475 (no repro found yet) 2017-12-07 12:39:17 -08:00
Ryan Cavanaugh b7b43fe601 Fixes #20527 2017-12-07 12:39:16 -08:00
Ryan Cavanaugh 2cf7295c4e Fix #20520 2017-12-07 12:38:44 -08:00
Ryan Cavanaugh 6e74f7ee11 Fix #20523 2017-12-07 12:38:08 -08:00
Andy 19ea189b42 Support a "getCombinedCodeFix" service (#20338)
* Support a "getCombinedCodeFix" service

* Rename things

* Code review

* Rename things

* Update API baselines

* CodeActionAll -> CombinedCodeActions

* Take a `scope` parameter instead of `fileName` for flexibility

* Renames and bugfixes

* Make API changes internal

* Code review

* Update comment
2017-12-07 12:14:18 -08:00
Andy 18a7c3fb53 For import fix, prefer symlink over a real path (#20395)
* For import fix, prefer symlink over a real path

* fixes

* Use best result from all symlinks

* Make originalPath optional more

* Only include real path if a symlink isn't available
2017-12-06 11:27:38 -08:00
Andy 06aeab8f31 Minor cleanup for label completions (#20502) 2017-12-06 08:34:54 -08:00
Andy 8dca431733 Use InternalSymbolName.Default more (#20480) 2017-12-06 07:02:27 -08:00
wenlu.wang ae25d09761 add supports of completion label list (#20362) 2017-12-06 07:01:37 -08:00
Andy 8f23bf813c Add textChanges methods to insert nodes at the start of multiline bodies (#20445)
* Add textChanges methods to insert nodes at the start of multiline bodies

* Replace constructor body if not already multiline
2017-12-05 08:33:29 -08:00
Andy 8153397e91 Lazily compute signature type predicates (#17600)
* Lazily compute signature type predicates

* Use an instance of IdentifierTypePredicate to represent an unresolved type predicate

* Simplify `getMaybeTypePredicate`

* Invert representation of `resolvedTypePredicate`

* Remove `__unresolvedTypePredicate` type and remember to use `noTypePredicate` instead of `undefined` when in all `createSignature` calls

* Fix style of getTypePredicateOfSignature

* Use in createGetSymbolWalker

* Fix bugs for unions of type predicates

* Code review

* Make noTypePredicate purely an implementation detail of getTypePredictateOfSignature

* Add test

* Add test for #19642

* Add test with reversed order
2017-12-05 08:32:34 -08:00
Andy fd4d8ab96e Support a 'recommended' completion entry (#20020)
* Support a 'recommended' completion entry

* Code review

* Restore duplicate comments
2017-12-01 13:00:01 -08:00
Andrew Casey 8f1cdc9b0c Merge pull request #20373 from amcasey/PropertyUnderscore
Don't offer to prepend an underscore to the name of an unused private property
2017-11-30 13:08:26 -08:00
Nathan Shively-Sanders 2ec2238c1b Merge pull request #20198 from Microsoft/jsdoc-values-as-namespaces
Jsdoc values as namespaces
2017-11-30 12:56:11 -08:00
Andy 75e5b13775 Don't suggest import completions for /a/node_modules if we're in /b (#19928)
* Don't suggest import completions for /a/node_modules if we're in /b

* Remove test for delving into dependencies of dependencies
2017-11-30 11:25:01 -08:00
Nathan Shively-Sanders 69bbfedd63 Merge branch 'master' into jsdoc-values-as-namespaces 2017-11-30 10:34:50 -08:00
Andy 43a35bad2e Miscellaneous fixes to avoid duplicate completions (#20349)
* Miscellaneous fixes to avoid duplicate completions

* Move typeHasCallOrConstructSignatures to utility
2017-11-30 09:36:17 -08:00
Andy 56a046ddf4 installTypesForPackage refactor: Trigger even if resolved to a ".js" file (#20353)
* installTypesForPackage refactor: Trigger even if resolved to a ".js" file

* Use `extensionIsTypeScript`
2017-11-30 08:41:15 -08:00
Andrew Casey 011b567918 Don't offer to prepend an underscore to the name of an unused private property 2017-11-29 18:05:36 -08:00
Andy 93dca009f9 In navigation tree, don't merge static with non-static (#20347) 2017-11-29 15:25:06 -08:00
Nathan Shively-Sanders 61fe04ba0d Merge branch 'master' into jsdoc-values-as-namespaces 2017-11-28 15:01:40 -08:00
Wesley Wigham 5ee640d2b6 Move utilities for getting type parameter constraints and defaults from public lazy members to services (#20162) 2017-11-28 13:37:42 -08:00
Andy cb5fd53731 Handle shebang in import code fix (#20306) 2017-11-28 15:41:59 -05:00
Andy bbb56fed11 Support parameter properties in getRelatedSymbol (#20202) 2017-11-28 14:12:28 -05:00
Andy 185f15d2af Support both baseUrl and relative paths when adding missing import (#19724)
* Support both baseUrl and relative paths when adding missing import

* Code review

* Always use getRelativePathNParents, not getRelativePathLength
2017-11-28 14:01:51 -05:00
Cameron Taggart b36379c597 replaced @parm typo with @param (#20277) 2017-11-27 10:10:55 -08:00
Mohamed Hegazy 6b3cfc7008 Fix #19959 and #19958: Remove un-localizable messages (#20019)
* Fix #19959 and #19958: Remove un-localizable messages

* Update message

* Update diagnostic messages
2017-11-24 22:02:48 -08:00
Andrew Casey 643e9fc1e4 Offer global completions in all blocks 2017-11-22 14:25:31 -08:00
Nathan Shively-Sanders bee7d06761 Binder-based prop-assignment decls: messy version 2017-11-22 13:52:45 -08:00
Andy 7c5a0ec9c6 Clean up outliningElementsCollector (#20143)
* Clean up outliningElementsCollector

* Use depthRemaining instead of maxDepth
2017-11-21 14:27:26 -05:00
Andy 53796eed59 Clean up lexical classifier (#20123) 2017-11-20 16:25:51 -08:00
Andy 97bb471e48 For import completion, if multiple re-exports exist, choose the one with the shortest path (#20049)
* For import completion, if multiple re-exports exist, choose the one with the shortest path

* Code review
2017-11-17 14:35:32 -08:00
Andy e7adb1ce79 Bundle fileName with CodeActionCommand (#19881)
* Bundle fileName with CodeActionCommand

* Update test

* Fix API tests

* Add new overloads in services

* Fix overload

* Update API baselines
2017-11-17 14:16:38 -08:00
Andy 0c0f4b81ae Simplify documentHighlights (#20091) 2017-11-17 10:19:35 -08:00