Commit Graph
15262 Commits
Author SHA1 Message Date
Ron Buckton 279b348440 Accept baselines 2017-12-18 12:32:13 -08:00
Ron Buckton 7944f5082b Merge branch 'master' into vfs 2017-12-18 12:12:51 -08:00
Andy 2efc92d1dc Adjust formatting rule priority: Never delete space after case (#20615) 2017-12-18 10:54:54 -08:00
Andy 9a62454485 Include static 'this' accesses in references of class (#20483) 2017-12-18 10:54:22 -08:00
csigs 31b2c11c15 LEGO: check in for master to temporary branch. 2017-12-16 05:10:04 +00:00
Andrew Casey 5e2dec7727 Merge pull request #20729 from amcasey/GH19839
Refine Extract Local
2017-12-15 16:51:25 -08:00
Andrew Casey 804949f744 Additional test case for contextual type check 2017-12-15 16:37:09 -08:00
Wesley Wigham ae73a9141d Allow JSXAttributes types to be shortcut-spread into the spread type like normal objects (#19047)
* Bring jsx type resolution inline with normal objects, move jsx attribute property ignorign into relationship check

* Improved errors and reordered members

* Always use inferrential mode for jsx pass

* Add some missing skipLibChecks

* New check mode instead of odd type mapper

* Do not enable object literal freshness checks on jsx spreads

* Fix minor style nits

* Update order of type for test

* Accept corrected baseline
2017-12-15 16:13:28 -08:00
Wesley Wigham dd933f4413 Fix get symbol at location to behave correctly for parameter assignments and jsx attributes (#20706)
* Fix get symbol at location to behave correctly got parameter assignments and jsx attributes

* Handle all those edge cases that weren;t explicitly handled

* Fix part of bug WRT getTypeAtLocation and for loops

* Baseline corrections pursuant to #20710

* Restore jsdoc tag interpretation

* Clean up some code, revert fourslash tests

* Cleanup types used by PR feedback
2017-12-15 15:50:22 -08:00
Andrew Casey adc3234e46 Don't insert a blank line after extracted locals at the start of the file 2017-12-15 15:49:27 -08:00
Andrew Casey 129d1924be Regression test for GH #20727 2017-12-15 15:11:18 -08:00
Andrew Casey 9efab94dfd Annotate fewer extracted constants with types
Expose `isContextSensitive` from the checker and omit type annotations
for expressions for which it returns false.
2017-12-15 15:11:17 -08:00
Andrew Casey e9ac87c2d6 Don't insert a blank line after extracted locals
Still insert a blank line after extracted properties.
2017-12-15 15:11:16 -08:00
Andrew Casey a3ab1ffcff Merge pull request #20713 from amcasey/GH19165
Stop assuming code fix test changes are in the originating file
2017-12-15 14:21:57 -08:00
Ron Buckton 6727499f47 Re-enable all tests 2017-12-15 13:44:37 -05:00
Wesley Wigham d89d68f426 make jsx attributes mutable locations (#20710) 2017-12-15 10:02:56 -08:00
csigs ed4bd2e5ab LEGO: check in for master to temporary branch. 2017-12-15 11:10:31 +00:00
Andrew Casey 8b0988543b Stop assuming code fix test changes are in the originating file
Triggering a fix in one file can result in changes in another file.
Instead of passing around the originating file, retrieve an appropriate
`ScriptInfo` for each `FileTextChanges`.

Fixes #19165
2017-12-14 16:50:28 -08:00
csigs be1d6da123 LEGO: check in for master to temporary branch. 2017-12-14 23:10:37 +00:00
Benjamin Lichtman 26c1a49d59 Merge pull request #20640 from uniqueiniquity/revertToJsDocInclusionList
Revert to inclusion list for JsDoc comment completion
2017-12-14 14:37:31 -05:00
csigs f6a383e3e4 LEGO: check in for master to temporary branch. 2017-12-14 17:10:08 +00:00
csigs 309468396d LEGO: check in for master to temporary branch. 2017-12-14 11:10:40 +00:00
csigs 064d9345e1 LEGO: check in for master to temporary branch. 2017-12-14 05:10:09 +00:00
csigs 5299e91be3 LEGO: check in for master to temporary branch. 2017-12-13 23:10:50 +00:00
Wesley Wigham e1278f091c Get resolved module exports in symbol chain and not raw exports (#20661)
* Actually get module exports and not module exports sans export stars

* style update

* Trim test a bit
2017-12-13 14:01:23 -08:00
Wesley Wigham 2c6501db52 Allow multiple star-star globs in one pattern (#20639)
* Allow multiple starglobs in one pattern

* Add extra test case
2017-12-13 12:57:16 -08:00
Ryan Cavanaugh f6603cd9f2 Merge pull request #20545 from RyanCavanaugh/codefixOmnibus
Omnibus fixes for telemetry-sourced crashes
2017-12-13 12:49:58 -08:00
Ryan Cavanaugh 8f8e6a36a7 Merge pull request #20679 from RyanCavanaugh/removeLibTodo
Remove TODO from lib.d.ts
2017-12-13 12:49:40 -08:00
Andy 84eb25c561 Handle arrays with properties in assert.deepEqual (#20674)
* Handle arrays with properties in assert.deepEqual

* Fix tests
2017-12-13 11:50:53 -08:00
Ryan Cavanaugh 100262537a Remove TODO 2017-12-13 10:58:04 -08:00
Ryan Cavanaugh 65e92c624b Merge pull request #20664 from RyanCavanaugh/clearResolutionCache
Clear the module resolution cache when new @types appear
2017-12-13 09:40:16 -08:00
Wesley Wigham 79a1240a19 Revert merge pull request #20429 (removing chai) (#20654)
* Revert "Merge pull request #20429 from Microsoft/unchai"

This reverts commit 66ec938164, reversing
changes made to 37a40561ac.

* Update lockfile
2017-12-13 06:49:50 -08:00
csigs 7125cad406 LEGO: check in for master to temporary branch. 2017-12-13 11:10:32 +00:00
csigs dbceefd05a LEGO: check in for master to temporary branch. 2017-12-13 05:10:08 +00:00
Ryan Cavanaugh 9e122d0305 Fix test 2017-12-12 17:22:41 -08:00
Wesley Wigham 40029a0523 Use TypeFlags.UnionOrIntersection not TypeFlags.Union (#20662) 2017-12-12 16:32:55 -08:00
Ryan Cavanaugh bd3a27ed52 Clear the module resolution cache when new @types appear 2017-12-12 16:11:37 -08:00
csigs ef23eb71be LEGO: check in for master to temporary branch. 2017-12-12 23:11:33 +00:00
Andy 8ad4aeece1 Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter (#20574)
* Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter

* Don't require newLineCharacter as input to ChangeTracker methods, and make it private again
2017-12-12 12:23:13 -08:00
Andy 21ff2cd501 Remove unnecessary getFirstChildOfKind helper function (#20647) 2017-12-12 11:25:58 -08:00
Nathan Shively-Sanders e58d80ad83 Merge pull request #20648 from Microsoft/nonprimitive-spreads-to-empty-object
Non-primitive spreads to empty object
2017-12-12 10:56:21 -08:00
csigs ea1e4102f5 LEGO: check in for master to temporary branch. 2017-12-12 17:10:08 +00:00
Nathan Shively-Sanders 43a5a271ee object spreads to {}
Specifically, when spreading `object` on the right, spread now returns the
left of the spread; previously it returned `object`, which loses
everything to the left.
2017-12-12 08:34:36 -08:00
Andy d53af092c7 Always check a return expression in a generator (#20621) 2017-12-12 07:50:11 -08:00
uniqueiniquity 97a573984f Add type alias declarations to inclusion list docs 2017-12-11 16:15:32 -08:00
uniqueiniquity 03b036b630 Revert "Loosen restrictions on jsdoc completion locations"
This reverts commit 612616a105.
2017-12-11 15:56:31 -08:00
csigs 72f2136080 LEGO: check in for master to temporary branch. 2017-12-11 23:11:30 +00:00
Yuichi Nukiyama 792b8bb78e Fix error messeage (#20601)
* Fix error messeage

* delete extra lint
2017-12-11 18:05:49 -05:00
Wesley Wigham eba15b5990 Preserve literal types in contextual unions (#19966)
* Cherrypick non-comparability related changes from prolific literals PR

* Renames and other style changes

* Accept changes to new tests

* Exclude the domain root from contextual typing literals except for type variables

* Readd simple preservation fix

* Add huge map test

* Revert changes to widening on destructuring initalizers

* Use tristate for subtype-reduction type

* Rename type and argument

* Move longer-running test to user suite
2017-12-11 18:03:38 -05:00
Wesley Wigham d01f4d140a Reimplement #20320 differently to handle multiple check orders better (#20588)
* Reimplement #20320 less elegantly but handle odd check orders better

* Consolidate 2 of 3 conditions
2017-12-11 13:32:16 -05:00