Commit Graph

17249 Commits

Author SHA1 Message Date
Nathan Shively-Sanders 22cdff59e4 Better fix for bogus duplicate identifier in module exports (#24491) 2018-05-30 09:59:14 -07:00
Ron Buckton fc3e88e26f Merge pull request #24481 from Microsoft/fix24173
Fix async generator return as well
2018-05-30 09:43:00 -07:00
Mohamed Hegazy 04dc76ec9c Merge pull request #24442 from Kingwl/fix-implement-interface-with-extends-class
add lookup for extends class when implement interface
2018-05-30 09:20:50 -07:00
Andy 5e2c7ffce6 isValidMethodAccess: use getTypeOfPropertyOfType instead of getTypeOfFuncClassEnumModule (#24488) 2018-05-30 09:12:24 -07:00
Andy 011a4df4dd Don't allow to rename string literal (#24477) 2018-05-30 07:50:48 -07:00
王文璐 e05d2bace3 fix broken test 2018-05-30 17:36:09 +08:00
王文璐 2cb211305b Merge branch 'master' into fix-implement-interface-with-extends-class 2018-05-30 09:05:56 +08:00
Ron Buckton 6f7715444f Fix async generator return as well 2018-05-29 17:54:59 -07:00
Ron Buckton 364fce393d Merge pull request #24474 from Microsoft/fix21115.2
Do not await iterated value in for-await-of
2018-05-29 17:54:10 -07:00
Ron Buckton 394862e829 Test for asyncIterator existance before defining 2018-05-29 17:12:50 -07:00
Andy f411164483 Simplify calculation of sourceFiles for getReferences (#24475) 2018-05-29 16:12:25 -07:00
Andy e99be8c47d Avoid duplicate import completions when a namespace is exported by two different modules (#24473) 2018-05-29 15:52:34 -07:00
Ron Buckton c224a824f3 Do not await iterated value in for-await-of 2018-05-29 15:33:43 -07:00
csigs 98a4dc7604 LEGO: check in for master to temporary branch. 2018-05-29 22:11:04 +00:00
Nathan Shively-Sanders 36c580378f Fix duplicate identifier error with module.exports (#24466)
A bug in checkSpecialAssignment added bogus duplicate identifier errors
when using module.exports assignment to export a class. This commit
fixes that.
2018-05-29 14:29:48 -07:00
Nathan Shively-Sanders 15bfaf1cf6 Skip IntrinsicAttributes elaboration in JSX errors (#24461)
* Skip IntrinsicAttributes elaboration in JSX errors

Do not issue an error message for a source type that comes from JSX
attributes and a target type that is an intersection containing
IntrinsicAttributes or IntrinsicClassAttributes. This will make error
messages simpler and less confusing.

Note:
1. There will always be elaboration under the skipped message, so this
won't elide errors completely.
2. Rarely (once in the tests) the intersection type will have more that
one non-Intrinsic* member. However, these additional members don't
provide useful information either, so it's fine to skip them.

* Add test of IntrinsicAttributes error

* Fix indentation in test
2018-05-29 14:00:26 -07:00
Ron Buckton c1a5d9bb06 Merge pull request #24463 from Microsoft/fix24288
Fix return and throw propagation for yield*
2018-05-29 13:34:31 -07:00
Ron Buckton 6657df47f0 Fix return and throw propagation for yield* 2018-05-29 12:56:46 -07:00
Andy 8bc1932ed5 moduleSpecifiers: Don't return a relative path to node_modules (#24460) 2018-05-29 12:40:06 -07:00
Andy 160b667846 fixUnusedIdentifier: Don't remove parameter in override or non-last parameter in callback (#24306)
* fixUnusedIdentifier: Don't remove parameter in override or non-last parameter in callback

* Only allow removing last parameters; don't care about contextual type
2018-05-29 12:39:45 -07:00
Andy 816f1cee5a Include '...' on doc comment for rest parameter (#24462) 2018-05-29 12:17:57 -07:00
Mohamed Hegazy 58f4c6fcbf Merge pull request #24457 from Microsoft/fixBuild
Fix build
2018-05-29 09:41:16 -07:00
csigs a839cbd710 LEGO: check in for master to temporary branch. 2018-05-29 16:10:37 +00:00
Mohamed Hegazy 94c455792a Remove unneeded assertions 2018-05-29 09:06:35 -07:00
csigs d5163357d3 LEGO: check in for master to temporary branch. 2018-05-29 10:10:39 +00:00
csigs 91aa60ac00 LEGO: check in for master to temporary branch. 2018-05-28 22:10:39 +00:00
王文璐 f9a55beec5 add lookup for extends class when implement interface 2018-05-28 18:38:07 +08:00
Mohamed Hegazy a7a68d9591 Merge branch 'fix-es5-export-class-name-object' of https://github.com/Kingwl/TypeScript into Kingwl-fix-es5-export-class-name-object 2018-05-25 15:45:31 -07:00
Mohamed Hegazy 725dbcc7a5 Merge branch 'master' of https://github.com/Microsoft/TypeScript 2018-05-25 15:45:12 -07:00
csigs 35c0aaa84d LEGO: check in for master to temporary branch. 2018-05-25 22:10:40 +00:00
Mohamed Hegazy 832893e559 Revert "Check detected npm path is existing"
This reverts commit 1fda3a4165.
2018-05-25 14:54:53 -07:00
csigs 5e848f6efb LEGO: check in for master to temporary branch. 2018-05-25 16:10:26 +00:00
csigs 4244c8e2b4 LEGO: check in for master to temporary branch. 2018-05-25 10:10:26 +00:00
王文璐 7f127de89e remove invalid check 2018-05-25 09:36:16 +08:00
Wesley Wigham 64642bb5c3 Dump fork output on unclean exit (#24394)
* Dump fork output on unclean exit

* Remember to clear timeout on process exit in case processes exit at very different times
2018-05-24 16:13:32 -07:00
Wesley Wigham 8f9c0861bc Use external aliases in quickinfo and signature help return types (#24391)
* Dont include import types in quick info type names

* Add UseAliasDefinedOutsideCurrentScope flag to LS operations which were missing it
2018-05-24 15:19:57 -07:00
Nathan Shively-Sanders e250942d6a Disallow nested object param syntax in callback tag (#24392)
* Callback tag:Disallow nested-object-param syntax

Previously this caused a crash in parsing. If/when we want to support
this syntax, we will need to fix this crash.

* Update baselines
2018-05-24 15:11:33 -07:00
csigs 3502d35057 LEGO: check in for master to temporary branch. 2018-05-24 22:10:36 +00:00
Elizabeth Dinella b745ea059e Fix to issue 23326 for completions on new.target (#24342)
* Fix to issue 23326 for completions on new.target

* Fixed linting issues - whitespace in if statements

* Removed debug statement in test case and consolidated and cleaned up code in switch statement for completions

* Added support for import.meta completion
2018-05-24 14:12:33 -07:00
Elizabeth Dinella 13734e7d68 Fix for issue #6154 - overriding methods with properties in the derived class (#24343)
* Fix to issue 6154 - Overriding a method with a property in the derived class should not cause a compiler error

* new baselines

* fixed deleted baselines
2018-05-24 14:12:13 -07:00
Sheetal Nandi 51058b56e5 Do not trigger invalidation if emitted file is in declarationDir 2018-05-24 13:36:52 -07:00
Wesley Wigham 4be4e56579 Hoisted declarations should occur after prologue directives (#24386) 2018-05-24 12:49:02 -07:00
Wesley Wigham a0b57808d0 Dont count duplicated errors in case-insensitive duped files in rwc (#24383) 2018-05-24 12:23:43 -07:00
Andy 16af96b006 moveToNewFile: Format the new file (#24379) 2018-05-24 11:08:32 -07:00
Andy bc570cd85f moveToNewFile: Respect UserPreferences#quote (#24365) 2018-05-24 09:36:37 -07:00
csigs 749f7bccf8 LEGO: check in for master to temporary branch. 2018-05-24 16:10:29 +00:00
Andy ee8337d8e4 Minor cleanups in importFixes (#23995) 2018-05-24 07:46:39 -07:00
王文璐 d5239cdf6a fix ambient context 2018-05-24 18:20:54 +08:00
kingwl cb2be44d02 fix export class declare with name object targeting es5 (#17494) 2018-05-24 18:16:38 +08:00
csigs 58bf08c7fc LEGO: check in for master to temporary branch. 2018-05-24 10:10:39 +00:00