Cyrus Najmabadi
dfb1ac0f00
Use constant in another place.
2014-12-16 17:14:45 -08:00
Cyrus Najmabadi
fab4955ef7
Add explanatory comments.
2014-12-16 17:10:21 -08:00
Mohamed Hegazy
cd7fc0c3fe
Merge pull request #1495 from Microsoft/crashWhileReportingError
...
Do not use the file name in errors unless it exists
2014-12-16 16:56:01 -08:00
Cyrus Najmabadi
535f9d8972
Rename method to be clearer, and add comments to explain the semantics.
2014-12-16 16:36:49 -08:00
Cyrus Najmabadi
7fc343eb43
Fix broken enum value alignment.
2014-12-16 16:27:26 -08:00
Cyrus Najmabadi
f3ce5d763c
CR feedback.
2014-12-16 16:27:14 -08:00
Cyrus Najmabadi
b73128c50f
CR feedback.
2014-12-16 16:17:48 -08:00
Cyrus Najmabadi
97a6abcc07
CR feedback.
2014-12-16 16:12:14 -08:00
Cyrus Najmabadi
f1a2e41a8a
Sort diagnostics in our baseline output.
...
This was we don't get noisy baselines just because a different phase of the compiler reported
the diagnostic.
This helps with Yui's refactoring work to move grammar checks into the type checker.
2014-12-16 15:56:56 -08:00
Anders Hejlsberg
fed3b5c0de
Adding comment
2014-12-16 15:47:22 -08:00
Cyrus Najmabadi
71c82dd33f
Remove obsolete comment.
2014-12-16 15:32:56 -08:00
Cyrus Najmabadi
94d576290e
Don't expose EmitHost. it is only used by a non-exposed function.
2014-12-16 15:10:15 -08:00
Jason Freeman
ab33a65d30
Fix issue #1503 with modules and imports sharing a name
2014-12-16 14:59:21 -08:00
Cyrus Najmabadi
5a2fb94a95
Clean things up so the services layer can easily emit without having to contort compiler hosts.
2014-12-16 14:42:58 -08:00
Cyrus Najmabadi
f5ad79fe7a
Remove the dependency that TypeChecker and Emitter have on Program.
...
Instead, these layers explicitly specify the functionality they need, and don't take in anything extra.
2014-12-16 14:12:17 -08:00
Cyrus Najmabadi
b665323d45
Make the emitter no longer depend on the Program.
...
This breaks layering. Also, it means the emitter depends on too large a surface area.
Now the emitter declares exactly what it needs, and only gets that.
2014-12-16 13:52:47 -08:00
Yui T
a3e8b6c6d7
Move grammar checking: interfaceDeclaration-remove it from checkModifiers in parser; there are still errors from incomplete grammar migration
2014-12-16 13:47:57 -08:00
Yui T
406576f1fc
Move grammar checking: propertyDeclaration, propertySignature; there are still errors from incomplete grammar migration
2014-12-16 13:36:00 -08:00
Yui T
c525877aaa
Move grammar checking: moduleDeclaration; there are still errors from incomplete grammar migration
2014-12-16 13:35:31 -08:00
Cyrus Najmabadi
96c3c90d9a
Rename typechecker parameter related to whether or not we produce diagnostics.
...
Comment what the flag means.
2014-12-16 13:30:34 -08:00
Cyrus Najmabadi
4aa361d4bf
Layer the compiler so that every layer only depends on hte layers below it.
...
The layering is now:
types
core
scanner
parser
binder
checker
emitter
program
2014-12-16 13:14:14 -08:00
Yui T
003515655e
Move grammar checking: methodDeclaration; there are still erros from incomplete grammar migration
2014-12-16 12:51:42 -08:00
Yui T
7a4d8cd8ee
Move grammar checking: setAccessor, getAccessor; there are still erros from incomplete grammar migration
2014-12-16 12:25:05 -08:00
Cyrus Najmabadi
c9ee88e5c4
Adding incremental test.
2014-12-16 11:58:47 -08:00
Jason Freeman
ba963c3220
Merge branch 'release-1.4' into parsePrimaryExpression
2014-12-16 11:25:57 -08:00
Jason Freeman
eaf1c5aa5f
Change the order of switch statements instead of converting to if-else
2014-12-16 11:25:22 -08:00
Cyrus Najmabadi
0a8744e841
Add helper method to reduce so many double negatives in the code.
2014-12-16 03:19:13 -08:00
Cyrus Najmabadi
8917e96663
Merge branch 'funcDeclsInBlocks' into sourceFileUpdate
...
Conflicts:
src/compiler/parser.ts
src/compiler/utilities.ts
2014-12-16 03:12:31 -08:00
Cyrus Najmabadi
935ba82efd
Don't check container invariants. They don't hold true in incremental scenarios.
2014-12-16 03:08:29 -08:00
Cyrus Najmabadi
6326b9d51f
Merge branch 'master' into sourceFileUpdate
2014-12-16 02:59:05 -08:00
Cyrus Najmabadi
592ad476a8
Reduce unnecessary arrow function allocations.
2014-12-16 02:53:58 -08:00
Cyrus Najmabadi
c7bb0a5ae6
Don't store variable statement flags on its variable declaration children.
2014-12-16 02:50:38 -08:00
Vladimir Matveev
59c73c5f34
Merge pull request #1466 from Microsoft/linked_imports
...
defer decision whether import used on the right side of import declarati...
2014-12-16 00:46:26 -08:00
Vladimir Matveev
5b38cb9a69
harden 'get import declaration' logic
2014-12-16 00:34:51 -08:00
Yui T
694771b2d7
Move grammar checking: functionDeclaration; there are still errors from incomplet grammar migration
2014-12-15 23:05:29 -08:00
Cyrus Najmabadi
e8a1056a38
Merge branch 'bindingElementContxt' into funcDeclsInBlocks
2014-12-15 21:48:35 -08:00
Cyrus Najmabadi
30f9a5ca2a
Do not pass context flags downward while parsing binding elements.
...
This prevents an unnecessary allocation, simplifies parsing code, and prevents
an issue where parsing depends on context flags not stored in the final tree.
This is an issue for incremental parsing that can lead to nodes being reused
inappropriately.
2014-12-15 21:41:02 -08:00
Cyrus Najmabadi
41e59824fb
Merge branch 'master' into funcDeclsInBlocks
2014-12-15 20:50:48 -08:00
Cyrus Najmabadi
fa4fab8a15
Change check cadence.
2014-12-15 19:37:15 -08:00
Yui T
25a6302b48
Move grammar checking: forStatement
2014-12-15 18:39:44 -08:00
Yui T
010745c371
Move grammar checking: forInStatement; there are still errors from incomplete migration
2014-12-15 18:28:24 -08:00
Yui T
e0e88adfc5
Move grammar checking: variableDeclaration, variableStatements; there are still erros from incomplete grammar migration
2014-12-15 18:10:35 -08:00
Mohamed Hegazy
8a87d51956
Do not use the file name in errors unless it exists
2014-12-15 17:32:11 -08:00
Yui T
20b7bb249e
Address code review
2014-12-15 17:23:33 -08:00
Daniel Rosenwasser
e3848b98b1
Fixed bug where function expressions were not getting checked in template expressions.
2014-12-15 16:45:17 -08:00
Yui T
90333fe49b
Address code review
2014-12-15 16:43:35 -08:00
Yui T
f22adf6785
Move grammar checking: constructorDeclaration; there are still errors from incomplete grammar migration
2014-12-15 16:42:31 -08:00
Yui T
bcf73a8207
Move grammar checking: enumDeclaration; there are still erros from incomplete grammar migration
2014-12-15 15:26:08 -08:00
Anders Hejlsberg
667e82fba2
Addressing CR feedback + Run fourslash tests with ES5 emit
2014-12-15 15:16:54 -08:00
Yui T
28a115ef37
Move grammar checking: breakStatement, continueStatement; there are still errors from incomplete grammar migration
2014-12-15 15:05:31 -08:00
Cyrus Najmabadi
Mohamed Hegazy
Anders Hejlsberg
Jason Freeman
Yui T
Vladimir Matveev
Daniel Rosenwasser