Commit Graph

12444 Commits

Author SHA1 Message Date
Mohamed Hegazy 97965574ed Merge pull request #14373 from DLehenbauer/fixSpreadUsage
Fix TypeError when JSDoc.tags is undefined
2017-02-28 16:37:04 -08:00
Anders Hejlsberg 21c43009a6 Enable new behavior only in --noImplicitThis mode 2017-02-28 16:09:24 -08:00
Kanchalai Tanglertsampan e74df1e38b Remove unnecessary comment 2017-02-28 15:51:41 -08:00
Kanchalai Tanglertsampan d6085f75c4 Return completions for JsDoc tagname even when there are no "@' sign prefix 2017-02-28 15:41:35 -08:00
Kanchalai Tanglertsampan 4aac67b4e6 Remove assertion 2017-02-28 09:59:17 -08:00
Anders Hejlsberg ee7b93c1a0 Merge branch 'master' into contextualThisType 2017-02-28 09:52:03 -08:00
Anders Hejlsberg 993397b5ab Introduce CheckMode enum and getContextualMapper() function 2017-02-28 08:54:38 -08:00
Andy fc9bcc1d8f Merge pull request #14343 from Microsoft/undefined_declarations
Add check for undefined declarations
2017-02-28 08:44:41 -08:00
Andy Hanson 7afee8c3ab Fix formatting 2017-02-28 07:55:25 -08:00
DLehenbauer 2a3800965b Fix TypeError when JSDoc.tags is undefined (see #14362) 2017-02-28 07:31:01 -08:00
Ron Buckton 4f1d7a56b9 Merge pull request #14338 from Microsoft/fix14334
Fix emit for downlevel generated catch variable
2017-02-27 16:04:34 -08:00
Mohamed Hegazy b977b8cc45 Respond to code review comments 2017-02-27 15:58:01 -08:00
Andy Hanson cc4a3a830f Add check for undefined declarations 2017-02-27 14:18:46 -08:00
Ron Buckton 8c2bcaedee Fix emit for downlevel generated catch variable 2017-02-27 11:46:56 -08:00
Mohamed Hegazy 36eb1ced1d Merge pull request #14324 from mihailik/master
Special-case (0,eval) for side-effect-free 0 left of comma
2017-02-27 11:32:11 -08:00
Kanchalai Tanglertsampan 5d46d434e0 Error when used enum before declaration 2017-02-27 11:21:12 -08:00
Anders Hejlsberg cd87d903a0 Update comment 2017-02-27 10:19:14 -08:00
andy-ms c2f4b202a4 Add more specific return type for getTypeParameters() 2017-02-26 17:48:27 -08:00
Oleg Mihailik 6a88cf0edf Better check for right.text, more comments in test 2017-02-26 23:13:50 +00:00
Oleg Mihailik 27675fc96e Avoid failing TS2695 for eval. 2017-02-25 23:35:24 +00:00
Anders Hejlsberg 20b4523d0f Rename applyToContextualType to mapType and remove old mapType 2017-02-24 19:52:22 -08:00
Anders Hejlsberg 9dc2bae2e6 Use contextual type of object literal as 'this' in methods 2017-02-24 18:00:27 -08:00
Jason Ramsay 21ef9078ad Wrapping LSHost's cancellationtoken with a throttle 2017-02-24 17:14:04 -08:00
Kanchalai Tanglertsampan ed7a3d00b9 Issue an error when class is used before class declaration 2017-02-24 16:46:21 -08:00
Nathan Shively-Sanders 5b23dbc999 Merge pull request #14302 from Microsoft/make-special-property-assignment-apply-only-to-lhs
Provide special property assignment symbol only for left-hand side of assignment
2017-02-24 15:14:30 -08:00
Mohamed Hegazy 1a579d1d4d Merge pull request #14284 from Microsoft/jsDocUpperCasePrimitiveTypes
Allow primitive types in JSDoc to start wtih uppercase letters
2017-02-24 14:31:30 -08:00
Nathan Shively-Sanders 82b5655e66 Special prop assignment symbol applies only to lhs
In a Javascript file, the binder assigns a SpecialPropertyAssignment
marker to the BinaryExpression node of several kinds of special
assignments. Then it binds a special symbol whose declaration is that
BinaryExpression node. But the symbol only applies to the left-hand side
of the assignment. The right-hand side is an independent expression that
should have its own symbols.

Previously, symbol lookup in the checker didn't check whether a
Javascript node that was part of a special property assignment came from
the lhs or the rhs. So the right-hand side would also incorrectly get
the special symbol intended for the left-hand side.

`getSpecialPropertyAssignmentSymbolFromEntityName` in the checker now
checks that its argument is the left-hand side of an assignment before
returning a special property assignment symbol.
2017-02-24 14:22:55 -08:00
Kanchalai Tanglertsampan 097bc77d0b Emit unique prologue directives at the top of bundle output file 2017-02-24 11:37:34 -08:00
Zhengbo Li 2d4b4c9c80 Merge pull request #14014 from zhengbli/12233
Fix jsdoc typedef symbol scope + avoid bind twice if the type has a namespace prefix
2017-02-23 21:26:32 -08:00
Mohamed Hegazy fd8040978b Allow primitive types in JSDoc to start wtih uppercase letters 2017-02-23 21:25:30 -08:00
Mohamed Hegazy 91571f05d3 Add support for handeling .js file correctelly in fixAddMissingMember code fix 2017-02-23 15:58:49 -08:00
Kanchalai Tanglertsampan d219f8afc5 Fix comment 2017-02-23 15:31:19 -08:00
Kanchalai Tanglertsampan 231c3cb8ab Emit first encounter shebang at the top of a output file 2017-02-23 15:27:22 -08:00
Kanchalai Tanglertsampan eca4af5029 When making unit test only include non empty line. This is crucial because it will allow us to test shebang which has to be the first line 2017-02-23 15:26:30 -08:00
Mohamed Hegazy 02ccd91159 Infer class properties from methods and not just constructors 2017-02-23 15:20:08 -08:00
Anders Hejlsberg 9b6b6cc289 Fix linting error 2017-02-22 19:32:34 -08:00
Anders Hejlsberg 168d367b5e Contextually type 'this' in accessors of object literals 2017-02-22 19:16:55 -08:00
Jason Ramsay e62108cf9b Removing throttling until tests prove it is required 2017-02-22 17:47:18 -08:00
Arthur Ozga 65da012527 Merge pull request #14158 from aozgaa/QuickFixPeriods
Add periods to diagnostic messages
2017-02-22 16:15:34 -08:00
Arthur Ozga 1c25034a18 instantiate generic this param correctly 2017-02-22 16:15:16 -08:00
Kanchalai Tanglertsampan 84b9ebd0d7 Return empty string instead to prevent exception downstream particularly in writeReferencePath 2017-02-22 15:42:22 -08:00
Jason Ramsay 497d8d3a58 Updates from CR comments 2017-02-22 15:33:57 -08:00
Vladimir Matveev eb34f0ca03 a few fixed in printer/factory (#14239) 2017-02-22 15:24:29 -08:00
Jason Ramsay a37053f780 Addressing CR comments
- Adding a throttle
- Refactor
- Navbar reset onCancel
2017-02-22 14:23:06 -08:00
Nathan Shively-Sanders dbaf1f6756 isConstructorType checks base constraint for undefined
Previously, it assumed there was always a base constraint, which is true
for correct code. For incorrect code, the base constraint may be
missing, which caused a crash because the base constraint was undefined.
2017-02-22 14:16:20 -08:00
Arthur Ozga 1217ca7986 Merge branch 'master' into ImplementMissingThis 2017-02-22 12:50:13 -08:00
Yui 31c4ad193f Merge pull request #14216 from Microsoft/master-fix13526
[Master] Fix13526 allow JSX attributes to be union type
2017-02-22 11:01:08 -08:00
Kanchalai Tanglertsampan f55167e565 Collect type from return statment in generator function 2017-02-22 10:23:47 -08:00
Mohamed Hegazy 7e2abfca28 Add a string indexer to any for object literals on a .js file 2017-02-21 18:44:57 -08:00
Herrington Darkholme 51966076d4 fix #14187, forIn should allow non primitive object as right hand side 2017-02-22 10:06:34 +08:00