Commit Graph

32734 Commits

Author SHA1 Message Date
Andy 9ee51fadd9 Have Symbol#isReferenced check the SymbolFlags of the reference (#21996) 2018-02-16 16:47:13 -08:00
Sheetal Nandi ecddf8468f Fix the assert for undefined leaf in LineNode (#21924)
Fixes #21818
2018-02-16 16:37:32 -08:00
Sergii Bezliudnyi b6f82adfed add template to jsdoc completion (#21978) 2018-02-16 16:27:57 -08:00
Andrew Casey 8341b1369d Merge pull request #22004 from amcasey/FARBadImport
Make FAR handle non-existent imported symbols
2018-02-16 16:17:04 -08:00
Mohamed Hegazy f95b9bc65d Port generated lib files (#22003)
* Port generated lib files

* Port generated lib files
2018-02-16 15:53:44 -08:00
Andrew Casey b64eefdb20 Remove redundant null check 2018-02-16 15:50:12 -08:00
Andrew Casey d2cbd8de06 Merge pull request #22001 from amcasey/OrganizeImportsMissedCommits
Group imports before sorting and coalescing
2018-02-16 15:28:15 -08:00
Andrew Casey 1faefc7703 Use correct lowercase name 2018-02-16 14:51:31 -08:00
Andrew Casey 9c2b95dae3 Make FAR handle non-existent imported symbols 2018-02-16 14:49:23 -08:00
Daniel Rosenwasser 4b34c428a7 Merge pull request #21751 from felicianotech/circleci
Try out CircleCI.
2018-02-16 14:12:35 -08:00
Nathan Shively-Sanders 7e8dab681a typingsInstaller:Remove triple-slash references (#21982)
Replace them with an explicit list of files in tsconfig. I got this list
by adding --listFiles to the jake-generated command.
2018-02-16 14:00:10 -08:00
Andrew Casey 7a31394788 Group imports before sorting and coalescing 2018-02-16 13:15:07 -08:00
Andrew Casey 70e9a5e6dc Merge pull request #21909 from amcasey/OrganizeImports
Introduce an organizeImports command
2018-02-16 12:49:02 -08:00
Andrew Casey 5c278cee17 Address PR feedback
Eliminate cancellation token

Add organizeImports.ts to tsconfig.json

Simplify ts.OrganizeImports.organizeImports

Simplify sortImports

Semantic change: all invalid module specifiers are now considered to be
equal.

Simplify comparisons using ||

Pull out imports with invalid modules specifiers

...for separate processing.  They are tacked on to the end of the
organized imports in their original order.

Bonus: downstream functions can now assume imports have valid module
specifiers.

Rename baseline folder with leading lowercase

Simplify coalesceImports

Remove some unnecessary null checks

Simplify baseline generation
2018-02-16 10:56:16 -08:00
Anders Hejlsberg 36a0550852 Fix issues 2018-02-16 10:52:38 -08:00
Andrew Casey f4141ac6bf Separate OrganizeImports into its own namespace and file 2018-02-16 10:52:29 -08:00
Andrew Casey 979b14689e Fix lint errors 2018-02-16 10:52:21 -08:00
Andrew Casey 5656f35b6a Introduce an organizeImports command
In phase 1, it coalesces imports from the same module and sorts the
results, but does not remove unused imports.

Some trivia is lost during coalescing, but none should be duplicated.
2018-02-16 10:51:38 -08:00
Andy b70aa229c6 getTextOfPropertyName: Assert input value is a PropertyName (#21981) 2018-02-16 10:48:57 -08:00
Daniel Rosenwasser 06286e760a Document 'ExportAssignment' slightly. 2018-02-16 01:17:45 -08:00
Andy cfc234f959 Simplify getBraceMatchingAtPosition (#21979) 2018-02-15 16:29:42 -08:00
Anders Hejlsberg 67c7fe6680 Accept new baselines 2018-02-15 13:57:05 -08:00
Anders Hejlsberg a8c0be344b Support recursive conditional types 2018-02-15 13:56:22 -08:00
Andy f8f4bb8fdd textChanges: Clean up handling of newLineCharacter (#21970) 2018-02-15 13:02:56 -08:00
Andy 347bff14a9 textChanges: Simplify getChanges (#21971)
* textChanges: Simplify getChanges

* Return ReadonlyArray
2018-02-15 13:02:45 -08:00
Andy 81df5313d7 Simplify getOccurrencesAtPosition (#21977) 2018-02-15 13:02:32 -08:00
Anders Hejlsberg 0f697c376b Merge pull request #21947 from Microsoft/fixKeyofWildcard
Fix issue with 'keyof T' and conditional types
2018-02-15 12:44:51 -08:00
Nathan Shively-Sanders 54a89ac026 Simplify bindPropertyAssignment inner loop 2018-02-15 12:25:55 -08:00
Nathan Shively-Sanders d180117d21 Move skipParentheses to utilities
Makes typingsInstaller compile without adding dependencies
2018-02-15 11:12:36 -08:00
Nathan Shively-Sanders 8bfcf331d5 Add symbols for just-added test 2018-02-15 10:47:04 -08:00
Nathan Shively-Sanders 8f98c77217 Merge branch 'master' into js-object-literal-assignments-as-declarations 2018-02-15 10:28:25 -08:00
Nathan Shively-Sanders 0191b70d62 Further cleanup 2018-02-15 09:54:55 -08:00
Nathan Shively-Sanders d2b933e0d6 Cleanup in binder: rename and move 2018-02-15 09:36:48 -08:00
Andy a133cec246 Fix bug: Interface type parameter merged with property is not unused (#21966) 2018-02-15 09:30:58 -08:00
Andy 1b6aa1386f Handle non-preserved const enums in debug messages (#21945) 2018-02-15 09:21:33 -08:00
Nathan Shively-Sanders 4fdef85608 Naming and duplication cleanup 2018-02-15 09:13:06 -08:00
Nathan Shively-Sanders 0cadfcf6df Clean up js decl code in checker+utilities 2018-02-14 15:48:20 -08:00
Andy 8518343dc8 Add isStringLiteralLike helper (#21953) 2018-02-14 13:25:04 -08:00
Andy 2ee92948d8 Support @param tag on property declaration initializer (#21907)
* Support @param tag on property declaration initializer

* Update test

* Finish updating test
2018-02-14 10:12:38 -08:00
Anders Hejlsberg 9b227fc520 Accept new baselines 2018-02-14 09:20:21 -08:00
Anders Hejlsberg 3de1cd6f2d Add regression tests 2018-02-14 09:20:13 -08:00
Anders Hejlsberg 3a61f638ba Instantiation of 'keyof T' for wildcard type produces wildcard type 2018-02-14 09:19:47 -08:00
Andy 47d84f87ce assertItemInCompletionList: Fix error messages (#21908)
* assertItemInCompletionList: Fix error messages

* Fix lint
2018-02-14 08:11:38 -08:00
Priyantha Lankapura 80464e8ff1 fix typo in intellisense (#21914) 2018-02-13 18:52:33 -08:00
Nathan Shively-Sanders bad155f072 Clean up bindPropertyAssignment
The add-intermediate-container-symbols loop is still quite confusing,
but it's not as bad as before.
2018-02-13 16:50:53 -08:00
Andrew Casey 9e6d862bf4 Merge pull request #21927 from amcasey/JakeLint
Fix jake lint on Windows
2018-02-13 16:29:39 -08:00
Andrew Casey 9d39ee7302 Fix jake lint on Windows
We need to pass `windowsVerbatimArguments: true` to `jake.exec` or it
parses the arguments incorrectly and doesn't actually lint.
2018-02-13 16:07:49 -08:00
Nathan Shively-Sanders 76a9ac4434 Restrict declaration initializers too 2018-02-13 15:52:35 -08:00
Nathan Shively-Sanders 88c67fa777 Refactor binder and update baselines.
Also improve assert message in fourslash.
2018-02-13 15:44:15 -08:00
Andy 8c2756fdf6 Support getting string literal completions based on a type argument constraint (#21168)
* Support getting string literal completions based on a type argument constraint

* Fix bug: look for require call before argument info

* Code review

* @sandersn code review

* Remove test cast

* Reduce completions.ts diff

* @weswigham review

* Remove getTypeArgumentConstraint's dependence on checkTypeArgumentConstraints

* Remove TODO
2018-02-13 15:18:26 -08:00