Commit Graph

35940 Commits

Author SHA1 Message Date
Andrew Casey e6bfce193c Add additional TODO about insertion positions 2017-09-27 10:40:12 -07:00
Andrew Casey 13e60bc497 Use resources, rather than string literals, in test baselines 2017-09-27 10:35:13 -07:00
Andrew Casey cb6037b563 Forbid extraction of constants to class scopes in JS 2017-09-27 10:30:02 -07:00
Andrew Casey 697bce74b8 Split range tests and helpers out of extractFunctions.ts 2017-09-26 17:29:36 -07:00
Andrew Casey 52ab05e99d Rename extractMethods.ts to extractFunctions.ts for consistency 2017-09-26 17:29:35 -07:00
Andrew Casey 2601bbcea7 Add simple tests for Extract Constant 2017-09-26 17:29:35 -07:00
Andrew Casey eb1fb5c164 Rename extractMethod.ts to extractSymbol.ts 2017-09-26 17:29:34 -07:00
Andrew Casey 3eea1a9e9a Generalize extract method to handle constants as well
Major changes:

1) Instead of skipping undesirable scopes, include them and mark them
with errors.  Constants can be extracted into more scopes.

2) Update the tests to call through the "public" API.  This caused some
baseline changes.

3) Rename refactoring to "Extract Symbol" for generality.

4) Return a second ApplicableRefactorInfo for constants.  Distinguish
the two by splitting the action name.
2017-09-26 17:29:34 -07:00
Sheetal Nandi ec95921315 Merge branch 'master' into projectRootAsCurrentDirectoryInEmit 2017-09-26 16:34:34 -07:00
Sheetal Nandi 6ba62d2d8d Revert all the changes except test case 2017-09-26 16:31:02 -07:00
Sheetal Nandi 68d360585a PR feedback 2017-09-26 16:21:15 -07:00
Wesley Wigham 6ffee104ca Split rwc input files (#18772)
* Handle translation between new and old log format styles

* Iteration

* Strip all backcompat

* Remove new parenthesis

* Handle directories in the test perf heuristic measurement

* Optional catch bindings!
2017-09-26 15:55:21 -07:00
Andy ecef2dc970 Improve testing of code fixes, and improve diagnostic messages (#18742)
* Improve testing of code fixes, and improve diagnostic messages

* Disambiguate `newFileContent` from `newRangeContent`
2017-09-26 15:16:29 -07:00
Andy a6555921f4 Update LKG (#18774) 2017-09-26 13:51:27 -07:00
Andy 5c239fa64c Remove redundant handler for JSDocComment in checkSourceElement (#18771) 2017-09-26 12:52:35 -07:00
Nathan Shively-Sanders fc933d7c33 Transform jsdoc types in the refactor, not emitter
The emitter now understands JSDoc types but emits them in the original
format.
2017-09-26 12:42:08 -07:00
Yuval Greenfield dcd2ddd0b7 Yes space after multiline comments 2017-09-26 12:09:58 -07:00
Sheetal Nandi 38f3a2b700 Renamed PartialSystem as DirectoryStructureHost and CachedPartialSystem as CachedDirectoryStructureHost 2017-09-26 11:05:52 -07:00
Sheetal Nandi 14febe2113 Rename watchedProgram.ts to watch.ts 2017-09-26 10:46:32 -07:00
Nathan Shively-Sanders 96b8093890 Move filenames to match refactoring rename 2017-09-26 09:08:39 -07:00
Nathan Shively-Sanders 13b37a4825 Change refactoring name and description 2017-09-26 08:58:18 -07:00
Adrian Leonhard 70087ed0d8 type WriteFileCallback: make param sourceFiles required. (#18731)
Fixes https://github.com/Microsoft/TypeScript/issues/15007
2017-09-25 17:22:26 -07:00
Anders Hejlsberg 1795614c41 Accept new baselines 2017-09-25 17:06:09 -07:00
Anders Hejlsberg 6a481e8ddc Update tests 2017-09-25 16:59:39 -07:00
Anders Hejlsberg 91691f6079 Strict function type checking only for certain function types 2017-09-25 16:59:18 -07:00
Daniel Rosenwasser 1cb5eb9685 Merge branch 'master' into correctlyCacheTaggedTemplates 2017-09-25 16:23:06 -07:00
Sheetal Nandi 23acff5bc8 Merge branch 'master' into watchImprovements 2017-09-25 16:18:26 -07:00
Wesley Wigham 8f9724811d Add fix for crash in #18712 (#18751) 2017-09-25 13:07:44 -07:00
Andy b4018a2ef1 Handle @typedef tag with missing type (#18662)
* Handle @typedef tag with missing type

* Add single quotes to diagnostic

* Remove redundant jsdoc checking (now done on every source element)

* Update baselines
2017-09-25 12:11:33 -07:00
Wesley Wigham 5a0c60a9a1 Include nearest test name in uncaught errors, catch suite errors (#18694) 2017-09-25 10:26:23 -07:00
Andy 17f10c032e Fix crash when @augments tag has no type (#18739) 2017-09-25 09:58:46 -07:00
Andy a4cf79baa5 Span length is not optional (#18558)
* Span length is not optional

* Fix calculation of length
2017-09-25 09:47:53 -07:00
Andy 024b1fd913 Make it a parse error for an @augments jsdoc tag to not include a type (#18745) 2017-09-25 09:26:59 -07:00
Nathan Shively-Sanders 8996d11096 Test:refactor JSDoc types to Typescript types 2017-09-25 09:02:42 -07:00
Nathan Shively-Sanders 6d218e2a48 Refactor JSDoc types to Typescript types
When the caret is on a Typescript declaration that has no type, but does
have a JSDoc annotation with a type, this refactor will add the
Typescript equivalent of the JSDoc type.

Notes:

1. This doesn't delete the JSDoc comment or delete parts of it. In fact,
due to bugs in trivia handling, it sometimes duplicates the comment.
These bugs are tracked in #18626.

2. As a bonus, when `noImplicitAny: true`, this shows up as a code fix in VS Code
whenever there is a no-implicit-any error. With `noImplicityAny: false`,
this code must be invoked via the refactoring command.
2017-09-25 08:56:51 -07:00
Wesley Wigham 0abfd6a165 Remove updateX functions for template parts (#18714) 2017-09-22 20:47:42 -07:00
Mohamed Hegazy 4221fb6a39 Check for initializer before using it (#18708) 2017-09-22 17:14:22 -07:00
Wesley Wigham b2ec33389c Add missing factory functions for template head, middle, tail, and no substituion template literal (#18709) 2017-09-22 16:54:46 -07:00
Arthur Ozga b21c46b9b5 support @extends in jsdoc 2017-09-22 16:21:31 -07:00
Andy 25ad0b5581 Apply "array-type" lint rule (#18699) 2017-09-22 16:14:41 -07:00
Wesley Wigham 5353475fce Always collect type and symbol baselines (#18621)
* Always generate type & symbol baselines

* Accept changed shadowed baselines

* Accept brand new type and symbol baselines

* Allow `getTypeAtLocation` to return undefined in the type writer

* Accept baselines which had missing type information

* Bind container for dynamically names enum members so they may be printed

* Accept type/symbol baselines for enums with computed members

* First pass at reducing typeWriter memory overhead

* Use generators to allow for type and symbol baselines with no cache

* Accept new baselines for tests whose output was fixed by better newline splitting

* Hard cap on number of declarations printed, cache declaration print text

* handle differing newlines better still to handle RWC newlines

* Lower abridging count, accept abridged baselines

* Limit max RWC error output size, limit RWC type and symbol baseline input size

* Move skip logic into type and symbol baseliner to streamline error handling

* Accept removal of empty baselines

* Canonicalize path earlier to handle odd paths in input files

* Do canonicalization earlier still, also ensure parallel perf profiles for different targets do not trample one another

* No need to pathify again
2017-09-22 15:52:04 -07:00
Ron Buckton 891e71d44f Remove freshness, more comprehensive grammar checks and diagnostic messages 2017-09-22 15:08:55 -07:00
Daniel Rosenwasser 92b7dcf20a Merge pull request #18660 from Microsoft/globalAugmentationPrinter
Correctly print global augmentations
2017-09-22 15:01:10 -07:00
Ron Buckton e81c83cdc7 Merge branch 'master' into dynamicNames 2017-09-22 14:45:22 -07:00
Wesley Wigham 5f4436d433 Keep a small reserve of tasks to not-batch, so all threads can have always have an initial task (#18696)
* Keep a small reserve of tasks to not-batch, so all threads can have an initial task"

* Assign no weight to new tests, but still place them at the end of the list
2017-09-22 14:44:26 -07:00
Andy 38905f46ce Minor cleanup to symbolWalker (#18549)
* Minor cleanup to symbolWalker

* Undo inlining
2017-09-22 14:07:07 -07:00
Filipe Silva d0fd964b69 Fix getSourceFile return type (#18689) 2017-09-22 11:54:20 -07:00
Andy 2399bac377 Make it a parse error for an @type jsdoc tag to not include a type (#18664)
* Make it a parse error for an `@type` jsdoc tag to not include a type

* Rename parameter
2017-09-22 10:45:43 -07:00
Andy 72c8b804da Use JSDoc @type tag type cast as a contextual type (#18690)
* Use JSDoc `@type` tag type cast as a contextual type

* Suggested changes
2017-09-22 10:42:02 -07:00
Andy a4b5870a52 Cleanups in formattingScanner.ts (#18599)
* Cleanups in formattingScanner.ts

* Move switch statement to function

* Fix assertions
2017-09-22 09:39:46 -07:00