ae3f29ade6
Accept baselines ( #18903 )
2017-10-02 19:08:13 -07:00
6f05e43b55
Merge branch 'master' into dynamicNames
2017-10-02 19:08:09 -07:00
35cfcff0d4
Use 'getTextOfNode'.
2017-10-02 18:44:54 -07:00
96bb796730
Improve error message for uncalled decorators.
2017-10-02 17:59:34 -07:00
6997e9b731
Merge pull request #17269 from Microsoft/watchImprovements
...
Watch improvements in tsserver
2017-10-02 17:38:22 -07:00
7f7d0c6c7b
Baseline public API ( #18897 )
...
* Add unit test which tracks public API changes
* Accept strict function types updates
* 100% Linefeeds, no carriage returns
* How were these missing?
* That would be why they were there
* Extract and comment
* Accept comment changes
2017-10-02 17:37:40 -07:00
8ac01d76f5
Separate namespace declarations in builder of intenal and exported interfaces and functions
2017-10-02 17:16:49 -07:00
a8b7f7d1e5
Include localized diagnostics ( #18702 )
...
* Add lcl files
* Add loclalization script
* Add localization build targets
* use async exists, and add assert
* Generate lcg file
* Add localize task to gulpFile
* Only run loclaize if the generated files neededs update. Also run localize as part of local
* Fix lint errors
* Linter love
* Respond to code review comments
2017-10-02 17:16:08 -07:00
3a2c723a69
Allow parsing a qualified type name containing a reserved word ( #18888 )
2017-10-02 17:04:28 -07:00
b244cd4fb4
Merge pull request #18864 from amcasey/GH18857
...
Handle repeated substitution of the same symbol during extraction
2017-10-02 17:03:03 -07:00
d620129d4a
Ensure getResolvedSignature never returns undefined ( #18883 )
2017-10-02 17:02:27 -07:00
3b4cbebee0
Handle repeated substitution of the same symbol during extraction
...
Old: Insert the same Node for every occurrence. The position was
repeatedly mutated during printing.
New: Thunk the Node so that a new one is constructed for every
occurrence.
Fixes #18857
2017-10-02 16:51:13 -07:00
e1380a866e
Refactor to reduce property duplication
2017-10-02 16:41:40 -07:00
2df7058af7
Merge pull request #18861 from amcasey/ConstantInsertionPosition
...
Improve insertion positions of extracted constants
2017-10-02 16:39:32 -07:00
4bb4711eff
Merge branch 'master' into watchImprovements
2017-10-02 16:34:43 -07:00
7f969e8138
Making APIs as internal so that we can enable them after we have figured out final details
2017-10-02 16:27:26 -07:00
6831e65235
Merge branch 'master' into refactor-jsdoc-types-to-typescript
2017-10-02 16:24:00 -07:00
724f71cae1
Describe the innermost scope as "enclosing scope" for constants
...
Using the same description as for functions was confusing because the
extracted constant was inserted below the top-level of that scope.
2017-10-02 15:57:36 -07:00
ba5f09b66d
Localize 'in' in extraction description
2017-10-02 15:30:52 -07:00
884c72efb4
Merge pull request #18654 from Microsoft/strictFunctionTypes
...
Strict function types
2017-10-02 23:09:17 +01:00
bff843a9c9
Improve error elaboration for invariant generic types
2017-10-02 13:39:55 -07:00
eefe5c9706
Fix acquiring format options for getEditsForRefactor ( #18848 )
...
* Fix acquiring format options for getEditsForRefactor
* Add test
* Fix test description
* Use `executeCommandSeq`
2017-10-02 13:26:35 -07:00
b80b2eeaa3
Move first/last shortcuts closer to the end of the helper flags.
2017-10-02 13:23:57 -07:00
898559b4e5
Merge branch 'master' into watchImprovements
2017-10-02 12:34:34 -07:00
835153ba50
PR feedback
2017-10-02 12:22:05 -07:00
fb3168d46f
Merge branch 'master' into dynamicNames
2017-10-02 11:40:28 -07:00
637ed57451
Fix crash when extending non-EntityNameExpression ( #18853 )
2017-10-02 10:39:03 -07:00
e6980722a6
Fix bug: Report errors on extends expression in JS even if an @augments tag is present ( #18854 )
2017-10-02 10:33:53 -07:00
141cd574c7
Merge pull request #18603 from RyanCavanaugh/pluginWork
...
Report external files in initial case for project load
2017-10-02 10:32:04 -07:00
a075ba9828
getSuggestionForNonexistentSymbol: Add comment ( #18885 )
2017-10-02 10:23:37 -07:00
d11172c86e
Use idText in a few more places ( #18842 )
2017-10-02 08:37:02 -07:00
b883fcbfdd
Enable "space-within-parens" lint rule ( #18856 )
2017-10-02 08:36:26 -07:00
d821bbf3f3
Simplify RulesMap construction ( #18858 )
2017-10-02 08:36:09 -07:00
a23d1bf3ea
Updated helper for marginally better minification.
2017-09-30 00:06:20 -07:00
86315ed411
Added test and adjusted reporting logic.
2017-09-29 22:01:00 -07:00
bcc93f2c08
Loosen restriction on usages in innermost scope
...
Now that we're smarter about where we declare the extracted local, we
can ignore usage problems in the innermost script - it'll always have
access to the same symbols as the extracted expression.
2017-09-29 18:00:27 -07:00
c08308a0f1
Reuse getSourceFileImportLocation
2017-09-29 17:37:39 -07:00
5da45fb6de
Addressed code review feedback.
2017-09-29 17:16:50 -07:00
08ef6e4bea
Accepted baselines.
2017-09-29 17:08:35 -07:00
966f370712
Use a better check.
2017-09-29 16:42:30 -07:00
936f98d9ad
Addressing CR feedback
2017-09-29 16:01:14 -07:00
9097a07758
Improve insertion positions of extracted constants
...
...mostly by putting them closer to the extraction site.
They now also follow all leading comments in a file (unfortunately,
including the doc comment on the first declaration).
Bonus: Special case declaration lists - declare the new variable as part
of the list, rather than before it, in case it depends on an earlier
entry.
2017-09-29 15:52:56 -07:00
7aee3a102c
Merge pull request #18831 from amcasey/AdditionSpecialCase
...
Eliminate special case for extracting from a binary operator chain
2017-09-29 13:10:28 -07:00
f71930c473
Print list of available refactors when we can't find one ( #18843 )
2017-09-29 11:08:45 -07:00
9e08caebf5
Merge branch 'master' into watchImprovements
2017-09-29 10:43:05 -07:00
683d6c7ddd
Add helper functions for using unescapeLeadingUnderscores ( #18793 )
...
* Add helper functions for using `unescapeLeadingUnderscores`
* More cleanup
2017-09-29 09:57:31 -07:00
0756aa1753
Merge branch 'master' into strictFunctionTypes
2017-09-28 15:39:57 -07:00
8e4c559f2c
Merge pull request #18829 from amcasey/JsExtractTests
...
Improve Extract* unit test coverage and correctness
2017-09-28 14:59:18 -07:00
41676248e5
Eliminate special case for extracting from a binary operator chain
...
1) It assumed left-associativity and was, therefore, wrong for (e.g.)
exponentiation.
2) Arguably, if a user selects `a + |b + c|`, they want to extract `b +
c`, not `a + b + c`. Not being able to do so is surprising (and we may
eventually want to allow it), but so is having the rest of the
least-common subtree extracted.
Fixes #18268
2017-09-28 14:54:52 -07:00
5613be4907
Only methods and constructors are bivariant in --strictFunctionTypes mode
2017-09-28 14:33:35 -07:00
Mohamed Hegazy
Ron Buckton
Daniel Rosenwasser
Sheetal Nandi
Wesley Wigham
Andy
Andrew Casey
Andrew Casey
Nathan Shively-Sanders
Anders Hejlsberg
Ryan Cavanaugh