Commit Graph

26317 Commits

Author SHA1 Message Date
uniqueiniquity 509b9ad087 Complete to single line jsdoc comment if no params 2017-11-02 09:55:56 -07:00
Mike Morearty 1a7a587a9e Fix TokenOrIdentifierObject.getText() crash (#19673)
TokenOrIdentifierObject.getText() needs to pass `sourceFile` as an
argument to `getStart()`.

Fixes https://github.com/Microsoft/TypeScript/issues/19670
2017-11-01 16:37:06 -07:00
Wesley Wigham ba98cbbf92 User code runner draft (#19539)
* Realworld runner draft

* Baseline tsc output instead of just checking exit code

* use latest instead of major minor pin

* Add 7 more test cases + update gitignore

* Update baselines for realworld/user tests

* Rename to user

* Do not commit lockfiles

* Add code to run user tests on CRON

* Add rest of most-dependend packages to user tests

Turns out levelup doesn't have types! So I removed that one.
2017-11-01 16:22:37 -07:00
Andy 6a382f1436 In typings installer, provide mandatory 'package.json' fields (#19663) 2017-11-01 14:20:26 -07:00
Nathan Shively-Sanders 5d7e87a9c2 Add "strictTuples" to list of strict flags 2017-11-01 11:52:52 -07:00
Nathan Shively-Sanders b228736596 Merge branch 'master' into 6229-known-length-tuples 2017-11-01 11:51:49 -07:00
Nathan Shively-Sanders 146addc4d5 Use explicit undefined checkk 2017-11-01 10:35:54 -07:00
Nathan Shively-Sanders f4d4e89fa9 Merge branch 'master' into guard-name-in-getSuggestionForNonexistentSymbol 2017-11-01 10:34:19 -07:00
Nathan Shively-Sanders a6a5b85b52 Switch from undefined guard to asserts
In both fixSpelling and getSuggestionForNonexistentSymbol
2017-11-01 10:33:24 -07:00
Anders Hejlsberg 81326ac901 Properly handle Object and Function types 2017-11-01 09:16:16 -07:00
Nathan Shively-Sanders db88c8eac2 Check function type parameters for this references
Previously, when checking for this references, the compiler did not
check type parameters. This caused it to miss some instantiations that
were necessary.

Also some cleanup:
1. Rename isIndependent* to is*FreeOfThisReference. 'Independent' was a
one-off concept that was unique to Typescript (and isn't referenced in
the spec), so I think the new name is friendlier to new readers.
2. Use `Array.every` whenever possible, since Typescript added a
dependency on ES5 since the code was first written.
3. Switch to JSDoc so that it shows up nicely in editors.
2017-11-01 09:12:01 -07:00
Benjamin Lichtman dcc1f1497f Merge pull request #19619 from uniqueiniquity/indentJsxText
Properly indent JSXText on format document
2017-11-01 09:03:52 -07:00
Ryan Cavanaugh 5dc02ef5cc Use a different RegEx 2017-10-31 18:38:00 -07:00
Homa Wong 53ad019ba1 Log top 5 largest files when TS language service is disabling. (#19315)
* Log top 5 largest files

* Show same message on second pass.

This second pass seemingly should be avoid. Bug there.

* Get all files and sort when error.

* Refactor

* Push logic to error branch

* Update to use array chain.

* Update to return string

* going functional.
2017-10-31 16:33:43 -07:00
Anders Hejlsberg 2a30aaff2f Merge branch 'master' into nominalInstanceof 2017-10-31 16:31:51 -07:00
Armando Aguirre cf2bdf8250 Merge pull request #19175 from armanio123/AddDefinitionAndBoundSpan
Added DefinitionAndBoundSpan command
2017-10-31 14:58:36 -07:00
uniqueiniquity b6ea2f955a Refactor test and annotate object literal 2017-10-31 14:52:15 -07:00
wenlu.wang deb94886fd fix completion module path (#19351)(#19367) (#19366)
* completion module path with re-export(#19351)

* completion module path with dynamic import(#19367)
2017-10-31 14:10:38 -07:00
uniqueiniquity f962aba24a Indent all lines of single JsxText node 2017-10-31 14:09:36 -07:00
Andy ce25dc9807 reduceRight is never used (#19605) 2017-10-31 13:29:28 -07:00
Nathan Shively-Sanders 98e9a561af Merge pull request #19219 from Microsoft/abstract-property-access-error-in-own-constructor-only
Abstract property access error in own constructor only
2017-10-31 13:27:24 -07:00
Wesley Wigham 7e1e7a711a Cache some LS calls in fourslash (#19517)
* Cache some LS calls in fourslash

* Add comment
2017-10-31 13:26:58 -07:00
Anders Hejlsberg 7f35c8fd07 Add type annotation 2017-10-31 13:00:30 -07:00
Anders Hejlsberg 25af351014 Nix getBestChoiceType, [] subtyping, nominal union reduction for classes 2017-10-31 12:50:01 -07:00
Ron Buckton 542a060875 Remove case-insensitive UI comparisons for now 2017-10-31 12:33:35 -07:00
Ron Buckton 88e56f3956 Assert arrays passed to relativeComplement are sorted 2017-10-31 11:49:52 -07:00
uniqueiniquity 3ebb2e8a34 Merge branch 'master' into jsxFragment 2017-10-31 10:53:57 -07:00
Ron Buckton 1d0a9ee453 PR feedback 2017-10-31 10:49:08 -07:00
Andy f4236ec5c8 Rename "isPartOfExpression" (#18469) 2017-10-31 08:05:39 -07:00
csigs d22d489407 LEGO: check in for master to temporary branch. 2017-10-31 04:10:09 +00:00
Wesley Wigham c2aa13dac5 Parenthesize export assignments if needed (#19590)
* parenthesize export assignments if needed

* Add default-specific parenthesization to handle lookahead

* New parenthesization logic for export default

* Handle commalist and comma cases
2017-10-30 18:23:32 -07:00
Ron Buckton 26ca98c820 Merge branch 'master' into dynamicNames 2017-10-30 18:02:53 -07:00
Ron Buckton 967a426fe1 Unify deduplication, fix deferred global diagnostics 2017-10-30 17:19:27 -07:00
Armando Aguirre d5c18a6fb7 Merge branch 'master' into AddDefinitionAndBoundSpan 2017-10-30 17:02:23 -07:00
Andrew Casey a89c055a48 Merge pull request #19578 from amcasey/GH19395
Don't pass synthesized node to typeToTypeNode
2017-10-30 16:35:20 -07:00
Andy 5e0c71e6ba The global "JSON" object should always exist (#19583) 2017-10-30 16:20:55 -07:00
Nathan Shively-Sanders f26ac9f414 Merge pull request #19589 from Microsoft/reorder-jsdoctag-kinds
Fix the order of JSDocTag kinds
2017-10-30 16:07:28 -07:00
Anders Hejlsberg 3d89837cfa Use nominal checks in union type subtype reduction 2017-10-30 15:35:51 -07:00
csigs 48457eafad LEGO: Merge pull request 19591
LEGO: Merge pull request 19591
2017-10-30 15:11:19 -07:00
csigs 5294c4190b LEGO: check in for master to temporary branch. 2017-10-30 22:10:50 +00:00
Andy 277e3189c2 Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional (#19507)
* Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional

* Increment servicesVersion

* Update api baselines
2017-10-30 15:10:34 -07:00
uniqueiniquity 976c25c672 Add support for enums and property signatures 2017-10-30 15:05:55 -07:00
Nathan Shively-Sanders aea2ee5726 Fix the order of JSDocTag kinds
JSDocTypeLiteral should not be grouped with the JSDocTag kinds, so move
it just before they start, instead of just after. This updates the
LastJSDocNode and LastJSDocTagNode.
2017-10-30 15:00:34 -07:00
Mohamed Hegazy 6c71ca84e7 Add utility function to check for strict option flags (#19427)
* Add utility function to check for strict option flags
- Correctelly check for noImplicitAny in checker
- Correctelly check for noImplicitAny in installTypesForPackage refactor

* Respond to code review comments

* Accept baselines

* Revert "Accept baselines"

This reverts commit cf4ef62830.

* Move type alias to core
2017-10-30 13:05:54 -07:00
Anders Hejlsberg 7f4a132af9 Merge pull request #19564 from Microsoft/fixGenericMappedTypeRelationships
Fix generic mapped type relationships
2017-10-30 12:42:24 -07:00
Matt 6de69df9c1 Fix #102: More accurate error message for module in type reference (#19324)
* Add: Logical OR of "SymbolFlags.ValueModule" into the "meaning" argument of the
"resolveName" call, in the "checkAndReportErrorForUsingNamespaceModuleAsValue"
function, when checking if a namespace is being used as a type.

* Fix: test "privacyImportParseErrors" error messages.

* Fix: test "typeofInternalModules" error message.

* Fix: test "moduleWithValuesAsType" error message.

* Fix: test "moduleAssignmentCompat2" error messages.

* Fix: test "moduleVisibilityTest3" error message.

* Fix: test "getAccessorWithImpliedReturnTypeAndFunctionClassMerge" error messages.

* Fix: test "staticInstanceResolution5" error messages.

* Fix: test "noCrashOnImportShadowing" error message.

* Fix: test "moduleAssignmentCompat3" error messages.

* Fix: test "primaryExpressionMods" error message.

* Fix: test "moduleInTypePosition1" error message.

* Fix: test "moduleAssignmentCompat1" error messages.

* Fix: test "moduleAssignmentCompat4" error messages.

* Fix: test "moduleCrashBug1" error message.
2017-10-30 12:38:18 -07:00
Ron Buckton 91c37f72d3 Merge pull request #19401 from Microsoft/fix19349
Remove escaped names of well known symbols from string completions
2017-10-30 12:37:13 -07:00
Anders Hejlsberg a01df0f20b Use nominal check in isTypeInstanceOf 2017-10-30 12:36:25 -07:00
Andy f0da3d7336 Fix declaration emit for typeof default export (#19471)
* Fix declaration emit for `typeof` default export

* Add comment
2017-10-30 11:40:32 -07:00
Andrew Casey 1f93526fd9 Assert that enclosing declaration is not synthesized 2017-10-30 11:22:07 -07:00