Commit Graph

26317 Commits

Author SHA1 Message Date
Klaus Meinhardt ec1ff29a8c really, really fix test(?) 2018-08-08 17:10:22 +02:00
Klaus Meinhardt 27d2a2d564 add test 2018-08-08 17:05:31 +02:00
Klaus Meinhardt 95494efe50 fix commonPrefix handling 2018-08-08 16:58:35 +02:00
Klaus Meinhardt f31b9d3891 fix test 2018-08-08 16:38:42 +02:00
Klaus Meinhardt 47e77901fd actually test the cache 2018-08-08 15:39:07 +02:00
Klaus Meinhardt bed93b48f5 fix moduleNameResolver cache
Fixes: #26271
2018-08-08 11:12:48 +02:00
Andrew Casey daccc978a8 Don't compute suggestion diagnostics for lib files
The check applied to semantic diagnostics (and `checkSourceFile`) should
also apply to suggestion diagnostics.  Fixes assert.
2018-08-07 17:58:35 -07:00
Andy 1a05f13aef moveToNewFile: Don't remove empty named imports (#26265) 2018-08-07 12:54:46 -07:00
Andy 794f3a5e76 goToTypeDefinition: Go to function return type (#25952)
* goToTypeDefinition: Go to function return type

* Add more tests

* If a function returns 'void' or some other type with no definition, just return the function definition.
2018-08-07 12:54:19 -07:00
Andy eaf0d59d35 Fix bug: symbol.valueDeclaration not guaranteed to be defined (#26267) 2018-08-07 12:13:45 -07:00
Ryan Cavanaugh 3fde17e85c Merge pull request #26234 from RyanCavanaugh/noVoidTest
Disallow expressions of type `void` to be used in truthiness checks
2018-08-07 08:37:42 -07:00
王文璐 639190d607 fix compiler crash (#26209) 2018-08-07 10:09:26 +08:00
Andy 937afab4b0 Support signature help for contextual parameter type (#26022) 2018-08-06 16:46:30 -07:00
Anders Hejlsberg eeb19c1e22 Merge pull request #26236 from Microsoft/fixCircularReturnType
Fix circular return type issue
2018-08-06 16:38:31 -07:00
Sheetal Nandi f67bdd429a Skip loading configured project just to report project info through synchronizeProjectList for project opened by external project 2018-08-06 16:24:14 -07:00
Ryan Cavanaugh ca10b7a6fa Add checks for remaining truthiness positions 2018-08-06 16:11:43 -07:00
Anders Hejlsberg bf19d214f3 Revise logic that computes the contextual type for a parameter 2018-08-06 16:10:10 -07:00
Sheetal Nandi 8c4607d8eb Dont delay external project update from openExternalProject
Since external projects are needed to be uptodate when opening file,
so in most likely scenarios these will be loaded anyways so there is no saving in postponing this work
2018-08-06 16:06:40 -07:00
Sheetal Nandi a0190e397a Delay update graph when opening external project, and delay load configured project referenced from external project when opening it 2018-08-06 16:01:15 -07:00
Sheetal Nandi 4475d81b9c Add flags on commandLineOption to indicate strictFlag or option affecting semanticDiagnostics 2018-08-06 14:54:57 -07:00
Ryan Cavanaugh bad002cfb7 Merge pull request #26150 from Kingwl/CheckReturnUnknow
add check for function return unknow type
2018-08-06 13:52:14 -07:00
Andy d0ed21cad1 completions: 'true' and 'false' are type keywords (#26237) 2018-08-06 12:42:56 -07:00
Klaus Meinhardt 7299bceafb infer number index signature in JS object literals (#26221)
Fixes: #26208
2018-08-06 11:52:51 -07:00
Anders Hejlsberg cfa29ae2fa Merge branch 'master' into fixCircularReturnType
# Conflicts:
#	src/compiler/diagnosticMessages.json
2018-08-06 10:53:20 -07:00
Anders Hejlsberg 6a17f4d162 Merge branch 'master' into fixCircularReturnType
# Conflicts:
#	tests/baselines/reference/recursiveResolveDeclaredMembers.types
#	tests/baselines/reference/typeGuardsWithInstanceOfByConstructorSignature.types
2018-08-06 10:42:35 -07:00
Alexander T 37b9a6bca4 25840 - Add a more meaningful error message to the case when calling a public static method on an instance (#25922)
* add a more meaningful error message to the case when calling a public static method on an instance

* Fix tests
2018-08-06 10:24:48 -07:00
Ryan Cavanaugh 14d3c69c72 Disallow exprs of type void to be used in truthiness checks 2018-08-06 09:40:22 -07:00
Anders Hejlsberg dc34c5e719 Use getReturnTypeFromAnnotation instead of ad hoc checks 2018-08-06 06:51:45 -07:00
王文璐 723ee8a35e visit exclamation token 2018-08-06 18:40:10 +08:00
Kagami Sascha Rosylight 76ae12d143 Change esnext.asynciterable to es2018.asynciterable 2018-08-06 16:30:08 +09:00
Anders Hejlsberg ab7defa5ea Clean up return type checking logic 2018-08-05 08:47:55 -07:00
Anders Hejlsberg ee721225ae Ensure type parameters are erased in contextual signature from @type tag 2018-08-04 11:30:20 -07:00
Anders Hejlsberg 539775779e Erase type parameters when fetching return type from JSDoc @type tag 2018-08-04 09:13:22 -07:00
Sheetal Nandi d419968c0d Refresh semantic diagnostics when compiler options affecting semantic diagnostics generation changes
Fixes #26195
2018-08-03 16:27:25 -07:00
Sheetal Nandi c6ca96bdcf Removing debugger statements from tests 2018-08-03 15:41:44 -07:00
Sheetal Nandi 1e5e61873d Send event on referencing large file 2018-08-03 15:22:28 -07:00
Klaus Meinhardt 3b022a4e66 add link to issue 2018-08-03 23:19:04 +02:00
Anders Hejlsberg e4443bb993 Properly catch and error on circular function return types 2018-08-03 14:03:30 -07:00
Klaus Meinhardt a1978eb8a1 add test 2018-08-03 22:10:18 +02:00
Sheetal Nandi 77e29b7f0e Merge pull request #26169 from Microsoft/largeFile
Do not read files greater than maxFileSize which is currently 4mb
2018-08-03 10:38:02 -07:00
Klaus Meinhardt 6df61272f3 createProgram: don't use TypeChecker
Avoids using the TypeChecker when trying to reuse the Program structure.
This allows SourceFiles contained in the old Program to be updated using ts.updateSourceFile

Fixes: #26166
2018-08-03 17:54:15 +02:00
Sheetal Nandi 46d223dc1b Fixes to ensure getDefinitionAndBoundSpan works correctly when using composite projects
Project references need to be detached from the project when closing project
In SourceMapDecoder handle when the redirected file to project reference is set as the output of the project
Keep configured project alive if project it references has open ref
Fixes #26164
2018-08-02 16:36:50 -07:00
Sheetal Nandi 9df88316a2 Merge pull request #26137 from Microsoft/updateGraphIfDirty
Use updateGraphIfDirty to do quick check if project update is needed
2018-08-02 16:32:36 -07:00
Mohamed Hegazy 5fbc7d92c2 Port generated lib files 2018-08-02 14:44:17 -07:00
Wesley Wigham fefc47fae3 Flag JS Literals and ignore assignments/accesses to invalid props, instead of adding an index (#25996)
* Remove index signatures from js literals, use an object flag to indicate errors should be ignored instead

* Add focused test on the keyof problem

* Fix fourslash test

* Reenable errors with noImplicitAny flag

* Also disable excess property checks outside of noImplicitAny mode for js literals

* Edit and move comments
2018-08-02 13:40:44 -07:00
Sheetal Nandi 135425d40b Do not read files greater than maxFileSize which is currently 4mb
Fixes #24762
2018-08-02 13:03:58 -07:00
Mohamed Hegazy 150fd90db9 Port generated lib files 2018-08-02 10:04:57 -07:00
王文璐 691459304f add check for function return unknow type 2018-08-02 18:24:45 +08:00
Ryan Cavanaugh 3ab7a98ecf Merge pull request #26121 from mattmccutchen/issue-23999
"Could not find a declaration file for module" error needs to use the unmangled package name where appropriate.
2018-08-01 20:55:31 -07:00
Matt McCutchen d45e422b46 Have getAssignmentReducedType use the comparable relation instead of
typeMaybeAssignableTo.

typeMaybeAssignableTo decomposed unions at the top level of the assigned
type but didn't properly handle other unions that arose during
assignability checking, e.g., in the constraint of a generic lookup
type.

Fixes #26130.
2018-08-01 23:26:17 -04:00