Commit Graph
26450 Commits
Author SHA1 Message Date
Nathan Shively-Sanders 6798bd576b Primitives are not assignable to any-type indexers
`string/numberIndexTypesRelatedTo` needs to prevent primitives from being
assignable to an indexer of type 'any'. However, these two functions take
an apparent type, which no longer has the primitive flag set. I thought of
three ways to provide this information:

1. Pass the original type into `string/numberIndexTypesRelatedTo` and
check its flag.
2. Record a boolean `isPrimitive` before converting to the apparent type,
and pass it to `string/numberIndexTypesRelatedTo`.
3. Create a helper function `isPrimitive` that takes the apparent type and
compares it to globalString/Number/Boolean/ESSymbolType.

I decided on (1) because it seems like the simplest and safest. But none
of the options are elegant. Please suggest improvements.
2015-10-15 09:45:38 -07:00
zhengbli 3e37b3158b Address code review at 5127 2015-10-14 21:36:35 -07:00
zhengbli b7c93c012f Address CR from 5127 2015-10-14 17:50:29 -07:00
Zhengbo Li 8864b06cbf Merge pull request #5127 from zhengbli/newAddDirectoryWatcher
Add directory watcher for tsserver and tsc
2015-10-14 17:43:10 -07:00
Ryan Cavanaugh 1a36fce4c2 JavaScript LS scaffolding + JS module inference 2015-10-14 17:36:03 -07:00
zhengbli fcfc25eeb0 Fix lint errors 2015-10-14 16:57:08 -07:00
zhengbli f91bee0324 Re-read file content upon closing 2015-10-14 16:50:31 -07:00
zhengbli c75499974e Fix rwcRunner 2015-10-14 16:31:27 -07:00
zhengbli 6013968b1f Address build errors 2015-10-14 16:25:27 -07:00
zhengbli 62664fdeda Add timer for batch processing directory changes 2015-10-14 16:09:41 -07:00
zhengbli def268cccf Fix issues with removing roots 2015-10-14 15:48:25 -07:00
zhengbli 002f0c066b CR feedback 2015-10-14 15:10:05 -07:00
Mohamed Hegazy 21e30e0f59 Merge pull request #5235 from Microsoft/fixDecoratorDiagostics
Fix exception in compiler when type checking decorators with generics.
2015-10-14 12:29:08 -07:00
Nathan Shively-Sanders e964cb10ca Make constructor use merged parent symbol
Previously in getSignatureFromDeclaration, it just used the parent symbol
without checking whether it was merged.
2015-10-14 12:24:22 -07:00
Sheetal Nandi 81763543f3 Fix the duplicate function implementation error that depended on order of files 2015-10-14 12:00:43 -07:00
Mohamed Hegazy 5234bf698c Merge pull request #5033 from Microsoft/dirkb/fix_5032
Fixed #5032: tsserver: Format on type broken
2015-10-14 09:49:50 -07:00
Vladimir Matveev 124447763b Merge pull request #5233 from Microsoft/relaxedUseBeforeDef
allow forward references to block scoped variables from functions
2015-10-13 14:19:01 -07:00
Mohamed Hegazy 99d448a167 Merge pull request #5231 from Microsoft/removeExperimentalAsyncFunctions
Remove experimental async functions
2015-10-13 14:17:36 -07:00
Ryan Cavanaugh b2d666c489 Merge pull request #5184 from RyanCavanaugh/fix5096
Don't issue completion in JSX text
2015-10-13 13:27:39 -07:00
Vladimir Matveev 0465f1b0bb revert enum related changes 2015-10-13 13:18:58 -07:00
Vladimir Matveev bc02341e99 addressed PR feedback, updated tests to suppress reachability errors where they are not needed 2015-10-13 10:58:55 -07:00
Vladimir Matveev 48b24343b1 use isBlockScopedNameDeclaredBeforeUse for block scoped variables and enums 2015-10-13 00:07:36 -07:00
Vladimir Matveev 938dd747c6 Merge branch 'master' into reachabilityChecks 2015-10-12 22:33:25 -07:00
Ron Buckton 0fa89ad99c Fixes #5104. 2015-10-12 17:38:55 -07:00
Vladimir Matveev eb3b91cf1b addressed PR feedback 2015-10-12 17:24:39 -07:00
Yui 77eaf04386 Merge pull request #4914 from Microsoft/exponentiation
[ES7] Exponentiation
2015-10-12 16:37:45 -07:00
Sheetal Nandi 11b270f6ca Add testcase - generating declaration file results in more errors in ts file 2015-10-12 16:27:11 -07:00
Vladimir Matveev f952873ef1 allow forward references to block scoped variables from functions 2015-10-12 16:18:37 -07:00
Vladimir Matveev c8ba16644b Merge pull request #4911 from Microsoft/liftDtsOnlyRestriction
extend the list of extensions for module file names in node_modules f…
2015-10-12 14:48:47 -07:00
Nathan Shively-Sanders 92c2d48465 Lint: remove trailing whitespace 2015-10-12 14:37:10 -07:00
Yui T 90258794a6 Address PR feedback 2015-10-12 14:32:48 -07:00
Sheetal Nandi b38a81bc73 Emit enabled for JS files 2015-10-12 14:31:44 -07:00
Mohamed Hegazy 92f1b48cc8 Remove --experimentalAsyncFunctions 2015-10-12 14:27:33 -07:00
Nathan Shively-Sanders d6ae55708d Do not mark class members as ambient or export.
Even members of ambient classes. These flags have no useful semantics
there, and it prevents ambient classes from merging properly with
interfaces.
2015-10-12 14:25:39 -07:00
Nathan Shively-Sanders 8a051343ff Merge pull request #5169 from Microsoft/fix-simple-uses-of-polymorphic-this-in-services
Fix simple uses of polymorphic this in services
2015-10-12 13:54:50 -07:00
Vladimir Matveev 4ccf630f63 merge with master 2015-10-12 13:45:06 -07:00
Sheetal Nandi 286fb3e948 Fix the lint error 2015-10-12 13:10:54 -07:00
Sheetal Nandi f28fbfd7c5 Merge branch 'master' into tscJsFiles 2015-10-12 12:51:24 -07:00
Sheetal Nandi a87dae15a9 Verify that when emit blocking error occurs rest of the emit occurs as expected 2015-10-12 12:44:21 -07:00
Sheetal Nandi 5e14edb4b7 Verify the emit file name is unique and doesnt overwrite input file
Fixes #4424
2015-10-12 12:25:13 -07:00
Ryan Cavanaugh c05297cfea Merge pull request #5178 from RyanCavanaugh/fix5132
Escape quotes when emitting React
2015-10-12 11:56:46 -07:00
Yui T e405ccebec fix linter failure 2015-10-12 11:48:38 -07:00
Zhengbo Li 5605c8a639 Merge pull request #5177 from zhengbli/i4684
Change the definition of NodeFilter in lib.d.ts
2015-10-12 11:44:26 -07:00
zhengbli de52865243 Remove prototype from NodeFilter static type 2015-10-12 11:35:36 -07:00
Vladimir Matveev 22e68de7ec Merge pull request #5216 from Microsoft/checkFunctionsInClassExpressions
check functions in class expressions
2015-10-12 11:09:21 -07:00
Vladimir Matveev d757e5e7a2 Merge pull request #5226 from Microsoft/blockScopedExports
check initialization of exported block scoped variables
2015-10-12 10:32:57 -07:00
Wesley Wigham 1ae7b7c254 Merge branch 'master' into out-module-concat 2015-10-12 10:21:01 -07:00
Vladimir Matveev adf9f9b8df check initialization of exported block scoped variables 2015-10-12 09:59:41 -07:00
Vladimir Matveev c35419e12e add rule to insert space between async keyword and open paren 2015-10-11 22:19:51 -07:00
Vladimir Matveev a0683276d1 check functions in class expressions 2015-10-11 21:57:17 -07:00