Commit Graph
26450 Commits
Author SHA1 Message Date
Nathan Shively-SandersandGitHub fc306ba641 Merge pull request #15849 from Microsoft/allow-spread-after-required-params
Allow spreading arrays after required parameters
2017-05-17 09:14:20 -07:00
Andy Hanson b9c3a992e1 getAllPossiblePropertiesOfTypes: Skip primitives 2017-05-17 08:26:51 -07:00
Andy Hanson 0ff187c8ac Remove 'isDeclarationFile()' function, use '.isDeclarationFile' 2017-05-17 08:12:23 -07:00
Andy Hanson 0c60824860 Set @typedef parent pointer, but still do not bind a symbol 2017-05-17 08:02:07 -07:00
Andy Hanson dc40f5d6b9 Merge branch 'master' into jsdoc 2017-05-17 07:17:32 -07:00
AndyandGitHub fc4dd2b4e5 Merge pull request #15890 from Microsoft/todoComments
Services utilities: Combine `isInsideComment` with `isInComment`
2017-05-17 07:09:33 -07:00
Arthur Ozga 11019e4a4a Merge branch 'master' into typeToStringViaTypeNode 2017-05-16 15:35:31 -07:00
Arthur Ozga 0820f69270 respond to comments 2017-05-16 15:28:32 -07:00
Andy Hanson 0defde7185 Services utilities: Combine isInsideComment with isInComment 2017-05-16 15:05:46 -07:00
AndyandGitHub ed7ae8060f Merge pull request #15880 from Microsoft/getDeclarationOfKind
getDeclarationOfKind: Improve type safety
2017-05-16 15:02:09 -07:00
Klaus MeinhardtandMohamed Hegazy 5fb77a0901 Update return types of APIs (#15887)
* Update types.ts

* Update types in parser.ts and scanner.ts
2017-05-16 14:13:58 -07:00
AndyandGitHub 8ceaa33943 Merge pull request #15860 from Microsoft/no-filter
getTokenAtPositionWorker: Remove duplicate loop
2017-05-16 14:05:54 -07:00
Andy Hanson ea42644c8f Replace unnecessary let with two consts 2017-05-16 10:25:46 -07:00
Nathan Shively-Sanders 353d9e2310 Clean up original errors
The old "supplied parameters do not match any call signature" was
either inaccurate, redundant or vague. The previous commits fix the
vagueness problem. This commit fixes the inaccuracy and redundancy.

1. When there are NO candidates, the error should say so. (This only
happens once in our tests, when calling `super()` with a base class of
type `any` in a JS file.)
2. When the call is to a decorator, `resolveCall` already receives a
specific fallback error message from the decorator handling code. Adding
"supplied parameters do not match ..." is not helpful.

I also cleaned up the new code a bit after I noticed that all the error
creation functions take `string | number`, so I didn't need calls to
`toString` in my code.
2017-05-16 09:48:23 -07:00
Andy Hanson badfcbfb43 findAncestor: Add generic overload for use with type predicates 2017-05-16 09:45:01 -07:00
Andy Hanson ffa21fe271 getDeclarationOfKind: Improve type safety 2017-05-16 09:38:26 -07:00
Anders HejlsbergandGitHub 2a9a6e821f Merge pull request #15863 from Microsoft/fixRedundantTypeInference
Eliminate redundant work in type inference
2017-05-16 09:34:31 -07:00
Anders Hejlsberg ed1a6c10e2 Address CR feedback + defer creation of visited map 2017-05-16 09:12:32 -07:00
Nathan Shively-Sanders 381f056c68 Split error messages so they are localisable 2017-05-16 08:05:07 -07:00
Andy Hanson 2d3c7bae24 break -> continue 2017-05-16 07:10:38 -07:00
Arthur Ozga b2176c1872 no ascii escaping in param names 2017-05-15 19:11:36 -07:00
Arthur Ozga bba41a8a0c avoid ascii escaping literal text 2017-05-15 18:42:49 -07:00
Nathan Shively-Sanders 35a9be3b6c Improve arity errors for all calls
Not just ones with a single call signature.
This is pretty great!
2017-05-15 16:22:04 -07:00
Sheetal Nandi ea60e9966d Get configFiles as part of file names 2017-05-15 16:07:08 -07:00
Mohamed HegazyandGitHub d51e467238 Fix #15463: use intersection types to emulate spread in generic react components (#15851)
* Fix #15463: use intersection types to emulate spread in generic react components

* Fix lint errors

* reverse condition
2017-05-15 15:46:50 -07:00
Anders Hejlsberg e9ccb16642 Eliminate redundant exploration in type inference 2017-05-15 15:32:14 -07:00
Ron Buckton 05d2f2d5d9 Fix issue with throw in async delegator. 2017-05-15 15:28:55 -07:00
Nathan Shively-Sanders 93b1eafb9f Improve arity error messages
For calls with one signature.
2017-05-15 15:25:21 -07:00
Andy Hanson 4d028a81ee getTokenAtPositionWorker: Remove duplicate loop 2017-05-15 15:18:31 -07:00
Andy Hanson 0140e6df77 Remove goToImplementation test, not supported for parameters 2017-05-15 15:02:47 -07:00
Andy Hanson 38784b761a Support for JSDoc in services 2017-05-15 14:45:30 -07:00
Sheetal Nandi ec2f9670d9 Merge branch 'master' into ownJsonParsing 2017-05-15 11:36:45 -07:00
AndyandGitHub 687ab54d17 Merge pull request #15846 from Microsoft/findAllRefs_symbolNoName
findAllReferences: In `export default foo`, symbol name is `foo`
2017-05-15 10:38:21 -07:00
Nathan Shively-Sanders b61eaf70a1 Inline function that is called once 2017-05-15 10:31:47 -07:00
Arthur Ozga 20a4e32bec parenthesization in factory 2017-05-15 10:19:00 -07:00
Nathan Shively-Sanders 26416c32f3 Allow spreading arrays after required parameters
This allows:

1. Spreading arrays into all-optional parameters whose types match.
2. Spreading arrays into parameter lists that are too short and whose
body presumably uses `arguments`.
2017-05-15 10:17:36 -07:00
AndyandGitHub 278fb803b1 Merge pull request #15781 from Microsoft/inline
Inline resolvedModuleFromResolved
2017-05-15 09:51:01 -07:00
Andy Hanson 5eb2bd08ac findAllReferences: In export default foo, symbol name is foo 2017-05-15 08:34:05 -07:00
Dick van den Brink 8af5910555 Only report used before declaration errors on regular enums
const enums don't generate code and the values are inlined so now error is necessary
2017-05-15 14:55:17 +02:00
Arthur Ozga 6fd86b47f9 temp 2017-05-12 17:51:14 -07:00
Arthur Ozga 9e9054bd2b handle todo 2017-05-12 17:42:10 -07:00
Ron BucktonandGitHub 50e2912cd2 Merge pull request #15791 from Microsoft/fix13935
Adds CommaList to avoid large deeply nested comma expressions
2017-05-12 16:49:13 -07:00
Arthur Ozga a32bc985bf respond to comments 2017-05-12 16:27:35 -07:00
Alex Eagle 4240f6f5d9 Extract diagnostics formatter used by --pretty
This allows compilers other than tsc.js to display nice in-context diagnostics
2017-05-12 16:19:46 -07:00
Sheetal Nandi 303d7b209e Merge branch 'master' into completionListForClassElementDeclarations 2017-05-12 15:31:52 -07:00
Mohamed Hegazy ca748d6c02 Add insertSpaceAfterTypeAssertion to the server protocol 2017-05-12 14:48:13 -07:00
Arthur Ozga 0588f8b380 cleanup 2017-05-12 13:56:54 -07:00
Arthur Ozga 62dbf12825 Merge branch 'master' into typeToStringViaTypeNode 2017-05-12 13:09:43 -07:00
Mohamed HegazyandGitHub d68b436e7d Merge pull request #15789 from Microsoft/master-fix15742
[Master] fix15742
2017-05-12 12:22:43 -07:00
Sheetal Nandi 99ea9c730f Add the members of interfaces that need to be implemented to class element completion 2017-05-12 12:13:16 -07:00