Before this change, when failed lookup location didnt fall in root directory,
we tried to find the ancestor directory of the rootDirectory to watch.
We also created subDirectory map for the directories that are being watched so we dont go through invalidation if path is unwanted directory
With this change, we will watch those subdirectories instead of root. On windows node supports file system level recursive watching so the earlier approach was better because we reduced number of watches created
But on other os, since node doesnt support it, we create the watches for existing folders outselves, so earlier approach becomes expensive.
This should be better compromize to satisfy both types of OS.
Fixes#24434
A bug in checkSpecialAssignment added bogus duplicate identifier errors
when using module.exports assignment to export a class. This commit
fixes that.
* Skip IntrinsicAttributes elaboration in JSX errors
Do not issue an error message for a source type that comes from JSX
attributes and a target type that is an intersection containing
IntrinsicAttributes or IntrinsicClassAttributes. This will make error
messages simpler and less confusing.
Note:
1. There will always be elaboration under the skipped message, so this
won't elide errors completely.
2. Rarely (once in the tests) the intersection type will have more that
one non-Intrinsic* member. However, these additional members don't
provide useful information either, so it's fine to skip them.
* Add test of IntrinsicAttributes error
* Fix indentation in test
* fixUnusedIdentifier: Don't remove parameter in override or non-last parameter in callback
* Only allow removing last parameters; don't care about contextual type
* Callback tag:Disallow nested-object-param syntax
Previously this caused a crash in parsing. If/when we want to support
this syntax, we will need to fix this crash.
* Update baselines
* Fix to issue 23326 for completions on new.target
* Fixed linting issues - whitespace in if statements
* Removed debug statement in test case and consolidated and cleaned up code in switch statement for completions
* Added support for import.meta completion
* Fix to issue 6154 - Overriding a method with a property in the derived class should not cause a compiler error
* new baselines
* fixed deleted baselines
Sheetal Nandi
Nathan Shively-SandersandGitHub
Ryan Cavanaugh
Ron Buckton
Anders Hejlsberg
AndyandGitHub
Mohamed HegazyandGitHub
csigs
王文璐
Vyacheslav Pukhanov
Zzzen
falsandtru
Wesley WighamandGitHub
Elizabeth DinellaandGitHub