Commit Graph

21651 Commits

Author SHA1 Message Date
Andy e6980722a6 Fix bug: Report errors on extends expression in JS even if an @augments tag is present (#18854) 2017-10-02 10:33:53 -07:00
Ryan Cavanaugh 141cd574c7 Merge pull request #18603 from RyanCavanaugh/pluginWork
Report external files in initial case for project load
2017-10-02 10:32:04 -07:00
Andy a075ba9828 getSuggestionForNonexistentSymbol: Add comment (#18885) 2017-10-02 10:23:37 -07:00
Andy d11172c86e Use idText in a few more places (#18842) 2017-10-02 08:37:02 -07:00
Andy b883fcbfdd Enable "space-within-parens" lint rule (#18856) 2017-10-02 08:36:26 -07:00
Andy d821bbf3f3 Simplify RulesMap construction (#18858) 2017-10-02 08:36:09 -07:00
Ron Buckton 7eedf2e487 Update baselines 2017-10-01 13:04:00 -07:00
Daniel Rosenwasser e2c6aac414 Accepted baselines. 2017-09-30 00:11:23 -07:00
Daniel Rosenwasser a23d1bf3ea Updated helper for marginally better minification. 2017-09-30 00:06:20 -07:00
Daniel Rosenwasser 81b3e85592 Accepted baselines. 2017-09-29 23:05:38 -07:00
Daniel Rosenwasser f94bdedc79 Added test for module & global examples. 2017-09-29 23:01:33 -07:00
Daniel Rosenwasser 803b5660fc Accepted baselines. 2017-09-29 22:02:35 -07:00
Daniel Rosenwasser 86315ed411 Added test and adjusted reporting logic. 2017-09-29 22:01:00 -07:00
Andrew Casey bcc93f2c08 Loosen restriction on usages in innermost scope
Now that we're smarter about where we declare the extracted local, we
can ignore usage problems in the innermost script - it'll always have
access to the same symbols as the extracted expression.
2017-09-29 18:00:27 -07:00
Andrew Casey c08308a0f1 Reuse getSourceFileImportLocation 2017-09-29 17:37:39 -07:00
Daniel Rosenwasser 5da45fb6de Addressed code review feedback. 2017-09-29 17:16:50 -07:00
Daniel Rosenwasser d039942d9a Accepted baselines. 2017-09-29 17:13:50 -07:00
Daniel Rosenwasser 08ef6e4bea Accepted baselines. 2017-09-29 17:08:35 -07:00
Daniel Rosenwasser 966f370712 Use a better check. 2017-09-29 16:42:30 -07:00
Anders Hejlsberg 936f98d9ad Addressing CR feedback 2017-09-29 16:01:14 -07:00
Andrew Casey 9097a07758 Improve insertion positions of extracted constants
...mostly by putting them closer to the extraction site.

They now also follow all leading comments in a file (unfortunately,
including the doc comment on the first declaration).

Bonus: Special case declaration lists - declare the new variable as part
of the list, rather than before it, in case it depends on an earlier
entry.
2017-09-29 15:52:56 -07:00
Andrew Casey 7aee3a102c Merge pull request #18831 from amcasey/AdditionSpecialCase
Eliminate special case for extracting from a binary operator chain
2017-09-29 13:10:28 -07:00
Andy f71930c473 Print list of available refactors when we can't find one (#18843) 2017-09-29 11:08:45 -07:00
Sheetal Nandi 9e08caebf5 Merge branch 'master' into watchImprovements 2017-09-29 10:43:05 -07:00
Andy 683d6c7ddd Add helper functions for using unescapeLeadingUnderscores (#18793)
* Add helper functions for using `unescapeLeadingUnderscores`

* More cleanup
2017-09-29 09:57:31 -07:00
Anders Hejlsberg c626d9d47c Accept new baselines 2017-09-28 15:44:17 -07:00
Anders Hejlsberg 0756aa1753 Merge branch 'master' into strictFunctionTypes 2017-09-28 15:39:57 -07:00
Andrew Casey 8e4c559f2c Merge pull request #18829 from amcasey/JsExtractTests
Improve Extract* unit test coverage and correctness
2017-09-28 14:59:18 -07:00
Andrew Casey 41676248e5 Eliminate special case for extracting from a binary operator chain
1) It assumed left-associativity and was, therefore, wrong for (e.g.)
exponentiation.
2) Arguably, if a user selects `a + |b + c|`, they want to extract `b +
c`, not `a + b + c`.  Not being able to do so is surprising (and we may
eventually want to allow it), but so is having the rest of the
least-common subtree extracted.

Fixes #18268
2017-09-28 14:54:52 -07:00
Anders Hejlsberg 1609196b22 Accept new baselines 2017-09-28 14:34:03 -07:00
Anders Hejlsberg 5613be4907 Only methods and constructors are bivariant in --strictFunctionTypes mode 2017-09-28 14:33:35 -07:00
Andrew Casey a73a553f58 Assert that Extract* baselines are syntactically valid 2017-09-28 14:31:35 -07:00
Andrew Casey 0d5d5cdf28 For any Extract* baseline that is valid JS, produce a JS baseline 2017-09-28 14:13:48 -07:00
Andy 7959bd0a3d Check JSDoc @param tag names (#18777) 2017-09-28 13:44:38 -07:00
Andy 4bba6ee02e Support accessing enum types from JSDoc (#18703) 2017-09-28 13:43:39 -07:00
Andy 0b7dd5a4a5 Rename test baseline to be compatibile with windows (#18827) 2017-09-28 13:32:38 -07:00
Daniel Rosenwasser 0ea7c61eb5 Merge pull request #18810 from Microsoft/unusedErrorArgs
Remove unused arguments for diagnostics
2017-09-28 12:51:57 -07:00
Armando Aguirre a39110add9 Merge pull request #18806 from armanio123/FixScriptBlockFormatting
Fixed formatting on script blocks
2017-09-28 12:35:32 -07:00
Andy 1a2de721b5 Fixes to @augments handling (#18775)
* Fixes to @augments handling

* Renames and diagnostic changes

* Add test for < > characters

* Use more specific return type
2017-09-28 12:34:54 -07:00
Nathan Shively-Sanders d797b4ab76 Correctly transform jsdoc parameter types
And give a better name for rest params
2017-09-28 11:40:56 -07:00
Andrew Casey 8e7a5bac92 Merge pull request #18824 from amcasey/ExtractFunctionRename
Rename extractMethod tests to extractFunction for consistency
2017-09-28 10:58:34 -07:00
Andrew Casey 49d24fd89e Rename extractMethod tests to extractFunction for consistency 2017-09-28 10:36:16 -07:00
Armando Aguirre 5225b40aab Addedn rangeContainsRange helper function 2017-09-28 10:23:30 -07:00
Andrew Casey 5f30106269 Merge pull request #18783 from amcasey/ExtractConstant
Initial implementation of Extract Constant
2017-09-28 10:09:44 -07:00
Andy a92d315eb6 Remove unnecessary cast (#18822) 2017-09-28 09:57:32 -07:00
Nathan Shively-Sanders 724a813105 Merge branch 'master' into refactor-jsdoc-types-to-typescript 2017-09-28 09:17:28 -07:00
Daniel Rosenwasser 76d92a5dd6 Remove unused arguments in program.ts. 2017-09-27 22:04:52 -07:00
Daniel Rosenwasser 9b77dd6a98 Merge pull request #16595 from alexeagle/pretty
--pretty diagnostics: move context after the file/error
2017-09-27 21:41:36 -07:00
Daniel Rosenwasser fbbf3d22e3 Accepted baselines. 2017-09-27 20:56:59 -07:00
Daniel Rosenwasser b029857528 Give a more helpful error message when users try decorating using expressions that take no arguments. 2017-09-27 20:46:42 -07:00