Commit Graph
21714 Commits
Author SHA1 Message Date
Josh Goldberg ca00b3248b Added --noImplicitThis code fix for functions used as object properties (#31138)
* Added --noImplicitThis code fix for functions used as object properties

Before trying out all the various possibilities for where these functions could be used, I figured I'd start out with a relatively simple use case to verify this is the right approach. Is it? 😄

Starts on #28964.

* Fixed function expression names; included new baselines

* Got JSDocs to work, hooray!

* Added test for 'any' case of no function uses

* Refactored for inferFunctionReferencesFromUsage

* Fixed inference bug: undefined references cause parameters to default

* Removed dead code comments
2019-06-17 19:00:15 -07:00
Andrew Branch 04fbd93bf8 Revert previous fix and improve error message instead 2019-06-17 15:21:21 -07:00
Ron Buckton 179381301e Move class property transform (#31848)
* Revert "Revert "Move class property transformation into new transformer. (#30467)""

This reverts commit 53467ae4a4.

* Fix emit issues
2019-06-17 14:26:42 -07:00
Orta Therox f1a0a7f863 Don't let the additional property setting on an object show up as a definition for the lanmguage server 2019-06-17 13:30:39 -07:00
Anders Hejlsberg 32584249b2 Union array literals in inference similar to object literals 2019-06-17 08:37:33 -10:00
Andrew Branch 48f74fdf80 Consider non-public literal members in index type of constrained type parameters 2019-06-14 17:29:39 -07:00
Nathan Shively-Sanders b4b5bf04a1 Fix lint 2019-06-14 16:07:41 -07:00
Nathan Shively-Sanders 3ef953a819 Allow passing skipPercent
Currently, the default is 5%.

0 gives you 0% time savings
2.5 gives you 29%
5 gives you 38%
10 gives you 50%
20 gives you 65%
2019-06-14 15:59:39 -07:00
Andrew Branch 54f5f2baf2 Fix smartSelection returning extra span inside string quotes when cursor is outside them 2019-06-14 15:50:09 -07:00
Nathan Shively-Sanders a852f2feea Skip costly tests
1. Add a script to generate a sorted list of most costly tests. A tests'
cost is roughly `runtime% / number of edits`. A slow test that's only
been updated once is much less valuable than a slow test that has
been updated 20 times: the latter test is catching more changes in the
type system.

2. Check in the results of running this script. I want to make the
skipping behaviour deterministic and the same for everybody, even though
you may get slightly better performance by examining only *your* test
changes.

3. Add code to skip tests until it reaches a 5% chance of missing an
edit. Right now this provides a 38% speedup.

Still not done:
4. Make this value configurable.
5. Make the CI configuration specify a 0% chance of missing an edit.
2019-06-14 13:35:41 -07:00
Alexander T a18aeee1eb @typescript-eslint/no-unnecessary-qualifier 2019-06-14 12:34:28 +03:00
Alexander T 627211b06b quotes 2019-06-14 12:18:27 +03:00
Alexander T 650600c5e4 linebreak-style 2019-06-14 11:58:42 +03:00
Alexander T f611ec68ed microsoft-typescript/no-double-space 2019-06-14 11:52:48 +03:00
Alexander T 65ddc1fef2 microsoft-typescript/type-operator-spacing 2019-06-14 11:48:52 +03:00
Alexander T a96a08a329 microsoft-typescript/boolean-trivia 2019-06-14 11:17:49 +03:00
Alexander T 4e6fb72737 no-new-func 2019-06-14 11:02:15 +03:00
Alexander T bea1bcb466 brace-style 2019-06-14 10:51:09 +03:00
Alexander T 1cc0ff22c1 no-eval 2019-06-14 10:25:02 +03:00
Alexander T 123ca0d639 no-empty 2019-06-14 10:21:51 +03:00
Alexander T d8796d5eaf @typescript-eslint/no-this-alias 2019-06-14 10:16:19 +03:00
Alexander T f96fb53e4c no-restricted-globals 2019-06-14 10:12:06 +03:00
Alexander T 1ccb4d2d82 microsoft-typescript/debug-assert 2019-06-14 10:00:33 +03:00
Alexander T f6ccfb39cc @typescript-eslint/semi 2019-06-14 09:46:02 +03:00
ExE Boss 81f71530c4 fix(lib): Fix RegExp constructor with string|RegExp and flags (#30586) 2019-06-13 15:38:11 -07:00
Sheetal Nandi 73bf2684ac Rename to use contextSpan 2019-06-13 12:41:21 -07:00
Wesley Wigham 74c6bc1f85 Filter primitives from union when checking for mismatched excess props if nonprimitive type is present (#31708)
* Filter primitives from union when checking for mismatched excess props if nonprimitive type is present

* Use maybeTypeOfKind
2019-06-12 17:31:57 -07:00
Sheetal Nandi da2aa9781e Revert to using spread instead of mutating value later 2019-06-12 15:25:16 -07:00
Sheetal Nandi a0d164f142 Merge pull request #31820 from microsoft/nodeModules
When resolving from typings cache, handle node code modules
2019-06-12 10:55:26 -07:00
Sheetal Nandi 520f7e8067 Merge pull request #31818 from microsoft/sharepointIssue
Do not watch tsconfig files from folders that we canot watch (because they are at roots we want to ignore)
2019-06-12 10:47:17 -07:00
Benjamin Lichtman 0628adc056 Merge pull request #31865 from amcasey/FunctionHintSpan
Correct outline hint spans for functions
2019-06-12 10:13:21 -07:00
Andrew Casey 1bf28f21de Add regression test 2019-06-11 17:50:36 -07:00
Andrew Casey 65881602b6 Correct outline hint spans for functions 2019-06-11 16:58:08 -07:00
Ron Buckton 375487ec60 Add __spreadArrays helper (#31166) 2019-06-11 14:15:57 -07:00
Anders Hejlsberg ad322a561a Merge pull request #31838 from microsoft/emptyIntersectionReduction
Empty intersection reduction
2019-06-11 12:25:51 -07:00
Anders Hejlsberg 3a1fb1bea6 Properly preserve CheckFlags.Readonly when widening properties 2019-06-11 09:25:00 -07:00
Daniel Rosenwasser d023427226 Merge pull request #31831 from shibukawa/patch-1
Fix es2019.string.d.ts
2019-06-10 16:13:38 -07:00
Daniel Rosenwasser a7a0c3300d Improve ts6307 error (#31706)
Improve ts6307 error
2019-06-10 15:17:49 -07:00
Daniel Rosenwasser 79aff027f3 Merge pull request #31290 from a-tarasyuk/bug/29880
29880 - No completions for computed string properties
2019-06-10 13:45:58 -07:00
Anders Hejlsberg d2397e0380 Fix minor issue 2019-06-09 10:05:55 -07:00
Anders Hejlsberg d4c9f24577 Intersections of disjoint types become never upon construction 2019-06-09 07:46:13 -07:00
Yoshiki Shibukawa 24a2ed7d83 Fix es2019.string.d.ts
trimLeft and trimRight's comments are swapped.
2019-06-09 08:43:38 +09:00
Sheetal Nandi 2fd80b3142 When resolving from typings cache, handle node code modules
Fixes #29865
2019-06-07 16:21:39 -07:00
Sheetal Nandi 6ed8aae683 Test when node typings dont get added on subsequent update graph because of invalid typing
Test for #29865
2019-06-07 16:19:56 -07:00
Sheetal Nandi a6c72a0cf3 Do not watch tsconfig files from folders that we canot watch
Fixes #30818
2019-06-07 12:10:21 -07:00
Anders Hejlsberg 4856768212 Merge branch 'master' into wideningInAccessExpressions 2019-06-07 11:52:24 -07:00
Anders Hejlsberg 69706bd064 Merge branch 'master' into wideningInAccessExpressions 2019-06-07 10:54:39 -07:00
gb714us 7acca501b6 create outlining span for JsxFragment 2019-06-07 03:48:19 -07:00
Andrew Branch 53467ae4a4 Revert "Move class property transformation into new transformer. (#30467)"
This reverts commit 3139cf2f85.
2019-06-06 17:40:02 -07:00
Nathan Shively-Sanders bdf8d5c8cb Update DOM and baselines 2019-06-06 15:13:16 -07:00