Commit Graph

32750 Commits

Author SHA1 Message Date
Sheetal Nandi 796302294f Review feedback 2018-08-10 14:44:44 -07:00
Sheetal Nandi c8e10a9a66 Merge pull request #26296 from ajafff/modulenameresolver-cache
fix moduleNameResolver cache
2018-08-10 14:36:54 -07:00
Andy 4bb740218d getDefaultExportInfo: Use getImmediateAliasedSymbol instead of getAliasedSymbol (#26364) 2018-08-10 14:35:18 -07:00
Sheetal Nandi 9ba224d3b0 Merge pull request #26305 from ajafff/common-prefix
moduleNameResolver: fix getCommonPrefix
2018-08-10 13:35:24 -07:00
Klaus Meinhardt 3469b62be6 review comments 2018-08-10 22:25:27 +02:00
Klaus Meinhardt 4db7c869e5 restore old algorithm 2018-08-10 22:11:16 +02:00
Wesley Wigham 19e04b2cdb Dont use baseURL relative absolute paths in declaration emit, use absolute paths in bundle emit (#26341) 2018-08-10 12:54:45 -07:00
Andy Hanson ac460e30e7 code review 2018-08-10 11:50:39 -07:00
TypeScript Bot ef7997cb73 Update user baselines (#26358) 2018-08-10 10:27:14 -07:00
王文璐 6432bd9def check index access for fixed length tuple 2018-08-10 10:49:37 +08:00
Andy a73161e9d5 Don't store @template constraint in a TypeParameterDeclaration node (#26283)
* Don't store @template constraint in a TypeParameterDeclaration node

* Code review

* Update API
2018-08-09 17:39:15 -07:00
Andy 5efd1cb4a7 fixAddMissingMember: Support interface and don't crash on type parameter (#25995)
* fixAddMissingMember: Support interface and don't crash on type parameter

* Remove InfoBase
2018-08-09 17:32:28 -07:00
Andy 639fdcc916 Don't include class getter in spread type (#26287)
* Don't include class getter in spread type

* Code review
2018-08-09 15:34:29 -07:00
Andy 55a620c433 Don't crash on computed property in destructure (#26334) 2018-08-09 15:29:45 -07:00
Anders Hejlsberg df2af29977 Accept new baselines 2018-08-09 16:34:01 -04:00
Anders Hejlsberg 89a8b5094a Add test 2018-08-09 16:33:54 -04:00
Anders Hejlsberg 8ff8008fc0 Make T[K] yield never when T is never 2018-08-09 16:31:54 -04:00
Wesley Wigham fce3d9f34d Check the ambientness of a symbol name before attempting to trim it (#26312)
* Check the ambientness of a symbol name before attempting to trim it

* Use find instead of forEach, remember to also exclude global augmentations
2018-08-09 13:20:37 -07:00
Wesley Wigham f6af618ab9 Still generate signatures in SkipContextSensitive mode just to match on return types (#25937)
* Still generate signatures in SkipContextSensitive mode just to match on return types

* Add cache for context-free type of a signature node

* Accept post-merge baseline
2018-08-09 10:17:50 -07:00
Andy Hanson 77494d6294 getScriptInfoOrConfig: Canonicalize tsconfig path before lookup 2018-08-09 08:19:57 -07:00
Anders Hejlsberg 01f6093a9c Merge pull request #26143 from mattmccutchen/issue-26130
Have getAssignmentReducedType use the comparable relation instead of typeMaybeAssignableTo.
2018-08-09 07:43:46 -07:00
Anders Hejlsberg 20ebe1eb2b Merge pull request #26244 from Microsoft/fixThisAndContextualTypes
Revise logic that computes the contextual type for a parameter
2018-08-09 06:07:11 -07:00
Klaus Meinhardt d2dc17d765 fix handling if there is no commonPrefix 2018-08-09 11:50:00 +02:00
王文璐 23601a10b8 improve completions for union type in type arguments 2018-08-09 17:26:34 +08:00
Wesley Wigham a36a53bfdb Actually add sorting of elaboration text to user baselines 2018-08-08 13:40:21 -07:00
Wesley Wigham c6fd0c8d29 Ping ryan instead of mohammed for user PRs now 2018-08-08 13:36:03 -07:00
Klaus Meinhardt 711b5660cb unittests/moduleResolution: actually assert in checkResolvedModule
this change uncovered a bug in testPreserveSymlinks which always silently failed
2018-08-08 21:16:09 +02:00
Klaus Meinhardt 20442fe363 handle failed lookups 2018-08-08 20:45:31 +02:00
Klaus Meinhardt 95082e4743 make it work for root directory 2018-08-08 20:29:59 +02:00
Ryan Cavanaugh 6210b7db54 Merge pull request #26245 from Kingwl/fix-compiler-crash
fix compiler crash (#26209)
2018-08-08 11:12:16 -07:00
Klaus Meinhardt ec1ff29a8c really, really fix test(?) 2018-08-08 17:10:22 +02:00
Klaus Meinhardt 27d2a2d564 add test 2018-08-08 17:05:31 +02:00
Klaus Meinhardt 95494efe50 fix commonPrefix handling 2018-08-08 16:58:35 +02:00
Klaus Meinhardt f31b9d3891 fix test 2018-08-08 16:38:42 +02:00
Klaus Meinhardt 47e77901fd actually test the cache 2018-08-08 15:39:07 +02:00
Klaus Meinhardt bed93b48f5 fix moduleNameResolver cache
Fixes: #26271
2018-08-08 11:12:48 +02:00
Andrew Casey daccc978a8 Don't compute suggestion diagnostics for lib files
The check applied to semantic diagnostics (and `checkSourceFile`) should
also apply to suggestion diagnostics.  Fixes assert.
2018-08-07 17:58:35 -07:00
Andy 1a05f13aef moveToNewFile: Don't remove empty named imports (#26265) 2018-08-07 12:54:46 -07:00
Andy 794f3a5e76 goToTypeDefinition: Go to function return type (#25952)
* goToTypeDefinition: Go to function return type

* Add more tests

* If a function returns 'void' or some other type with no definition, just return the function definition.
2018-08-07 12:54:19 -07:00
Andy eaf0d59d35 Fix bug: symbol.valueDeclaration not guaranteed to be defined (#26267) 2018-08-07 12:13:45 -07:00
Wesley Wigham 32e99ba8f9 Add TEST-results.xml to the gitignore 2018-08-07 10:48:45 -07:00
Ryan Cavanaugh 3fde17e85c Merge pull request #26234 from RyanCavanaugh/noVoidTest
Disallow expressions of type `void` to be used in truthiness checks
2018-08-07 08:37:42 -07:00
王文璐 639190d607 fix compiler crash (#26209) 2018-08-07 10:09:26 +08:00
Andy 937afab4b0 Support signature help for contextual parameter type (#26022) 2018-08-06 16:46:30 -07:00
Anders Hejlsberg eeb19c1e22 Merge pull request #26236 from Microsoft/fixCircularReturnType
Fix circular return type issue
2018-08-06 16:38:31 -07:00
Anders Hejlsberg 9d71023b5c Add fourslash tests 2018-08-06 16:33:21 -07:00
Sheetal Nandi f67bdd429a Skip loading configured project just to report project info through synchronizeProjectList for project opened by external project 2018-08-06 16:24:14 -07:00
Ryan Cavanaugh ca10b7a6fa Add checks for remaining truthiness positions 2018-08-06 16:11:43 -07:00
Anders Hejlsberg bf19d214f3 Revise logic that computes the contextual type for a parameter 2018-08-06 16:10:10 -07:00
Sheetal Nandi 8c4607d8eb Dont delay external project update from openExternalProject
Since external projects are needed to be uptodate when opening file,
so in most likely scenarios these will be loaded anyways so there is no saving in postponing this work
2018-08-06 16:06:40 -07:00