Commit Graph

32750 Commits

Author SHA1 Message Date
Collins Abitekaniza f70f8eb70d refactor baseline 2018-10-16 07:57:02 +03:00
Sheetal Nandi cb954cbb0a Merge pull request #27871 from Microsoft/formatting
Handle when advancing past , of call expression moves past endPos of formatting
2018-10-15 21:10:09 -07:00
Collins Abitekaniza 66b299dc6e refactor diagnostics 2018-10-16 06:59:00 +03:00
Collins Abitekaniza 2e993230e6 use decl key value if any 2018-10-16 06:59:00 +03:00
Sheetal Nandi 3aa33aa4ed Simplify the test 2018-10-15 15:55:45 -07:00
Anders Hejlsberg 04fd365ec3 Merge pull request #27911 from Microsoft/fixCircularMappedType
Fix circular mapped type instantiations for arrays and tuples
2018-10-15 15:51:31 -07:00
Daniel Rosenwasser b852f3a428 Merge pull request #27898 from nd-02110114/patch-1
Delete the link which doesn't work in CONTRIBUTING.md
2018-10-15 14:02:08 -07:00
Anders Hejlsberg 9767522ca0 Merge pull request #27695 from Microsoft/mixedDiscriminantTypes
Allow non-unit types in union discriminants
2018-10-15 13:10:27 -07:00
Nathan Shively-Sanders c184184713 Add getEffectiveConstructSignatures (#27561)
* Add helpers that understand constructor functions

* getEffectiveConstructSignatures gets construct signatures from type, and
  call signatures from constructor functions if there are no construct
  signatures.
* getEffectiveConstructSignatureReturnType gets the "JS Class type" for
  constructor functions, and the return type of signatures for all other
  declarations.

This is a first step toward making constructor functions have construct
signatures instead of call signatures, which will also contribute to
fixing instantiation of generic constructor functions, which is basically
broken right now.

Note that the baselines *improve* but, because of the previously
mentioned generic problem, are still not correct. Construct signatures
for constructor functions and generic constructor functions turns out to
be an intertwined problem.

* Correct correct originalBaseType

And, for now, return anyType for generic constructor functions used as
base types. Don't give an incorrect error based on the function's return
type, which is usually void.

* Add error examples to tests

* Add construct signatures instead of getEffective* functions

* Fix typo in baseline

* Remove pesky newline

I thought I got rid of it!

* Test of constructor tag on object literal method

It doesn't work, and shouldn't in the future, because it's a runtime
error.
2018-10-15 12:47:57 -07:00
Anders Hejlsberg 3930525678 Accept new baselines 2018-10-15 10:24:10 -07:00
Anders Hejlsberg 0c3221c220 Add regression test 2018-10-15 10:24:00 -07:00
Anders Hejlsberg 709f5f2fc4 Handle circular mapped type instantiations for arrays and tuples 2018-10-15 10:18:54 -07:00
TypeScript Bot bb275b999c Update user baselines (#27905) 2018-10-15 08:08:33 -07:00
Daiki Nishikawa b94dfd9cea delete link 2018-10-15 10:03:01 +09:00
Sheetal Nandi e3bfec5217 Handle when advancing past , of call expression moves past endPos of formatting
Fixes #26513
2018-10-12 16:06:24 -07:00
Andy 54a5be1860 At '.' in object literal, don't close the object (#27850)
* At '.' in object literal, don't close the object

* Include diagnostics test
2018-10-12 08:49:04 -07:00
Andrey Roenko 15b4af63dd #27716: fix protected methods for intersection fo generic classes 2018-10-12 18:23:07 +03:00
Sheetal Nandi 12cd3ea6ac Merge pull request #27849 from Microsoft/unionWithIndexedLiteral
Use string/number signature to get contextual type
2018-10-11 17:50:16 -07:00
Nathan Shively-Sanders ec0e8cbe2b noImplicitAny as suggestion (#27693)
* noImplicitAny as suggestion

Note that not all noImplicitAny errors turn into suggestions. In
particular,

1. reportErrorsFromWidening does not, because it doesn't log an error
that infer-from-usage fixes, and fixing it would require
otherwise-unnecessary code.
2. auto types do not have implicit any suggestions, because that would
require running control flow in noImplicitAny mode.

* Rename reportImplicitAny+forbid it for non-checkJS

In JS, you only get implicit any errors/suggestions with checkJS or
ts-check turned on.

* Update baselines

* Use isCheckJsEnabledForFile

* Remove noImplicitAny parameter since it's in scope already
2018-10-11 16:15:38 -07:00
Sheetal Nandi 99b271853a Merge pull request #27844 from Microsoft/includeJson
Allow files to be included by `*.json` pattern in include of tsconfig
2018-10-11 15:48:44 -07:00
Sheetal Nandi 9cda8d61fa Merge pull request #27714 from Microsoft/okToSkipJsonOverrite
Skip writing json file if it is going to overwrite same location
2018-10-11 15:48:28 -07:00
Matt McCutchen d19fb98ec6 When instantiating a mapped type, clone the type parameter. (#27597)
This gives the type parameter returned by getTypeParameterFromMappedType
an accurate constraint.

Fixes #27596.
2018-10-11 15:45:51 -07:00
Sheetal Nandi c0729a22fd Use string/number signature to get contextual type
Fixes #26587
2018-10-11 15:12:13 -07:00
Sheetal Nandi 92f3f1cde0 Allow files to be included by *.json pattern in include of tsconfig
Fixes #25636
2018-10-11 14:45:27 -07:00
Nathan Shively-Sanders 4d504f9b30 assertNever special-cases nodes with SyntaxKind (#27712)
* assertNever special-cases nodes with SyntaxKind

* Fix single-quote lint

* Use stringify when not a node
2018-10-11 12:33:29 -07:00
Sheetal Nandi 578f8db7d9 Add test cases for transitive reference with different module resolution 2018-10-11 12:26:19 -07:00
Anders Hejlsberg 5a126e2b27 Merge pull request #27587 from Microsoft/fixUnionOfTupleIndexing
Fix indexing and destructuring of unions of tuple types
2018-10-11 12:01:24 -07:00
Sheetal Nandi ae1bd8bc33 Merge branch 'master' into transitiveReferences 2018-10-11 11:33:23 -07:00
Sheetal Nandi 2787a2793a Skip writing json file if it is going to overwrite same location
Fixes #24715
2018-10-11 11:12:44 -07:00
Sheetal Nandi 6365eb05f4 Merge pull request #27715 from Microsoft/handleEmitDeclarationOnly
Do not generate jsFile path if its emitOnlyDeclarations is set
2018-10-11 11:08:40 -07:00
Sheetal Nandi 0d91838593 Do not generate jsFile path if its emitOnlyDeclarations is set
Fixes #27009
2018-10-11 10:14:59 -07:00
Anders Hejlsberg b040ea66d1 One more CR fix 2018-10-11 10:13:36 -07:00
TypeScript Bot d493c47aac Update user baselines (#27710) 2018-10-11 09:58:25 -07:00
Anders Hejlsberg dd6365615d Address CR feedback 2018-10-11 08:45:47 -07:00
Sheetal Nandi b2bae85cce Merge pull request #27609 from Microsoft/betterStaticError
Report the errors for static incompatibility only if instance types are assignable
2018-10-10 15:42:46 -07:00
Sheetal Nandi 3e91652640 Merge pull request #27688 from Microsoft/fixTsBuildIncrementalNoErrorScenario
Remove any existing errors in case of successful build in tsbuild watch mode
2018-10-10 15:42:31 -07:00
Anders Hejlsberg 6cdba6d351 Accept new baselines 2018-10-10 15:40:19 -07:00
Anders Hejlsberg 22907bfb07 Add tests 2018-10-10 15:40:12 -07:00
Anders Hejlsberg 7737cd5f1f Accept new baselines 2018-10-10 15:11:57 -07:00
Anders Hejlsberg c110f57deb Discriminant must include at least one unit type and no instantiable types 2018-10-10 15:11:35 -07:00
Andy dd764b318f importFixes: Skip alias when testing isTypeOnlySymbol (#27674) 2018-10-10 13:45:52 -07:00
Sheetal Nandi ba0f5581f6 Remove any existing errors in case of successful build in tsbuild watch mode
Fixes #27685
2018-10-10 12:52:34 -07:00
Ryan Cavanaugh fc788393ab Merge pull request #26810 from Kingwl/fix_lookup_regression_again_and_again
fix lookup regression again and again
2018-10-10 09:44:37 -07:00
王文璐 20054d9e10 Merge branch 'master' into fix_lookup_regression_again_and_again 2018-10-10 15:24:03 +08:00
Anders Hejlsberg d0698751ce Allow discriminant property to contain some non-unit types 2018-10-09 18:41:58 -07:00
Andy Hanson 0933155706 Always emit related diagnostic when a call expression can be fixed by adding a semicolon 2018-10-09 16:04:25 -07:00
Sheetal Nandi 07966dcb12 Merge pull request #27643 from Microsoft/simpleTypeMap
Converted legacySafelist to map to avoid using array prototype methods accidently to match with filename
2018-10-09 14:11:10 -07:00
Sheetal Nandi 88f79de9f4 Merge branch 'master' into transitiveReferences 2018-10-09 14:03:58 -07:00
Sheetal Nandi 23ec0c4484 Accept public api change 2018-10-09 13:45:17 -07:00
Sheetal Nandi 51ff0d32da Merge pull request #27625 from Microsoft/fileAddedWithAmbientModule
Use ambient modules as references to keep track of reporting and usage of modules correctly
2018-10-09 13:43:12 -07:00