4e0bb7a80a
Fix typo comment
2018-11-11 19:03:46 -08:00
7017d1a9ef
Merge branch 'master' into async-es2018
2018-11-12 11:04:21 +09:00
3dfd9c1b9b
Add test for #28468
2018-11-11 18:47:02 +01:00
293eba6203
Change isolatedModules to allow const enum declaration and disallow access
...
Fixes #20703 with solution suggested in https://github.com/Microsoft/TypeScript/issues/20703#issuecomment-361434795
Previously, `--isolatedModules` gave an error for any ambient const enum, which
meant that some third-party libraries would always give errors even if the
ambient const enums they declare were never used. Now, we only give an error
when an ambient const enum is referenced, which allows such libraries to still
be used as long as the const enums are never accessed.
Some nuances:
* As before, the error is only surfaced for *ambient* const enums. With
non-ambient const enums, we know that an `isolatedModules` build will emit the
enum and produce a plain reference rather than inlining the constant, so
everything will still work.
* I originally planned to do this check in the code path that inlines the
constant, but that code is only exercised at emit time, so, for example, the
TS language service wasn't giving an error in my editor. Instead, I do the
check at typecheck time next to another const-enum-related check.
* This can be a breaking change when using `skipLibCheck` because the error is
typically moved from a .d.ts file to a .ts file.
Testing done:
I ran this TS build on a large project of mine that previously had disabled
`isolatedModules` so I could use the `chalk` library. With `isolatedModules`
enabled, there was no longer an error in the chalk typedefs, and a reference to
the `Level` const enum produced an error in my editor.
2018-11-10 14:47:05 -08:00
a2205ad53d
Merge pull request #28429 from Microsoft/fixEmptyObjectIntersection
...
Fix empty object intersections
2018-11-10 00:44:57 -08:00
15d28d6c8e
Update user baselines ( #28457 )
2018-11-09 17:54:23 -08:00
b0d85c0270
Merge pull request #28450 from Microsoft/libErrors
...
Remove lib file errors from builder cache when global files are to be emitted
2018-11-09 17:42:08 -08:00
7d4e0e6297
Fix duplicated amd module comments in declaration bundle ( #28451 )
2018-11-09 17:18:34 -08:00
1b8bfc832a
Check modifiers on variable like declarations only
2018-11-09 17:13:39 -08:00
146afddae1
Accepted baselines.
2018-11-09 17:09:16 -08:00
d6df82a77c
Merge pull request #28454 from Microsoft/codeFixAfterPrologue
...
Include code fix after prologue
2018-11-09 16:56:43 -08:00
941d97c45a
Handle global augmentation in the module
2018-11-09 16:41:18 -08:00
43c447867b
PR feedback
2018-11-09 16:24:19 -08:00
17b77dfdce
Accepted baselines.
2018-11-09 16:21:16 -08:00
15f2f047f8
Updated test case.
2018-11-09 16:21:06 -08:00
f7ad54b432
Only complain about BigInt literals in pre-ESNext targets.
2018-11-09 16:20:54 -08:00
c60ff902f1
Include code fix after prologue
...
Fixes #15515
2018-11-09 16:02:16 -08:00
047b76f979
Merge branch 'master' into codefix_add_missing_new_operator
2018-11-10 01:45:11 +02:00
02ca5bebbf
Merge pull request #28340 from saschanaz/listindent-revive
...
List position based formatting
2018-11-09 15:34:16 -08:00
50a0174582
Merge pull request #27629 from Microsoft/sourceMapGenerator
...
Simplify source map generation
2018-11-09 14:50:22 -08:00
fdafbd6e95
Report identical modifiers needed error when checking the file instead of reporting it as part of another file's type check
2018-11-09 14:43:32 -08:00
2585ccbe39
Merge pull request #28281 from ryanclarke/master
...
Add codefix for 'convert to unknown' diagnostic
2018-11-09 14:43:25 -08:00
a27b29f025
Remove lib file errors when all files are to be emitted.
...
Fixes #26389
2018-11-09 14:43:01 -08:00
6927bc74fd
Remove SortedUniqueList
2018-11-09 14:32:31 -08:00
e335a360c8
Change 'if' in combined switch case to two separate cases ( #28444 )
2018-11-09 12:48:47 -08:00
c0e5c80e53
Add exports of current module to getSymbolsInScope ( #28442 )
2018-11-09 12:48:10 -08:00
b48c2b295d
Merge pull request #24396 from falsandtru/lib/Symbol.toStringTag
...
Don't constrain string tag values
2018-11-09 12:29:46 -08:00
89a58aee14
Merge pull request #28438 from Microsoft/maxNodeModuleJsDepth
...
Add affectsModuleResolution to compile options: maxNodeModuleJsDepth
2018-11-09 12:29:09 -08:00
972a149d4a
Update Feature_request.md
2018-11-09 12:24:09 -08:00
0010a38660
Merge pull request #28343 from Microsoft/lib/update-nov-2018
...
Lib update Nov 2018
2018-11-09 12:06:41 -08:00
151dc074a8
Merge branch 'master' into sourceMapGenerator
2018-11-09 11:50:51 -08:00
c77f0c41c2
Add affectsModuleResolution to compile options: maxNodeModuleJsDepth
...
Fixes inferred project incorrectly modifying existing compiler options
Fixes #27108
2018-11-09 10:48:28 -08:00
93206993ed
Merge pull request #28436 from Microsoft/circularTransitiveExports
...
Use seen map to avoid circular transitive exports to cause stack overflow
2018-11-09 09:46:05 -08:00
aaf1d8055b
Support finding references at module in module.exports = or export in export = ( #28221 )
...
* Support finding references at `module` in `module.exports =` or `export` in `export =`
* Add json test
2018-11-09 09:38:45 -08:00
9dbe037e84
Use seen map to avoid circular transitive exports to cause stack over flow
...
Fixes #28433
2018-11-09 09:22:39 -08:00
69c61cd166
Merge pull request #27988 from KnisterPeter/fix24931
...
Correct codefix by removing private modifier
2018-11-09 08:47:49 -08:00
e1dc52f06e
add more testcases
2018-11-09 09:51:51 +01:00
499bed540b
Better reference usage detection
2018-11-09 09:45:20 +01:00
6bd298b884
add test for remove modifier and parameter
2018-11-09 09:45:12 +01:00
13e85ac3a9
add more modifiers
2018-11-09 09:45:12 +01:00
d411fa34a7
Add test case for codeFix
2018-11-09 09:45:11 +01:00
de7faa1b7e
Remove obsolte ts namespace
2018-11-09 09:45:11 +01:00
e6e71978df
Correct codefix by removing private modifier
...
In case of private attribute and private constructor parameter with
assignment in the constructor body, the parameter is flagged as unused.
This is caused by the private modifier which is shadowed by the
explicity assignment in the body.
This commit updates the codefix to just remove the private modifier in
this cases.
Closes #24931
2018-11-09 09:45:11 +01:00
187fa20bf2
Accept new baselines
2018-11-09 06:45:41 +01:00
627f1ad876
Add regression tests
2018-11-09 06:45:21 +01:00
6b641de465
LEGO: Merge pull request 28428
...
LEGO: Merge pull request 28428
2018-11-08 20:10:40 -08:00
23b7284ca3
LEGO: check in for master to temporary branch.
2018-11-09 04:10:18 +00:00
7995f9153a
apply suggested changes
2018-11-09 11:26:58 +09:00
62419bb103
Merge pull request #28419 from Microsoft/elaborateAssert
...
Elaborate assert of infos attached to project
2018-11-08 15:45:38 -08:00
c0587191fc
Merge pull request #28418 from ajafff/internal-comments
...
remove even more internal comments
2018-11-08 14:58:33 -08:00
Michael Tang
Kagami Sascha Rosylight
Klaus Meinhardt
Alan Pierce
Anders Hejlsberg
TypeScript Bot
Sheetal Nandi
Wesley Wigham
Daniel Rosenwasser
iliashkolyar
Daniel Rosenwasser
Ron Buckton
Andy
BigAru
Markus Wolf
csigs
csigs