Commit Graph

28909 Commits

Author SHA1 Message Date
Wesley Wigham 96937fd592 Allow union signatures to merge when they have differing argument counts (#28604)
* Allow union signatures to merge when they have differing argument counts

* Accept updated baselines

* Adjust comments io changed tests
2018-11-19 17:05:28 -08:00
Sheetal Nandi ddded2df7c Merge pull request #28610 from Microsoft/resolvedReferencedDirectMap
Create map from fileNames in referenced projects to resolvedProjectReference for quick determination of fileName to projectReferenceRedirect
2018-11-19 16:58:48 -08:00
Sheetal Nandi 979dac3ced Create map from fileNames in referenced projects to resolvedProjectReference for quick determination of fileName to projectReferenceRedirect 2018-11-19 14:55:41 -08:00
Sheetal Nandi 07769483e7 Merge pull request #28607 from Microsoft/extendedDiagnostics
Enable statistics reporting per program through temporary build api
2018-11-19 14:25:50 -08:00
Klaus Meinhardt 12ef619dc6 resolve TypeReference in class decorator at parent of class
Fixes: #28603
2018-11-19 22:39:01 +01:00
Nathan Shively-Sanders 0774bb81ce Fix crash on property assignment of unresolved module (#28606)
Previously, the compiler would crash when binding a non-top-level
property assignment on the symbol of an unresolved module:

```js
import x from 'arglebaz'
{
    x.bar = 1
}
```

That's because `x` looks like an alias but doesn't have a
valueDeclaration (since there is no file named 'arglebaz'), and the new
code for binding Object.defineProperty calls forgot to check for an
undefined valueDeclaration.

This change adds the checks for an undefined valueDeclaration.
2018-11-19 13:29:46 -08:00
Sheetal Nandi 99d357db57 Enable statistics reporting per program through temporary build api 2018-11-19 12:38:36 -08:00
Andy 79b9fa51b6 Avoid infinite loop checking yield expression (#21728)
* Avoid infinite loop checking yield expression

* Revert now-unneeded change

* Revert test filename changes
2018-11-19 11:18:32 -08:00
Andy ca7f78b8df Fix typo (#28526) 2018-11-19 10:54:54 -08:00
TypeScript Bot b3b927291f Update user baselines (#28601) 2018-11-19 10:54:13 -08:00
Andy b8a8ceae86 Handle merging unknownSymbol (#28453)
* Handle merging unknownSymbol

* mergeSymbol of unknown target returns source, not unknown
2018-11-19 10:51:58 -08:00
Sheetal Nandi dc03115d14 Merge pull request #28585 from Microsoft/isTypeOnlyCompletion
Properly set symbolMeanings when calling getSymbolsInScope
2018-11-19 08:50:41 -08:00
Sheetal Nandi eeaa8bb527 Merge pull request #28533 from Microsoft/generateGetAndSet_noFindAllRefs
generateGetAccessorAndSetAccessor: Don't use FindAllReferences
2018-11-19 08:47:12 -08:00
Sheetal Nandi d7e08669f5 Merge pull request #28588 from dsherret/removeNonInternalStuffJsDocComment
Remove jsdoc comment on ts namespace
2018-11-19 08:44:29 -08:00
vvakame d6d9c9ec20 Show diagnostic when error found with --showConfig option 2018-11-19 19:06:43 +09:00
David Sherret 1acfce680e Remove jsdoc on ts namespace. 2018-11-17 11:50:06 -05:00
Wesley Wigham 608a8307ac Dont emit module resolution errors when looking up specifiers for container symbols (#28558) 2018-11-16 17:15:40 -08:00
Andy Hanson 59c014ba32 Properly set symbolMeanings when calling getSymbolsInScope 2018-11-16 17:04:29 -08:00
Andy da33c580eb Minor cleanups in checkUnusedIdentifiers (#28513) 2018-11-16 16:58:36 -08:00
Wesley Wigham cd08a22ef5 Clamp calculated sourcemap positions rather than throwing (#28583)
* Clamp calculated sourcemap positions rather than throwing, to allow the underlying file to drift out of date with the sourcemap without a crash

* Clamp line as well
2018-11-16 16:05:07 -08:00
Andy 12f3d0d54c Enable --strictPropertyInitialization (#27558)
* Enable --strictPropertyInitialization

* Code review
2018-11-16 16:02:23 -08:00
Daniel Rosenwasser 5a4378ef1e Accepted baselines. 2018-11-16 15:59:14 -08:00
Daniel Rosenwasser b7da98b1c3 Use intersection of member names to find largest overlap. 2018-11-16 15:59:00 -08:00
Sheetal Nandi 6bb1ff2214 Merge pull request #27376 from Microsoft/codeFixCannotFindModule_suggestion_falsePositive
Don't implicit-any diagnostic for json module
2018-11-16 15:48:37 -08:00
Daniel Rosenwasser 6ae288fbb3 Merge remote-tracking branch 'origin/master' into overlappyTypes 2018-11-16 15:02:13 -08:00
Andrew Casey 642803c182 Merge pull request #28559 from amcasey/FileSize
Expose aggregate file sizes in FileStats
2018-11-16 13:52:12 -08:00
Andy e0dca0bd95 Error when destructuring private property in a parameter (#28562) 2018-11-16 12:47:05 -08:00
Andrew Casey 5c1c34a16e Add telemetry test 2018-11-16 11:00:41 -08:00
Andrew Casey a8c634d70d Restore useText 2018-11-16 10:48:06 -08:00
Nathan Shively-Sanders ea8ccc2ce4 In JS, constructor functions infer from call+construct (#28353)
* constructor functions infer from call+construct

Also fix an incorrect combining of inferences for rest parameters: the
inferred types will be arrays in the body of the function and the
arguments from outside the function will be the element type.

* All functions infer from call+construct contexts
2018-11-16 09:51:07 -08:00
Andy 1089424035 Ensure getApplicableRefactors doesn't crash when given a position (#28361) 2018-11-16 09:30:37 -08:00
Andy a6ef176dbb Consistently return 'void' from ChangeTracker methods (#28563) 2018-11-16 08:58:00 -08:00
Sheetal Nandi f7584ad868 Merge pull request #28572 from calebsander/fix/unused-baselines
Remove unused baselines
2018-11-16 08:53:32 -08:00
Andy 0c4ceeec24 Don't consider 'typeof a' as using 'a' (#28528)
* Don't consider 'typeof a' as using 'a'

* Also handle markPropertyAsReferenced

* Use isInTypeQuery
2018-11-16 08:35:36 -08:00
Caleb Sander 10fa76c06a Remove unused baselines 2018-11-15 23:31:13 -08:00
Andy Hanson d29a072a4a Merge branch 'master' into tsconfig_canonicalpath 2018-11-15 17:20:13 -08:00
Andrew Casey 8bfdb4145d Fix tests and lint 2018-11-15 16:00:35 -08:00
Andrew Casey d5b95b5904 Update API baseline 2018-11-15 15:54:21 -08:00
Andy b059135c51 When adding relative completions with rootDirs, still add completions for regular relative imports (#28561) 2018-11-15 15:11:27 -08:00
Florian Regensburger 1fd2371a37 Fixed codeFixAll behavior and adjusted changed fourslash tests 2018-11-15 23:05:14 +01:00
Florian Regensburger 94118b64c5 Properly check if a codefix is needed 2018-11-15 23:05:14 +01:00
Florian Regensburger 70fee3fb36 Review changes and adjustment of fourslash tests 2018-11-15 23:05:14 +01:00
Florian Regensburger 2dae10f6ba Revert whitespace change 2018-11-15 23:03:15 +01:00
Florian Regensburger 1e6a5f3d0b Add codefix for 'Cannot find name' diagnostic 2018-11-15 23:03:15 +01:00
Andrew Casey 2c7d67fded Expose aggregate file sizes in FileStats
We're not sure that file counts are a good proxy for project size and
this will give us more direct insight.
2018-11-15 13:56:24 -08:00
Andrew Casey 02d5cb045c Expose file size from TextStorage
Since it's for telemetry, it prefers to return a stale value rather than
triggering file IO (though it will load the file if not even a stale
value is available).
2018-11-15 13:56:24 -08:00
Wesley Wigham b90d2910fb Strongly typecheck unions of intrinsic tag names (#28557) 2018-11-15 13:46:32 -08:00
Klaus Meinhardt 1ad7b0fe69 forEachToken: correctly handle JSDocTag (#28369)
* forEachChild: handle JSDocTags and all their children

* fix codefix for unused identifier

* fix lint

* fix build

* Fix test failures
2018-11-15 13:22:25 -08:00
Nathan Shively-Sanders 6cee7c3080 Better nameless parameter implicit any error (#28554)
* Initial version, doesn't work for primitives yet.

Need to find out why.

* Primitives now work, plus improve error message

null and void don't even parse without parameter names so they are not
tested.

* Codefix: Add names to nameless parameters

* Improve error wording

* Add detail to error message
2018-11-15 12:45:39 -08:00
Andy 079f0436f3 Remove unused function (#28531) 2018-11-15 09:34:07 -08:00