Commit Graph

34031 Commits

Author SHA1 Message Date
Andrew Casey fe015ef30f Document failure to handle type parameter shadowing 2017-08-29 11:24:04 -07:00
Andrew Casey b09d2277b8 Test that in-scope type parameters are not passed explicitly 2017-08-29 11:24:03 -07:00
Andrew Casey ee80019d16 Switch from .js to .ts so that baselines are syntactically valid 2017-08-29 11:15:58 -07:00
Andrew Casey bf0333ae07 Delete unused baselines 2017-08-29 11:15:58 -07:00
Andrew Casey b2cc722483 Comment out headers in Extract Method baselines 2017-08-29 11:15:54 -07:00
Andrew Casey 30802cda97 Handle loose type parameters in Extract Method
Known limitations:

1. If a type parameter on an inner symbol shadows a type parameter on an
outer symbol, the generated code will be incorrect.  We should either
rename one or more type parameters or forbid the extraction.

2. Type arguments are always passed explicitly, even if they would be
inferred correctly.
2017-08-29 11:10:16 -07:00
Nathan Shively-Sanders 63cb84f3d1 Codefix jsdoc types for anything with a .type
That means type parameters and type arguments are still not handled.
2017-08-29 10:38:16 -07:00
Andy 2350d46e44 Simplify isContextSensitive (#17722) 2017-08-29 10:28:22 -07:00
Andy 7ac4380514 Use getPropertyOfObjectType to get a superclass property (#18113) 2017-08-29 10:23:30 -07:00
Andy 78524c1b90 Avoid climbing ancestors in getAnyImportSyntax (#17832) 2017-08-29 09:41:57 -07:00
Andy 6168d6f074 Inline checkLiteralExpression (#17720) 2017-08-29 09:38:44 -07:00
Andy 9daa70c47e Revert "Handle indexed access types in getSymbolAtLocation and findAllReferences (#17787)" (#18111)
This reverts commit 30b3cb0f68.
2017-08-29 09:37:27 -07:00
Andy 7306b13f74 Don't issue a use-before-declared error for a property that exists in a superclass (#17910)
* Don't issue a use-before-declared error for a property that exists in a superclass

* Simplify isInPropertyInitializer

* Respond to PR comments
2017-08-29 09:18:09 -07:00
Anders Hejlsberg 86930c9aab Accept new baselines 2017-08-29 09:01:31 -07:00
Anders Hejlsberg e3b1487240 Check all properties are present before checking types in relationships 2017-08-29 09:00:17 -07:00
Andy 30b3cb0f68 Handle indexed access types in getSymbolAtLocation and findAllReferences (#17787) 2017-08-29 07:53:22 -07:00
Nathan Shively-Sanders b082c27fbe Test:jsdoc codefix for variable-like declarations 2017-08-28 16:10:03 -07:00
Nathan Shively-Sanders 16ccb66377 Provide jsdoc type code fixes for all variable-like decls
This includes 3 SyntaxKinds I missed earlier: Parameter,
PropertyDeclaration and PropertyAssignment.
2017-08-28 16:09:09 -07:00
Wesley Wigham 3ea031cf1c Fix RWC - use replayLog, not recordLog (#18095) 2017-08-28 15:45:21 -07:00
Henry Mercer 01657e2036 Fix typo in comment 2017-08-28 23:43:29 +01:00
Henry Mercer 2c028ae3e5 Generalise empty object literal property access fix to all object literals 2017-08-28 23:14:19 +01:00
Andy 934da9fb39 Remove template strings in checker.ts (#18016)
* Remove template strings in checker.ts

* Inline function
2017-08-28 15:03:34 -07:00
Daniel Rosenwasser a60b1037f8 Merge pull request #18077 from fwouts/regex-bug
Fix #18071: Printer failure when encountering RegularExpressionLiteral
2017-08-28 14:10:29 -07:00
Ryan Cavanaugh 67f2716156 Detect bad plugins and work around them 2017-08-28 13:32:20 -07:00
Nathan Shively-Sanders 278dcc6fac Merge pull request #18029 from Microsoft/allow-string-enum-in-element-access
Allow string enum in element access
2017-08-28 12:56:08 -07:00
Andy bab287d252 Simplify getAccessibleSymbolChain (#18053) 2017-08-28 11:44:41 -07:00
Nathan Shively-Sanders 8087206078 Explain boolean exception in getIndexedAccessType
Booleans are not treated like other unions in order to skip straight to
error reporting so that the error is reported with 'boolean' instead of
'true'.
2017-08-28 11:09:25 -07:00
Nathan Shively-Sanders 197040d3fd Merge branch 'master' into allow-string-enum-in-element-access 2017-08-28 11:00:13 -07:00
Nathan Shively-Sanders 2f646daf0a Move lone test case into central test file 2017-08-28 10:53:11 -07:00
Wesley Wigham 117ef21bfc Always use case-insensitive fs operartions for RWC (#18046)
* Always use case-insensitive fs operartions for RWC

* wrappedIO handles case sensitivity checks
2017-08-28 10:23:41 -07:00
Nathan Shively-Sanders 28a6ac3a77 Merge branch 'master' into fix2-getConstraintOfIndexedAccess
Also fix test failure from last commit.
2017-08-28 10:02:54 -07:00
Nathan Shively-Sanders 20e579847a Test:T[keyof T] =/=> T[K] where K extends keyof T 2017-08-28 09:12:14 -07:00
Nathan Shively-Sanders 04339d2df7 Disallow T[K] = T[keyof T] where K extends keyof T
`K = keyof T` was already correctly disallowed.
2017-08-28 09:05:56 -07:00
Ryan Cavanaugh e54828f86c Merge pull request #18084 from Microsoft/deps
Move browser-resolve to devDependencies
2017-08-28 08:18:53 -07:00
Andy Hanson b21d3f03bd Move browser-resolve to devDependencies 2017-08-28 07:48:43 -07:00
Francois Wouts 170bc6f519 Add test for #18071 2017-08-28 08:14:08 +10:00
Francois Wouts 884cadf0a3 Fix TypeScript printer bug when encountering regular expression literals
See https://github.com/fwouts/sample-js-selfparsing/blob/typescriptbug/src/script.js to reproduce the bug.

Not sure where to put tests for this, unfortunately!
2017-08-27 22:03:56 +10:00
Wesley Wigham a32d99dfc8 Use visitNode (#18059) 2017-08-25 18:22:03 -07:00
Andy e73b10a304 Use isPartOfExpression in extractMethod, not isExpression (#18047)
* Use isPartOfExpression in extractMethod, not isExpression

* Add whitespace
2017-08-25 15:15:16 -07:00
Andy 4d05bfdf4a moduleAugmentations may contain an Identifier (#18009)
* `moduleAugmentations` may contain an `Identifier`

* Add comment

* Rename function
2017-08-25 15:14:51 -07:00
Ron Buckton eb75619cda Merge pull request #18051 from Microsoft/fix17551
Fix crash in name resolution with custom transforms and emitDecoratorMetadata
2017-08-25 15:14:21 -07:00
Wesley Wigham 38c3f67652 Visit destructuring computed names (#18052) 2017-08-25 15:10:47 -07:00
Paul van Brenk 69a8504d59 Merge pull request #17791 from Microsoft/dynamicFiles
Introduce the concept of a Dynamic File
2017-08-25 14:24:12 -07:00
Ron Buckton bdfb92aebe Fix crash in name resolution with custom transforms and emitDecoratorMetadata 2017-08-25 14:17:48 -07:00
Paul van Brenk 6f6c3c2464 Merge branch 'master' into dynamicFiles
# Conflicts:
#	src/server/utilities.ts
2017-08-25 13:25:46 -07:00
Anders Hejlsberg 555a742d16 Merge pull request #18042 from Microsoft/fixMappedTypeIndexedAccess
Defer mapped type indexed access transformations
2017-08-25 20:59:16 +01:00
Andy fe1242c8a9 Don't try to extract import to a method (#18025) 2017-08-25 09:53:56 -07:00
Andy 3a0ab74ed6 Test for action description of code actions, and simplify description for extracting method to file (#18030)
* Test for action description of code actions, and simplify description for extracting method to file

* Add unit test file missing from tsconfig.json (only affects gulp) and update tests

* Use the actual number

* Use "module scope" or "global scope" instead of "this file"
2017-08-25 09:53:28 -07:00
Anders Hejlsberg e79d75a383 Add regression test 2017-08-25 08:55:43 -07:00
Anders Hejlsberg cf998bf350 Accept new baselines 2017-08-25 08:49:59 -07:00