Commit Graph

34031 Commits

Author SHA1 Message Date
csigs fd3ededf09 LEGO: check in for master to temporary branch. 2017-10-19 22:10:33 +00:00
Andy c1b4d59752 Fixup line and offset of rename location of refactor (#19265)
* Fixup line and offset of rename location of refactor

* Fixes

* Handle "\r" only documents

* Update api baselines

* Fix error if an edit comes *after* the rename location

* Add bounds check

* Simpler implementation: get new text, then calculate line starts the usual way
2017-10-19 14:31:23 -07:00
Nathan Shively-Sanders 97a6f14ca2 Consolidate jsdoc node getters
They are now used both in getJSDocCommentsAndTagsWorker and in
geParameterSymbolFromJSDoc.
2017-10-19 14:12:56 -07:00
Nathan Shively-Sanders c2bbfafcbe Fix getParameterSymbolFromJSDoc 2017-10-19 09:13:31 -07:00
Nathan Shively-Sanders ecdc4b363e Test:jsdoc @param errors on vardecls/assignments 2017-10-19 09:12:49 -07:00
csigs 8695f38d6f LEGO: Merge pull request 19342
LEGO: Merge pull request 19342
2017-10-19 09:10:30 -07:00
csigs 5a6e5e7f79 LEGO: check in for master to temporary branch. 2017-10-19 16:10:06 +00:00
Andy 1f282f19e0 Fix "noStringLiteral" lint errors (#19310) 2017-10-19 08:15:48 -07:00
Andy a53d3bb5aa Remove some unnecessary undefined checks in extractSymbol (#19256) 2017-10-19 08:15:01 -07:00
Wesley Wigham 8212c962cd Workaround for nonnull operator on indexed accesses (#19275)
* Quick and dirty workaround

* Add third case to show current behavior

* Rename variable, replace elaboration from comment with links
2017-10-18 17:39:05 -07:00
Anders Hejlsberg f8d9079c47 Add regression test 2017-10-18 16:59:43 -07:00
Anders Hejlsberg e0c10853ce Accept new baselines 2017-10-18 16:59:35 -07:00
Anders Hejlsberg a885894baa Infer properties of type {} when argument of a mapped type is incorrect 2017-10-18 16:58:56 -07:00
Nathan Shively-Sanders d8373c3dbb Merge pull request #19314 from Microsoft/fix-tsc-instrumented
Fix four tsc-instrumented bugs
2017-10-18 16:41:40 -07:00
Sheetal Nandi 8fc651870e Merge pull request #19306 from Microsoft/doNoWriteFilesMultipleTimes
Fixes the issue with emit where in same file is emitted multiple times
2017-10-18 16:12:36 -07:00
Andy 0f55f4a701 Use Promise instead of PromiseLike (#19305) 2017-10-18 16:04:42 -07:00
Andy 6c1afba389 Remove extra blank line in logs (#19307) 2017-10-18 16:04:18 -07:00
Vakhurin Sergey 2b6ef79ada Fixed incorrect insertSpaceBeforeFunctionParenthesis behavior on functions with type-arguments
There was an interference between the SpaceBeforeOpenParenInFuncDecl and the NoSpaceAfterCloseAngularBracket rules. So, the NoSpaceAfterCloseAngularBracket eliminated a space which has been added by the SpaceBeforeOpenParenInFuncDecl rule.
2017-10-19 02:00:05 +03:00
Armando Aguirre 16c3255988 Updated an incredible amount of tests. 2017-10-18 15:49:46 -07:00
Andy f1abe3c284 Fix undefined error using getEffectiveTypeRoots (#19300) 2017-10-18 15:47:15 -07:00
Andy e5f8287e5c findAllRefs: Support anonymous default export (#19302) 2017-10-18 15:46:39 -07:00
Mohamed Hegazy 5fa8db55b2 Fix https://github.com/Microsoft/TypeScript/issues/19270: ensure output name is a valid locale name (#19308)
* Fix https://github.com/Microsoft/TypeScript/issues/19270: ensure output name is a valid locale name

* Use const instead of var

* Add comment

* Fix typo

* Split the concat logic for generatedLCGFile
2017-10-18 15:46:09 -07:00
Nathan Shively-Sanders 79c672424e Fix lint 2017-10-18 15:32:24 -07:00
Nathan Shively-Sanders 93c2b10f68 Fix tsc-instrumented
1. Make recursiveCreateDirectory correctly handle relative paths.
2. Remove dependency on Harness
3. Correctly increment iocapture0, iocapture1, ... iocaptureN.
4. Stop double-nesting baseline files.
2017-10-18 15:29:11 -07:00
Sheetal Nandi 9bea0dbdc2 Actually use cached semantic diagnostics 2017-10-18 15:28:20 -07:00
csigs 7bfda06189 LEGO: Merge pull request 19312
LEGO: Merge pull request 19312
2017-10-18 15:10:49 -07:00
csigs 7d23ed152b LEGO: check in for master to temporary branch. 2017-10-18 22:10:31 +00:00
Wesley Wigham 75a687b524 make getCurrentDirectory required (#19303) 2017-10-18 14:57:18 -07:00
Nathan Shively-Sanders b40e18df00 Merge pull request #19304 from Microsoft/dedupe-jsdoc-annotation-refactors
Fixes for refactor "Annotate with type from JSDoc"
2017-10-18 14:50:13 -07:00
Armando Aguirre 8004fec2ce Addressed PR comments: added simplified/full version, changed design 2017-10-18 14:48:06 -07:00
Sheetal Nandi f59241971d Merge pull request #19138 from Microsoft/configuredProjectRef
Handle the configured project lifetime to account for files added to the project after config file gets reloaded
2017-10-18 14:23:25 -07:00
Sheetal Nandi 7e780c0a1a Do not cache the semantic diagnostics when compiler options has --out since we would anyways get all fresh diagnostics 2017-10-18 13:49:54 -07:00
Sheetal Nandi 835d7cb910 Simplify emit changed files further
Also use source file version as the signature of declaration file instead of computing it from text
2017-10-18 13:34:13 -07:00
Sheetal Nandi 8fbfb5ffc0 Modify api to emit affected files using callback instead of generating in memory output
Also marking few apis introduced during watch improvements changes that are suppose to be internal for now
2017-10-18 13:34:13 -07:00
Sheetal Nandi f9c901ada7 Use get files affected by internally and hence use file paths as input 2017-10-18 13:34:13 -07:00
Sheetal Nandi d3f954e0cc Add failing testcase where when d.ts file is in program, the files get emitted multiple times with --out setting 2017-10-18 13:34:12 -07:00
uniqueiniquity a7f9ec00ed Respond to CR 2017-10-18 13:17:07 -07:00
Nathan Shively-Sanders f82dd7b1da Move isJSDocIndexSignature to utilities 2017-10-18 13:16:22 -07:00
Nathan Shively-Sanders aa73ed8226 Fix bugs in jsdoc annotation refactor
1. Transform index signatures to TS index signatures.
2. Print object literals on a single line.
3. Only offer the refactor when it could add types. (There must not be a
type annotation already, and there must be a JSDoc that applies.)
2017-10-18 13:07:54 -07:00
Nathan Shively-Sanders 2473ffcaac Add a better test for jsdoc index signatures.
The test case shows that the errorenous error no longer appears.
2017-10-18 13:06:15 -07:00
Nathan Shively-Sanders c13506e70c Update annotateWithTypeFromJSDoc tests
1. Object literals are single-line now.
2. Index signatures transform to TS index signatures.
3. The refactoring is only available when it could add types.
2017-10-18 13:04:13 -07:00
Bill Ticehurst 89e19fff35 Merge pull request #19301 from Microsoft/dev/bill/port19228toMaster
Port #19228 to master
2017-10-18 12:54:51 -07:00
Nathan Shively-Sanders f374117858 Remove erroneous error for JSDoc object literals
appears with checkJS.
2017-10-18 11:32:48 -07:00
Bill Ticehurst 9da745d37b Update API baselines 2017-10-18 10:41:57 -07:00
Bill Ticehurst 45ba0ac3b9 Set the scriptKind from the host configuration if present 2017-10-18 10:41:57 -07:00
Andy 3220ebc182 Disambiguate same-named refactors using description (#19267)
Disambiguate same-named refactors using actionName
2017-10-18 10:23:18 -07:00
csigs f8f662d0a1 LEGO: Merge pull request 19297
LEGO: Merge pull request 19297
2017-10-18 09:10:32 -07:00
csigs 2ca0df8844 LEGO: check in for master to temporary branch. 2017-10-18 16:10:11 +00:00
csigs d01df0208a LEGO: Merge pull request 19288
LEGO: Merge pull request 19288
2017-10-18 03:10:30 -07:00
csigs d08b58c7d1 LEGO: check in for master to temporary branch. 2017-10-18 10:10:12 +00:00