Commit Graph

34031 Commits

Author SHA1 Message Date
Benjamin Lichtman f4765a6ea3 Fix error introduced by rebase 2018-08-29 15:56:22 -07:00
Benjamin Lichtman bb892d951d Use non-diagnostics-producing typechecker to get type 2018-08-29 15:54:19 -07:00
Benjamin Lichtman 97e539339d Add comment explaining special casing 2018-08-29 15:53:34 -07:00
Benjamin Lichtman 3ad6a66e69 Add tests and validate diagnostic spans 2018-08-29 15:53:05 -07:00
Benjamin Lichtman 158f0b0c0b Allow codefix to apply to function expression in variable declaration 2018-08-29 15:52:35 -07:00
Benjamin Lichtman cc4e1f833e Look for correct description 2018-08-29 15:50:34 -07:00
Benjamin Lichtman d21c078363 Test for existence of diagnostic when running tests 2018-08-29 15:49:48 -07:00
Anders Hejlsberg a28791565d Merge pull request #26746 from Microsoft/noUnionInferences
Don't infer unions for disjoint callback parameter candidates
2018-08-29 15:45:43 -07:00
Nathan Shively-Sanders 29dbabe2e1 In JS, fix contextual type of this assignments (#26743)
in object literal methods inside an object literal with a type
annotation.

Note that this does not change:

1. The type of `this` in object literal methods.
2. The fact that this-property assignments are still declarations. They
just don't block contextual typing like most declarations do.

This change is a bit expensive. It first calls getThisContainer, which
walks the tree upward. Then it calls checkThisExpression, which will
usually call getContextualType on the object literal method. If the new
code then returns true, it will proceed to redo much of that work.

Calling checkThisExpression should not cause incorrect circularity
failures; we only have to inspect the shape of the object literal and
not the types of its properties to determine its type.
2018-08-29 15:06:38 -07:00
Andy 7b4f864b49 moduleSpecifiers: Simpler criteria for preferring relative path vs baseUrl (#25803)
* moduleSpecifiers: Simpler criteria for preferring relative path vs baseUrl

* Don't unconditonally use a path mapping
2018-08-29 15:06:26 -07:00
Sheetal Nandi 02e1a32c1c Merge pull request #26742 from Microsoft/addShortWatch
Fixes issue when --build --watch queue becomes incorrect because it isnt reset correctly
2018-08-29 14:43:22 -07:00
Anders Hejlsberg b17aaf0edf Accept new baselines 2018-08-29 14:15:09 -07:00
Anders Hejlsberg c48c3632bd Update tests 2018-08-29 14:02:15 -07:00
Anders Hejlsberg 529ed2d59d Stop inferring unions for disjoint callback parameter inferences 2018-08-29 13:42:20 -07:00
Ron Buckton 210de32933 Merge branch 'master' into typesVersions 2018-08-29 13:26:13 -07:00
Ron Buckton 838110a4f8 Merge pull request #26741 from Microsoft/gulpWatch
Fix overlapping test runs in 'gulp watch'
2018-08-29 13:24:12 -07:00
Sheetal Nandi 90abaa1c45 Reset the build queue correctly
Fixes issue reported in #26545#issuecomment-416961260
2018-08-29 13:10:55 -07:00
Ron Buckton 111300ccd5 Fix overlapping test runs in 'gulp watch' 2018-08-29 12:57:05 -07:00
Sheetal Nandi d6ff1a7241 Move parsing of build options to commandLineParsing so it can be tested and it lines with other commandline parsing 2018-08-29 12:52:27 -07:00
Sheetal Nandi 068840d471 Add shortname for watch option 2018-08-29 11:58:38 -07:00
Anders Hejlsberg d066e1e9e3 Merge pull request #26676 from Microsoft/complexRestParameterTypes
Improve checking of complex rest parameter types
2018-08-29 11:39:04 -07:00
Andy 02630273a2 codeFixInferFromUsage: Assume that using x[0] means that x is an array (#26739)
* codeFixInferFromUsage: Assume that using `x[0]` means that `x` is an array

* Remove unnecessary '||' with non-falsy LHS

If only there were some kind of type-checker for JavaScript that could detect this sort of thing
2018-08-29 11:37:31 -07:00
Andrew Casey f7e45c500f Merge pull request #26650 from amcasey/LogPid
Substitute process ID for "PID" in log file names
2018-08-29 11:19:13 -07:00
Andy 0feeb48783 Make generator function name a completion list blocker (#26640)
* Make generator function name a completion list blocker

* Improvements for class/object members

* Separate KeywordCompletionFilter.None and .All
2018-08-29 10:53:32 -07:00
Sheetal Nandi 9100047f84 Merge pull request #26723 from Microsoft/buildCleanSourcemaps
Add js source maps to list of outputs when doing --build
2018-08-29 10:21:25 -07:00
csigs 4affe1f891 LEGO: Merge pull request 26736
LEGO: Merge pull request 26736
2018-08-29 09:10:58 -07:00
csigs 983b0b4f95 LEGO: check in for master to temporary branch. 2018-08-29 16:10:32 +00:00
Anders Hejlsberg a2d2f5aee6 Merge branch 'master' into complexRestParameterTypes 2018-08-29 07:51:07 -07:00
Wenlu Wang f67d7e01cf add test case and fix regression (#26726) 2018-08-29 06:58:55 -07:00
Anders Hejlsberg 9f4ae5f5ea Fix typo 2018-08-29 06:57:21 -07:00
王文璐 0d3adffd1a accept baseline 2018-08-29 18:42:02 +08:00
王文璐 597bb0e764 Merge branch 'master' into strictParameter 2018-08-29 18:28:36 +08:00
Nathan Shively-Sanders 30f611b055 Add survey event (#26455)
* Start adding survey event

* Add surveyReady event

* Remove old notes

* Move event, simplify type, add test

1. Move the survey event to sendProjectTelemetry so that it happens on
open instead of on editing tsconfig.
2. Remove URL from the survey type; VS code should control this
information.
3. Add test based on large files event test. I'm not sure it's in the
right place, though.

* Fix tests and update API baseline

* Split survey sending from telemetry

Based on tests requested during review.

* Add additional assertion
2018-08-28 19:57:39 -07:00
Ron Buckton 5f6a2cbf69 Merge branch 'master' into typesVersions 2018-08-28 17:37:23 -07:00
Ron Buckton 37c33f4369 Use semver ranges 2018-08-28 17:24:02 -07:00
Andy cff04e6050 Ensure JsonSourceFile has all the non-optional properties of SourceFile (#26162)
* Ensure JsonSourceFile has all the non-optional properties of SourceFile

* Set properties in parseSourceFile
2018-08-28 16:43:14 -07:00
Sheetal Nandi 199d496ef1 Merge pull request #26716 from Microsoft/lazyConfiguredProjectsFromExternalProject
Add option --lazyConfiguredProjectsFromExternalProject to enable lazy load of configured projects referenced by external project
2018-08-28 16:19:01 -07:00
Sheetal Nandi 723e64ba3b Add js source maps to list of outputs when doing --build
Fixes #26619
2018-08-28 16:17:10 -07:00
Sheetal Nandi 03bb5d170e Use protocol.UserPreferences in server to store UserPreferences 2018-08-28 15:53:00 -07:00
Sheetal Nandi 52fef42baa Merge branch 'master' into lazyConfiguredProjectsFromExternalProject 2018-08-28 14:49:00 -07:00
Sheetal Nandi fc90b8f98b lazyConfiguredProjectsFromExternalProject as userpreference instead of command line option 2018-08-28 14:41:22 -07:00
Andy 9106fdbc47 Support signature help for type parameters of a type (#26702) 2018-08-28 14:21:09 -07:00
Ron Buckton 04a524511e Add semver range parsing support 2018-08-28 14:11:01 -07:00
Andy 552bd1c8a2 Support import fix/completions for export = (#25708) 2018-08-28 13:04:11 -07:00
Andy b94061c587 getEditsForFileRename: Avoid changing import specifier ending (#26177)
* getEditsForFileRename: Avoid changing import specifier ending

* Support .json and .jsx extensions

* Restore typeRoots tests

* Fix json test

* When --jsx preserve is set, import ".tsx" file with ".jsx" extension

* Support ending preference in UserPreferences
2018-08-28 13:03:24 -07:00
Sheetal Nandi 96e61407c5 Add option --lazyConfiguredProjectsFromExternalProject to enable lazy load of configured projects referenced by external project
Fixes #26696
2018-08-28 12:49:09 -07:00
Ron Buckton 37ec065d93 Add path back-reference tests 2018-08-28 11:44:40 -07:00
Andy 3931b72118 noUnusedLocals: Destructuring assignment is a write (#26365)
* noUnusedLocals: Destructuring assignment is a write

* Code review

* Clarify test
2018-08-28 11:43:45 -07:00
Sheetal Nandi 530a530ac0 Merge pull request #26590 from Microsoft/buildRefactoring
Refactor ts build and report watch status when doing --build --watch
2018-08-28 11:43:35 -07:00
Ryan Cavanaugh 6c2e851689 Merge pull request #26317 from Kingwl/parameter-initializer-lookup-fix
add special check for parameter initializer lookup if targeting es2015+
2018-08-28 11:33:58 -07:00