Commit Graph

34031 Commits

Author SHA1 Message Date
Wesley Wigham fdeb8f01df Fix typo in runner selection in gulp 2019-01-24 12:58:46 -08:00
Sheetal Nandi 9acff37947 Add test to test the readFile called on prepend input file for emitting and verifying emit 2019-01-24 12:17:45 -08:00
Sheetal Nandi 61b95fea5a Merge pull request #29555 from petebacondarwin/external-skip-trivia-fix
Use the correct source when skipping trivia
2019-01-24 12:09:10 -08:00
Anders Hejlsberg 71d70ef161 Merge pull request #29563 from Microsoft/fixSwitchControlFlow
Fix switch statement control flow logic
2019-01-24 10:36:52 -08:00
Ryan Cavanaugh d782a546a5 Merge pull request #29556 from fuafa/trailing-comma
fix trailing comma should not allowed in dynamic import argument
2019-01-24 10:20:26 -08:00
Anders Hejlsberg 936ee9b921 Accept new baselines 2019-01-24 10:12:43 -08:00
Anders Hejlsberg 500c4729e9 Add additional repro 2019-01-24 10:12:35 -08:00
Anders Hejlsberg 48cad7788d Accept new baselines 2019-01-24 09:30:54 -08:00
Anders Hejlsberg 83f7f4d190 Add regression test 2019-01-24 09:30:46 -08:00
Anders Hejlsberg 9844436231 Match control flow logic for switch statements to conditional expressions 2019-01-24 09:30:36 -08:00
TypeScript Bot 387201cda0 Update user baselines (#29560) 2019-01-24 09:27:32 -08:00
Pete Bacon Darwin 331b9bcfde Use the correct source when skipping trivia
A custom `SourceMapSource` can optionally provide its own `skipTrivia`
function. If this is not provided then the compiler will use the default
function designed for TypeScript source files.

Previously, when calling this default function we were passing the current
`sourceMapSource` rather than the specified `source` whose trivia needs
to be skipped. This resulted in the `pos` being incorrectly calculated for
external source files that need mapping.

**Side note:**

There are actually two possible constructors available for creating
`SourceMapSource` objects. One of them defaults to an identity function
for the `skipTrivia` function if it is not provided (see
https://github.com/Microsoft/TypeScript/blob/49689894d747714d6b2b8461b9033020efec9625/src/compiler/utilities.ts#L6972-L6976)
and the other one leaves the `skipTrivia` field `undefined` (see
https://github.com/Microsoft/TypeScript/blob/5fc8f1dd801dbacfe7e2d624f80b7a6a3868d180/src/services/services.ts#L776-L797)

Unfortunately, it appears that the second of these two constructors is the
one available when importing the "typescript" module in node.js code.
2019-01-24 10:28:10 +00:00
xiaofa d7601b755f fix trailing comma should not allowed in dynamic import argument 2019-01-24 18:16:34 +08:00
Ryan Cavanaugh 2f6c65e691 Merge pull request #26653 from Kingwl/improve_type_arguments_parser_1
parse less than token rather than left shift in context of type argum…
2019-01-23 16:21:12 -08:00
Ryan Cavanaugh ebebc9fdb6 Merge pull request #29546 from chrisrpatterson/update-badge-url
Updating badge url
2019-01-23 12:49:42 -08:00
Chris Patterson 41568ba7c6 Updating badge url
Updating the badge url to use the new url format.
2019-01-23 14:16:23 -05:00
Sheetal Nandi 73fe3fc0f5 Merge pull request #29532 from Microsoft/umdModuleGlobalMerge
Handle find all references for symbol merged with UMD module and global var
2019-01-23 11:13:58 -08:00
Sheetal Nandi d42185373a PR feedback 2019-01-23 10:48:17 -08:00
BigAru 5ec1201e3a exclude nested functions and classes at containingThis check 2019-01-23 19:36:00 +01:00
Ron Buckton e1477b41b7 Fix lint error 2019-01-22 16:28:00 -08:00
Ron Buckton c2e74ae96e Merge pull request #29534 from Microsoft/fix29355
Fix crash in signatureHelp
2019-01-22 16:16:42 -08:00
Ron Buckton 60487dc7cb Enable debug info by default when debugging the language server 2019-01-22 15:41:22 -08:00
Ron Buckton 76b78a4df5 Fix crash in signatureHelp 2019-01-22 15:02:30 -08:00
Sheetal Nandi f0227ecb2c Handle find all references for symbol merged with UMD module and global var
Fixes #29093
2019-01-22 14:52:39 -08:00
Ron Buckton 60639ce5a8 Replace most instances of getTextOfPropertyName in checker 2019-01-22 14:24:21 -08:00
kingwl b4b6e144ef Merge branch 'master' into PropertyDeclarationExclamationToken 2019-01-22 23:36:43 +08:00
BigAru dbd58599f4 do not provide refactoring when it contains this
because this behaves differently in arrow than in function
2019-01-22 05:42:01 +01:00
BigAru 52e94d2b80 Merge remote-tracking branch 'upstream/master' into m-lambda-to-fn 2019-01-22 05:10:32 +01:00
Anders Hejlsberg 2ea0251709 Accept new baselines 2019-01-20 08:21:49 -08:00
Anders Hejlsberg cf479fc384 Add regression test for #29168 2019-01-20 08:21:41 -08:00
Anders Hejlsberg dbea08f9c8 Accept new baselines 2019-01-20 08:21:26 -08:00
Anders Hejlsberg 60e7528ee6 No union type reductions in contextual types 2019-01-20 08:20:40 -08:00
Anders Hejlsberg dbfef5356c Accept baseline changes 2019-01-19 10:34:48 -08:00
Anders Hejlsberg 2e94f47602 Add tests 2019-01-19 10:34:38 -08:00
Anders Hejlsberg 980a6817b3 Accept baseline API changes 2019-01-19 10:34:29 -08:00
Anders Hejlsberg ec30c20ec9 Validate const assertion operand 2019-01-19 10:25:41 -08:00
kingwl e38ac0d5a4 fix api 2019-01-20 02:17:09 +08:00
kingwl e8497096d8 Merge branch 'master' into improve_type_arguments_parser_1 2019-01-20 01:54:49 +08:00
Gabriela Britto bd290e6eed add test for convert to named parameters refactoring 2019-01-18 16:54:57 -08:00
Gabriela Britto 919ed79f3a implement new parameter creation 2019-01-18 16:49:11 -08:00
Andrew Casey 3a2f6a3ed1 Merge pull request #29470 from amcasey/InterfaceImplementations
Don't treat interfaces as implementations
2019-01-18 16:28:49 -08:00
Anders Hejlsberg beb02703b8 Support '<const> xxx' and 'xxx as const' 2019-01-18 16:16:45 -08:00
Anders Hejlsberg 0b1da02a62 Add missing return statements (ugh) 2019-01-18 16:02:13 -08:00
Pranav Senthilnathan d38c616e29 Fix resolution of properties from prototype assignment in JS (#29302)
* fix type derived from prototype assignment

* accept new baselines

* remove direct intersection with object literal assigned to prototype

* add tests

* change webpack submodule commit

* fix submodule commits

* comment and simplify getJSDocTypeReference

* remove circularity guards that aren't hit anymore
2019-01-18 16:00:18 -08:00
Anders Hejlsberg 0b366ce751 Address CR feedback 2019-01-18 14:47:58 -08:00
Wesley Wigham 20285e66e9 Include all flow nodes made within try blocks as antecedents for catch or finally blocks (#29466)
* Include all flow nodes made within `try` blocks as antecedents for `catch` or `finally` blocks

* Fix typo
2019-01-18 14:43:31 -08:00
Anders Hejlsberg ef89d26dc8 Accept new baselines 2019-01-18 09:34:47 -08:00
Anders Hejlsberg 2200d35385 Add tests 2019-01-18 09:34:38 -08:00
Ron Buckton b317334c2a Merge pull request #29447 from Microsoft/fixGulp
Fix gulp builds not building some targets, use LKG by default
2019-01-17 17:19:42 -08:00
Anders Hejlsberg c809002bd3 Accept new baselines 2019-01-17 17:17:03 -08:00