Commit Graph

20961 Commits

Author SHA1 Message Date
Andy d8142339f9 Use 'filter' array helper (#20452) 2017-12-04 13:36:01 -08:00
Andy 93551ab93b Update test that import code fix doesn't use node_modules global import if classic resolution is set (#20453) 2017-12-04 13:15:45 -08:00
Mohamed Hegazy 272266f0e1 Update user tests baselines 2017-12-04 13:07:02 -08:00
Andy 334bf4eaf7 Remove 'debugger' statement from test (#20444) 2017-12-04 10:47:50 -08:00
Andy Hanson 2c929015d6 Fix deepEqual emptyArray tests 2017-12-04 10:47:17 -08:00
Nathan Shively-Sanders f4ae9ba5df Merge pull request #20413 from JoshuaKGoldberg/patch-1
Comment typo fix in es2015.ts: "propety"
2017-12-04 08:21:01 -08:00
andy-ms 72b7d6ef4e Remove dependency on chai 2017-12-03 18:36:29 -08:00
Josh Goldberg a4f83b0835 Added console clearing with a message to --watch starts
I advocated against immediately clearing the console when starting --watch in #17756 because it was confusing to have the console suddenly become blank, wait a while, and _then_ give output. After using the feature for a little while, I think it's a little disorienting how the console will only start clearing after the first recompile. This change clears the console and immediately prints a new "Starting compilation in watch mode..." message.
2017-12-03 14:45:33 -08:00
csigs dbf2ffaaad LEGO: Merge pull request 20420
LEGO: Merge pull request 20420
2017-12-03 09:10:27 -08:00
csigs 60ec20a136 LEGO: check in for master to temporary branch. 2017-12-03 17:10:09 +00:00
Josh Goldberg ff7510dc92 Fixed prettyContextNotDebugAssertion.errors baseline 2017-12-02 21:36:36 -08:00
Josh Goldberg eb5d8d0dd7 Prettified timestamps and error reports in --pretty
Timestamps look like Gulp's, with grey times inside white brackets.
Files have cyan filenames, yellow line and column numbers, and grey TS{####} errors. I wonder if those are actually useful for folks using the --pretty CLI: are they used for anything outside Visual Studio... Can we just get rid of them?

Re-uses compiler/program's color logic in compiler/watch. The relevant variables are now exported and marked `@internal`. Is there a preferred way of re-using this code in both those files?
2017-12-02 20:56:35 -08:00
Josh Goldberg c9f044ef2d Comment typo fix in es2015.ts: "propety" 2017-12-02 18:48:47 -08:00
benbraou 49a48ffd4d fix(es2018): add a target and an initial lib (#20385)
* run Jake LKG before es2018 addition

Fixes #20342

* fix(es2018): add a target and an initial lib

Fixes #20342
2017-12-02 11:16:59 -08:00
Josh Goldberg 08c6dc99c6 "tsc --watch should clear screen on new compilation" Two: Electric Boogaloo (#20389)
* tsc --watch should clear screen on new compilation

* added optional clearScreen method to System]
* implemented via `x1Bc`, reset screen
* fixes 13020

* Feedback on if statements; api .d.ts baseline additions

* Stopped clearing screen in tsc.js's reportWatchMode

* Added unit tests
2017-12-02 11:11:49 -08:00
csigs e90bf5e81b LEGO: Merge pull request 20406
LEGO: Merge pull request 20406
2017-12-01 21:10:30 -08:00
csigs c92aab8baf LEGO: check in for master to temporary branch. 2017-12-02 05:10:05 +00:00
Mohamed Hegazy 59e5bbc393 Make sure autoArrayType is unique, even if no lib is available (#20344)
* Make sure autoArrayType is unique, even if no lib is available

* fix typo
2017-12-01 19:51:14 -08:00
Wesley Wigham 1045d95a44 Always instantiate the extends clause, even in the presence of an error (#20232)
* Still instantiate the extends clause even when theres a noimplicitany error in js

* Only be permissive for JS

* In JS, instantiate classes even when they have too many type arguments, instead of returning unknownType
2017-12-01 21:09:06 -05:00
Anders Hejlsberg f6b1a1de59 Merge pull request #20404 from Microsoft/fixUntypedFunctionCall
Fix untyped function call on constrained type variable
2017-12-01 17:19:32 -08:00
Anders Hejlsberg 35188c5093 Accept new baselines 2017-12-01 16:54:40 -08:00
Anders Hejlsberg 3531bd2b57 Add regression test 2017-12-01 16:54:32 -08:00
Anders Hejlsberg 5465a5aa72 Check apparent type instead of function type in isUntypedFunctionCall 2017-12-01 16:48:29 -08:00
Mohamed Hegazy 65af685b49 Remove periods from refactor/quickfix messages (#20237)
* Fix #19959 and #19958: Remove un-localizable messages

* Update message

* Reorder error messages

* Fix https://github.com/Microsoft/TypeScript/issues/15399: remove periods at the end of messages

* Accept baselines for error code changes

* accept baselines for removed periods

* Update diagnostic messages
2017-12-01 16:38:59 -08:00
Nathan Shively-Sanders 8d7c2a2a77 Merge pull request #20370 from Microsoft/cutoff-inference-for-recursive-mapped-types
Cut off inference for recursive mapped types
2017-12-01 15:10:06 -08:00
Nathan Shively-Sanders 84d747a89c Simplify mappedTypeStack cache key 2017-12-01 14:48:59 -08:00
Nathan Shively-Sanders 0e5b53579d mappedTypeStack uses a string based on symbols
Previously it was a pair of [Type, Symbol].
2017-12-01 14:43:20 -08:00
Anders Hejlsberg bc628bfa29 Merge pull request #20380 from Microsoft/literalContexts
Fewer intermediate object literal and array literal types
2017-12-01 14:12:29 -08:00
Andy fd4d8ab96e Support a 'recommended' completion entry (#20020)
* Support a 'recommended' completion entry

* Code review

* Restore duplicate comments
2017-12-01 13:00:01 -08:00
Mine Starks 973cb767c7 Merge pull request #20369 from minestarks/noemitcos
compileOnSaveAffectedFileList shouldn't return any files for noEmit projects
2017-12-01 11:33:02 -08:00
Mine Starks 1fbe684834 compileOnSaveAffectedFileList shouldn't return any files for noEmit projects 2017-11-30 14:55:41 -08:00
Andrew Casey 8f1cdc9b0c Merge pull request #20373 from amcasey/PropertyUnderscore
Don't offer to prepend an underscore to the name of an unused private property
2017-11-30 13:08:26 -08:00
Nathan Shively-Sanders 2ec2238c1b Merge pull request #20198 from Microsoft/jsdoc-values-as-namespaces
Jsdoc values as namespaces
2017-11-30 12:56:11 -08:00
Nathan Shively-Sanders 7208204877 Don't mutate symbol flags after creation 2017-11-30 12:33:34 -08:00
Andy 75e5b13775 Don't suggest import completions for /a/node_modules if we're in /b (#19928)
* Don't suggest import completions for /a/node_modules if we're in /b

* Remove test for delving into dependencies of dependencies
2017-11-30 11:25:01 -08:00
Anders Hejlsberg a82b1b27d8 Accept new baselines 2017-11-30 10:37:17 -08:00
Nathan Shively-Sanders 0e4537e943 Update baselines with new SymbolFlags 2017-11-30 10:37:15 -08:00
Anders Hejlsberg 7ccbbfc928 Preserve literal types only when contextual type has literals of same kind 2017-11-30 10:36:07 -08:00
Nathan Shively-Sanders 69bbfedd63 Merge branch 'master' into jsdoc-values-as-namespaces 2017-11-30 10:34:50 -08:00
Nathan Shively-Sanders 665c2ecf91 Add SymbolFlag for containers of JS special decls
And update some doc comments
2017-11-30 10:27:38 -08:00
Andrew Casey 4c7b49156f Merge pull request #20359 from amcasey/CorrectEnumBaselines
Correct errorForUsingPropertyOfTypeAsType03
2017-11-30 10:09:22 -08:00
Nathan Shively-Sanders c7d53f8b70 Fix whitespace lint 2017-11-30 09:41:55 -08:00
Nathan Shively-Sanders 1068ee105d Test:inference to self-referential mapped type
From a self-referential type.
2017-11-30 09:40:43 -08:00
Andy 43a35bad2e Miscellaneous fixes to avoid duplicate completions (#20349)
* Miscellaneous fixes to avoid duplicate completions

* Move typeHasCallOrConstructSignatures to utility
2017-11-30 09:36:17 -08:00
Nathan Shively-Sanders b1316e589e Cut off inference for recursive mapped types
Previously, when inferring to a self-referential (or otherwise recursive)
homomorphic mapped type from a source type that also has recursive
references, type inference would enter infinite recursion.

Now there is a more complex stack for mapped type inference. It mirrors
the existing symbolStack but (1) includes the source type and (2) is
passed through inferTypeForHomomorphicMappedType, which is actually
called outside of inferTypes, and so restarts the symbolStack cache
every time.
2017-11-30 09:33:05 -08:00
csigs 192fabf89c LEGO: Merge pull request 20368
LEGO: Merge pull request 20368
2017-11-30 09:10:36 -08:00
csigs 224ffdc092 LEGO: check in for master to temporary branch. 2017-11-30 17:10:15 +00:00
Andy 56a046ddf4 installTypesForPackage refactor: Trigger even if resolved to a ".js" file (#20353)
* installTypesForPackage refactor: Trigger even if resolved to a ".js" file

* Use `extensionIsTypeScript`
2017-11-30 08:41:15 -08:00
Andrew Casey d7da7d48d3 Update affected fourslash test 2017-11-29 18:27:56 -08:00
Andrew Casey 011b567918 Don't offer to prepend an underscore to the name of an unused private property 2017-11-29 18:05:36 -08:00