Commit Graph

20961 Commits

Author SHA1 Message Date
Andrew Casey 568c8a3298 Allow extraction of variable decls used outside the extracted range
If there are only declarations, use the new function as the initializer
for a destructuring declaration.

If there are declarations and writes, changes all of the `const`
declarations to `let` and add `| undefined` onto any explicit types.
Use destructuring assignment to accomplish both "initialization" and
writes.

I don't believe there is a case where there are both declarations and a
return (since the declarations wouldn't be available after the return).

UNDONE: this could probably be generalized to handle binding patterns
but,
for now, only identifiers are supported.

Fixes #18242
Fixes #18855
2017-10-11 16:38:38 -07:00
Andrew Casey bada0095ed Merge pull request #18979 from amcasey/DeepClone
Introduce getSynthesizedDeepClone
2017-10-11 16:36:25 -07:00
Anders Hejlsberg 6cf41ae882 Merge pull request #19107 from Microsoft/fixRecursiveCallbacks
Fix checking of recursive callback types
2017-10-12 00:28:16 +01:00
Anders Hejlsberg 7ee96293ca Accept new baselines 2017-10-11 16:03:23 -07:00
Anders Hejlsberg 19f70f6d3d Add additional test 2017-10-11 16:03:15 -07:00
Anders Hejlsberg 9ef417b846 Account for type queries in type literals 2017-10-11 16:02:58 -07:00
Nathan Shively-Sanders d00ab417c6 checkTypeParameters now always calls fillMissingTypeArguments
And refactor checkTypeParameters to be easier to use and to read.
2017-10-11 15:58:54 -07:00
Andrew Casey eb4f067ecb Don't clobber the position of cloned nodes 2017-10-11 15:52:48 -07:00
Sheetal Nandi 4d7c112ef7 Make sure project root paths of inferred projects are canonical when comparing 2017-10-11 15:33:17 -07:00
Sheetal Nandi 562a0463bc Merge pull request #19111 from Microsoft/useCaseSensitiveProjectRootToSearchConfigFile
Handle case sensitivity when looking up config file for Script info
2017-10-11 15:31:00 -07:00
Wesley Wigham b949245336 Add ValueModule as a valid object literal type, as they are immutable (#19090)
* Add ValueModule as a valid object literal type, as they are immutable

* Rename method based on usage
2017-10-11 15:13:33 -07:00
Wesley Wigham 9f4130b204 Fix incorrect cast target (#19093)
Found while updating #18285 to latest master. Not sure what this fixes, but it was definitely incorrect - `node` must be a `Block` at this point, so this cast must have been intended for `node.parent`, which was checked against `TryStatement` right before it.
2017-10-11 14:52:23 -07:00
Andy 917ae32937 Always log output of execSync (#19110)
* Always log output of execSync

* Fix lint
2017-10-11 14:50:45 -07:00
Nathan Shively-Sanders 156e7e2069 Test:Incorrect number of type args during err reporting 2017-10-11 14:02:20 -07:00
Nathan Shively-Sanders 3fef16008d Fill missing type arguments during error reporting
Previously, only the success path did this; it was missing in the error
reporting path in resolveCall. This resulted in crashes for unsupplied
type arguments when the supplied type arguments were incorrect.
2017-10-11 14:01:25 -07:00
Mohamed Hegazy 7e1dd66c19 Update to use help wanted instead of Accepting PRs (#19105) 2017-10-11 13:44:07 -07:00
Nathan Shively-Sanders d7424b00b2 Merge branch 'master' into refactor-jsdoc-types-to-typescript 2017-10-11 13:41:45 -07:00
Sheetal Nandi deed981715 Handle case sensitivity when looking up config file for Script info
Fixes #17726
2017-10-11 13:35:06 -07:00
Nathan Shively-Sanders 1a1c1f9e93 Add and update jsdoc annotation refactoring tests 2017-10-11 13:34:16 -07:00
Nathan Shively-Sanders 4930cad653 Convert all JSDoc parameters and return types of functions 2017-10-11 13:33:31 -07:00
Nathan Shively-Sanders 461e29bbd8 Merge pull request #18965 from Microsoft/set-symbol-on-union-of-spreads
Set symbol on union that is returned from `getSpreadType`
2017-10-11 13:25:45 -07:00
Ron Buckton 73d06f796d Merge pull request #19056 from Microsoft/fix16221
Fix recursive reference in type parameter default
2017-10-11 12:49:35 -07:00
Sheetal Nandi bce77fdfd9 Merge pull request #18960 from Microsoft/builderHandlesChangeInResolution
Builder handles changes in resolution/references when file's contents dont change
2017-10-11 12:11:44 -07:00
Ron Buckton 26290a88ac Updated error baseline 2017-10-11 12:07:16 -07:00
Anders Hejlsberg 38cec12190 Accept new baselines 2017-10-11 12:02:01 -07:00
Anders Hejlsberg 07e4819b8b Add regression test 2017-10-11 12:01:38 -07:00
Anders Hejlsberg 81fc2a14d1 Don't check for callbacks in recursive call that resulted from callbacks 2017-10-11 12:01:26 -07:00
Ron Buckton d08770bdff Merge pull request #19046 from Microsoft/fix15395
Fix emit for classes with both fields and 'extends null'
2017-10-11 11:49:22 -07:00
Sheetal Nandi 142a88a4ae Update the comment on emit handler method 2017-10-11 10:51:46 -07:00
Andy e85c6330ba Add package-lock.json to repository (#19099) 2017-10-11 10:03:53 -07:00
Andy 0c4fe37a92 In issue template, recommend to use typescript@next (#19098) 2017-10-11 10:03:29 -07:00
Charles Pierce 576bd8c25f Ensure Async Modifier is maintained through ES6 Class Conversion (#19092) 2017-10-11 09:04:51 -07:00
Nathan Shively-Sanders de68f067d5 Set flags on fresh object types from getSpreadType
Previously, getSpreadType didn't set any flags and relied on its callers
to do so. This was error-prone because getSpreadType often returns
non-fresh types.
2017-10-11 08:17:40 -07:00
Sheetal Nandi cf9b83accc Instead of counting events with name, verify each event to not equal event name 2017-10-10 21:15:20 -07:00
Sheetal Nandi 993890f06c Verify errors more correctly in tsc-watch mode 2017-10-10 21:11:33 -07:00
Sheetal Nandi 9767d77143 Update comment on emit handler functions 2017-10-10 18:41:45 -07:00
Sheetal Nandi a7fa187fb2 Merge pull request #19058 from Microsoft/whenWatchesFail
Swallow the directory watcher exceptions and ignore them
2017-10-10 18:32:22 -07:00
Sheetal Nandi 7f1ddaf7b8 Merge branch 'master' into configFileDiag 2017-10-10 18:30:59 -07:00
Sheetal Nandi 0e2eb3a2b8 Combine the event manager testing 2017-10-10 18:25:26 -07:00
Wesley Wigham d0168af142 Functioning parallel unittests (#18956) 2017-10-10 17:59:43 -07:00
Sheetal Nandi bb4abbd95e Do not generate config file diagnostics event when the file opened doesnot belong to the configured project 2017-10-10 17:37:02 -07:00
Sheetal Nandi c5b4f5e7e7 Use filterMutate instead of removeWhere 2017-10-10 17:36:20 -07:00
Anders Hejlsberg d815ba13f8 Accept new baselines 2017-10-10 17:34:44 -07:00
Anders Hejlsberg 83020dbbd6 Add regression test 2017-10-10 17:34:32 -07:00
Anders Hejlsberg 5a1d846e76 Properly account for possibly referenced type parameters 2017-10-10 17:34:16 -07:00
Wesley Wigham 856961b84c Add regression test for #18668 (#19085) 2017-10-10 17:20:10 -07:00
Sheetal Nandi d7269f1386 Merge pull request #19053 from Microsoft/resolutionCacheDefensiveChecks
Resolution cache defensive checks
2017-10-10 17:18:53 -07:00
Sheetal Nandi 52d7c7278d Add comment about swallowing exception 2017-10-10 17:16:53 -07:00
Sheetal Nandi e30a66d22f Add utitlity for stringContains 2017-10-10 17:16:39 -07:00
Wesley Wigham edf0a95e89 Stop erroneous match of midfile sourceMappingUrl (#19084) 2017-10-10 16:41:54 -07:00