Commit Graph

28909 Commits

Author SHA1 Message Date
Andy e7b338e943 Don't treat a declaration as a type argument position (#25046) 2018-06-21 10:18:37 -07:00
Daniel Rosenwasser 077d64fb83 Merge pull request #25122 from mprobst/fix-case-insensitive
Fix the build on case-sensitive file systems.
2018-06-21 10:03:45 -07:00
Nathan Shively-Sanders 43d0794ba3 Fix crash when binding jsdoc-style inner namepaths (#25106)
* getDeclarationIdentifier handles undefined name

getNameOfDeclaration actually doesn't handle all declarations, only
those that produce names that could be reasonably used as an identifier.
Until now, getDeclarationIdentifier assumed that getNameOfDeclaration
always returned a name. This caused crashes whenever we tried to get the
name of something like a Constructor.

* Add test and baselines

* getNameOfDeclaration can return undefined

This requires all callers to handle it, which turns out now to be too
disruptive.

* Fix lint
2018-06-21 10:01:39 -07:00
Andy 40899eaf5b Error on 'const' in class expression (#25125) 2018-06-21 09:57:52 -07:00
Andy 3e50f502bb Mark some Type[] and Signature[] as ReadonlyArray (#25099) 2018-06-21 09:57:14 -07:00
Mohamed Hegazy 398b3ef6f6 Merge pull request #25124 from nrcoley/update-mailmap
Update Mailmap - Remove Contributor Info
2018-06-21 09:23:07 -07:00
Martin Probst 4b7208a79f Fix the build on case-sensitive file systems.
Dashed locale names like `pt-BR` were misspelled as `pt-br` in several
locations.

This is a follow up fix to #23146.
2018-06-21 13:52:53 +02:00
csigs 328822e6d5 LEGO: Merge pull request 25120
LEGO: Merge pull request 25120
2018-06-21 03:11:04 -07:00
csigs 4bb3f645b5 LEGO: check in for master to temporary branch. 2018-06-21 10:10:39 +00:00
Daniel Rosenwasser 33b1e3a39a Accepted baselines. 2018-06-21 00:31:33 -07:00
Daniel Rosenwasser 4f32691f3e Try to report errors on types who have matching type references. 2018-06-21 00:31:33 -07:00
Daniel Rosenwasser 9ba2eff4b0 Accepted baselines. 2018-06-21 00:31:30 -07:00
Daniel Rosenwasser 639d9ebb15 Added test. 2018-06-21 00:27:12 -07:00
Ron Buckton 2fc014a2d8 Accept new LKG 2018-06-20 21:40:48 -07:00
Ron Buckton c8c0428162 Cleanup, remove some unneeded dependencies, make it easier to add gulp.watch support later 2018-06-20 18:24:12 -07:00
Nathan Shively-Sanders 0f55566cf4 In JS, always check the extends tag of a class before its heritage clause (#25111)
* Check extends tag first in getClassExtendsHeritageClauseElement

Previously getBaseTypeNodeOfClass checked, but this is only used in a
few places.

* Fix names and add test

* Update API baseline

* Move jsdocAugments tests to conformance/jsdoc

* Better naming in checkClassLikeDeclaration
2018-06-20 16:28:30 -07:00
Sheetal Nandi 3eeb36bd22 Merge pull request #25102 from Microsoft/declarationEmitWithNoEmitAndWatch
Mark the declarations visible correctly when emit is disabled but asked to emit declarations for watch mode
2018-06-20 16:04:57 -07:00
nrcoley 4a078479e4 Remove contributor info 2018-06-20 17:08:09 -04:00
Andy f3e2e891da navigationBar: Avoid double recursion on special property assignment (#25077) 2018-06-20 12:57:34 -07:00
Sheetal Nandi f506b28e95 Mark the declarations visible correctly when emit is disabled but asked to emit declarations for watch mode
Fixes #25068
2018-06-20 12:28:50 -07:00
Andy 1c3259d29b Add CompletionInfo command to protocol (#25080)
* Add CompletionInfo command to protocol

* Add comments to protocol
2018-06-20 09:13:04 -07:00
TypeScript Bot 28e0fc56bb Update user baselines (#25091) 2018-06-20 07:15:36 -07:00
Andy b3f9ec3796 Fix bug: Still implement a method even if the return type is defined in another file (#24978) 2018-06-19 16:36:18 -07:00
Mohamed Hegazy 9706f1729e Merge pull request #25075 from Dangoo/feat/add_intl-number-format_format-to-parts_types
Add Intl.NumberFormat.formatToParts types
2018-06-19 14:20:26 -07:00
dangoo 2ef73ab4fa Fix test messages to mention esnext.intl 2018-06-19 22:58:26 +02:00
Andy 7f553f4f93 refactorConvertToGetAccessAndSetAccess: Don't trigger on leading trivia (#25054)
* refactorConvertToGetAccessAndSetAccess: Don't trigger on leading trivia

* Update API (#24966)
2018-06-19 13:46:03 -07:00
Andy db85f37669 fixUnusedIdentifier: Don't needlessly exclude jsdoc (#25014) 2018-06-19 13:44:00 -07:00
dangoo b7f5f2a92b Add missing references in clparser and libs.json 2018-06-19 22:24:32 +02:00
dangoo 48e1a891a6 Add Intl.NumberFormat.formatToParts types 2018-06-19 21:28:49 +02:00
Nathan Shively-Sanders 03fff50fa4 Simplify getJSDocCommentAndTags (#24997)
Previously, getJSDocCommentAndTags could recur up to four times if any
of four predicates matched. However, to avoid duplicates, the predicates
have been tuned to be mutually exclusive, which means that the recursion
can be turned into a while loop. The while loop is much simpler and
safer, since it is guaranteed to only walk up the tree one time. In
addition, the extra check that adds jsdoc from initializers only runs
once, before the loop, further reducing the opportunity for duplicate
jsdocs.

I thought about further simplifying the code that gets the next node to
check, but to know when to stop the loop, I'd need a predicate that is
as complicated as the code in `getNextJSDocCommentLocation`, so I kept
the existing code, just reordering it for compactness.
2018-06-19 10:14:47 -07:00
Mohamed Hegazy 392b7eaca4 Merge pull request #22226 from markusjohnsson/issue_22180
Infer parameter names and types when applying Delcare Method codefix
2018-06-19 09:47:19 -07:00
TypeScript Bot d41b65756e Update user baselines (#25070) 2018-06-19 06:50:17 -07:00
Markus Johnsson f0c52a4548 Accept baseline 2018-06-19 13:21:07 +02:00
Ron Buckton 5bc8f957f1 Address lint warnings 2018-06-19 02:31:03 -07:00
Markus Johnsson aa87cc5b73 Merge branch 'master' of github.com:Microsoft/TypeScript 2018-06-19 11:18:20 +02:00
Ron Buckton fe2cb17f28 Accept API baselines 2018-06-19 02:05:17 -07:00
Ron Buckton 5472f7a4a0 Fix fs.copyFileSync not supported in Node 6 2018-06-19 01:29:22 -07:00
Ron Buckton 6e57d621c2 Disable gulp.watch for now 2018-06-18 23:01:49 -07:00
Ron Buckton ad4338dd76 Remove excess exports from exec.js 2018-06-18 23:00:30 -07:00
Ron Buckton 21c23d4e4e Merge branch 'master' into gulpProjectRefs 2018-06-18 22:51:37 -07:00
Ron Buckton 891b15f60a Update gulpfile to support project references 2018-06-18 22:45:13 -07:00
Ryan Cavanaugh 4fafe0b502 Merge pull request #25049 from RyanCavanaugh/tsbuild-fixes
Fixes downstream prepend projects not being built correctly on upstream changes
2018-06-19 12:01:42 +12:00
Ryan Cavanaugh a72fe5dd8e Add a testcase 2018-06-18 16:44:25 -07:00
Ryan Cavanaugh e060871e85 Merge pull request #25048 from RyanCavanaugh/cachePathsInSourceMaps
Do fewer calls to getRelativePathToDirectoryOrUrl when writing sourcemaps
2018-06-19 09:35:33 +12:00
Ron Buckton 0944c29a47 Adds failed test tracking 2018-06-18 13:25:29 -07:00
Ryan Cavanaugh 43d1ae42a9 Do fewer calls to getRelativePathToDirectoryOrUrl when writing sourcemaps 2018-06-18 11:12:19 -07:00
Ryan Cavanaugh bb29a1087e Fixes downstream prepend projects not being built correctly on upstream changes 2018-06-18 11:11:03 -07:00
TypeScript Bot 3bab6af97a Update user baselines (#24989) 2018-06-18 09:00:22 -07:00
Ron Buckton aa26a59835 Merge pull request #24244 from Andarist/redefining-helpers
Use redefining helper pattern for better tree-shakeability
2018-06-18 01:11:23 -07:00
Anders Hejlsberg 43bac20b83 Array literals contextually typed by tuple types with rest elements 2018-06-16 13:30:17 -07:00