Commit Graph

28909 Commits

Author SHA1 Message Date
Wesley Wigham 40a2eb2b4b Unify couldContainTypeVariables and the similar check done during instantiation (#30969)
* Stop symbol based filtering in couldContainTypeVariables

* Unify couldContainTypeVariables and the similar check done during instantiation
2019-04-19 16:01:53 -07:00
Wesley Wigham 1a4c15fb11 handle generic types in getArrayifiedType (#30606) 2019-04-19 14:32:33 -07:00
karthikkp 0d4913d51a baseline changes in other tests accepted 2019-04-20 01:40:48 +05:30
karthikkp 181d126b02 diagnostic messages conflicts resolved 2019-04-20 01:38:17 +05:30
Andrew Branch f0a3d2bf92 Filter out zero-width selections 2019-04-19 09:44:42 -07:00
Andrew Branch 95fb694eed Consistify tabs/spaces in test and baselines 2019-04-19 08:58:29 -07:00
Peter Šándor 08bd017db9 JSDoc author tag parsing updates (#17244) 2019-04-19 12:03:33 +02:00
Peter Šándor 00279e9eca Parse unexpected comments after email in author JSDoc tag (#17244) 2019-04-19 11:17:09 +02:00
Peter Šándor ea9d519424 Support email in author JSDoc tag
- fixes #17244
2019-04-19 11:15:39 +02:00
Daniel Rosenwasser 2eea21636b Merge pull request #29242 from Kingwl/attach_property_to_default_export
add transformer for emit add property to default export
2019-04-18 23:30:48 -04:00
Andrew Branch b472e9a9c4 Add baselines for new tests 2019-04-18 18:08:37 -07:00
Andrew Branch b6a0988052 Merge pull request #30776 from andrewbranch/feature/10178
Add flag to allow access to UMD globals from modules
2019-04-18 18:05:44 -07:00
Andrew Branch 6177596c27 Revert accidental submodule change I guess 2019-04-18 17:52:09 -07:00
Andrew Branch 99ace033bf Revert accidental line ending change 2019-04-18 17:23:54 -07:00
Andrew Branch 511cc79642 Revert accidental line break added 2019-04-18 17:21:52 -07:00
Andrew Branch 12492a369e Rename test to match 2019-04-18 16:28:12 -07:00
Andrew Branch d8936fd290 Rename to be smarter 2019-04-18 16:23:06 -07:00
Andrew Branch f0f7d82d7a Remove debug info 2019-04-18 16:05:08 -07:00
Andrew Branch 5479893f00 Skip lone variable declarations 2019-04-18 16:05:08 -07:00
Andrew Branch fed910fd0c Add stop for JSDoc comments 2019-04-18 16:05:08 -07:00
Andrew Branch d73eabd35a Special rules for binding elements, extend brace/whitespace logic to other kinds of bookended lists 2019-04-18 16:05:08 -07:00
Andrew Branch 74fc84ff84 Snap to nodes directly behind the cursor, create special rules for ParameterNodes 2019-04-18 16:05:07 -07:00
Andrew Branch 4ecdc82736 Solidify fake tree approach 2019-04-18 16:05:07 -07:00
Andrew Branch fcb7f0152f Rethink sibling expansion by creating fake subtrees 2019-04-18 16:05:07 -07:00
Andrew Branch 70e2672ab3 Add rules for expanding selection to sibling nodes 2019-04-18 16:05:07 -07:00
Andrew Branch 0f7bc02892 Move to language service 2019-04-18 16:05:06 -07:00
Andrew Branch 61425cb304 Move most logic to separate file 2019-04-18 16:05:06 -07:00
Andrew Branch 0a4ef0f630 Distinguish between same-line and different-line braces 2019-04-18 16:05:06 -07:00
Andrew Branch 039487c84e Also skip TemplateHeads 2019-04-18 16:05:06 -07:00
Andrew Branch fd88e52252 Start imports 2019-04-18 16:05:06 -07:00
Andrew Branch e62c2333eb Add support for string literals 2019-04-18 16:05:06 -07:00
Andrew Branch f98c00ab9d Add more tests, special handling for mapped types 2019-04-18 16:05:05 -07:00
Andrew Branch af3d0f0248 Start smart select API 2019-04-18 16:05:05 -07:00
Matt Bierner 7ccc89b0d7 Check to make sure default npm exists at path before trying to use it (#30910)
* Check to make sure default npm exists at path before trying to use it

**Bug**
If the typings installer is run under a copy of node that does not include npm—but on a machine that does have npm installed—it will incorrectly try to use the npm that does not exist next to its running version of node

**Fix**
Make sure that we check that npm we select exists before trying to use it as the default. Otherwise, fall back to using plain old `npm`

* Add command line flag to gate new behavior

* Fix missing semicolon
2019-04-18 14:24:41 -07:00
Andrew Branch 680d18207c Add tests for destructuring from variable with inferrable type 2019-04-18 12:01:11 -07:00
Andrew Branch af498eb6ca Clean up synthetic binding name creation and discriminating 2019-04-18 11:50:26 -07:00
Anders Hejlsberg 4ce0d202e9 Accept new baselines 2019-04-18 11:39:36 -07:00
Wesley Wigham d987907d2b Remove no longer extant gulp command from README (#31019) 2019-04-18 11:38:01 -07:00
Andrew Branch e7fb18e395 Handle case where you have to add a destructuring after a try/catch block 2019-04-18 11:36:47 -07:00
Anders Hejlsberg 3a89fead70 Merge branch 'master' into ignoreStringIndexSignaturesOnly
# Conflicts:
#	tests/baselines/reference/keyofAndIndexedAccess2.errors.txt
#	tests/baselines/reference/keyofAndIndexedAccess2.js
#	tests/baselines/reference/keyofAndIndexedAccess2.symbols
#	tests/baselines/reference/keyofAndIndexedAccess2.types
#	tests/cases/conformance/types/keyof/keyofAndIndexedAccess2.ts
2019-04-18 11:31:06 -07:00
Nathan Shively-Sanders c3a9429420 Handle JSDoc backticks in the parser, not scanner (#30939)
* Scan backticks in jsdoc as a single token less often

Previously, matching backticks in jsdoc would always be scanned as one
token to aid parsing incorrect jsdoc that uses backticks for parameter
names:

``js
/** @param {string} `nope`
 * @param {number} `not needed`
 */
```

However, this is wrong for code fences, which use triple backticks. This
fix parses a single backtick as a single token if it's immediately
followed by another backtick or by a newline. It retains the
questionable tokenisation of backticks-as-pairs in other cases, however.
A better fix might be to have the parser ignore backticks in jsdoc
instead.

* Add test case

* Handle jsdoc backticks in the parser, not scanner

Previously, the jsdoc scanner had ad-hoc handling of backticks that was
similar in structure to the normal scanner's handling, but much simpler.
This was a smaller code change, but is handled backwards: the special
case of backtick-quoted parameter names was handled in the scanner
instead of in the jsdoc identifier parsing code. That made it overapply
and block correct handling of asterisks across newlines, which was most
obvious in code fences inside jsdoc, as in #23517.

Fixes #23517

* More cleanup
2019-04-18 09:35:40 -07:00
Wesley Wigham 0574c1fae1 Hide the table of perf results from the bot inside an expando element (#31007) 2019-04-18 09:09:22 -07:00
Andrew Branch 92f0ac7efc Remove unnecessary change 2019-04-17 18:48:01 -07:00
Andrew Branch 08bb58b0c1 Enable renaming object binding patterns when needed 2019-04-17 18:43:01 -07:00
Andrew Branch ef18453166 Add tests for binding elements that need to be renamed 2019-04-17 18:43:01 -07:00
Andrew Branch 42c9b47add Fix let/const selection for binding patterns 2019-04-17 18:43:01 -07:00
Andrew Branch 06c8506f96 Add new baselines 2019-04-17 18:43:01 -07:00
Andrew Branch 4c73b2e7bd Basic support for binding patterns in async/await code fix 2019-04-17 18:43:00 -07:00
Anders Hejlsberg 33c3ce9cd0 Merge pull request #31002 from Microsoft/fixIsStringIndexSignatureOnlyType
Fix isStringIndexSignatureOnlyType function
2019-04-17 17:19:34 -07:00
Sheetal Nandi 2a29880c61 Handle simple lib file in the test case 2019-04-17 16:43:10 -07:00